Commit Graph

3731 Commits

Author SHA1 Message Date
xster
9eb9ea0ffa
Let the tool warn about all old API plugins (#48282) 2020-01-13 21:30:42 -08:00
Jonah Williams
79c286705c
[flutter_tools] Refactor Environment and FileStore to be context-free (#48759) 2020-01-13 19:25:35 -08:00
Jonah Williams
9f145f6ced [flutter_tools][web] Add basic service worker generation support to web applications (#48344) 2020-01-13 17:13:02 -08:00
Zachary Anderson
ef62092b9b
Revert "[flutter_tools] File system utilities (#48738)" (#48755)
This reverts commit 0349660622.
2020-01-13 14:30:37 -08:00
Jacob MacDonald
03a59bff03
Serve packages uris in flutter_tools dev web server (#48743)
* support mapping /packages/<package>/<path> requests to package:<package>/<path> uris in the web device file server
2020-01-13 13:21:57 -08:00
Zachary Anderson
0349660622
[flutter_tools] File system utilities (#48738) 2020-01-13 13:17:45 -08:00
Zachary Anderson
23a3d1014f
[flutter_tool] Make BotDetector context free (#48605) 2020-01-13 10:12:06 -08:00
Ian Hickson
e2b169ebd3 Apply void_checks lint. (#48267) 2020-01-13 10:03:01 -08:00
Zachary Anderson
4d096c434f [flutter_tool] Make CommandHelp context free (#48584) 2020-01-10 16:53:01 -08:00
Emmanuel Garcia
fca5917519 Test hot reload targeting a Fuchsia device (#48472) 2020-01-10 14:38:01 -08:00
Zachary Anderson
8b139a8c41
[flutter_tool] Use the delegate's toString in the ErrorHandlingFileSystem (#48597) 2020-01-10 14:35:49 -08:00
Zachary Anderson
67a68e9fa6
[flutter_tools] Fix analytics opt out event (#48585) 2020-01-10 14:35:19 -08:00
Tim Sneath
5280dda15b Improve toolchain text (#48102) 2020-01-10 14:28:03 -08:00
Emmanuel Garcia
ec2d58335a Make subcommands return success instead of null (#48100) 2020-01-10 11:28:01 -08:00
Jonah Williams
5d30c0970a
[flutter_tools][web] Add support for web app manifests and arbitrary resource files (from web/) (#48316) 2020-01-10 09:37:20 -08:00
Jonah Williams
749589d896
[flutter_tools] Remove context usage from status and clean up test cases (#48446) 2020-01-10 09:36:49 -08:00
Alexandre Ardhuin
82262d8896 format operator== according to flutter style guide (#48449) 2020-01-09 08:23:02 -08:00
Zachary Anderson
23ce192a8f Reland: Reword flutter run help screen. (#48423) 2020-01-09 08:18:03 -08:00
Zachary Anderson
07161e8267
[flutter_tool] Don't use context in ProcessUtils (#48444) 2020-01-08 15:20:32 -08:00
stuartmorgan
58d6c425e4
Check for desktop project files before building (#48350)
Moves the checks that projects have been configured for desktop to a lower level, where they will cover more codepaths (e.g., 'run'), and improves them to check for native build projects, rather than just directories, to catch cases where the directory exists (e.g., due to accidental creation of generated files).

Also adds links to the error messages pointing to instructions on adding desktop support to a project.

Fixes #47145
2020-01-08 12:39:49 -08:00
Jonah Williams
f7b8d62cbc
[flutter_tool] Refactor Logger and Terminal to (mostly) no longer depend directly on context (#47269) 2020-01-08 12:35:12 -08:00
Tim Sneath
6b66412136 Update first-run information URLs (#48154) 2020-01-08 12:33:03 -08:00
Zachary Anderson
a1bf03f87a
Revert "Esarbanis flutter run help (#48314)" (#48351)
This reverts commit 866fa64dce.
2020-01-07 15:06:40 -08:00
Jonah Williams
bf6c4c4a41
[flutter_tools]web]Add support for --csp mode to build web (#48319) 2020-01-07 12:20:03 -08:00
Zachary Anderson
866fa64dce
Esarbanis flutter run help (#48314)
* Reword flutter run help screen.

* As per Hixie request, added Efthymios Sarmpanis to the AUTHORS file

* fix test

Co-authored-by: Efthymis Sarmpanis <e.sarbanis@gmail.com>
2020-01-07 12:10:08 -08:00
Alexandre Ardhuin
4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Jonah Williams
2221a9f514
[flutter_tool] Cache the path context in the flutter tool (#48250)
recomputing the path context in the getter violates flutter repo style guide and adds a small but measurable overhead to all path operations
2020-01-06 13:57:13 -08:00
Jonah Williams
ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable (#47398) 2020-01-06 11:04:20 -08:00
Jenn Magder
0aed0b61a1
Add newlines between plugin names in GitHub template (#46937) 2020-01-03 17:53:54 -08:00
Devon Carew
c924f499f5
ignore a (potentially) unused import in generated code (#47593) 2020-01-03 11:04:03 -08:00
Angjie Li
9df1790f24 Flutter Web Driver Support (#47890) 2020-01-02 19:48:01 -08:00
Jenn Magder
dc99d61e5d Remove simulator arch in Profile and Release, App.xcframework (#48002) 2020-01-02 13:03:01 -08:00
Jenn Magder
a6c3ffe10c Allow Xcode project Info.plist to be moved (#47993) 2020-01-02 12:03:02 -08:00
Dan Field
24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081)
This reverts commit 04ea3183ce.
2020-01-02 11:47:28 -08:00
Francisco Magdaleno
04ea3183ce
Revert "Add many more global analyses. (#47875)" (#48080)
This reverts commit e768c92fbc.
2020-01-02 09:25:59 -08:00
Ian Hickson
e768c92fbc
Add many more global analyses. (#47875)
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
2019-12-30 17:12:19 -08:00
Francisco Magdaleno
f2f9d0e4fd
Revert "Flutter Web Driver Support (#47470)" (#47698)
This reverts commit cc1c9649c4.
2019-12-23 15:20:11 -08:00
Jenn Magder
9861a1c045
flutter build ios-framework generate Flutter.podspec (#47556) 2019-12-23 13:12:36 -08:00
Alexandre Ardhuin
4adad2c652
update list of lints (#47661) 2019-12-23 18:40:56 +01:00
Jenn Magder
85e9be36bf
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266)" (#47568)
This reverts commit 648a5d8a1e.
2019-12-20 17:45:16 -08:00
Angjie Li
cc1c9649c4 Flutter Web Driver Support (#47470) 2019-12-19 19:53:01 -08:00
Jenn Magder
648a5d8a1e
Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266) 2019-12-19 14:18:10 -08:00
Dan Field
41a911099b comments (#47473) 2019-12-19 13:48:02 -08:00
Jonah Williams
3fe6668849
[flutter_tool] ensure extraGenSnapshotArguments are forwarded to gen_snapshot from Android builds (#47059) 2019-12-19 13:44:21 -08:00
Dan Field
0a9ff388bf Revert "Use platform appropriate filepaths" (#47395) 2019-12-18 18:08:02 -08:00
Lau Ching Jun
2df964581f
Revert "Flutter Web Driver Support (#45951)" (#47389)
This reverts commit 1ef0eadb45.
2019-12-18 17:02:31 -08:00
Jenn Magder
9184f4d6fb
Build iOS frameworks with relative output path (#47369) 2019-12-18 15:31:54 -08:00
Dan Field
b23238890a Pipe through test-randomize-ordering-seed (#47243) 2019-12-18 13:58:01 -08:00
Lau Ching Jun
7850e2525f
Is executable doesn't mean a+x (#47359) 2019-12-18 12:21:46 -08:00
Angjie Li
1ef0eadb45 Flutter Web Driver Support (#45951)
* Support Flutter Driver test for Flutter Web application.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation issues.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation.

* Remove unused file from dartdoc check.

* Sync to date.

* Revert change to dartdoc.

* Address comments.

* Apply suggestions from code review

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* Update copyrights.

* Update allowed list for browsers.

* Verify command line arguments for Drive command is correctly parsed.

* Make waitUntilFirstFrameRasterized throw unimplementedError for Flutter Web Driver.

* Add comment for why sync WebDriver is used.

* Update documentations.

* Add more unit tests and update documentation.

* Configure test.dart so that web_extension_test will be executed with --platform=chrome.

* Revert unnecessary changes.

* Add new file path for Windows to blacklist.

* Reconstruct the structure of flutter_driver/test/src folder to remove filtering logic in dev/bots/test.dart/

* Fix path to web_extension_test.dart.

* Add instructions for how to use WebFlutterDriver.

* Update getLayerTree to use sendCommand instead of _sendCommand.

* Update pubspec files.
2019-12-18 10:45:39 -08:00
Zachary Anderson
d328e0cea0 [flutter_tool] Improve iOS mDNS failure error message (#47348) 2019-12-18 09:23:00 -08:00
Emmanuel Garcia
9884f9980f Change meaning of a plugin not supporting the android platform (#47015) 2019-12-17 19:48:01 -08:00
Jenn Magder
65ad8d805a
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928)" (#47264)
This reverts commit e54e301d50.
2019-12-17 17:20:57 -08:00
Jenn Magder
e54e301d50 Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928) 2019-12-17 16:13:01 -08:00
Emmanuel Garcia
a15a81be21
Fix androidSdk NPE (#47187) 2019-12-17 14:10:36 -08:00
Jenn Magder
1cdf0f44db
Only set flutter run usage values for targeted device platforms (#46931) 2019-12-17 14:09:34 -08:00
Alek Åström
853c8c569f [flutter_tools] Add violating plugin name to validation errors (#46601) 2019-12-17 14:08:03 -08:00
George Wright
56f4eaf58c
Re-enable --no-link-platform for JIT mode (#47242) 2019-12-17 17:05:32 -05:00
Jonah Williams
0a2d8e0cce
[flutter_tool] Remove direct usage of package:linter in the flutter_tools (#47174) 2019-12-16 18:37:20 -08:00
Jonah Williams
a723c94650
[flutter_tool] restructure ProjectFileInvalidator to no longer directly depend on context (#45739) 2019-12-16 18:12:04 -08:00
Zachary Anderson
a72cca137d
[flutter_tool] Print a helpful message on some mDNS failures (#47157) 2019-12-16 14:57:29 -08:00
Todd Volkert
fc9b30a4f1
Revert "flutter_tools: Remove unused //ignore comments; change flutter-specific ones to "ignore_for_flutter" (#45917)" (#46999)
This reverts commit f28592018d.

It broke forbidden_imports_test, which uses a custom ignore directive.
2019-12-13 12:23:12 -08:00
Sam Rawlins
f28592018d flutter_tools: Remove unused //ignore comments; change flutter-specific ones to "ignore_for_flutter" (#45917) 2019-12-13 12:03:02 -08:00
Jonah Williams
0497235c20
[flutter_tool] experimental resident web runner is not debuggable (#46916) 2019-12-12 19:05:48 -08:00
Jenn Magder
dfa6eb31a0
Revert "flutter run FULL_PRODUCT_NAME (#46838)" (#46925) 2019-12-12 17:34:54 -08:00
Jenn Magder
7a7e2bb247 flutter run FULL_PRODUCT_NAME (#46838) 2019-12-12 17:03:01 -08:00
Jonah Williams
5ba2830c83
[flutter_tool][gallery] Standardize target platform override behavior in tool and update flutter gallery to support it (#46206) 2019-12-12 15:20:52 -08:00
Jonah Williams
23b7853dfd
[flutter_tool] remove ability to disable Fingerprinter with DISABLE_FLUTTER_BUILD_CACHE env variable (#46913) 2019-12-12 15:12:53 -08:00
Jonah Williams
8ca55605c8
[flutter_tool] forward device-vmservice-port to iOS device launch arguments (#46822) 2019-12-12 13:55:42 -08:00
Jonah Williams
592a842b86
[flutter_tool] fix NPE in daemon caused by returning null connection info from experimental web runner (#46909) 2019-12-12 13:55:09 -08:00
Emmanuel Garcia
a467932d5b
Skip plugins that don't have an android impl when building AARs (#46835) 2019-12-12 12:38:09 -08:00
Danny Tuppeny
4944622b5d
Support URL tunnelling (pass dwds UrlEncoder through to editors via daemon) (#44271)
* Prposal for supporting URL tunnelling

* Update daemon.md

* Add the ability for daemon to call clients to expose URLs

* Fix dwds mock in web_fs tests

* Fix type error

* Remove build_runner import from run

* Move appStartedTime back to after the app has started

* Remove nested DI scope and pass urlTunneller down

* Fix import

* Tweak TODO

* Fix existing tests

* Fix spec to use result instead of params for response object

* Fix exposeUrl to use a url field, as spec'd

* Test that the daemon's exposeUrl sends a request and handles the response
2019-12-12 18:43:58 +00:00
Lau Ching Jun
535526b03c
Enable web for some of the golden tests (#46820)
* Make golden test timeout longer, some tests are flaky if the timeout is too short

* Enable some golden tests for web
2019-12-12 10:36:41 -08:00
Sean Freiburg
418b814555 Add buildNumber param to "flutter build aar" command (#46291) 2019-12-12 10:28:01 -08:00
Emmanuel Garcia
354f80b84a
Check and give execute permission to Gradle if needed (#46748) 2019-12-11 16:36:03 -08:00
Jonah Williams
8b88c8296f
remove test_api dependency from flutter_tools/base/io (#46796) 2019-12-11 13:31:30 -08:00
Jonah Williams
d0e5824040
[flutter_tool] Update require.js artifact location for tests (#46787) 2019-12-11 12:56:58 -08:00
Zachary Anderson
895ffc80dc
[flutter_tool] Handling of certain unrecoverable filesystem errors (#46617) 2019-12-11 12:54:36 -08:00
Jonah Williams
01953a1015
[flutter_tool] fix NPE in log reader for web server device (#46729) 2019-12-10 16:14:48 -08:00
Koichi Ishida
4938ea0385 Fix typo in gradle tools exit message (#46580) 2019-12-10 13:41:31 -05:00
Jonah Williams
bda9d90804
[flutter_tool] Reland: support --fast-start for Android applications (as an opt-in) (#46140) 2019-12-10 10:26:14 -08:00
Jonah Williams
81aa2710d2
[flutter_tool] add a vmservice API for hot ui requests (#45649) 2019-12-09 21:31:34 -08:00
Jonah Williams
523ac7b6f5
[flutter_tool] Always re-copy Framework/podspec when regenerating iOS module project (#45877) 2019-12-09 21:18:09 -08:00
Jonah Williams
d0526d3f92
[flutter_tool] Prevent accidental calls to io.exit in unit tests (#46639) 2019-12-09 18:58:29 -08:00
Christopher Fujino
0268510480 Fix analytics regression (#46242) 2019-12-09 15:13:02 -08:00
Jonah Williams
63cc4ad3aa
Revert "[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests (#46210)" (#46630)
This reverts commit b698c9d72e.
2019-12-09 13:13:59 -08:00
Jonah Williams
b698c9d72e
[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests (#46210) 2019-12-09 13:01:37 -08:00
Lau Ching Jun
c2eb0681ce
Implement screenshot test for flutter web. (#45530) 2019-12-06 14:25:39 -08:00
Amr Yousef
237c478683 Update iOS build signing error message (#45835) 2019-12-06 10:41:06 -08:00
Jonah Williams
e6fa5717d1
fix release web builds where the target file is not under lib (#46179) 2019-12-05 15:57:12 -08:00
Jenn Magder
fb69a393b8
Add bitcode and architectures to App.framework build ios framework command (#46130) 2019-12-05 12:16:54 -08:00
Zachary Anderson
e98acc7d1d [flutter_tool] Print version info on a no-op upgrade. (#46109) 2019-12-05 12:16:48 -08:00
Zachary Anderson
99684ce159 [flutter_tool] Make Device.dispose() abstract (#46006) 2019-12-05 08:48:00 -08:00
Jenn Magder
d01de941b9
Revert "Support --fast-start for Android applications (as an opt-in) (#45431)" (#46138)
This reverts commit 2a113165c0.
2019-12-04 18:12:57 -08:00
Jonah Williams
2a113165c0
Support --fast-start for Android applications (as an opt-in) (#45431) 2019-12-04 17:34:25 -08:00
Emmanuel Garcia
9e94eb93bc
Remove flutterBuildPluginAsAarFeature flag (#46101) 2019-12-04 15:42:08 -08:00
Christopher Fujino
dfc108c66c improve resetChanges() dartdoc (#46008) 2019-12-04 09:58:01 -08:00
Zachary Anderson
4484ae4043 [flutter_tool] Do not continue with a no-op 'upgrade' (#46011) 2019-12-03 20:08:24 -08:00
Emmanuel Garcia
09126abb22
Enable Android embedding v2 on the beta, dev and stable channel (#46040) 2019-12-03 17:43:00 -08:00
Jonah Williams
b96d818c19
Remove record/replay/bug report functionality from the tool (#45999) 2019-12-03 13:24:45 -08:00