Commit Graph

279 Commits

Author SHA1 Message Date
Greg Spencer
88f3811055
Turn on avoid_dynamic_calls lint, except packages/flutter tests, make appropriate changes. (#84476)
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated.

Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
2021-06-14 14:16:57 -07:00
Anis Alibegić
c99ed373b3
Fixed large amount of spelling errors (#83744) 2021-06-02 10:14:06 -07:00
Ian Hickson
5e0cc4cba4
Migrate to ChannelBuffers.push (#82564) 2021-05-21 15:09:03 -07:00
Yegor
2f3f5f09eb
FlutterDriver: deprecate enableAccessibility; redirect it to setSemantics; add setSemantics tests (#82939)
* deprecate enableAccessibility; redirect it to setSemantics

Co-authored-by: David Iglesias <ditman@gmail.com>
2021-05-19 22:10:26 -07:00
Ian Hickson
2ae1e39810
Revert "Migrate to ChannelBuffers.push (#82057)" (#82525) 2021-05-14 12:09:03 -07:00
Ian Hickson
b86d5c0094
Migrate to ChannelBuffers.push (#82057) 2021-05-13 14:34:04 -07:00
Alexandre Ardhuin
157bc92d4a
end of sort_child_properties_last (#82457) 2021-05-13 13:39:04 -07:00
Alexandre Ardhuin
7d46d43635
use throwsXxx instead of throwsA(isA<Xxx>()) (#82328) 2021-05-12 09:59:02 -07:00
Nguyen Phuc Loi
3cfbb958b3
[flutter_driver] support log communication for WebFlutterDriver (#81150) 2021-05-11 10:44:01 -07:00
Alexandre Ardhuin
df3662b15e
use throwsA (#82238) 2021-05-11 10:19:01 -07:00
Ren You
7f1d1414cc
Revert "Migrate to ChannelBuffers.push (#81235)" (#81829)
This reverts commit 35ad43f20c.
2021-05-04 06:17:19 -07:00
Ian Hickson
35ad43f20c
Migrate to ChannelBuffers.push (#81235) 2021-05-03 17:14:03 -07:00
Dan Field
0866005f70
Add benchmark for number of GCs in animated GIF (#81240) 2021-04-27 10:39:02 -07:00
Angjie Li
b74df388e1
Revert "Migrate to ChannelBuffers.push (#76288)" (#81226)
This reverts commit c26ed03c8a.
2021-04-26 12:57:17 -07:00
Ian Hickson
c26ed03c8a
Migrate to ChannelBuffers.push (#76288)
* Migrate to ChannelBuffers.push

* Move TestDefaultBinaryMessenger to its own file

* Apply deprecations and fix usages
2021-04-23 15:39:34 -07:00
Phil Quitslund
9c0270d960
sort directives (#80901) 2021-04-22 10:14:02 -07:00
Kaleb Hermes
1912f7dea2
[flutter_driver] Add waitForTappable to flutter_driver (#79581) 2021-04-14 16:54:02 -07:00
Dan Field
d377c1baed
Always write full timeline before summary (#79310) 2021-03-31 13:01:28 -07:00
Kaushik Iska
2e7e5b4530
Add timeline summary entries to capture vsync frame lag (#79090) 2021-03-26 19:44:01 -07:00
Michael Goderbauer
a7e3b1a35d
Clean up ignores that are not ignoring anything (#78493) 2021-03-19 15:32:46 -07:00
Ian Hickson
f3c25fa07a
Align more closely with package:test (#77118) (#78343) 2021-03-16 13:58:02 -07:00
Zachary Anderson
e7e1a04aa3
Revert "Align more closely with package:test (#77118)" (#78329)
This reverts commit 0cbe597540.
2021-03-16 09:26:34 -07:00
Ian Hickson
0cbe597540
Align more closely with package:test (#77118) 2021-03-15 16:28:02 -07:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint (#77434) 2021-03-05 18:38:15 -08:00
Michael Goderbauer
807bb29888
enable prefer_function_declarations_over_variables lint (#77398) 2021-03-05 18:29:04 -08:00
Greg Spencer
c6ef4c75d9
Turn on sized_box_for_whitespace lint, fix instances. (#77099) 2021-03-03 17:29:02 -08:00
Sam Rawlins
9e28f61549
Remove "unnecessary" imports in flutter_driver (#76158) 2021-02-16 16:41:05 -08:00
Wyte Krongapiradee
6db3d61ed4
fix(flutter_driver): Properly declare socket as nullable (#75769) 2021-02-11 10:51:04 -08:00
Han van Venrooij
09fd46a199
Widen getText support for RichText with multiple text spans in driver (#75603) 2021-02-10 17:01:08 -08:00
Michael Goderbauer
147bb4db3f
More null-safety fixes for flutter_driver (#75343) 2021-02-03 15:26:03 -08:00
Ian Hickson
a1141d9f0f
Revert "Add test for driver test organisation (#75271)" (#75317)
This reverts commit 26e976d767.
2021-02-03 08:53:17 -08:00
Michael Goderbauer
26e976d767
Add test for driver test organisation (#75271) 2021-02-02 19:41:02 -08:00
Michael Goderbauer
cf7a6319e0
Reland "Make flutter_driver be usable from a null-safe app (#75175)" (#75269) 2021-02-02 14:56:05 -08:00
Michael Goderbauer
ada04e6cfa
Revert "Make flutter_driver be usable from a null-safe app (#75175)" (#75266)
This reverts commit 9fd5242e65.
2021-02-03 03:32:29 +08:00
Michael Goderbauer
9fd5242e65
Make flutter_driver be usable from a null-safe app (#75175) 2021-02-02 10:34:11 -08:00
Dan Field
3ece9c63d9
Flutter_driver nnbd (#74856) 2021-01-27 23:55:26 -08:00
Dan Field
d1538320d2
Roll packages to null safe (vm_service, test, etc.) (#74671) 2021-01-26 09:15:54 -08:00
Kate Lovett
aed4518569
Remove deprecated WaitUntil[NoTransientCallbacks, NoPendingFrame, FirstFrameRasterized] methods from flutter_driver (#73754) 2021-01-20 16:19:03 -08:00
voobel
ea7017d3a8
enableFlutterDriverExtension: optionally disable text entry emulation (#71656) 2020-12-16 09:09:22 -08:00
Jonah Williams
a76289bb1b
[flutter_tools] run web unit tests in sound null safety (#70799) 2020-11-19 16:49:05 -08:00
Konstantin Scheglov
cc52b32b65
Ignore several import_of_legacy_library_into_null_safe (#69904)
* Ignore import_of_legacy_library_into_null_safe instead of un-migrating.
2020-11-08 17:46:16 -08:00
Dan Field
36f9af3f55
reland driver vm_service migration (#69126)
* One more reland of "Driver vm service (#68654)" (#69074)" (#69077)" (#69089)"

This reverts commit e5814756a2.

* pub run test
2020-10-27 11:30:24 -07:00
Dan Field
e5814756a2
Revert "Revert "Revert "Driver vm service (#68654)" (#69074)" (#69077)" (#69089)
This reverts commit 05ab0eba19.
2020-10-27 01:47:03 -07:00
Dan Field
05ab0eba19
Revert "Revert "Driver vm service (#68654)" (#69074)" (#69077)
This reverts commit 19ce7a86af.
2020-10-26 19:22:25 -07:00
Jonah Williams
19ce7a86af
Revert "Driver vm service (#68654)" (#69074)
This reverts commit 3ecac303b4.

Co-authored-by: Dan Field <dfield@gmail.com>
2020-10-26 18:56:34 -07:00
Dan Field
3ecac303b4
Driver vm service (#68654)
Migrate flutter_driver to use package:vm_service
2020-10-26 17:09:14 -07:00
Alexandre Ardhuin
17cdf5559d
enable unnecessary_string_escapes and use_raw_strings (#68302) (#69025) 2020-10-26 12:42:05 -07:00
Zachary Anderson
cbcd1321ed
Revert "enable unnecessary_string_escapes and use_raw_strings (#68302)" (#68714)
This reverts commit ae06c19a37.
2020-10-21 08:16:13 -07:00
Alexandre Ardhuin
ae06c19a37
enable unnecessary_string_escapes and use_raw_strings (#68302) 2020-10-21 16:34:24 +02:00
Hans Muller
98c519dbe2
Updated one reference to FlatButton in real_tests/extension_test.dart (#68505) 2020-10-19 13:12:17 -07:00
Marcin Jeleński
d2d072199b
Flutter Driver: command extensions and extension feature cleanup (#67916) 2020-10-16 22:29:47 -07:00
Hans Muller
6219b30850
Replace obsolete FlatButton reference in flutter_driver extension_test.dart (#67952) 2020-10-12 14:22:13 -07:00
Marcin Jeleński
759ddb1ccd
Reland "Flutter Driver - Create widget finders from serialized finders extensions" with null safety (#67711)
* Flutter Driver - Create widget finders from serialized finders extensions
2020-10-09 13:28:25 -07:00
Jonah Williams
4f2fcca6a9
Reland "[null-safety] reland: migrate app side flutter driver to null-safety" (#67570) 2020-10-08 17:42:02 -07:00
Jonah Williams
4042eb97b9
Revert "Flutter Driver - Create widget finders from serialized finders extensions (#67456)" (#67687)
This reverts commit 74f6fa4564.
2020-10-08 15:34:55 -07:00
Marcin Jeleński
74f6fa4564
Flutter Driver - Create widget finders from serialized finders extensions (#67456) 2020-10-08 15:27:02 -07:00
Dan Field
ad49e25a6b
Revert "[null-safety] reland: migrate app side flutter driver to null-safety (#67441)" (#67561)
This reverts commit d411242468.
2020-10-07 13:57:49 -07:00
Jonah Williams
d411242468
[null-safety] reland: migrate app side flutter driver to null-safety (#67441)
Reland: #67155

Fixes analysis error caused by landing of material migration, and g3 error caused by moving of fuchsia lib.
2020-10-06 16:51:37 -07:00
Jonah Williams
4818537044
Revert "[null-safety] migrate app dependencies of flutter driver (#67155)" (#67433)
This reverts commit e826442ef4.
2020-10-06 10:41:45 -07:00
Jonah Williams
e826442ef4
[null-safety] migrate app dependencies of flutter driver (#67155)
Ensures all of the libraries that the application side code import are migrated to null safety. full null safety migration is blocked by json rpc 2 and a breaking change to vm service client.
2020-10-06 10:30:15 -07:00
Jonah Williams
f6cbf488e1
[null-safety] pass experiments to builders (#67152)
Force opt-in flutter test platform to null safety for repo testing
2020-10-02 16:38:50 -07:00
Brian Eaton
7a4d8e190c
Make sure all isolates start during flutter driver tests. (#65703) 2020-09-18 14:42:04 -07:00
Dan Field
2acd170814
Make parameter optional (#65444) 2020-09-16 16:47:04 -07:00
renyou
51bb11f7ce
Revert "Reland "Make sure all isolates start during flutter driver tests" (#64432)" (#65635)
This reverts commit ccd4f6dd18.
2020-09-11 14:15:31 -07:00
Brian Eaton
ccd4f6dd18
Reland "Make sure all isolates start during flutter driver tests" (#64432) 2020-09-10 12:50:04 -07:00
Angjie Li
d2fa384c31
Allow Developers to enable Accessibility testing on WebFlutterDriver and get the underlying webDriver (#65051) 2020-09-08 13:15:06 -07:00
Im-Kevin
418e424794
Fix the test error of "Add finders for enableFlutterDriverExtension" and resubmit (#65276) 2020-09-08 12:10:05 -07:00
Jonah Williams
14af5bbe1e
Revert "Add finders for enableFlutterDriverExtension (#64308)" (#65273)
This reverts commit db4dda2052.
2020-09-04 17:01:30 -07:00
Im-Kevin
db4dda2052
Add finders for enableFlutterDriverExtension (#64308) 2020-09-04 14:50:02 -07:00
LongCatIsLooong
6536f65048
Revert "Warns when single line text fields overflow (#63639)" (#64573)
This reverts commit 0ab5ecc86b.
2020-08-25 11:11:15 -07:00
LongCatIsLooong
0ab5ecc86b
Warns when single line text fields overflow (#63639) 2020-08-24 18:16:05 -07:00
Jonah Williams
cb615b3bd7
Revert "Make sure all isolates start during flutter driver tests. (#61841)" (#62239)
This reverts commit 5fa5701d72.
2020-07-24 18:16:44 -07:00
Brian Eaton
5fa5701d72
Make sure all isolates start during flutter driver tests. (#61841) 2020-07-24 15:36:13 -07:00
Kaushik Iska
afd745e893
Filter profiling events by names not category (#61185)
Category isn't preserved by timeline events as `Dart_TimelineEvent`
specifies the category as `embedder`.

Fixes: https://github.com/flutter/flutter/issues/60008
2020-07-10 12:13:56 -07:00
Jia Hao
dd6dd7aef1
Fix tracing of startup events (#59982)
When `retainPriorEvents` is passed as true, the current behavior still limits timeline events to the timestamp after `traceEvents` is called. This can cause startup events to be missing.

This fixes it by passing null to `stopTracingAndDownloadTimeline` for the start and end time.

Related: #58430
2020-06-23 08:07:05 +08:00
Christopher Fujino
5cfb16b193
Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59876)
This relands #59120, which was reverted in #59870.
2020-06-19 12:03:38 -07:00
Christopher Fujino
0d7ff7a9e7
Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59870)
This reverts commit 8665e13801.
2020-06-19 10:52:52 -07:00
Ian Hickson
8665e13801
Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120) 2020-06-18 18:08:01 -07:00
Kaushik Iska
60cfe4957a
Timeline summary contains CPU, GPU and Memory usage (#58820)
As of flutter.dev/go/engine-cpu-profiling, we collect the CPU and
Memory usage. With work being done to collect GPU usage on iOS as well.

This adds them to the timeline summary.

Fixes: https://github.com/flutter/flutter/issues/58803
2020-06-08 17:17:46 -07:00
Jim Graham
e48e2e6ab9
add rasterizer start times to timeline summaries (#58514) 2020-06-03 16:18:02 -07:00
Jonah Williams
cd7dfd0a0a
[flutter_driver] make timeline request in chunks (#58430)
Work-around large timeline data killing devicelab machines by requesting data in 1 second intervals and combining at the end. Non-breaking change to the driver API.
2020-06-01 13:58:44 -07:00
Jia Hao
073126fdb3
Allow waitUntilFirstFrameRasterized without a root widget (#56430) 2020-05-13 09:12:03 -07:00
Jia Hao
342c6286ce
Eagerly wait for the driver extension on FlutterDriver.connect() (#56428) 2020-05-13 09:07:04 -07:00
Jia Hao
c2b7342ca4
Handle uncaught error for warnIfSlow (#56418) 2020-05-06 08:16:03 -07:00
Kaushik Iska
057a25cd45
[timeline] Sort timeline events before summarizing (#55771) 2020-04-27 16:34:02 -07:00
Aubrey Anderson
d537834b38
Allow headers to be passed to the WebSocket connection for VMServiceFlutterDriver (#54698) 2020-04-15 18:25:02 -07:00
Pierre-Louis
21588019bd
[flutter_driver] Fix browser check (#54741) 2020-04-15 10:40:03 -07:00
Kaushik Iska
7b9aeb2ff2
[flutter_driver] Reland add SceneDisplayLag stats to timeline summary (#54490) 2020-04-11 15:30:01 -07:00
Kaushik Iska
50b4c39c5d
Revert "[flutter_driver] Add SceneDisplayLag stats to timeline summary (#54218)" (#54480)
This reverts commit ce92333bf7.
2020-04-10 12:48:48 -07:00
Kaushik Iska
ce92333bf7
[flutter_driver] Add SceneDisplayLag stats to timeline summary (#54218) 2020-04-10 12:20:01 -07:00
Kaushik Iska
4987210ab6
[benchmarks] Handle multiple begin/end trace events (#54220)
Parser would earlier alternate after finding the first
begin event, not it looks for pairs.

Fixes: https://github.com/flutter/flutter/issues/54095
2020-04-10 10:32:41 -07:00
liyuqian
54d75a515a
Print frame begin time in summary (#50272) 2020-04-02 10:16:03 -07:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping (#50322) 2020-02-07 16:35:55 +01:00
Dan Field
8b2993337a
revert #48985 (#49572) 2020-01-27 14:36:02 -08:00
Angjie Li
f0a175f41d Use flutter_tools to start WebDriver browser. (#49228) 2020-01-21 16:48:02 -08:00
Anthony
b67d5ec6e9 [a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set (#48985) 2020-01-17 15:13:01 -08:00
Jenn Magder
d0c4458b80
Fix whitespace and commas in flutter_driver extension_test (#48982) 2020-01-16 17:15:00 -08:00
Alexandre Ardhuin
003541499b use isA<Xxx>() matcher (#48482) 2020-01-16 12:43:03 -08:00
Xavjer
6408f71a7c [Flutter Driver] Extend getText to support more widgets (#48809) 2020-01-15 16:49:11 -08:00