LongCatIsLooong
aa609127e7
Use dart analyze package for num.clamp ( #139867 )
...
Extacted from #130101 , dropped the `@_debugAssert` stuff from that PR so it's easier to review.
2023-12-11 20:25:26 +00:00
Kate Lovett
133711ba9a
Analyze against using Stopwatches in the framework ( #138507 )
2023-11-29 08:49:35 -06:00
Ian Hickson
d6bf1447f4
Update the tool to know about all our new platforms ( #132423 )
...
...and add a test so we remember to keep it in sync.
2023-08-24 21:54:59 +00:00
Greg Spencer
8b768de18f
Add lint check to make sure samples are linked and have tests ( #130523 )
...
## Description
This adds a checker that will check all of the API docs examples to make sure that they are linked from at least one source file in the packages.
It also checks to make sure that all of the examples have an associated test. Since there are a large number that don't have tests at the moment, there is also a large exception list that can be burned down (burn down list is in https://github.com/flutter/flutter/issues/130459 ).
Because there are missing links currently, this PR will only pass after https://github.com/flutter/flutter/pull/130521 is merged.
## Related Issues
- https://github.com/flutter/flutter/issues/129956
- https://github.com/flutter/flutter/issues/130459
## Tests
- Added test for the checker.
2023-07-18 15:26:09 +00:00
LongCatIsLooong
d4733a3fd4
Reduce _DoubleClampVisitor false positives ( #128539 )
...
I'm getting a few false positives in https://github.com/flutter/flutter/pull/128522/checks from the `num.clamp` checker since I introduced a class with a `clamp` method.
2023-06-08 22:42:35 +00:00
Tomasz Gucio
99c7e9f088
Add spaces after flow control statements ( #126320 )
2023-05-15 11:07:30 +02:00
Ian Hickson
806c1f8186
Deprecate these old APIs ( #116793 )
...
Deprecate these old APIs
2023-04-06 19:53:50 +00:00
Danny Tuppeny
d163620f1f
Prevent bots/analyze.dart crashing on circular dependencies ( #123802 )
...
Prevent bots/analyze.dart crashing on circular dependencies
2023-03-30 21:01:06 +00:00
Michael Goderbauer
42f61b32c5
Check cc files ( #123704 )
...
Check cc files
2023-03-29 18:40:58 +00:00
Ian Hickson
db5711bfad
remove obsolete todo in doubleClamp lint ( #122745 )
...
remove obsolete todo in doubleClamp lint
2023-03-17 20:55:51 +00:00
Nabeel Parkar
e5a382ec92
Migrate activation issue template to Github form issues ( #119916 )
...
Migrate activation issue template to Github form issues
2023-02-28 08:08:01 +00:00
Lioness100
26b6c1bedd
Fix typos ( #121171 )
...
* Fix typos
* lowercase animated & opacity
* Undo typo fix
---------
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
Ian Hickson
6205c110d6
Remove "note that" in our documentation (as per style guide) ( #120842 )
...
* lerp documentation
* Remove Note, Note That from repo
* Improve BorderSide documentation.
* apply review comments
2023-02-17 22:27:33 +00:00
Greg Price
98b3e48ed4
Fix hang on successful dev/bots/analyze.dart ( #117660 )
...
Fixes #117659
It turns out this was due to the output-suppression timer introduced
recently as part of cleaning up the output (#109206 ); on success, the
script would wait 10 minutes for the timeout to expire. This didn't
affect CI because this feature doesn't apply in CI (as detected by
lack of color on stdout.)
Fix the issue by cleaning up the timer on success in the same way
as on failure.
While here, clean up the final summary messages slightly,
and also cut the trailing space that printProgress was leaving
on each line.
2023-02-08 00:04:23 +00:00
Ian Hickson
4c99da6c56
Avoid printing blank lines between "Another exception was thrown:" messages. ( #119587 )
2023-02-01 23:57:54 +00:00
yaakovschectman
455e6aca50
Test integration test apps' runner files against current template app ( #118646 )
...
* Create template file test
* Add to .ci.yaml
* Add to TESTOWNERS
* Organize test script
* Push license to top of file
* Equals sign
* Utilize path.join
* Expand error message
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
* Fix missing newline string
* Move template file test to analyze.dart
* Fix newline
* Var name
* Fix extension length
* Use ignore-list for filenames
* Update dev/bots/analyze.dart
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
* Indentation
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-01-24 17:00:22 -05:00
Michael Goderbauer
c757df3bfa
Remove unnecessary null checks in dev/bots ( #118846 )
2023-01-21 01:39:19 +00:00
Ian Hickson
9fdb64b7e7
Taboo the word "simply" from our API documentation. ( #116061 )
2022-12-11 22:43:22 +00:00
Zachary Anderson
a84e369bd2
Revert "Allow Flutter golden file tests to be flaky ( #114450 )" ( #114902 )
...
This reverts commit 53e6876226
2022-11-08 09:26:55 -08:00
Kate Lovett
53e6876226
Allow Flutter golden file tests to be flaky ( #114450 )
...
* allow marking a golden check as flaky
* add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib
* Pause
* ++
* ++
* Analyzer therapy
* Once more with feeling
* Nits
* Review feedback
* Silly oops
* Test progress
* More tests
* Finish
* Nits
* Analyzer
* Review feedback
Co-authored-by: Yegor Jbanov <yjbanov@google.com>
2022-11-08 01:14:03 +00:00
Viren Khatri
e2ab3e581e
fixed inconsistent file names for *_chip.dart files and added a test ( #111364 )
2022-09-17 03:17:06 +00:00
Ian Hickson
97901da149
Cleaner test.dart output. ( #109206 )
2022-08-14 08:53:54 +00:00
Ian Hickson
7ded3d91da
API documentation cleanup ( #108500 )
2022-08-10 22:03:20 +00:00
Ian Hickson
03aa059c3c
Do not abort at first error when tests fail. ( #108936 )
2022-08-05 16:18:54 -07:00
Michael Goderbauer
10a7c9ba22
Unify analysis options ( #108462 )
2022-07-28 09:07:49 -07:00
Greg Spencer
07de84f014
Add StarBorder and StarBorder.polygon, with example. ( #108489 )
2022-07-28 00:01:05 +00:00
Michael Goderbauer
8a7b35933c
flutter update-packages --force-upgrade + analyzer fix ( #108198 )
2022-07-25 10:10:31 -07:00
Alexandre Ardhuin
93a74ca9f2
remove unused members in executable libs ( #107464 )
2022-07-12 21:41:08 +00:00
stuartmorgan
6c6ae06381
Add Windows to the platform_channels example ( #106754 )
2022-06-30 14:54:07 +00:00
Christopher Fujino
aac5e95ae5
[flutter_tools] refactor packages_autoroller.dart script ( #106580 )
2022-06-27 14:09:10 -07:00
Christopher Fujino
a30012b275
Add update packages roller ( #100982 )
2022-06-22 17:04:07 -07:00
Darren Austin
d9be807192
Updated the analyze.dart deprecation check to only look for beta branch versions. ( #105290 )
2022-06-06 21:16:49 -07:00
gaaclarke
64a0c19652
switched to a double variant of clamp to avoid boxing ( #103559 )
2022-05-18 13:26:08 -07:00
Chris Bracken
110c0a7f80
[ci] Add pointer to template image assets wiki ( #103787 )
...
Many of our flutter_tools templates include image assets such as
application icons. Adding these will trigger an analysis error from our
CI tooling.
This adds a pointer to the wiki describing the procedure for adding or
updating image assets in the templates:
https://github.com/flutter/flutter/wiki/Managing-template-image-assets
Uncovered while working on https://github.com/flutter/flutter/issues/103371
2022-05-14 10:28:59 -07:00
Michael Goderbauer
8bec125aaf
Avoid analyzing API example code twice, clean-up ( #103548 )
2022-05-11 21:27:45 -07:00
Greg Spencer
6504f2896c
Adds menuBarMenuLabel, and removes unneeded key localizations ( #102100 )
...
When I added localizations for shortcut keys, I added some that actually can't be shortcut keys, so I'm removing them again. These are mostly Japanese-specific keys that don't even appear on modern keyboards for the most part.
Also, added menuBarMenuLabel for an accessibility label for menu bar menus.
I modified the code for the localization generation scripts to add a --remove-undefined flag that will remove any localizations that don't appear in the canonical locale.
2022-05-09 09:25:52 -07:00
Zachary Anderson
577919dbfe
Don't hardcode ink sparkle spir-v ( #102674 )
2022-05-04 09:28:45 -07:00
Phil Quitslund
80849adee1
[dev, bots, examples] rename local functions with _s ( #102703 )
2022-04-28 10:44:06 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Christopher Fujino
41b73894bc
Test framework for executable files ( #101853 )
2022-04-13 22:44:07 -07:00
Michael Goderbauer
a01424773e
Enable unnecessary_import ( #101600 )
2022-04-08 12:56:45 -07:00
Michael Goderbauer
195a1cc413
Prepare dev (minus flutter_gallery) for use_super_parameters ( #100516 )
2022-03-29 12:52:42 -07:00
Jonah Williams
0a9a43b99a
Use flutter pub instead of dart pub ( #99159 )
2022-02-25 11:31:23 -08:00
Jonah Williams
83a88058d6
use dart pub deps to analyze consumer dependencies ( #99079 )
2022-02-24 19:26:27 -08:00
Christopher Fujino
87fe3fe031
rename two unit tests that were not actually being run on CI ( #98299 )
2022-02-14 17:40:13 -08:00
Greg Spencer
3750beacb4
Update platform shims in dev/manual_tests ( #94616 )
...
Updates the platform shims in dev/manual_tests so that Windows and Linux can be built. I had to update the Windows shims, because I was unable to build a Windows app there.
Also updates the analyze.dart script to report all license issues simultaneously instead of just dying after the first failure.
The only substantive code changes are in dev/bots/analyze.dart and dev/bots/test/analyze_test.dart
2022-01-07 12:16:24 -08:00
Paul Berry
f3a389c40f
Respect --dart-sdk parameter when running analyze.dart tests. ( #95174 )
2021-12-15 13:39:16 -08:00
Dan Field
bf60291493
Improve sync*/async* opt outs ( #95286 )
2021-12-14 19:00:52 -08:00
Jonah Williams
fda4094767
[framework] dont allocate forgotten children set in profile/release mode ( #94911 )
2021-12-14 10:51:30 -08:00
Dan Field
ab0a335973
Ban sync*/async* from user facing code ( #95050 )
2021-12-12 13:05:03 -08:00
Ian Hickson
bde9f11831
Add a test to verify that we only link to real issue templates ( #93528 )
2021-11-19 13:13:05 -08:00
Zachary Anderson
366648ae90
Revert "Reland: "Update outdated runners in the benchmarks folder ( #91126 )" ( #92535 )" ( #93323 )
...
This reverts commit bfe9c59831
2021-11-09 08:44:56 -08:00
Greg Spencer
bfe9c59831
Reland: "Update outdated runners in the benchmarks folder ( #91126 )" ( #92535 )
2021-11-08 21:28:02 -08:00
Zachary Anderson
b412f6fff8
Revert "Update outdated runners in the benchmarks folder ( #91126 )" ( #92106 )
...
This reverts commit 31e3364771
2021-10-19 10:35:15 -07:00
Greg Spencer
31e3364771
Update outdated runners in the benchmarks folder ( #91126 )
...
This change updates the platform runners in the benchmarks subdir.
I've attempted to replace the entire group with new code as if the project were recreated with flutter create so that they don't become a Frankenstein of minor changes to make it work again, but just plain old generated code that can be replaced and updated in place.
2021-10-19 08:27:29 -07:00
Ian Hickson
126cd7388e
Clean up dependency pins and update all packages ( #91109 )
2021-10-04 10:28:03 -07:00
Christopher Fujino
7fbfb1fad9
update consumer dependencies signature ( #91116 )
2021-10-01 13:32:47 -07:00
Daco Harkes
67fdf937c3
[bots] verbose logs when analyzing samples ( #90447 )
2021-09-27 12:38:07 -07:00
Ian Hickson
2420718389
Remove our extra timeout logic. ( #89952 )
2021-09-15 09:42:05 -07:00
Kate Lovett
616f9bcffa
Add tag support for executing reduced test sets ( #86821 )
2021-08-30 15:41:02 -07:00
Darren Austin
807ca68d5c
Enhance the skip test parsing the analyzer script. ( #88894 )
2021-08-25 14:56:03 -07:00
Darren Austin
41ff30c871
Added a check to the analyzer script to detect skipped tests. ( #88003 )
...
Added a check to the analyzer script to detect skipped tests that aren't commented.
The comment following the `skip` parameter should include either a link to a
github issue tracking the reenabling of the test, or a '[intended]' tag with
a brief description of why the test should never be enabled for the given
condition.
2021-08-10 23:03:48 -07:00
Greg Spencer
169bb1b73f
Fix the sample code analyzer to properly handle missing_identifier errors ( #87593 )
...
This fixes how the sample analyzer handles missing_identifier errors. It was looking at the wrong line, and missing an else clause, so it was silently allowing missing_identifier errors to pass.
In addition, this fixes the sample generation so that it uses the correct filename for the output files: it previously was looking for the first line that had a filename, which was meant to indicate a non-generated line. This change adds a new Line.generated constructor for generated lines, so that they can also have the correct filename associated with them.
2021-08-03 17:39:12 -07:00
Jonah Williams
0d3b44e835
[flutter] replace 'checked mode' with 'debug mode' ( #87408 )
2021-08-03 13:25:05 -07:00
Greg Spencer
0151359c07
Fix some errors in snippets ( #87528 )
2021-08-03 10:20:04 -07:00
Greg Spencer
57224f81d5
Fix analysis script to run from anywhere ( #86683 )
...
Fixes a small problem with the analyze.dart script that fixes it so that it can be invoked from any directory, not just the Flutter root.
2021-07-26 15:31:37 -07:00
Michael Goderbauer
045ba2b661
Migrate dev/bots to null safety ( #86522 )
2021-07-19 13:59:15 -07:00
Dan Field
e36e62e9a6
Revert "Revert "Audit hashCode overrides outside of packages/flutter ( #85370 )" ( #85451 )" ( #85567 )
...
This reverts commit 2be0d57fa2
2021-06-30 09:46:54 -07:00
Ren You
2be0d57fa2
Revert "Audit hashCode overrides outside of packages/flutter ( #85370 )" ( #85451 )
...
This reverts commit 9846fa5145
2021-06-28 09:55:31 -07:00
Dan Field
9846fa5145
Audit hashCode overrides outside of packages/flutter ( #85370 )
2021-06-26 17:36:04 -07:00
Dan Field
9c0bd18c40
Reland eliminate timeouts from integration tests ( #85141 )
2021-06-23 13:08:51 -07:00
Alexandre Ardhuin
34059eec2c
enable lint prefer_interpolation_to_compose_strings ( #83407 )
2021-06-01 11:14:06 -07:00
Jonah Williams
14759dc5a4
Revert "[flutter_tools] pin transitive deps during --transitive-closure ( #80911 )" ( #80959 )
...
This reverts commit c2aa193c5f
2021-04-22 09:39:39 -07:00
Jonah Williams
c2aa193c5f
[flutter_tools] pin transitive deps during --transitive-closure ( #80911 )
2021-04-21 21:40:48 -07:00
Jenn Magder
4f3ec01d32
Add frontend_server_client to dependency allowlist ( #80912 )
2021-04-21 18:13:43 -07:00
Jenn Magder
95d7d671c6
Remove analyze --dartdocs flag ( #80484 )
2021-04-18 09:29:02 -07:00
Jonah Williams
f6f59c58bc
create SDK package allowlist for core packages ( #80318 )
2021-04-16 14:29:32 -07:00
Alexandre Ardhuin
a6832d4d32
add missing trailing commas ( #79299 )
2021-03-29 21:29:02 -07:00
Michael Goderbauer
197b440e96
Migrate out custom ignore syntax to flutter_ignore ( #78497 )
2021-03-19 15:33:05 -07:00
Ian Hickson
f3c25fa07a
Align more closely with package:test ( #77118 ) ( #78343 )
2021-03-16 13:58:02 -07:00
Zachary Anderson
e7e1a04aa3
Revert "Align more closely with package:test ( #77118 )" ( #78329 )
...
This reverts commit 0cbe597540
2021-03-16 09:26:34 -07:00
Ian Hickson
0cbe597540
Align more closely with package:test ( #77118 )
2021-03-15 16:28:02 -07:00
Tong Mu
7abee113e8
[Analyze] Make deprecation note analyzer clearer on quote misuse ( #77653 )
...
* Impl
* Escape$
* eofnl
* Make message more clear
2021-03-09 13:21:45 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint ( #77434 )
2021-03-05 18:38:15 -08:00
Michael Goderbauer
7e017d318e
Enable file_names and package_names lints ( #77087 )
2021-03-02 15:24:04 -08:00
Jenn Magder
65e94f51c0
Remove unused flutter_driver_screenshot integration test ( #76575 )
2021-02-23 19:56:02 -08:00
Yuqian Li
fb552edcb8
Do not analyze files that are not checked in git ( #69723 )
2020-11-07 05:19:02 -08:00
Dan Field
76784651d4
Move package:integration_test to flutter/flutter ( #69622 )
2020-11-05 17:28:47 -08:00
Jonah Williams
5fa801718f
[flutter_tools] remove train and inject-plugins command ( #67766 )
...
The train command does nothing and was originally added to provide a no-output default for generating app-jit snapshots. The inject-plugins command is only for a repo-only analysis check, which is not necessary since we regenerate during pub get.
#29805
2020-10-09 15:43:39 -07:00
Jonah Williams
14722d3166
[gallery] add linux and windows files to gallery example ( #66736 )
...
Check in linux and windows platform code now that they are stable, so that we could use in devicelab in the future. Removed the ICO from the windows example to avoid analysis check, and since it won't be important for benchmarking or UI tests
2020-09-28 10:07:35 -07:00
Darren Austin
4253e42b43
Add .DS_Store to ignore list for the analyzer to run on macos cleanly. ( #65530 )
2020-09-18 14:37:04 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. ( #65568 )
2020-09-16 14:14:06 -07:00
Jim Graham
210f7680fc
ignore .idea directory in dart analyzer and analyzer benchmark output ( #55235 )
2020-07-29 17:16:26 -07:00
Darren Austin
753b84894c
Ignore .idea/* files in the analysis bot. ( #61215 )
2020-07-20 18:51:04 -07:00
Christopher Fujino
5cfb16b193
Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter ( #59120 )" ( #59876 )
...
This relands #59120 , which was reverted in #59870 .
2020-06-19 12:03:38 -07:00
Christopher Fujino
0d7ff7a9e7
Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter ( #59120 )" ( #59870 )
...
This reverts commit 8665e13801
2020-06-19 10:52:52 -07:00
Ian Hickson
8665e13801
Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter ( #59120 )
2020-06-18 18:08:01 -07:00
Michael Goderbauer
584fd5f913
Word substitutions ( #59484 )
...
* Word substitutions
* ++
2020-06-16 09:15:43 -07:00
Paul Berry
c32d1387ab
Fix overly specific detection of non-UTF8 files in analyzer bot. ( #56295 )
...
An upcoming Dart SDK change
(fa2fd41166
2020-05-04 09:10:20 -07:00
Jonah Williams
0b3f5cfcc0
[flutter_tools] initial support for enable experiment, run, apk, ios, macos ( #54617 )
2020-04-21 20:39:36 -07:00
