github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
NaN Commits 822 Branches 1,017 Tags 2 GiB
ae11f77f20
Commit Graph

18 Commits

Author SHA1 Message Date
Matan Lurey
71d50a1616
Start using bin/cache/engine.{stamp|realm} instead of bin/internal/engine.{realm|version}. (#164352) 
Towards https://github.com/flutter/flutter/issues/164315.

See also:
https://github.com/flutter/flutter/blob/master/docs/tool/Engine-artifacts.md.

There are more usages in `flutter/flutter`, but some will require more
specialized review (i.e. from release folks, or the Dart SDK team), so
I'll split those off.

~~Requires https://github.com/flutter/flutter/pull/164317 to merge
first.~~ ✅
 2025-03-02 00:54:33 +00:00
Mouad Debbar
f2e6dbc567
[web] Remove HTML from bots, test suites and e2e tests (#161537) 
- Stop running framework tests in HTML mode in CI.
- Update some READMEs
- Remove HTML-specific integration tests
 2025-01-22 18:50:46 +00:00
Matan Lurey
607c79cdfd
Remove WEB_SHARD_COUNT, which no longer exists post-Cirrus. (#161527) 
Towards https://github.com/flutter/flutter/issues/161387.
 2025-01-13 20:21:00 +00:00
Mouad Debbar
8731c396a7
[web] Make FLUTTER_WEB_AUTO_DETECT false by default (#160191) 
Now that "auto" is not supported anymore, it makes more sense to make
this dart define false by default. And there's no need to pass
`FLUTTER_WEB_AUTO_DETECT=false` anymore.
 2024-12-27 20:56:25 +00:00
Michael Goderbauer
5491c8c146
Auto-format Framework (#160545) 
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.

**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
 2024-12-19 20:06:21 +00:00
David Iglesias
1e1b5271f4
[tool] Removes deprecated --web-renderer parameter. (#159314) 
Removes the `--web-renderer` option.

Flutter tool users won't be able to select their web renderer.

In order to not drop test coverage, tests are still run with the HTML
Renderer, until its code is fully removed from the engine.

Part of https://github.com/flutter/flutter/issues/145954

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-12-02 18:33:02 +00:00
Matan Lurey
bf36437cae
Add --dry-run to dev/bots/test.dart. (#158956) 
Closes https://github.com/flutter/flutter/issues/158884.

/cc @reidbaker.

Example output:

```sh
% SHARD=tool_integration_tests SUBSHARD=6_6 dart dev/bots/test.dart --dry-run 
▌13:59:18▐ STARTING ANALYSIS
▌13:59:18▐ --dry-run enabled. Tests will not actually be executed.
▌13:59:18▐ SHARD=tool_integration_tests
▌13:59:18▐ SUBSHARD=6_6
▌13:59:18▐ |> bin/flutter: 
  --version
▌13:59:18▐ |> bin/cache/dart-sdk/bin/dart (packages/flutter_tools): 
  run
  test
  --reporter=expanded
  --file-reporter=json:/var/folders/qw/qw_3qd1x4kz5w975jhdq4k58007b7h/T/metrics_1731621558619861.json
  --test-randomize-ordering-seed=20241114
  -j1
  test/integration.shard/shader_compiler_test.dart
  test/integration.shard/overall_experience_test.dart
  test/integration.shard/expression_evaluation_test.dart
  test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart
  test/integration.shard/isolated/native_assets_test.dart
  test/integration.shard/isolated/native_assets_agp_version_test.dart
  test/integration.shard/coverage_collection_test.dart
  test/integration.shard/devtools_uri_test.dart
  test/integration.shard/deprecated_gradle_settings_test.dart
  test/integration.shard/batch_entrypoint_test.dart
  test/integration.shard/bash_entrypoint_test.dart
  test/integration.shard/background_isolate_test.dart
```
 2024-11-20 21:01:54 +00:00
Jason Simmons
30fc10d602
Update the web test suite runner to use the correct flutter_driver output path if FLUTTER_TEST_OUTPUTS_DIR is set (#153966) 
A pending change to the flutter_drone LUCI recipe is using a logging library that sets the FLUTTER_TEST_OUTPUTS_DIR environment variable (see https://flutter.googlesource.com/recipes/+/b111cd3ef2297e66905cc48c2cfedce0cf1ba46f)

flutter_driver uses FLUTTER_TEST_OUTPUTS_DIR as its output directory if it is set.  run_web_tests invokes flutter_driver and needs to look for outputs in that directory.
 2024-08-22 22:32:02 +00:00
Jackson Gardner
8f0e77696f
Set dart defines properly while in debug mode. (#152262) 
Turns out just supporting the right value for `kDebugMode` was a lot simpler than I thought. Debug builds used to never go through the build system code path when using `flutter run`, but now that we have wasm this can occur with the run command.

This should address https://github.com/flutter/flutter/issues/148850
 2024-07-25 22:00:50 +00:00
Jackson Gardner
17584ab790
Re-enable debug canvaskit e2e tests. (#151565) 
Now that https://github.com/flutter/engine/pull/53718 is fixed, these tests should be fine.

After this, we should be able to close https://github.com/flutter/flutter/issues/147731
 2024-07-11 20:05:53 +00:00
Yegor
ff0ab6ba45
Send q once (#149767) 
The previous expression `success || line.contains('--- TEST FAILED ---')` made it such that as soon as success is reported, the test would send "q" on every line of stdout, which is wrong. This fixes the condition such that "q" is sent once, only when `--- TEST SUCCEEDED ---` or `--- TEST FAILED ---` is printed.
 2024-06-05 22:44:01 +00:00
Yegor
180cda380c
Revert "make output of flutter run web tests verbose (#149694)" (#149766) 
This reverts commit cd8e84f465.

Can't tell why, but it seems to have broken some web tests.
 2024-06-05 13:23:00 -07:00
Yegor
cd8e84f465
make output of flutter run web tests verbose (#149694) 
This is to make debugging flakes on LUCI easier. Right now, when the tool crashes it saves the error output into a file and prints the file path, but the file is not accessible from LUCI.

Example: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8746361237956626577/+/u/run_test.dart_for_web_long_running_tests_shard_and_subshard_5_5/stdout
 2024-06-05 15:02:53 +00:00
Yegor
d5836ee60c
[web] skip debug mode CanvasKit e2e tests due to flakiness; unskip all other modes (#147736) 
- Skip debug mode CanvasKit e2e tests due to flakiness.
- Unskip all other modes (`text_editing_integration` was over-skipped).

Fixes https://github.com/flutter/flutter/issues/146189
 2024-05-02 22:23:30 +00:00
Yegor
1d0e798c21
[web] increase chromedriver logging level (#147687) 
This can help debugging https://github.com/flutter/flutter/issues/146189
 2024-05-02 10:16:37 -07:00
Yegor
f256f68831
[web] remove platform_messages_integration test (#147654) 
This functionality is already fully covered by https://github.com/flutter/engine/blob/main/lib/web_ui/test/engine/platform_views/message_handler_test.dart

This might help with https://github.com/flutter/flutter/issues/146189 a little.
 2024-05-01 21:12:01 +00:00
Jesse
ece6ac2bb6
Clean up flutterRoot (#147010) 
The flutterroot param is accessible from the util function after the recent refactor of utils https://github.com/flutter/flutter/pull/146592 so this change cleans up the references to the suite runners to make them simpler. 

Part of https://github.com/flutter/flutter/issues/145482
 2024-04-18 22:33:08 +00:00
Jesse
e660a93c63
Create web tests suite & runner_utils (#146592) 
Move from `test.dart` into new `runner_utils.dart` file:
- shard calculation related methods + `shuffleSeed` logic
- env variable flag calculation
- runner wrapper methods `runDartTest` and `_runFromList`

Create web tests suite class containing:
- web long running tests
- runWebHtmlUnitTests
- runWebCanvasKitUnitTests
- runWebSkwasmUnitTests
- the associate helper methods with the above
 2024-04-17 20:44:08 +00:00