Commit Graph

25 Commits

Author SHA1 Message Date
Jenn Magder
a2678be7ad
Platform view devicelab ad banner scroll list real ads (#145239)
Reland https://github.com/flutter/flutter/pull/144745, which was reverted due to a the Android app ads not being set up correctly, crashing on launch: https://github.com/flutter/flutter/pull/145228

Add the missing [`com.google.android.gms.ads.APPLICATION_ID` `meta-data` tag](https://developers.google.com/admob/android/quick-start#import_the_mobile_ads_sdk) to the manifest.

Validated both `platform_views_scroll_perf__timeline_summary` and `platform_views_scroll_perf_impeller__timeline_summary` ran locally on an Android emulator.

Successful presubmit runs:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf__timeline_summary/4/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf_impeller__timeline_summary/4/overview

Original commit message:
_________
This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257
2024-03-16 05:44:21 +00:00
auto-submit[bot]
ca2d4865cf
Reverts "Reland: "Platform view devicelab ad banner scroll list real ads" (#145224)" (#145228)
Reverts: flutter/flutter#145224
Initiated by: hellohuanlin
Reason for reverting: breaks the tree
Original PR Author: hellohuanlin

Reviewed By: {gmackall, jmagman}

This change reverts the following previous change:
Reland https://github.com/flutter/flutter/pull/144745, which got reverted due to Android lockfile. Fixed by `dart dev/tools/bin/generate_gradle_lockfiles.dart`

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-15 20:09:18 +00:00
hellohuanlin
da4d0e4fab
Reland: "Platform view devicelab ad banner scroll list real ads" (#145224)
Reland https://github.com/flutter/flutter/pull/144745, which got reverted due to Android lockfile. Fixed by `dart dev/tools/bin/generate_gradle_lockfiles.dart`

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-15 19:20:25 +00:00
auto-submit[bot]
7f1c93d732
Reverts "Platform view devicelab ad banner scroll list real ads (#144745)" (#145189)
Reverts: flutter/flutter#144745
Initiated by: gspencergoog
Reason for reverting: appears to have broken the build.

Original PR Author: hellohuanlin

Reviewed By: {jmagman, jonahwilliams}

This change reverts the following previous change:
This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-15 00:21:25 +00:00
hellohuanlin
be78542d6c
Platform view devicelab ad banner scroll list real ads (#144745)
This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-14 21:41:07 +00:00
Jonah Williams
08a2635e2b
[devicelab] add benchmark for complex non-intersecting widgets with platform views (#116436) 2022-12-02 21:37:45 +00:00
Chris Yang
1560d0cef7
[Benchmark: platform_views_layout] show and hide more PlatformViews (#110688) 2022-09-02 17:05:55 +00:00
Dan Field
9c0bd18c40
Reland eliminate timeouts from integration tests (#85141) 2021-06-23 13:08:51 -07:00
Dan Field
d377c1baed
Always write full timeline before summary (#79310) 2021-03-31 13:01:28 -07:00
Michael Goderbauer
99b9ec8d40
Reland "Migrate some benchmarks to NNBD (#75023)" (#75431) 2021-02-09 10:06:08 -08:00
Zachary Anderson
998d1c6523
Revert "Revert "Revert "Migrate some benchmarks to NNBD (#75023)" (#75053)" (#75265)" (#75331)
This reverts commit 1e8e414787.
2021-02-04 01:49:02 +08:00
Michael Goderbauer
1e8e414787
Revert "Revert "Migrate some benchmarks to NNBD (#75023)" (#75053)" (#75265) 2021-02-02 19:36:05 -08:00
Zachary Anderson
25134a16d1
Revert "Migrate some benchmarks to NNBD (#75023)" (#75053)
This reverts commit 49de01c928.
2021-01-29 23:52:30 -08:00
Michael Goderbauer
49de01c928
Migrate some benchmarks to NNBD (#75023) 2021-01-29 18:21:04 -08:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. (#65568) 2020-09-16 14:14:06 -07:00
Chris Yang
c5a69b9b8a
Reland "Branch out android platform view perf testing #60238" 2nd time (#61748) 2020-07-22 18:36:11 -07:00
Chris Yang
6a525b9aa5
Revert "Reland "Branch out android platform view perf testing (#60238)" (#61554)" (#61642) 2020-07-16 13:14:52 -07:00
Chris Yang
63ceeb8f15
Reland "Branch out android platform view perf testing (#60238)" (#61554) 2020-07-16 11:23:52 -07:00
Chris Yang
77efc00af0
Revert "Branch out android platform view perf testing (#60238)" (#61482)
This reverts commit 9f4499f431.
2020-07-14 15:10:21 -07:00
Chris Yang
9f4499f431
Branch out android platform view perf testing (#60238) 2020-07-14 13:07:41 -07:00
Ming Lyu (CareF)
c3217dac7f
await timelinesummary to file (#60774) 2020-07-06 13:19:19 -04:00
Emmanuel Garcia
b176042c1a
Add benchmark for hybrid composition on Android (#55609) 2020-04-28 19:24:15 -07:00
Emmanuel Garcia
a3c6e4a0b9
Reland: Add Platform View benchmark (#52839) 2020-03-18 13:24:52 -07:00
Emmanuel Garcia
dc8ffe0430
Revert "Add benchmark for platform views (#52717)" (#52834)
This reverts commit 1f1731842a.
2020-03-18 11:16:38 -07:00
Emmanuel Garcia
1f1731842a
Add benchmark for platform views (#52717) 2020-03-18 10:55:50 -07:00