Sangam Shrestha
d261411b4c
Remove redundant useMaterial3: true ( #163376 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
This PR removes redundant useMaterial3: true as described in
https://github.com/flutter/flutter/issues/162818
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
- https://github.com/flutter/flutter/issues/162818
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
2025-03-14 17:50:20 +00:00
Michael Goderbauer
5491c8c146
Auto-format Framework ( #160545 )
...
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.
**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2024-12-19 20:06:21 +00:00
Michael Goderbauer
55b6f049a6
Enable unreachable_from_main lint - it is stable now!!1 ( #129854 )
...
PLUS: clean-up of all the unreachable stuff.
2023-07-06 00:09:01 +00:00
Michael Goderbauer
6a5405925d
Make MultiChildRenderObjectWidget const ( #119195 )
2023-01-31 11:13:59 -08:00
Dominik Roszkowski
156c313219
Dispose animation controller in platform view benchmarks ( #110413 )
2022-10-26 13:24:14 -07:00
Michael Goderbauer
195a1cc413
Prepare dev (minus flutter_gallery) for use_super_parameters ( #100516 )
2022-03-29 12:52:42 -07:00
Michael Goderbauer
b8a2456737
Enable library_private_types_in_public_api lint ( #81578 )
2021-05-10 16:26:16 -07:00
Michael Goderbauer
99b9ec8d40
Reland "Migrate some benchmarks to NNBD ( #75023 )" ( #75431 )
2021-02-09 10:06:08 -08:00
Zachary Anderson
998d1c6523
Revert "Revert "Revert "Migrate some benchmarks to NNBD ( #75023 )" ( #75053 )" ( #75265 )" ( #75331 )
...
This reverts commit 1e8e414787
2021-02-04 01:49:02 +08:00
Michael Goderbauer
1e8e414787
Revert "Revert "Migrate some benchmarks to NNBD ( #75023 )" ( #75053 )" ( #75265 )
2021-02-02 19:36:05 -08:00
Zachary Anderson
25134a16d1
Revert "Migrate some benchmarks to NNBD ( #75023 )" ( #75053 )
...
This reverts commit 49de01c928
2021-01-29 23:52:30 -08:00
Michael Goderbauer
49de01c928
Migrate some benchmarks to NNBD ( #75023 )
2021-01-29 18:21:04 -08:00
Chris Yang
c5a69b9b8a
Reland "Branch out android platform view perf testing #60238 " 2nd time ( #61748 )
2020-07-22 18:36:11 -07:00
Chris Yang
6a525b9aa5
Revert "Reland "Branch out android platform view perf testing ( #60238 )" ( #61554 )" ( #61642 )
2020-07-16 13:14:52 -07:00
Chris Yang
63ceeb8f15
Reland "Branch out android platform view perf testing ( #60238 )" ( #61554 )
2020-07-16 11:23:52 -07:00
Chris Yang
77efc00af0
Revert "Branch out android platform view perf testing ( #60238 )" ( #61482 )
...
This reverts commit 9f4499f431
2020-07-14 15:10:21 -07:00
Chris Yang
9f4499f431
Branch out android platform view perf testing ( #60238 )
2020-07-14 13:07:41 -07:00
Emmanuel Garcia
b176042c1a
Add benchmark for hybrid composition on Android ( #55609 )
2020-04-28 19:24:15 -07:00
Emmanuel Garcia
a3c6e4a0b9
Reland: Add Platform View benchmark ( #52839 )
2020-03-18 13:24:52 -07:00
Emmanuel Garcia
dc8ffe0430
Revert "Add benchmark for platform views ( #52717 )" ( #52834 )
...
This reverts commit 1f1731842a
2020-03-18 11:16:38 -07:00
Emmanuel Garcia
1f1731842a
Add benchmark for platform views ( #52717 )
2020-03-18 10:55:50 -07:00
