pq
aedef5139b
Analyze command cleanup.
...
Removing some special-casing in pursuit of aligning `flutter analyze` output with that provided by server/IDEs. Specifically:
* strong-hints (stale, no longer supported)
* "analyzer says" comment handling in favor of `//ignore`s
* `conflictingNamePattern` --- no longer needed
Next up some of the error filter regexps...
2016-03-11 10:35:17 -08:00
John McCutchan
5e140b7533
Add DevicePortForwarder with adb fix
2016-03-11 09:26:17 -08:00
Ian Hickson
1b9cd52081
Enable ALL THE LINTS
...
Well, all the easy ones, anyway.
For some reason `// ignore:` isn't working for me so I've disabled
lints that need that. Also disabled those that require a ton of work
(which I'm doing, but not in this PR, to keep it reviewable).
This adds:
- avoid_init_to_null
- library_names
- package_api_docs
- package_names
- package_prefixed_library_names
- prefer_is_not_empty
- sort_constructors_first
- sort_unnamed_constructors_first
- unnecessary_getters_setters
2016-03-10 23:15:31 -08:00
Hixie
1d03522857
Remove the _EquationMember.hashCode override
...
Since we removed our operator== overload, we can now allow people to put
these in collections again.
Also, turn on two more analyzer lints: avoid_empty_else and hash_and_equals.
2016-03-10 17:27:02 -08:00
Devon Carew
83caeb35ed
Merge pull request #2584 from devoncarew/redux_analysis_options
...
move the analysis_options to a file
2016-03-10 14:37:58 -08:00
Eric Seidel
37f0b5dd98
Revert "Add DevicePortForwarder"
2016-03-10 14:23:39 -08:00
Devon Carew
b9fafc1765
adjust a regex for intl files
2016-03-10 14:21:23 -08:00
Yegor
96db7c0a5a
Merge pull request #2580 from yjbanov/lower-xcode-version-requirement
...
[ios] reduce xcode version requirement to 7.0
2016-03-10 14:08:48 -08:00
Devon Carew
780e4e6212
move the analysis_options to a file
2016-03-10 13:47:20 -08:00
John McCutchan
5fcaebbf51
Merge pull request #2506 from johnmccutchan/device_port_forward
...
Add DevicePortForwarder
2016-03-10 13:23:40 -08:00
Yegor Jbanov
23e634a613
[ios] reduce xcode version requirement to 7.0
...
Build bots only have 7.0.
2016-03-10 13:08:58 -08:00
John McCutchan
131359f4bc
Add DevicePortForwarder
2016-03-10 12:49:07 -08:00
Jason Simmons
3b5fba4022
Merge pull request #2578 from jason-simmons/flx_working_dir
...
Add an option to specify a working directory for the FLX builder
2016-03-10 12:43:35 -08:00
Yegor
c2b175d1db
Merge pull request #2575 from yjbanov/ios-device-discovery
...
[ios] look for the best available devicetype/runtime when booting
2016-03-10 11:25:56 -08:00
Yegor Jbanov
9383466dd5
[ios] look for the best available devicetype/runtime when booting
2016-03-10 11:04:02 -08:00
Eric Seidel
3e2a4d9b4d
flutter run
should fail if pub get
fails.
...
Previously we were ignoring the return code and continuing.
@devoncarew
2016-03-10 09:36:09 -08:00
Hixie
c7339de6bc
Enable always_declare_return_types lint
...
And fix a zillion omissions this uncovered.
2016-03-09 17:57:39 -08:00
Hixie
8950d3ccc4
Make flutter analyze useful for package conflicts
...
Also, resolve our package conflict, since reflectable has been fixed.
2016-03-09 17:41:05 -08:00
Hixie
5810cd80bd
Avoid 'as' keyword
...
It has performance implications in release mode.
We'll enable the lint once https://github.com/dart-lang/linter/issues/195 is fixed.
2016-03-09 15:00:55 -08:00
Jason Simmons
5108a6cc58
Add an option to specify a working directory for the FLX builder
...
This allows building an FLX without leaving any temporary files in the app's
source directory
2016-03-09 14:59:40 -08:00
Alhaad Gokhale
5faf84c3fa
Merge pull request #2528 from alhaad/depsfile_hook
...
Add `flutter_tools build` hooks to also generate depfile.
2016-03-09 12:29:31 -08:00
Alhaad Gokhale
b8d64ffe68
Add flutter_tools build
hooks to also generate depfile.
...
Fixes #1942 .
2016-03-09 11:24:47 -08:00
Devon Carew
2e9fef8c46
fix a regression in flutter logs
2016-03-09 10:48:34 -08:00
Devon Carew
ee5c5970dc
fix npe in lastLogcatTimestamp
2016-03-08 19:04:49 -08:00
Adam Barth
e4b1eab854
Remove //examples/widgets
...
Most of the remaining widget examples are actually manual tests. This patch
moves them into //dev/manual_tests. A couple are examples of using services,
which I've moved to //examples/layers/services. The remainder are out-dated and
are removed by this patch.
2016-03-08 16:37:32 -08:00
John McCutchan
9cb7001a39
Add ServiceProtocolDiscovery
2016-03-08 15:13:48 -08:00
John McCutchan
8803cecea1
Refactor DeviceLogReader
2016-03-08 10:38:22 -08:00
Devon Carew
52efc7fb68
implement --watch for flutter analyze
2016-03-07 13:46:42 -08:00
Devon Carew
b52fa986b6
fix rebase
2016-03-07 10:36:04 -08:00
Steve Messick
913315bc87
Improve the error message when a target is specified but not found.
...
https://github.com/flutter/flutter/issues/2368
2016-03-07 08:53:33 -08:00
Steve Messick
8cc5312054
Merge remote-tracking branch 'upstream/master'
2016-03-07 05:17:13 -08:00
Devon Carew
93b31a41df
fix flutter create
2016-03-04 18:56:26 -08:00
Steve Messick
cea21fb7b1
Merge remote-tracking branch 'upstream/master'
2016-03-04 14:38:55 -08:00
Steve Messick
2e878746a3
Improve message when target not found
2016-03-04 14:36:32 -08:00
Devon Carew
c1caa26989
fix a mac test
2016-03-04 13:10:51 -08:00
Ian Hickson
047276a666
Random fixes to dartdocs, http lib, analyzer
...
This is a variety of trivial fixes that I collected while going through the dartdocs.
This does contain some non-comment changes.
2016-03-03 23:56:40 -08:00
Yegor
cd0ddce963
Merge pull request #2402 from yjbanov/use-xcrun
...
[ios] use xcrun to launch simulator instead of hardcoded path
2016-03-03 17:14:13 -08:00
Yegor Jbanov
e69f6562ed
[ios] use xcrun to launch simulator instead of hardcoded path
2016-03-03 16:58:16 -08:00
Adam Barth
9b7ee3b7cc
Merge pull request #2377 from abarth/rm_test
...
Remove test dependency from package:flutter
2016-03-03 16:53:22 -08:00
Yegor Jbanov
58b2c630ab
[ios] generate flx on first ios launch
2016-03-03 16:10:03 -08:00
Devon Carew
6ab1ff3511
Merge pull request #2398 from devoncarew/fix_zip
...
fix the zip tool when building for ios
2016-03-03 15:28:33 -08:00
Devon Carew
361893b180
fix the zip tool when building for ios
2016-03-03 15:18:32 -08:00
Devon Carew
f68d86dab2
show stdout on xcode failures
2016-03-03 15:10:45 -08:00
Devon Carew
8283ce87e2
fix the stop command tests
2016-03-03 13:58:49 -08:00
Adam Barth
41cdd600df
Remove test dependency from package:flutter
...
The mojo_sdk has cleaned up its dependencies, so we no longer need to depend on
package:test from package:flutter.
2016-03-03 12:26:58 -08:00
Adam Barth
932b09c33a
Merge pull request #2048 from abarth/test2
...
Switch from hack_load_vm_file_hook to PlatformPlugin
2016-03-03 12:11:53 -08:00
Devon Carew
6868d24f37
Merge pull request #2380 from devoncarew/atom_validation
...
Atom validation
2016-03-03 12:10:30 -08:00
Devon Carew
e1f476b6d0
Merge pull request #2378 from devoncarew/refactor_stop
...
refactor the stop command to not use DeviceStore
2016-03-03 12:06:57 -08:00
Devon Carew
c54d54b7be
improve the atom validation
2016-03-03 12:06:30 -08:00
Adam Barth
96ec5316b8
Switch from hack_load_vm_file_hook to PlatformPlugin
...
This patch switches us from using our previous hacking approach to integrating
with package:test to using the new PlatformPlugin interface.
2016-03-03 11:23:36 -08:00