Jenn Magder
8ddc27e607
Split globals.dart into null sound and unsound libraries ( #79016 )
2021-03-31 16:55:20 -07:00
Jonah Williams
29207e4f78
[flutter_tools] split application package factory dependencies ( #79461 )
2021-03-31 15:11:58 -07:00
Gurjinder Partola
fed35b4d9c
[flutter_tools] Add support for versioned Android cmdline tools ( #78253 )
2021-03-25 13:42:39 -07:00
Jenn Magder
8893e89d11
Migrate device_port_forwarder to null safety ( #78949 )
2021-03-24 16:56:14 -07:00
Jenn Magder
63d6ec56af
Migrate deferred_components_validator to null safety ( #78934 )
2021-03-24 15:20:05 -07:00
Jenn Magder
d165ea5c42
Migrate os to null safety ( #78901 )
2021-03-23 17:28:09 -07:00
Zachary Anderson
5efc7169eb
Reverts "Implement dartPluginClass support for plugins #74469 " ( #78623 )
...
* Revert "Enable dart_plugin_registry_test (#76645 )"
This reverts commit 109e0bb9f5https://github.com/flutter/flutter/pull/76662 (#77093 )"
This reverts commit cdca6485f0#76662 )"
This reverts commit dadbd47d09#76561 )"
This reverts commit 098ece522d#76838 )"
This reverts commit 1610a27476#74469 )"
This reverts commit b7d4806243
2021-03-23 14:28:11 -07:00
Gary Qian
2a8b296ae9
[flutter_tools] Deferred components: Encode base module loading units in manifest metadata ( #78079 )
2021-03-15 15:58:06 -07:00
Gurjinder Partola
2e17a8e676
Fix avdmanager path detection ( #78166 )
2021-03-15 11:18:04 -07:00
Jenn Magder
d018c24bb8
MockProcessUtils->FakeProcessManager in version_test ( #77985 )
2021-03-12 16:38:04 -08:00
Jonah Williams
a01f37245b
[flutter_tools] remove globals from terminal ( #77953 )
2021-03-12 12:53:05 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint ( #77434 )
2021-03-05 18:38:15 -08:00
Gary Qian
ee41782732
[flutter_tools] Deferred components build system ( #76192 )
2021-03-04 18:09:02 -08:00
Jonah Williams
945e0df104
[flutter_tools] remove several AndroidSdk Mocks ( #77264 )
2021-03-04 12:24:03 -08:00
Jonah Williams
90f353f9b1
[flutter_tools] dont crash when looking for AS4.1 on windows with no LOCALAPPDATA ( #77261 )
2021-03-04 11:29:20 -08:00
Michael Goderbauer
7b251f5f37
Enable use_function_type_syntax_for_parameters lint ( #77163 )
2021-03-04 08:59:17 -08:00
Jonah Williams
05ce6ce511
[flutter_tools] remove mock from android studio test ( #77158 )
2021-03-03 11:04:02 -08:00
William Oprandi
679b8c2982
Fix Android Studio detection and plugins on Linux ( #75612 )
2021-03-03 08:29:03 -08:00
Jonah Williams
72a835fa55
[flutter_tools] remove mocks from android SDK tests ( #76887 )
2021-02-27 11:56:01 -08:00
Jonah Williams
2951363dc8
[flutter_tools] switch FakeCache to cache.test and NoopUsage to TestUsage ( #76802 )
2021-02-26 11:13:32 -08:00
Gary Qian
9df362a73f
[flutter_tools] Refactor DeferredComponents validator and add build target ( #76400 )
2021-02-24 17:51:03 -08:00
Jonah Williams
bbaced6d12
[flutter_tools] cache adb path ( #76650 )
2021-02-23 17:26:02 -08:00
Jonah Williams
b678d0adec
[flutter_tools] remove globals and mocks from android gradle builder and test ( #76416 )
2021-02-19 21:07:43 -08:00
Emmanuel Garcia
b7d4806243
Implement dartPluginClass support for plugins ( #74469 )
2021-02-19 09:22:45 -08:00
Jenn Magder
62d8969203
Adopt Artifacts.test(localEngine:) in a few tests ( #76354 )
2021-02-18 19:31:03 -08:00
Jonah Williams
6b14558a68
[flutter_tools] remove global usage of flutterUsage from gradle ( #76330 )
2021-02-18 15:52:00 -08:00
Sam Rawlins
ba58ad0385
Remove "unnecessary" imports in test/general.shard ( #75954 )
2021-02-18 13:38:24 -08:00
Jonah Williams
04182572f7
[flutter_tools] allow bypassing context for FlutterProject creation, remove fromPath ( #76258 )
2021-02-18 12:36:04 -08:00
Gary Qian
ba5cc2cba4
[flutter_tools] Deferred components setup validator ( #75739 )
2021-02-18 12:01:03 -08:00
Jonah Williams
bfcb43d2fc
[flutter_tools] remove local engine from globals in gradle ( #76277 )
2021-02-18 11:30:44 -08:00
Jenn Magder
e5b5e1475c
Adopt FakeProcess, remove MockProcess ( #76276 )
2021-02-18 11:13:26 -08:00
Jonah Williams
555721de24
[flutter_tools] remove mock process manager from gradle tests ( #76252 )
2021-02-17 17:00:12 -08:00
Jonah Williams
93e7d34dc4
[flutter_tools] Remove globals/mocks from GradleUtils ( #76020 )
2021-02-17 14:26:57 -08:00
Jonah Williams
65599e2825
[flutter_tools] use less path manipulation in the Android SDK ( #75930 )
2021-02-16 13:54:44 -08:00
Jonah Williams
dce8f71228
[flutter_tools] do not use context logger in gradle ( #75940 )
2021-02-12 17:38:52 -08:00
Hidenori Matsubayashi
4cc0ab2d19
[flutter_tools] Add ARM64 Linux host and cross-building option support ( #61221 )
2021-02-12 14:25:30 -08:00
Jonah Williams
97a9f2ae93
[flutter_tools] move gradle helper methods into AndroidBuilder class body, split unit tests ( #75931 )
2021-02-12 14:24:13 -08:00
mx1up
cc95c972b7
properly pass on gradle exit code ( #71484 ) ( #71582 )
2021-02-11 14:11:03 -08:00
Jenn Magder
5b823cded8
Remove dead mock classes ( #75757 )
2021-02-10 17:01:28 -08:00
Jenn Magder
88e6d46d5e
MockProcessManager -> FakeProcessManager ( #75544 )
2021-02-09 16:05:30 -08:00
Jenn Magder
152d88a3df
Add exception to FakeCommand ( #75545 )
2021-02-09 10:07:46 -08:00
Jonah Williams
021311ed8a
Revert "[flutter_tools] move process manager into tool ( #75350 )" ( #75639 )
...
This reverts commit 8b6baae44c
2021-02-08 09:21:46 -08:00
Jonah Williams
8b6baae44c
[flutter_tools] move process manager into tool ( #75350 )
...
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Jonah Williams
44d5950d27
[flutter_tools] switch dart defines to base64 to avoid windows control characters ( #75027 )
...
= gets escaped into %3D which seems to be tripping up cmake on windows since % is a control character. Switch to base64 encoding, since this does not have % nor , in the output character set.
This change is not trivially cherry pickable, and isn't tested on windows aside from my local, manual tests due to the planned CI work not being complete yet.
Fixes #75017
Fixes #74705
2021-02-02 09:10:48 -08:00
Jenn Magder
73506f36f7
Replace MockConfig with TestConfig ( #75044 )
2021-02-01 18:16:05 -08:00
Jonah Williams
18b1e23e89
[flutter_tools] move some fakes out of mocks.dart ( #74992 )
2021-01-29 14:28:18 -08:00
Jonah Williams
8db51f665d
[flutter_tools] remove mock android device from log reader test ( #74995 )
2021-01-29 14:27:58 -08:00
Jenn Magder
dbb1958c5e
Add canRun override to FakeProcessManager ( #74865 )
2021-01-28 19:06:56 -08:00
Jenn Magder
6ecb8cbcfa
Replace MockUsage with TestUsage ( #74946 )
2021-01-28 18:49:04 -08:00
Jenn Magder
ff87150ba9
Revert "Swap MockStdio to FakeStdio in tests ( #74838 )" ( #74867 )
...
This reverts commit 547ed88ab3
2021-01-27 19:35:16 -08:00
Jenn Magder
547ed88ab3
Swap MockStdio to FakeStdio in tests ( #74838 )
2021-01-27 17:33:47 -08:00
Jenn Magder
3f380ca544
Swap mockito import for test/fake ( #74847 )
2021-01-27 16:02:44 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. ( #74832 )
...
* opt out the flutter tool
* oops EOF
* fix import
* Update tool_backend.dart
* Update daemon_client.dart
* fix more
2021-01-27 15:17:53 -08:00
Alexandre Ardhuin
d546e1d311
fix for upcoming lint use_named_constants ( #74788 )
2021-01-27 20:20:44 +01:00
Jenn Magder
1ad6edb8d5
Remove MockProcessManager from channel_test and other tests ( #74780 )
2021-01-27 11:17:29 -08:00
Jonah Williams
efcf2c664e
[flutter_tools] check if process manager can find adb ( #74672 )
2021-01-25 14:15:23 -08:00
xster
e0dcb787dc
groovy escaping was wrong for aar ( #72554 )
2021-01-07 11:43:27 -08:00
Jenn Magder
cdacae89e1
Revert "Launch named iOS simulators ( #72323 )" ( #72447 )
...
This reverts commit 84a7a611b0
2020-12-16 11:52:59 -08:00
Jenn Magder
84a7a611b0
Launch named iOS simulators ( #72323 )
2020-12-15 15:06:47 -08:00
Jason Simmons
2c3ba5b635
Create symlinks for local engine Maven metadata files required by the Android Gradle plugin ( #71600 )
2020-12-03 15:28:06 -08:00
Emmanuel Garcia
8dd0de7f58
Relands: Migrate template to Gradle 6.7 and AGP 4.1.0 ( #71446 )
2020-12-01 19:01:09 -08:00
Jonah Williams
f8883445ca
Revert "[flutter_tools] post process the gradle log output ( #71499 )" ( #71527 )
...
This reverts commit d688b52a93
2020-12-01 17:53:14 -08:00
Jonah Williams
d688b52a93
[flutter_tools] post process the gradle log output ( #71499 )
2020-12-01 17:13:33 -08:00
Jenn Magder
a5ee7f7cfc
Add XCFramework artifacts ( #71113 )
2020-12-01 10:00:16 -08:00
Amir Hardon
7df04fdbd3
Revert "Migrate template to Gradle 6.7 and AGP 4.1.0 ( #70808 )" ( #71096 )
...
This reverts commit 8e73bab94c
2020-11-23 12:27:36 -08:00
Emmanuel Garcia
8e73bab94c
Migrate template to Gradle 6.7 and AGP 4.1.0 ( #70808 )
2020-11-20 13:05:35 -08:00
Jonah Williams
f98c468317
[flutter_tools] remove unused JSON schema ( #70480 )
2020-11-13 13:02:40 -08:00
Jonah Williams
a40ee8a3fb
[flutter_tools] migrate .packages to package_config, partial ( #70200 )
2020-11-11 13:50:41 -08:00
Jonah Williams
2fb53d83f2
[flutter_tools] remove all globals from cache and cache_test ( #69505 )
2020-11-06 15:26:45 -08:00
Mokusesei
6269abb75b
Reland: fix android studio 4.1 plugin path for mac ( #69954 )
2020-11-06 10:57:04 -08:00
Jonah Williams
e18533e7ab
[flutter_tools] remove globals from android_workflow ( #69548 )
2020-11-06 10:55:52 -08:00
Vyacheslav Egorov
4c24eb10b8
Revert "Fix: fix android studio 4.1 plugin path for macOS" ( #69870 )
...
This reverts commit 422a97d1e5https://github.com/flutter/flutter/issues/69863
2020-11-05 11:18:00 +01:00
Mokusesei
422a97d1e5
Fix: fix android studio 4.1 plugin path for macOS ( #69364 )
2020-11-04 17:25:53 -08:00
Alexandre Ardhuin
17cdf5559d
enable unnecessary_string_escapes and use_raw_strings ( #68302 ) ( #69025 )
2020-10-26 12:42:05 -07:00
Zachary Anderson
cbcd1321ed
Revert "enable unnecessary_string_escapes and use_raw_strings ( #68302 )" ( #68714 )
...
This reverts commit ae06c19a37
2020-10-21 08:16:13 -07:00
Alexandre Ardhuin
ae06c19a37
enable unnecessary_string_escapes and use_raw_strings ( #68302 )
2020-10-21 16:34:24 +02:00
Jonah Williams
e422d5c724
[flutter_tools] reland: --no-android-gradle-daemon in devicelab ( #68491 )
...
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.
Example:
flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
2020-10-19 10:27:58 -07:00
Jonah Williams
ed5482de19
Revert "[flutter_tools] add --android-gradle-daemon option, use in devicelab ( #68409 )" ( #68489 )
...
This reverts commit ddab72e79f
2020-10-19 09:33:52 -07:00
Jonah Williams
ddab72e79f
[flutter_tools] add --android-gradle-daemon option, use in devicelab ( #68409 )
...
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.
Example:
flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
2020-10-19 09:12:21 -07:00
Alexandre Ardhuin
73301a35a2
Sync lints ( #68136 )
2020-10-15 15:37:04 -07:00
Jonah Williams
27936e9f22
Revert "[flutter_tools] ensure android log reader works in flutter drive ( #68131 )" ( #68222 )
...
This reverts commit d962c8f2a2
2020-10-15 10:50:56 -07:00
Jonah Williams
2321b72dfb
[flutter_tools] move gradle download failure handling into tool ( #68140 )
...
This crash affects anyone using flutter, so move it into the tool where it can be tested and documented. Ensure it works on windows devicelab too.
2020-10-15 09:20:52 -07:00
Jonah Williams
d962c8f2a2
[flutter_tools] ensure android log reader works in flutter drive ( #68131 )
2020-10-14 14:04:33 -07:00
Jonah Williams
9e70180f63
[flutter_tools] do not measure progress timeout ( #67959 )
...
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
2020-10-13 13:05:47 -07:00
Jonah Williams
1c976933f3
[flutter_tools] support Android Studio 4.1 on Windows ( #67992 )
...
Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.
fixes #67986
2020-10-13 11:33:26 -07:00
Jonah Williams
fd11d149f7
[flutter_tools] teach flutter drive to uninstall if install fails ( #67936 )
...
Work towards #39925
Currently flutter run will uninstall and reinstall if the initial install fails and the APK was previously installed. Allow drive to share this same logic by moving it into installApp and out of startApp.
This should reduce the occurrence of the error in the devicelab.
2020-10-12 12:49:36 -07:00
Jonah Williams
6180a4c179
[flutter_tools] fix documentation, globals, and todos in the android codebase ( #66980 )
...
Cleans up some undocumented classes and re-organizes the AndroidDevices class to avoid the need for the static testing only member. Adds a script for tracking globals.
2020-10-05 15:47:57 -07:00
Jenn Magder
e8fbb43aac
Replace MockFile with memory file system files ( #66941 )
2020-09-29 17:50:33 -07:00
Jonah Williams
9bc533c9e5
[flutter_tools] do not error flutter doctor on missing AS/intellij plugins ( #66782 )
...
In cases where the Intellij/AS plugins are not located, display links to where they can be downloaded but do not surface an error. This should generally reduce confusion about whether the plugins are required for every installed IDE. For example, frequently users may only install AS so that they can install the Android SDK - or they may have multiple copies of Intellij installed.
For example: #66762
2020-09-29 16:51:28 -07:00
knaeckeKami
8e9e13449b
Teach the flutter tool how to find android output files if the flavor contains uppercase letters ( #66687 )
...
This changes the name of the generated output files on android in case a flavor with uppercase letters is used.
Previously, the lowercased flavor name would be used for the apk/aab file. Now, the flavor name is used as-is.
2020-09-25 15:54:55 -07:00
Daniel Edrisian
3a5e45404d
Updated androidMissingSdkInstructions error message ( #65964 )
2020-09-17 15:57:06 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. ( #65568 )
2020-09-16 14:14:06 -07:00
Jonah Williams
08e3ed9e2d
[flutter_tools] prevent creation of android devices if adb is not located ( #65184 )
...
More work to prevent current #2 crash issue on stable. If adb is not located do not list/create android devices.
2020-09-03 11:01:43 -07:00
Jonah Williams
d3515f5fb6
[flutter_tools] add analytics to code size, add more testing ( #64578 )
...
* [flutter_tools] add analytics to code size, add more testing
* add gradle case
* Update build_macos_test.dart
* move analytics to code size tooling
* Update analyze_size.dart
* fix analysis
2020-08-27 09:45:10 -07:00
Jonah Williams
401d401c59
[flutter_tools] reland: avoid creating Android Devices if AndroidSDK cannot be found ( #64665 )
...
Avoid creating AndroidDevice discovery if the SDK cannot be located. Previously the tool would use which/where adb, however this required us to handle the AndroidSdk class being potentially null - which required an additional layer of indirection around all access. Sometimes these were forgotten leading to NPEs.
In general, not much can be done with an Android Device if the actual SDK is not installed.
Reland with fixed code + tests for null SDK + adb in AndroidDeviceDiscovery
2020-08-27 09:44:31 -07:00
Jenn Magder
f5187535d5
Revert "[flutter_tools] avoid creating Android Devices if AndroidSDK cannot be found ( #64524 )" ( #64602 )
...
This reverts commit 47596c6203
2020-08-25 17:55:58 -07:00
Jonah Williams
47596c6203
[flutter_tools] avoid creating Android Devices if AndroidSDK cannot be found ( #64524 )
...
Avoid creating AndroidDevice discovery if the SDK cannot be located. Previously the tool would use which/where adb, however this required us to handle the AndroidSdk class being potentially null - which required an additional layer of indirection around all access. Sometimes these were forgotten leading to NPEs.
In general, not much can be done with an Android Device if the actual SDK is not installed.
2020-08-25 11:08:27 -07:00
xster
a2e5e074ab
Move Android doctor SDK check to 29 and Cirrus images to 30 ( #63517 )
2020-08-20 11:06:32 -07:00
Jonah Williams
4954a46ff0
[flutter_tools] shrink API surface of Android SDK ( #63867 )
...
Attempt to simplify the Android SDK interface ahead of refactoring it. The locateAndroidSdk static method is called at startup to locate the android SDK, returning null if it cannot be found. These helper methods attempted to first look up the AndroidSDK if it was already null - which could only cover the case where someone installed the Android SDK while flutter was running (possibly through an IDE)
2020-08-19 14:44:56 -07:00
Jonah Williams
9225d8d5b7
[flutter_tools] move to fake_async, skip failing tests ( #63536 )
2020-08-11 19:36:05 -07:00
