Michael Goderbauer
5491c8c146
Auto-format Framework ( #160545 )
...
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.
**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2024-12-19 20:06:21 +00:00
David Iglesias
1e1b5271f4
[tool] Removes deprecated --web-renderer parameter. ( #159314 )
...
Removes the `--web-renderer` option.
Flutter tool users won't be able to select their web renderer.
In order to not drop test coverage, tests are still run with the HTML
Renderer, until its code is fully removed from the engine.
Part of https://github.com/flutter/flutter/issues/145954
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-02 18:33:02 +00:00
Yegor
e8d2e5814e
[web] hide the --web-renderer option in the tool ( #152683 )
...
Hide the `--web-renderer` option in the Flutter Tool. The defaults already cover all fully supported modes:
- `flutter build web` provides canvaskit + dart2js
- `flutter build web --wasm` provides skwasm + dart2wasm
We do not want to encourage production usage of any other permutations (e.g. `auto` or `html`), in particular those that simply do not work (e.g. `skwasm` + dart2js).
Fixes https://github.com/flutter/flutter/issues/140096
Fixes https://github.com/flutter/flutter/issues/151786
2024-08-07 18:40:58 +00:00
Christopher Fujino
0d95243fb2
[flutter_tools] Precache after channel switch ( #118129 )
...
Fixes https://github.com/flutter/flutter/issues/44118
2023-06-09 01:46:24 +00:00
Victoria Ashworth
cd18c8c02f
Workaround for Dart VM timeout ( #127875 )
...
Workaround solution for: https://github.com/flutter/flutter/issues/121231
See https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 Error Case 2 for more information.
Sometimes the `ios-deploy` process does not return the logs from the application. We've been unable to figure out why. This is a solution to workaround that by using `idevicesyslog` alongside `ios-deploy` as a backup in getting the log for the Dart VM url. As explained in https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 , when error case 2 happens, the `idevicesyslog` does successfully find the Dart VM.
Also, in the comments of the code it mentions `syslog` is not written on iOS 13+, this was added in response to this issue: https://github.com/flutter/flutter/issues/41133 .
However, `idevicesyslog` does in fact work (at least for iOS 16), we use it to collect device logs for our CI tests already: 1dc26f80f0/dev/devicelab/lib/framework/devices.dart (L998-L1006)
2023-06-02 17:17:57 +00:00
Michael Goderbauer
5e1ba701ed
enable no_literal_bool_comparisons lint ( #126647 )
2023-05-16 16:14:23 +00:00
Christopher Fujino
b2c65acd5a
[flutter_tools] Remove --no-sound-null-safety #4 ( #124039 )
...
Re-land of https://github.com/flutter/flutter/pull/123297 without any of
the commits at the end attempting to fix customer-testing.
Fixes https://github.com/flutter/flutter/issues/118810
2023-04-04 15:25:27 -07:00
Casey Hillers
6fe54f8811
Revert "[flutter_tools] Remove --no-sound-null-safety #3 " ( #123969 )
...
Revert "[flutter_tools] Remove --no-sound-null-safety #3 "
2023-04-03 00:19:22 +00:00
Christopher Fujino
820ec70a8d
[flutter_tools] Remove --no-sound-null-safety #3 ( #123297 )
...
[flutter_tools] Remove --no-sound-null-safety #3
2023-03-29 17:56:23 +00:00
Christopher Fujino
7e151b4641
[flutter_tools] throw tool exit on invocation of flutter format ( #121646 )
...
[flutter_tools] throw tool exit on invocation of flutter format
2023-03-16 21:40:26 +00:00
Bartek Pacia
37fc9ed260
[flutter_tools] Clean up boolArgDeprecated and stringArgDeprecated ( #122184 )
...
[flutter_tools] Clean up `boolArgDeprecated` and `stringArgDeprecated`
2023-03-13 21:20:19 +00:00
Parker Lougheed
9e11d4a105
Use correct API docs link in create --sample help message ( #118371 )
...
* Use correct API doc link in create --sample help message
* Verify Flutter and Dart website links in tool help messages use https
* Adjust test failure reasoning message
2023-01-12 23:47:19 +00:00
Gary Qian
21861423f2
[flutter_tools] analyze --suggestions --machine command ( #112217 )
2022-10-03 17:40:58 +00:00
Liam Appelbe
4453ba0a4d
Null safety migration of packages/flutter_tools/test/general.shard, part 2/2 ( #110712 )
...
* Migrate packages/flutter_tools/test/general.shard, part 2/2
* Fix analysis
* Fix tests
* Fix analysis
* Apply suggestions from code review
Co-authored-by: Christopher Fujino <fujino@google.com>
Co-authored-by: Christopher Fujino <fujino@google.com>
2022-09-07 12:28:52 -07:00
Jesús S Guerrero
e271e8428b
add GeneralInfo project validator to analyze --suggestions ( #109874 )
2022-08-19 21:18:49 +00:00
Aman Verma
b02f68a66c
[flutter_tools] refactor stringsArg ( #105032 )
2022-08-05 13:17:06 +00:00
Bryan Oltman
bf7df23350
Remove superfluous periods from pub --help subcommand descriptions. ( #106925 )
...
* Remove periods from pub --help command descriptions
* Add trailing period consistently
* Remove added period from PackagesInteractiveGetCommand description
* Verify line ending for first line of command description
* Update _allowedTrailingPatterns to validate that lines end with only one period, bang, or colon
2022-07-11 13:06:31 -04:00
Aman Verma
8fbf89b9f2
[flutter_tools] throw error when argResults is null ( #103827 )
2022-05-17 12:37:08 -07:00
Aman Verma
f86dfdd2b7
[flutter_tools] boolArg refactor ( #102088 )
2022-05-09 21:54:08 -07:00
Jesús S Guerrero
596e9d1c47
[flutter_tools] stringArg refactor ( #103231 )
2022-05-09 09:54:12 -07:00
Pierre-Louis
3e43c3e110
Categorize flutter tool commands ( #87747 )
2021-10-05 17:28:04 -07:00
Danny Tuppeny
dec122a4d8
Remove incorrect text about web renderer default ( #85214 )
2021-06-28 12:56:06 -07:00
Hattomo (TomohiroHattori)
08a70e7ac8
Enable avoid_escaping_inner_quotes lint ( #81153 )
2021-05-19 09:54:02 -07:00
Ian Hickson
a7eb2c8a1a
Use "aliases" in args to fix some technical debt ( #81073 )
2021-04-27 14:54:03 -07:00
Ian Hickson
ce318b7b53
All arguments must be documented. ( #75888 )
2021-02-14 12:56:05 -08:00
