Jonah Williams
4e16e67946
[devicelab] explicitly enable vulkan validation in test. ( #147382 )
...
Part of https://github.com/flutter/flutter/issues/142659
this test expects validation layers on, so we need to explicitly enable
them before we can turn them off by default.
2024-04-25 14:07:53 -07:00
auto-submit[bot]
65d5d36759
Reverts "Try to be more consistent about deleting test apps in devicelab logic ( #146931 )" ( #146947 )
...
Reverts: flutter/flutter#146931
Initiated by: Hixie
Reason for reverting: more failures
Original PR Author: Hixie
Reviewed By: {reidbaker}
This change reverts the following previous change:
Fixes #137555 .
This is an updated version of https://github.com/flutter/flutter/pull/146856 , which was reverted in https://github.com/flutter/flutter/pull/146927 . The first commit is identical to the original PR, and subsequent commits are the fixes to address failures detected in devicelab post-commit.
2024-04-17 21:08:47 +00:00
Ian Hickson
fb7e8b0653
Try to be more consistent about deleting test apps in devicelab logic ( #146931 )
...
Fixes #137555 .
This is an updated version of https://github.com/flutter/flutter/pull/146856 , which was reverted in https://github.com/flutter/flutter/pull/146927 . The first commit is identical to the original PR, and subsequent commits are the fixes to address failures detected in devicelab post-commit.
2024-04-17 20:19:42 +00:00
auto-submit[bot]
f8c3e52776
Reverts "Try to be more consistent about deleting test apps in devicelab logic. ( #146856 )" ( #146927 )
...
Reverts: flutter/flutter#146856
Initiated by: Hixie
Reason for reverting: breaking tree
Original PR Author: Hixie
Reviewed By: {reidbaker}
This change reverts the following previous change:
Fixes https://github.com/flutter/flutter/issues/137555 .
2024-04-17 17:41:16 +00:00
Ian Hickson
0301c8dfa4
Try to be more consistent about deleting test apps in devicelab logic. ( #146856 )
...
Fixes https://github.com/flutter/flutter/issues/137555 .
2024-04-17 17:18:26 +00:00
gaaclarke
57ad4ff018
Added a devicelab test for vulkan validation layers ( #134685 )
...
This makes sure validation layers are being used and that there are no
validation errors
fixes https://github.com/flutter/flutter/issues/134175
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-14 09:13:35 -07:00
