Andrew Kolos
13beab1ecc
add verbose logging to select hot reload/hot restart tests ( #147673 )
...
In service of https://github.com/flutter/flutter/issues/146879 and https://github.com/flutter/flutter/issues/145812 . In these issues, we see what appears to be the flutter tool getting stuck somewhere during hot reload. It may help if we knew were exactly where we are getting stuck (preparing assets, writing them to device, etc.).
This PR adds a new parameter to `FlutterTestDriver::run`, `verbose`. When verbose is set, `FlutterTestDriver` will run `flutter` with `--verbose` in its tests. Keep in mind that `FlutterTestDriver` only prints logs from `flutter` when a test fails, so this shouldn't spam the logs of passing tests.
This PR sets the parameter when invoking the flaky tests from https://github.com/flutter/flutter/issues/146879 and #145812 , so we should see more detailed logs in future flakes.
While this is a low risk PR, you can verify the change by intentionally breaking hot reload code, clearing the cached tool binaries, and then running either of these tests.
2024-05-02 04:03:32 +00:00
Ian Hickson
a2e2574941
Remove the fast reassemble / single widget reload feature ( #132255 )
...
Fixes https://github.com/flutter/flutter/issues/132157
2023-08-10 21:48:06 +00:00
Jason Simmons
a08a211040
Ignore app.stop events received before the app.detach response in attach integration tests ( #128593 )
...
The app.detach command will close the VM service connection, which yields an app.stop event in the daemon protocol. The daemon does not guarantee any ordering between this event and the response to the app.detach.
See https://github.com/flutter/flutter/issues/128546
2023-06-09 17:50:03 +00:00
Christopher Fujino
4ff505c861
[flutter_tools] more debugging for timeouts in break_on_framework_exceptions test ( #125584 )
...
Better debugging to investigate: https://github.com/flutter/flutter/issues/125241
When the `test/integration.shard/break_on_framework_exceptions_test.dart` test times out, log out verbose logging to give clues as to why it did not complete.
From one local run it looks like the test runner is failing to load a test file (when I checked the path locally, the file was there, and re-running the `flutter test ...` invocation succeeded--in that the app threw an exception):
```
14:12 +26 -1: breaks when StatefulWidget.build throws [E]
Timed out launching `flutter test`
package:matcher fail
test/integration.shard/break_on_framework_exceptions_test.dart 623:11 _timeoutAfter.<fn>
250s Spawning flutter [test, --disable-service-auth-codes, --machine, --start-paused, test/test.dart] in /tmp/flutter_break_on_framework_exceptions.GUJDAZ
251s <=stdout= {"protocolVersion":"0.1.1","runnerVersion":null,"pid":25763,"type":"start","time":0}
<=stdout= {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0}
<=stdout= {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0}
258s <=stdout= {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3 throwToolExit\npackage:flutter_tools/src/compile.dart 813:13 DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11 _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20 _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18 _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart...
<=stdout= {"testID":1,"error":"Failed to load \"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart\": Compilation failed for testPath=/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","stackTrace":"","isFailure":false,"type":"error","time":7518}
<=stdout= {"testID":1,"result":"error","skipped":false,"hidden":false,"type":"testDone","time":7521}
<=stdout= {"count":1,"time":7526,"type":"allSuites"}
<=stdout= {"success":false,"type":"done","time":7529}
259s Process exited (1)
371s Expecting test.startedProcess event
[+ 95] <=stdout= {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0}
[+ 95] <=stdout= {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0}
[+ 7600] <=stdout= {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3 throwToolExit\npackage:flutter_tools/src/compile.dart 813:13 DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11 _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20 _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18 _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24...
Expecting test.startedProcess event is taking longer than usual...
```
2023-04-27 18:37:59 +00:00
Danny Tuppeny
1a6a20cdc6
[flutter_tools] Include mode in app.start event, and forward app.start to DAP clients ( #121239 )
...
[flutter_tools] Include mode in app.start event, and forward app.start to DAP clients
2023-04-05 05:39:09 +00:00
Ben Konyi
5a36bddd2b
Stop serving Observatory by default ( #122419 )
...
Observatory can still be enabled by providing `--serve-observatory` or
invoking the `_serveObservatory` private service RPC via web socket or
HTTP.
Related to https://github.com/dart-lang/sdk/issues/50233
2023-03-23 12:52:30 -04:00
Ben Konyi
ecd7518df5
Reland "Remove references to Observatory ( #118577 )" ( #121606 )
...
This reverts commit 275ab9c69b
2023-02-28 11:57:04 -05:00
Michael Goderbauer
275ab9c69b
Revert "Reland "Remove references to Observatory ( #118577 )" ( #121215 )" ( #121555 )
...
Revert "Reland "Remove references to Observatory (#118577 )""
2023-02-27 23:46:53 +00:00
Ben Konyi
fbae472fc3
Reland "Remove references to Observatory ( #118577 )" ( #121215 )
...
This reverts commit 298d8c76ba
2023-02-27 09:26:43 -05:00
Ian Hickson
6205c110d6
Remove "note that" in our documentation (as per style guide) ( #120842 )
...
* lerp documentation
* Remove Note, Note That from repo
* Improve BorderSide documentation.
* apply review comments
2023-02-17 22:27:33 +00:00
Casey Hillers
298d8c76ba
Revert "Remove references to Observatory ( #118577 )" ( #120929 )
...
This reverts commit 2df140f40d
2023-02-16 21:28:30 -08:00
Christopher Fujino
c6b636fa51
[flutter_tools] Replace Future.catchError() with Future.then(onError: ...) ( #120637 )
...
* wip run_local_linter.dart
* get run_local_linter.dart working
* slow working implementation
* speed up run_local_linter.dart
* fix run_local_linter.dart
* remove catchError
* another fix
* fix another
* fix
* more fixes
* fix moar
* fix moar
* fix
* finish
* fix tests
* clean up further
* code review
* delete run_local_linter.dart
2023-02-15 19:03:00 +00:00
Ben Konyi
2df140f40d
Remove references to Observatory ( #118577 )
...
Observatory is being deprecated for Dart 3.0 so it should no longer be
referenced in tooling messaging / flags.
See https://github.com/dart-lang/sdk/issues/50233
2023-02-13 14:29:30 -05:00
Ben Konyi
47a0674651
Reland "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119737 )
...
This reverts commit 254a796bc3
2023-02-06 09:23:35 -05:00
Zachary Anderson
254a796bc3
Revert "Reland "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119529 )" ( #119729 )
...
This reverts commit 7477d7ac79
2023-02-01 09:19:48 -08:00
Ben Konyi
7477d7ac79
Reland "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119529 )
...
* Reland "Add --serve-observatory flag to run, attach, and test (#118402 )"
This reverts commit 86ab01d2bd
2023-01-30 21:00:18 +00:00
Zachary Anderson
86ab01d2bd
Revert "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119302 )
...
This reverts commit 6cd4fa45e2
2023-01-26 16:43:39 -08:00
Ben Konyi
6cd4fa45e2
Add --serve-observatory flag to run, attach, and test ( #118402 )
...
This flag will allow for Observatory to be served by the VM service once it is disabled by default in the Dart SDK.
2023-01-25 12:46:08 -05:00
Michael Goderbauer
38630b6bd1
Remove unnecessary null checks in flutter_tool ( #118857 )
...
* dart fix --apply
* manual fixes
* fix after merge conflicts
* review
2023-01-23 21:43:08 +00:00
Danny Tuppeny
3599b3a877
Add support for expression compilation when debugging integration tests ( #113481 )
...
Fixes #79439 .
2022-10-25 15:34:22 +01:00
Jonah Williams
db829c1e20
[flutter_tools] migrate more unit tests to null safety ( #106153 )
2022-06-17 21:34:27 -07:00
Jenn Magder
c6ced845e3
Remove custom unawaited, prefer dart:async version ( #103212 )
2022-05-07 08:49:04 -07:00
Alexandre Ardhuin
d40ee2149c
remove unnecessary .toString() ( #103226 )
2022-05-06 16:04:13 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Michael Goderbauer
dcde8163ce
migrate to super params ( #100509 )
2022-03-31 11:46:47 -07:00
Tomasz Gucio
e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint ( #98753 )
2022-02-22 14:39:20 -08:00
Lau Ching Jun
d7688ca093
Change all instance of throwing strings to throw specific error classes. ( #97325 )
2022-02-02 10:45:18 -08:00
Michael Goderbauer
5684b9f69e
Enable no_leading_underscores_for_local_identifiers ( #96422 )
2022-01-21 14:43:59 -08:00
Anna Gringauze
d7466d8963
Update dwds and other packages ( #94634 )
2021-12-07 14:29:07 -08:00
Anna Gringauze
ca62470796
De-flake web tool tests ( #93948 )
2021-11-30 17:39:05 -08:00
Jenn Magder
305a855f6d
Migrate integration test shard test data to null safety ( #92147 )
2021-10-20 14:58:05 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be24
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Ian Hickson
f25b833f27
Enable avoid_print lint. ( #91444 )
2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231
Revert "Enable avoid_print lint. ( #91332 )" ( #91438 )
...
This reverts commit cb378edc9e
2021-10-07 16:16:17 -04:00
Ian Hickson
cb378edc9e
Enable avoid_print lint. ( #91332 )
2021-10-07 09:53:03 -07:00
Anna Gringauze
831d82c8ea
Fix race conditions in test_driver for tool tests ( #88322 )
2021-08-17 18:37:04 -07:00
Anna Gringauze
33fd4f15a9
Fix race causing null dereference on getStack in web_tool_tests and CI flakes ( #87278 )
2021-07-29 16:59:02 -07:00
Ahmed Ashour
529a599ce6
Fix some indentation ( #84967 )
2021-07-01 13:41:04 -07:00
Greg Spencer
88f3811055
Turn on avoid_dynamic_calls lint, except packages/flutter tests, make appropriate changes. ( #84476 )
...
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated.
Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
2021-06-14 14:16:57 -07:00
Alexandre Ardhuin
34059eec2c
enable lint prefer_interpolation_to_compose_strings ( #83407 )
2021-06-01 11:14:06 -07:00
Ian Hickson
e5414695d4
Change --disable-dds to --no-dds to avoid double negatives ( #80900 )
...
Also, refactor internal code to do the same.
See https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-double-negatives-in-apis
2021-04-23 16:29:38 -07:00
Jonah Williams
2bada6097b
[flutter_tools] add timeline ANR integration test ( #79991 )
2021-04-08 15:23:11 -07:00
Ben Konyi
75a44a29ad
[ Web ] Register service extensions with DDS, not DWDS ( #79479 )
2021-04-02 18:19:04 -07:00
Michael Goderbauer
197b440e96
Migrate out custom ignore syntax to flutter_ignore ( #78497 )
2021-03-19 15:33:05 -07:00
Michael Goderbauer
a7e3b1a35d
Clean up ignores that are not ignoring anything ( #78493 )
2021-03-19 15:32:46 -07:00
Jonah Williams
9f420ffb3e
[flutter_tools] io cleanups to simplify null safety migration ( #77955 )
2021-03-12 16:21:14 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint ( #77434 )
2021-03-05 18:38:15 -08:00
Ian Hickson
b1cc48748d
Only write the pid-file while listening to SIGUSR signals. ( #74533 )
2021-02-10 16:06:05 -08:00
