Commit Graph

582 Commits

Author SHA1 Message Date
Alexandre Ardhuin
919dcf53f3
enable lints prefer_spread_collections and prefer_inlined_adds (#35189) 2019-06-27 21:23:16 +02:00
Alexandre Ardhuin
fecf99ff1e
enable lint avoid_bool_literals_in_conditional_expressions (#35055) 2019-06-25 17:40:05 +02:00
Anthony
04bd87794d
[Material] Update slider gallery demo, including range slider (#34597)
Update the flutter_gallery Slider demo by aligning the text field in the first slider, adding range slider examples (including custom range thumbs), and separating single slider and range slider examples with tabs.
2019-06-24 17:10:11 -04:00
LongCatIsLooong
d759197d1f
Add scrollbars to Gallery (#33634) 2019-06-06 10:54:28 -07:00
Chris Bracken
4d9923201b
Correct typos (#33322)
Corects a bnuch of typeos throuhgout teh Fluter codebsae.

Made use of the `misspell` tool:
https://github.com/client9/misspell
2019-05-24 19:12:45 -07:00
Darren Austin
5ba0461b6d
Fixed several issues with the confirmDismiss handling on the LeaveBehindItem demo. (#33080) 2019-05-20 18:10:24 -07:00
Sam Rawlins
c2a93bd545 Fix missing return statements on function literals (#33058) 2019-05-20 12:51:57 -07:00
Darren Austin
3d93f24c05
Tapping a modal bottom sheet should not dismiss it by default (#32528)
Removed the GestureDetector from the modal bottom sheet that dismissed it on tap and updated several tests to accommodate this change.
2019-05-15 15:50:39 -07:00
Phil Quitslund
d96c1c88b7
make immutables const (#32340)
* make immutables const
2019-05-09 05:47:01 -07:00
MH Johnson
a40e5c90f0
[Material] selected/unselected label styles + icon themes on BottomNavigationBar (#31018)
* add text style params

* add icon theme params

* Added tests
2019-05-02 18:20:16 -04:00
Dan Field
fe9512fa72
Re-enable const (#31600)
* Re-enable const
2019-04-29 16:02:42 -07:00
LongCatIsLooong
7d19f97d03
Fix refresh control in the gallery demo, update comments (#30129)
- Fixed the bug where CupertinoRefreshControl doesn't work in the gallery demo on Android.
- Updated documentation on CupertinoRefreshControl
- Added comments to the gallery demo
- Added concrete examples to ScrollPhysics
2019-04-25 20:49:47 -07:00
xster
8cfc92465d
CupertinoPicker fidelity revision (#31464) 2019-04-25 00:03:04 -07:00
rami-a
d4e4726ac2
Update SnackBar to allow for support of the new style from Material spec (#31275)
This PR introduces a number of changes and improvements to snack bars. This includes the ability to specify:

floating style of snack bars that adhere to the updated Material spec
elevation and shape on the SnackBar itself instead of relying on fixed values
a snackBarTheme as part of ThemeData which allows you to customize all of the above on an app-wide level.
This PR is includes the changes from #21484 as well as additional fixes and modifications. Thanks to @NikoYuwono for providing these changes and getting this off the ground!
2019-04-24 17:22:30 -04:00
Anthony
0572f158fb
[Material] Adaptive Slider constructor (#30572)
Adds an adaptive constructor for the Material Slider. An adaptive widget is one that renders itself as Material on Android, and Cupertino on iOS. This work is based off of a similar feature on Switches: bbb080b#diff-fe2bb980c6207699cbf45538fe927afa.

The motivation for this change is that we should provide adaptive constructors for as many widgets as necessary in the Material library. In Material, it is suggested that the slider is an iOS-style slider.
2019-04-24 16:26:22 -04:00
Justin McCandless
ec7f3f0956
2d transforms UX improvements (#30932)
Small usability fixes for pan and zoom demo. Title and instruction dialog.
2019-04-15 15:11:26 -07:00
rami-a
a12c5618de
Prevent vertical scroll in shrine by ensuring card size fits the screen (#30455) 2019-04-08 11:22:19 -04:00
Taym Haddadi
3067825946 Add confirmDismiss example to flutter_gallery (#30497) 2019-04-05 16:02:55 -07:00
Alexandre Ardhuin
32f1b810ae shorter nullable list duplications (#30305) 2019-04-05 10:23:35 -07:00
Justin McCandless
3ada502832
Pan and zoom gallery demo (#25164)
Adds the "2D Transformations" demo to the gallery, which shows how to do things such as navigate around a map a la Google Maps, or show a full screen zoomable photo.  The idea is to abstract this code into a first class widget soon.
2019-04-04 11:59:36 -07:00
Michelle Dudley
eb4b3e4b62 Fix Shrine overscroll glow indicator (#27217) 2019-04-04 09:51:01 -04:00
Alexandre Ardhuin
bfa1d25bf9
some formatting of map, parameters and spaces (#29760) 2019-03-23 00:02:21 +01:00
Alexandre Ardhuin
a6af422874
some spaces formatting (#29452)
* some space formattings

* always use blocks in if-else if a block is used

* format spaces in for and while

* allow multiline if conditions

* fix missing space
2019-03-20 23:23:31 +01:00
Alexandre Ardhuin
a0d1f93b07
fix block formatting (#29051) 2019-03-09 09:03:11 +01:00
Alexandre Ardhuin
440ce8fde6
Fix indentations of statements in BlockFunctionBody (#28933)
* fix indentof statements in BlockFunctionBody

* fix indentof statements in BlockFunctionBody in tests
2019-03-07 21:09:28 +01:00
Phil Quitslund
802eca29d2
set literal conversions (#27811) 2019-03-06 11:05:16 -08:00
Alexandre Ardhuin
4c1f4d14e1
fix some formatting issues (#28809)
* fix some formatting issues

* address review comments

* fix indent
2019-03-06 09:37:32 +01:00
Alexandre Ardhuin
387f885481
Add missing trailing commas (#28673)
* add trailing commas on list/map/parameters

* add trailing commas on Invocation with nb of arg>1

* add commas for widget containing widgets

* add trailing commas if instantiation contains trailing comma

* revert bad change
2019-03-01 08:17:55 +01:00
Will Larche
3423c831b9
[Gallery] Fix fortnightly analysis for consts. (#28431) 2019-02-24 21:48:50 +01:00
Will Larche
57a8b03c5e
[Gallery] Fortnightly demo moved from flutter/samples. (#28125)
* [Gallery] Fortnightly demo moved from flutter/samples.

* [Gallery] Fortnightly analysis corrections.

* [Gallery] Minor rename.

* [Gallery] Making floats ints.

* [Gallery] Fortnightly minor visual polish.

* [Gallery] Formatting.

* [Gallery] Upping package version for gallery to support fortnightly demo.

* [Gallery] Fortnightly copy correction.

* [Gallery] Fortnightly study polish.

* [Gallery] Fortnightly polish.

* [Gallery] Fortnightly copy correction.

* [Gallery] Fortnightly copy now held in '''.

* [Gallery] Fortnightly comment.

* [Gallery] Updates necessary when flutter_gallery_assets updates.

* [Gallery] Updating macrobenchmarks because we updated flutter_gallery_assets.

* [Gallery] Moving spaces to beginning of copy lines.

* [Gallery] Copy correction.

* [Gallery] Adding tooltip to satisfy smoke test.

* [Gallery] Minor pr feedback.

* [Gallery] Forced upgrade.
2019-02-24 11:53:43 +01:00
rami-a
b28bdabc63
Minor UI tweaks to Cards demo based on internal feedback (#28215)
* Minor UI tweaks to Cards demo based on internal feedback

* Analyzer

* Tweak ink ripple opacity

* Address PR feedback
2019-02-22 15:50:58 -05:00
Hans Muller
617ca62709
[Material] Expand BottomNavigationBar API (reprise) (#28159) 2019-02-21 16:05:36 -08:00
Kartik Sharma
b4adafac08 Fixed Cupertino Switch Demo (#27528) 2019-02-13 12:43:08 -08:00
rami-a
c348be9739
[Material] Update the card demo in the Gallery to demonstrate different uses of the Card widget (#27699)
Additionally, this adds a tappable Card example to the Card documentation.
2019-02-12 16:56:47 -05:00
Martin
6d31323971 Create slider with editable numerical value in gallery (#23506)
* Update doc header in Opacity class to fix issue #23311

* Added slider with editable numerical value to gallery. Fixes flutter#1542

* Revert "Update doc header in Opacity class to fix issue #23311"

This reverts commit 2d3642bbda.

* Fix typo in slider description

* Increase TextField size to pass accessibility test

* Added Semantics widget to pass accessibility test

* Made description start with caps to match other examples

* Removed unnecessary spacing Container widget

* Update authors file

* Fix indent

* Removed decimal and replaced boundaries with .clamp

Signed-off-by: Martin Staadecker <machstg@gmail.com>

* Undo line wrap from previous commit

Signed-off-by: Martin Staadecker <machstg@gmail.com>

* Update onSubmitted to only call setState when value has changed

Signed-off-by: Martin Staadecker <machstg@gmail.com>
2019-02-08 10:47:59 -05:00
rami-a
fc67f2efc7
Ensure Shrine app respects the platform toggle from Gallery options (#27400)
* Ensure Shrine app repsects the platform toggle from Gallery options

* Retrigger CI

* Retrigger CI again
2019-02-01 14:13:14 -05:00
MhdHejazi
af3cdb33da #19060 Update material.google.com links to material.io (#26807) 2019-02-01 10:14:48 -08:00
rami-a
cdddec7418
Update shrine login screen so that cancel dismisses the route (#27367)
Additionally, fix the status bar color for the login screen

Closes #26034
2019-02-01 09:34:13 -05:00
Jonah Williams
8c5a41113e
Add support for reverse to ReorderableListView (#26203) 2019-01-18 10:10:44 -08:00
jslavitz
cea4aa9b7b
Teach drag start behaviors to DragGestureRecognizer (#26246)
* the onStart callback will report the location of the pointer where it wins the gesture arena by default instead of the pointer down location. Fixes all tests related to changing this default value.
2019-01-09 10:53:47 -08:00
Michael Goderbauer
51732aee3b
Remove long-deprecated TwoLevelList (#26238) 2019-01-08 14:56:31 -08:00
jslavitz
e4fb4fe279
Revert "Teach drag start behaviors to DragGestureRecognizer (#23424)" (#26209)
This reverts commit 08538f91f0.
2019-01-07 17:59:03 -08:00
jslavitz
08538f91f0
Teach drag start behaviors to DragGestureRecognizer (#23424)
* Adds start behavior option to the drag gesture recognizer and makes it the default option when a drag gesture recognizer is created. Also fixes all the tests to work correctly with the new default behavior.
2019-01-07 15:11:12 -08:00
Michael Goderbauer
aca3aba10e
Turn clipping on for Card Demo (#26030) 2019-01-03 17:18:27 -08:00
Hans Muller
4857267e65
Updated Shrine demo (#25674) 2018-12-21 17:47:25 -08:00
xster
b8a035a3d4
Adds CupertinoTheme (#23759) 2018-12-18 20:36:35 -08:00
Hans Muller
8b34a12d45
Video demo instrumentation (#25489)
* Video Demo instrumentation

* Video Demo instrumentation

* Updated per review

* Fixed a typo
2018-12-18 14:46:45 -08:00
Trevor Wang
114335dff0 Support TextField multi-line hint text #20941 (#24976) 2018-12-11 22:46:05 -08:00
jslavitz
f250db6cb2
Adds small fix to Cupertino navigation demo 2018-12-10 09:34:17 -08:00
Hans Muller
ec4f22c17b
Revert "Restore Flutter Gallery Shrine Demo, again (round 3) (#24531)" (#24538)
This reverts commit 4ec8883b83.
2018-11-19 13:02:18 -08:00
Hans Muller
4ec8883b83
Restore Flutter Gallery Shrine Demo, again (round 3) (#24531) 2018-11-19 12:21:49 -08:00
Michael Beckler
9abce96e8e BottomNavigationBar: bug fix for dealing with animations with shifting tabs (#22264)
Should fix #22226.

Code introduced in #20890 caused a regression that broke color flooding animations in a BottomNavigationBar that has BottomNavigationBarType.shifting.

The original issue (#19653) dealt with background color changes not occurring until another tab was selected. The result is that the background color instantly changes whenever the state changes and when the widget changes, instead of allowing a new widget to animate the background color change.
2018-11-07 09:20:27 -08:00
Jonah Williams
ab2d0323a7
cleanup accessibility test skips in gallery (#23977) 2018-11-06 13:29:23 -08:00
Hans Muller
dd30efa190
Revert "Restore "Flutter gallery: updated Shrine demo" (#23878)" (#23888)
This reverts commit 76a1abd4c7.
2018-11-02 15:32:02 -07:00
Hans Muller
76a1abd4c7
Restore "Flutter gallery: updated Shrine demo" (#23878) 2018-11-02 14:33:10 -07:00
Jonah Williams
0b35937b13
Revert "Flutter gallery: updated Shrine demo (#23539)" (#23848)
This reverts commit 949cfcf172.
2018-11-01 19:30:11 -07:00
Hans Muller
949cfcf172
Flutter gallery: updated Shrine demo (#23539) 2018-11-01 12:48:24 -07:00
Devon Carew
e30f9a9447
add explicit const keywords (#23652) 2018-10-29 22:39:40 -07:00
Kevin Moore
8039620bb4
Remove duplicate code comment in flutter_gallery (#23422) 2018-10-23 19:01:58 -07:00
xster
b63ced55b4
Add a CupertinoTextField (#23194) 2018-10-22 19:20:17 -07:00
Alexandre Ardhuin
0fb84e96c7
Prefer void to null (#22977)
* Future<void> main

* Future<void>.delayed

* prefer_void_to_Null

* address review comments
2018-10-16 22:03:06 +02:00
matthew-carroll
04a26778c5
Revert "Reversion for roll (#22984)" (#23029)
This reverts commit 80f80ab08c.
2018-10-12 16:31:34 -07:00
matthew-carroll
80f80ab08c
Reversion for roll (#22984)
For G3 Roll:

* Revert "MaterialButton must honor its minWidth and height parameters (#22919)"

This reverts commit a02332335a.

* Revert "Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)"

This reverts commit 655bf6a290.

* Revert "ButtonTheme.of().colorScheme defers to Theme (#22880)"

This reverts commit a590940e45.

* Revert "Bring TextTheme into alignment with the current Material spec (#22330)"

This reverts commit 8bfb4b3ee5.

* Revert "Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)"

This reverts commit eea3465ae7.

* Manual adjustments to fix reversion issues.
2018-10-11 18:17:46 -07:00
Hans Muller
a590940e45
ButtonTheme.of().colorScheme defers to Theme (#22880)
ButtonThemeData no longer requires a colorScheme. If colorScheme is null, ButtonTheme.of() will initialize it from the current Theme.
2018-10-10 11:40:30 -07:00
Hans Muller
8bfb4b3ee5
Bring TextTheme into alignment with the current Material spec (#22330) 2018-10-09 17:00:15 -07:00
Jonah Williams
fb7a5937ba
Basic scroll semantics support (#21764) 2018-10-09 14:16:28 -07:00
Hans Muller
655bf6a290 Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)
* Update uses of ButtonTheme.bar

* updated gallery themes

* Remove unnecessary const

Fixes #22789
2018-10-08 15:53:35 -07:00
xster
9c080269a8
Add some missing voiceover labels in gallery (#22753) 2018-10-08 11:51:16 -07:00
Hans Muller
bbb080b3a3
Material Switch optionally adapts per platform: Switch.adaptive() (#22688) 2018-10-08 10:39:59 -07:00
Alexandre Ardhuin
2ea1d81cdc
sort_constructors_first (#22575) 2018-10-04 07:28:07 +02:00
mockturtl
13684e4f8e use RadioListTile in expansion panels demo (#20240)
* use RadioListTile in expansion panels demo

Fixes #6048.
- expose `_Location`
- appease analyzer
2018-10-02 11:15:17 -07:00
Alexandre Ardhuin
f62afdcf57
add missing type parameter on methods (#22096) 2018-10-01 21:29:08 +02:00
xster
ac9dc5745e
Add support for material agnostic driver navigation (#22461) 2018-10-01 09:18:20 -07:00
Viet Do
2a8e35cc9c Cupertino Date Picker (#21251) 2018-09-28 18:29:28 -07:00
xster
75b24070dd
Add API docs link to each gallery demo (#22379) 2018-09-28 16:06:41 -07:00
xster
6b94e6b168 Fix picker demo safe area layout (#22244) 2018-09-26 09:28:27 -07:00
Ian Hickson
6d134e0c86
Animation API improvements (#21540) 2018-09-23 00:43:05 -07:00
Ian Hickson
989cf18b0d
[H] Cleanup (#21542)
* Improve documentation and clean up code.

* Remove "Note that".

The phrase "note that" is basically meaningless as a prefix to an
otherwise fine sentence.
2018-09-22 02:02:56 -07:00
Alexandre Ardhuin
a07d3719a1
enable lint prefer_generic_function_type_aliases (#21680) 2018-09-14 21:06:19 +02:00
Jonah Williams
e9e2ca160d
Don't use dense dropdown buttons in the Gallery date/time picker demo (#21693) 2018-09-12 14:15:28 -07:00
Alexandre Ardhuin
d927c93310
Unnecessary new (#20138)
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
2018-09-12 08:29:29 +02:00
xster
f23c9ae5f8
Cupertino nav bar transitions between routes (#20322) 2018-08-28 16:44:34 -07:00
Ian Hickson
53b635817c
Re-enable missing_return (#20844) 2018-08-28 11:22:57 -07:00
Viet Do
0b93911653
Add Cupertino Countdown Timer Picker (#20966)
Add a countdown timer picker as part of the Cupertino date picker.
2018-08-27 12:37:55 -07:00
xster
c418b2f328
Auto populate nav bar title and previous from page route (#19637) 2018-08-23 18:24:30 -07:00
Jonah Williams
e235ccd76f
Support disabled animations (#20354) 2018-08-23 11:50:04 -07:00
Will Larche
47cffd160c
[Gallery] Material elevations (shadows) demo (#20842)
* [Gallery] Elevations demo. TODO: Correct icon.

* [Gallery] More elevations for the elevation demo.

* [Gallery] Elevation toggle for elevation demo.

* [Demos] Update temp icon on elevations demo.

* [Demos] Changing action icon.

* [Demos] Same.

* [Demos] Adding new and const.

* [Demos] Reverting formatting.

* [Gallery] PR Feedback.
2018-08-22 13:02:35 -04:00
Ian Hickson
8c79f40d71
Fixes resulting from audit of issues links (#20772)
* Fixes resulting from audit of issues links

I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.

* Update run_test.dart

skip this test again since it failed on linux and macos bots
2018-08-18 16:44:39 -07:00
TL Lee
e2f3b3d6f2 Feature pesto new recipes (#19415)
<img width="273" alt="pesto_before" src="https://user-images.githubusercontent.com/13839358/43009716-64b6d726-8c0c-11e8-989a-13eaff72ccee.png">
<img width="273" alt="pesto_after" src="https://user-images.githubusercontent.com/13839358/43009717-66074a34-8c0c-11e8-92ae-f5fb4074f43a.png">
2018-08-17 17:58:25 -04:00
xster
eec2e629bf
copy edit modal sheet demo (#20703) 2018-08-16 14:10:04 -07:00
xster
db8d63575e
make overflow dots on iOS horizontal in gallery (#20702) 2018-08-16 13:12:41 -07:00
Natalie Sampsell
faffd3aef3 Add CupertinoActionSheet to gallery (#20411) 2018-08-15 01:01:30 -07:00
Viet Do
1057d39dd0
Support infinite scrolling for CupertinoPicker. (#19789)
Allows the cupertino picker to be scroll infinitely by adding builder.
2018-08-13 12:26:07 -07:00
Natalie Sampsell
64532336f4
Add segmented control to gallery (#19425) 2018-08-09 15:06:01 -07:00
Jonah Williams
ddd7e4ead1
improve semantics of chip demo (#20121) 2018-08-03 21:10:33 -07:00
Alexandre Ardhuin
eda03e2586
re-re-enable lint unnecessary_const (#20103) 2018-08-02 12:02:32 +02:00
David Shuckerow
f844fadaf3
Reorderable list widget and Material demo (#18374) 2018-07-30 15:21:00 -07:00
xster
cded7efbd0
Fix CupertinoSwitch accessibility (#19927) 2018-07-30 11:18:32 -07:00
Michael Goderbauer
3156c28882
Improve semantics for Drawer-Demo (#19911) 2018-07-30 09:28:24 -07:00
Todd Volkert
00aac68e2d
Revert flutter/flutter#19592 (#19861)
It was causing problems rolling Flutter into Fuchsia
2018-07-27 08:44:39 -07:00