Commit Graph

4391 Commits

Author SHA1 Message Date
Jenn Magder
b80b9bea38
Set DEFINES_MODULE for FlutterPluginRegistrant to generate modulemap (#40302) 2019-09-13 11:03:46 -07:00
Jonah Williams
69a296463e
Allow skipping webOnlyInitializePlatform in Flutter for Web (#40301) 2019-09-13 10:20:30 -07:00
stuartmorgan
a7cfdbd3f3
Convert build mode to lowercase in tool_backend (#40393)
On macOS and iOS, the build mode is converted to lowercase in the
Flutter-side script, allowing projects to pass configuration names
directly. This adds the same behavior to the tool_backend.dart script
currently used by Windows and Linux, so that Windows builds can do the
same (since the default configuration names used by VS, as in Xcode,
start with a capital letter).
2019-09-12 19:13:42 -07:00
Jenn Magder
ba13aa943c
Make FlutterPluginRegistrant a static framework so add-to-app can use plugins with static frameworks (#40401) 2019-09-12 18:51:49 -07:00
Francisco Magdaleno
09bb07f8dd
Adds list required components when VS is not installed (#40397) 2019-09-12 18:44:36 -07:00
stuartmorgan
72888c7f75
Harden macOS build use of Xcode project getInfo (#40375)
- Makes build_macos.dart handle the case where there is only one Xcode
  project in the macos/ directory, but it's not called Runner.xcodeproj
- Makes getInfo throw a tool exit when trying to get project info and it
  can't find a project, since that is a configuration error by the user
  rather than a tool bug.
2019-09-12 16:03:02 -07:00
Francisco Magdaleno
576a455a64
[windows] Refactor to optimize vswhere queries (#40197) 2019-09-12 15:48:25 -07:00
Jonah Williams
91af071570
ensure dart2js does not compile unsupported packages (#40368) 2019-09-12 15:25:21 -07:00
Jonah Williams
1667d0caa4
rename port to web-port and hostname to web-hostname (#40370) 2019-09-12 15:25:03 -07:00
Jonah Williams
1fec30efb6
Place existing dill into hot reload temp directory to boost initialization time (#40366) 2019-09-12 12:45:53 -07:00
Ryan Macnak
a6138bb005
Remove dead accessors of _getUnusedChangesInLastReload. (#39837)
This was part of a disused tool to explain what did and did not run after reload.
2019-09-12 12:34:58 -07:00
Jonah Williams
925a52fa6b
add host and port to run configuration for web devices (#40191) 2019-09-12 08:58:49 -07:00
Francisco Magdaleno
f5733f7a62 Fix crash on vswhere search from flutter doctor (#40263)
Fixes a crash introduced on #40011 due to an incorrect type in the vswhere search

Fixes #40238
2019-09-11 21:03:42 -07:00
Jonah Williams
270878fc50
fix copy command and remove resolve sync for macOS assemble (#40294) 2019-09-11 20:29:27 -07:00
Zachary Anderson
73c10e8ced
[flutter_tool] process.dart cleanup (#39899) 2019-09-11 18:20:42 -07:00
Emmanuel Garcia
3712ea63d8
Flip the default for proguard (#40282) 2019-09-11 17:51:51 -07:00
Jonah Williams
6d37867c4a
Place hot reload artifacts in a temp directory (#40171) 2019-09-11 12:57:43 -07:00
Jonah Williams
963c8a8921
Remove io and isolate from libraries for web sdk (#40259) 2019-09-11 12:40:33 -07:00
Jonah Williams
8eee93fa64
Ensure we send hot restart events for flutter web (#40175) 2019-09-11 09:38:42 -07:00
Christopher Fujino
c5e2bf5cfe
catch errors during gradle update (#37526) 2019-09-11 09:21:42 -07:00
Zachary Anderson
2c94f2b4d9
[flutter_tool] Kill a timing out process before trying to drain its stdout/err streams (#40159) 2019-09-11 08:30:29 -07:00
stuartmorgan
e6ae95c4ce
Add an ephemeral directory to Windows projects (#40194)
Moves files generated in windows/flutter/ as part of the build to an ephemeral/ subdirectory, matching the approach used on macOS (and in the future, Windows).

Adds that directory to the generated properties file to minimize hard-coding of paths in the project.
2019-09-11 07:46:57 -07:00
stuartmorgan
ef97a69dab
Make Swift plugin template swift-format compliant (#40195)
swift-format will alphabetize import statements, so Flutter* should be
before Foundation. Also, separating the "Generated file" comment
prevents the formatter from thinking that the comment is associated with
the following import, rather than the file, if it does re-order.
2019-09-11 07:43:50 -07:00
Jonah Williams
32c946f31b
make sure we launch with dwds (#40210) 2019-09-10 20:49:27 -07:00
Jonah Williams
609a78fdca
Revert "build bundle with assemble (#37508)" (#40204) 2019-09-10 20:03:52 -07:00
Jonah Williams
f614144f0a
Add "web" server device to allow running flutter for web on arbitrary browsers (#39951)
* add web server device

* remove extra async

* fixes to server device

* testing updates

* fix test cases

* address comments
2019-09-10 19:29:31 -07:00
Jonah Williams
a7aff56741
build bundle with assemble (#37508) 2019-09-10 19:28:38 -07:00
Jonah Williams
8504f3ae13
Update the supported library set for Flutter for web (#39983) 2019-09-10 17:27:30 -07:00
Emmanuel Garcia
f098de1fde
Enable Proguard by default on release mode (#39986) 2019-09-10 17:22:55 -07:00
Francisco Magdaleno
362cde43ff
[windows] Searches for pre-release and 'all' Visual Studio installations (#40011) 2019-09-10 17:01:53 -07:00
Jenn Magder
556e3d9e74
Keep Flutter.framework binaries writable so they can be code signed (#40174) 2019-09-10 15:17:56 -07:00
Jenn Magder
12229264e2
Show CocoaPods version in hint text (#40117) 2019-09-10 13:26:32 -07:00
Sam Rawlins
2bc8f999f7 Remove visibleForTesting annotation; this constructor is used outside of testing (#39997) 2019-09-10 13:12:53 -07:00
Jonah Williams
f877c97b3b
Use persisted build information to automatically clean old outputs in assemble (#39654) 2019-09-10 09:57:47 -07:00
Jonah Williams
79ec38f7f3
ensure we use pub from flutter sdk (#40131) 2019-09-10 07:41:59 -07:00
Jonah Williams
477ae6b8ce
cleanup use of build runner internals (#40045) 2019-09-09 18:16:03 -07:00
Jonah Williams
eb7eb3ce3c
use build runners script gen (#40049) 2019-09-09 18:15:17 -07:00
Jonah Williams
0f365d3add
remove dart dir chrome profile (#39934) 2019-09-09 18:14:13 -07:00
Jonah Williams
f19e4ab4f7
roll dwds (#40001) 2019-09-07 15:35:14 -07:00
Christopher Fujino
f945079c65
remove fallback code for ios/usb artifacts (#39585) 2019-09-06 14:23:20 -07:00
Jonah Williams
b2da79ce98
roll build runner and remove delay (#39988) 2019-09-06 14:19:12 -07:00
Harry Terkelsen
83da35fbbc
If there are no web plugins, don't generate a plugin registrant (#39910) 2019-09-06 12:54:31 -07:00
Jonah Williams
b4c3671718
Register reload sources call and make 'r' restart for web (#39950) 2019-09-06 10:41:15 -07:00
Jonah Williams
296e97f322
Revert "Correct libraries path and remove dart:io and dart:isolate for web dart platform (#39364)" (#39985)
This reverts commit 3f4d27c4bc.
2019-09-06 09:24:14 -07:00
Jonah Williams
3f4d27c4bc
Correct libraries path and remove dart:io and dart:isolate for web dart platform (#39364) 2019-09-06 08:21:41 -07:00
Jonah Williams
0167f53101
update packages --force upgrade (#39932) 2019-09-05 19:35:59 -07:00
stuartmorgan
4c2c7c417d
Switch to the Win32 Windows embedding (#39836)
Pulls the Win32 embedding artifacts instead of the GLFW versions for
Windows.

Fixes #38590
2019-09-05 10:09:12 -07:00
stuartmorgan
3948e8759e
Allow specifying a project for Xcode getInfo (#39782)
Avoids unnecessarily breaking projects that have another .xcodeproj in
their macos/ directory, which worked until the addition of the getInfo
call.
2019-09-05 10:07:03 -07:00
Jonah Williams
dd7694256e
remove input files argument to target (#39769) 2019-09-05 09:56:37 -07:00
Jonah Williams
4728ef5c16
handle browser refresh (#39776) 2019-09-05 09:56:05 -07:00
Jonah Williams
06348522c3
workaround for mangled web sdk source map packages (#39774) 2019-09-05 09:55:54 -07:00
Zachary Anderson
0f2af976a2
[flutter_tools] Add a timeout to another showBuildSettings command (#39579) 2019-09-05 09:50:46 -07:00
Kenzie Schmoll
d50d9c5e60
Register flutterVersion service in flutter_tools. (#39524)
* Register getFlutterVersion service in flutter_tools.

* Add short revision ids to response.

* Rename method and remove obsolete comments.

* Fix broken test by adding sendPeerNotifications flag.

* Implement mockPeer.sendNotification.
2019-09-05 09:50:36 -07:00
Devon Carew
57e6042f68
update to the latest package:dwds (#39834) 2019-09-05 09:50:10 -07:00
Ian Hickson
2efbc11b7a
Revert "Keep Flutter.framework binaries writable so they can be code signed (#39539)" (#39859)
This reverts commit 72cacb4040.
2019-09-04 17:47:39 -07:00
Jenn Magder
72cacb4040
Keep Flutter.framework binaries writable so they can be code signed (#39539) 2019-09-03 18:00:45 -07:00
Emmanuel Garcia
d230234d67
Revert Maven dependencies (#39747) (39157) (#39784) 2019-09-03 17:49:10 -07:00
Harry Terkelsen
6f4359d1b7
Add lib/generated_plugin_registrant.dart to gitignore (#39781) 2019-09-03 16:03:09 -07:00
Jonah Williams
d804097014
print launching on device message (#39748) 2019-09-03 12:55:06 -07:00
Jonah Williams
af851ab6bc
Revert "remove input files argument to target (#39701)" (#39768)
This reverts commit 5e7beaf7b8.
2019-09-03 12:47:33 -07:00
Jonah Williams
5e7beaf7b8
remove input files argument to target (#39701) 2019-09-03 12:46:08 -07:00
Jonah Williams
476a4de17e
Add delay to recompile request for web (#39752) 2019-09-03 11:53:46 -07:00
Jonah Williams
76ebcc8a14
remove web flag from create (#39756) 2019-09-03 11:53:27 -07:00
Emmanuel Garcia
1b429bdb47
Fix type mismatch in Gradle (#39747) 2019-09-03 11:39:30 -07:00
Jonah Williams
cc9b614efd
minor cleanup and prevent multiple exit (#39751) 2019-09-03 11:00:39 -07:00
Harry Terkelsen
d33cf11556
Automatically generated registrants for web plugins (#39628)
* WIP on web plugin registry

* WIP on registering plugins

* WIP on web plugin registration

* Only generate `package:flutter_web_plugins` imports if plugins are
defined

* Add parsing test

* Add documentation

* Fix analyzer warnings

* add license headers

* Add tests for package:flutter_web_plugins

* Run `flutter update-packages --force-upgrade`

* Fix analyzer errors

* Fix analyzer error in test

* Update copyright and remove flutter SDK constraints

* Enable tests since engine has rolled

* add flutter_web_plugins tests to bots

* Create an empty .packages file for WebFs test
2019-09-03 10:37:34 -07:00
Jenn Magder
0b93c96f52
Remove bitcode=NO from add-to-app flows (#39503) 2019-09-03 10:28:19 -07:00
Zachary Anderson
b9029c7672
[flutter_tool] Add onError callback to asyncGuard. Use it in Doctor (#39445) 2019-09-03 08:14:44 -07:00
stuartmorgan
2e058142d2
Fix macOS App.framework version symlink (#39702)
The Current->A symlink in a framework shouldn't have a trailing slash;
some versions of codesigning consider the version with a trailing slash
unsignable.
2019-09-02 16:26:15 -07:00
Emmanuel Garcia
b63cb44105
Use new Maven artifacts from Gradle (#39157) 2019-09-02 10:35:17 -07:00
Jonah Williams
f12a5ec347
dont hide build commands (#39555) 2019-09-01 23:57:11 -07:00
Jonah Williams
f5eb12cdc2
filter error message from skip build script checks (#39558) 2019-09-01 23:56:56 -07:00
Devon Carew
e468296af3
remove a period from the service protocol printout (#39545) 2019-08-31 11:39:00 -07:00
Kaushik Iska
fc05c3738c
Flutter Plugin Tool supports multi-platform plugin config (#38632) 2019-08-29 21:51:31 -07:00
Jonah Williams
b2a4ebe38f
Handle single unsupported device (#39541) 2019-08-29 21:39:38 -07:00
Emmanuel Garcia
6266d5f35d
Log flags in build apk and appbundle (#39457) 2019-08-29 21:37:35 -07:00
Jonah Williams
2dbf0106d8
Create dart tool directory if it is missing (#39543) 2019-08-29 21:31:57 -07:00
Dan Field
eefe9d9527
keep symbols for profile (#39530) 2019-08-29 20:54:30 -07:00
Jonah Williams
359b532570
Remove run in shell and add unit test for chrome launching (#39462) 2019-08-29 19:35:06 -07:00
Dan Field
632526aab9
Update validation to support Xcode11 version (#39463) 2019-08-29 15:28:05 -07:00
Jonah Williams
4984d1a33d
update packages (#39429) 2019-08-28 17:04:07 -07:00
Dan Field
cb965495d7
Reland "Relax arguments around local engine, build hello_world with bitcode" (#39434) 2019-08-28 15:19:04 -07:00
Emmanuel Garcia
4a1c62c28b
Add missing files in the Gradle wrapper directory (#39145) 2019-08-28 14:52:08 -07:00
Jonah Williams
f362419601
make sure profile is forwarded through build web command (#39414) 2019-08-28 14:05:01 -07:00
Jonah Williams
393106fbf5
Revert "Relax requirements around local engine, build hello_world with bitcode (#39357)" (#39431)
This reverts commit 202c1b4224.
2019-08-28 13:12:45 -07:00
Dan Field
202c1b4224
Relax requirements around local engine, build hello_world with bitcode (#39357) 2019-08-28 10:27:01 -07:00
Zachary Anderson
b7c714e84c
[flutter_tool] Use a timeout for xcode showBuildSettings (#39280) 2019-08-28 10:03:53 -07:00
xster
4640690d0f
let flutter build aar use a local engine (#39312) 2019-08-27 23:46:33 -07:00
Jonah Williams
55a1ba761d
Use output dir instead of specific paths in assemble rules (#39274) 2019-08-27 22:52:51 -07:00
Jonah Williams
80f96ee662
surface errors from build runner (#39358) 2019-08-27 19:08:10 -07:00
Jonah Williams
23637844a3
fix source map loading and service protocol for flutter web (#39189) 2019-08-27 19:06:48 -07:00
stuartmorgan
2476415b60
Rename macos_build_flutter_assets.sh (#39353)
The name is very misleading at this point, since it does substantially
more than build flutter_assets. Name it more generically as a wrapper
for 'assemble' for macOS builds.
2019-08-27 19:03:14 -07:00
Emmanuel Garcia
5353d5e877
Fid app bundle in Gradle 3.5 (#39126) 2019-08-27 17:08:02 -07:00
Zachary Anderson
91ae1409b9
[flutter_tool] Create a temp snapshot to run create_test.dart tests (#39338) 2019-08-27 14:28:03 -07:00
Jonah Williams
6f71ce26d6
Place terminalUi flag on terminal interface (#39214) 2019-08-27 14:20:51 -07:00
stuartmorgan
7407695816
Add profile support on macOS (#39264)
Fix some places where Debug/Release was treated as a binary switch.

Makes similar changes to Windows and Linux to simplify adding profile
support to those platforms in the future. This means `--profile` builds
will fail on Linux and Windows for now, but that's fine since they
aren't actually supported, and unlike `--release` don't provide useful
functionality at the native code level.

Also fixes 'stopApp' always using Debug on macOS, to avoid showing an
error when running Profile (or Release).

Fixes #33203
2019-08-26 16:30:30 -07:00
Jonah Williams
0f8b8c91a3
Kill resident runner on browser disconnect. (#39066) 2019-08-26 15:06:36 -07:00
Collin Jackson
a1c185f37a
Fix plugin template app's tests (#39080)
* Fix plugin template

* Add test of plugin template working
2019-08-26 14:57:16 -07:00
Michael Klimushyn
e31d88f9c9
Downgrade the AndroidX warning (#39147)
Originally we wanted to cast as wide of a net and make the warning as
prominent as possible. Recently we've received feedback that the false
positives are more harmful than not, so downgrading the loud message to
a single line warning.
2019-08-26 14:30:22 -07:00
Zachary Anderson
e9bd2ef087
[flutter_tool] Some additional input validation for 'version' (#39136) 2019-08-26 12:12:50 -07:00
Christopher Fujino
d1e0273ecb
refactor cocoapods validator to detect broken install (#38560) 2019-08-23 09:21:09 -07:00
Jonah Williams
b3014ff5c0
add profile mode to flutter web applications (#39073) 2019-08-23 08:47:01 -07:00
Jonah Williams
b2d19d2af5
Add support for macOS release/profile mode (3 of 3) (#38909) 2019-08-23 08:46:24 -07:00
Michael Thomsen
01a5d112d5
Make forward calls run interactively (#39052) 2019-08-23 11:16:30 +02:00
Mehmet Fidanboylu
d921098dd4
Break dependency of tools/lib/src from lib/src/commands/ (#39072) 2019-08-22 21:14:03 -07:00
Jonah Williams
9818d2df3b
Add web workflow to default validators (#39006) 2019-08-22 09:30:19 -07:00
Zachary Anderson
663dc1d774
[flutter_tool] Teach crash reporter about HttpException (#39005) 2019-08-22 09:18:25 -07:00
Jonah Williams
33e7af728a
Dont throw StateError when calling assemble with bad target (#39000) 2019-08-21 23:44:39 -07:00
Chris Bracken
ffa3785411
Update package versions to latest (#39013)
This fixes a breakage in fuchsia where package_config version 1.1.0 is
required but flutter_tools is currently locked to 1.05.
2019-08-21 19:15:33 -07:00
Jenn Magder
892d62f03a
Clean Xcode workspace during flutter clean (#38992) 2019-08-21 18:42:56 -07:00
∂ω∂
4277f364ff flutter_tools/version: git log.showSignature=false (#38576) 2019-08-21 13:55:57 -07:00
Zachary Anderson
36e8b93d1c
[flutter_tool] Only send one crash report per run (#38925) 2019-08-21 13:07:52 -07:00
Zachary Anderson
3ceef86b9a
[flutter_tool] Handle crashes from doctor validators (#38920) 2019-08-21 11:15:02 -07:00
stuartmorgan
01530928f0
Add build warning for non-debug desktop builds (#38932)
When building in profile or release mode on desktop, add a prominent
warning that it's actually a debug build. This is to help address issues
with people being unaware of the current state of builds due to
following third-party guides rather than official documentation.

macOS is not included since PRs are in flight for macOS release support.
2019-08-20 20:16:29 -07:00
Jonah Williams
3b4ab4eb30
Throw error when hot reload enters bad state (#38907) 2019-08-20 14:30:03 -07:00
Jenn Magder
4bffe3dd1d
Remove iphonesimulator from SUPPORTED_PLATFORMS for Profile and Release modes (#38905) 2019-08-20 13:30:43 -07:00
Zachary Anderson
398ac1f6c8
[flutter_tool] Remove some async file io (#38654) 2019-08-20 13:15:08 -07:00
Zachary Anderson
28bedb10da
[flutter_tool] Move http request close under try-catch (#38894) 2019-08-20 12:53:59 -07:00
Jonah Williams
2504a416bb
Create correctly structured framework for macOS (#38748) 2019-08-20 10:49:15 -07:00
Jonah Williams
700020fc6b
per file caching (#38869) 2019-08-20 10:40:02 -07:00
Jenn Magder
198c4f190a
Show process error when iOS install fails (#38712) 2019-08-20 10:29:49 -07:00
stuartmorgan
2daab305aa
Use GLFW-name artifacts on Windows and Linux (#38858)
Switch from the un-suffixed Windows and Linux libraries to the
_glfw-suffixed versions, in preparation for having non-GLFW versions
using the previous library/wrapper names.

Part of #38589
2019-08-20 06:29:49 -07:00
Jonah Williams
ae29174560
Handle compilation failures from web application (#38723) 2019-08-19 17:33:46 -07:00
Jonah Williams
7ed27b51a3
print service url when connecting to web applications (#38823) 2019-08-19 17:32:43 -07:00
Jenn Magder
4d81b0c970
Remove xcconfigs from template Copy Bundle Resources build phases (#38724) 2019-08-19 16:23:45 -07:00
Kate Lovett
6ff212b328
Comparing pixels instead of bytes with GoldenFileComparator (#38473) 2019-08-19 09:06:22 -07:00
Michael Thomsen
79d8967500
Fix publish cmd (#38490) 2019-08-19 08:02:13 +01:00
stuartmorgan
69acc0f545
Update the macOS Podfile template platform version (#38651)
Change the target macOS version from 10.13 to 10.11, per decision on
target platform.

Part of #33200
2019-08-16 18:49:57 -07:00
Todd Volkert
c22ce95e15
Change from using defaults to plutil for Plist parsing (#38662)
We were using the `defaults` command-line utility to parse
Plist files, but it was never supported by Apple, and it
appears that in an upcoming OS release, it will be less likely
to work:

> WARNING: The defaults command will be changed in an upcoming
> major release to only operate on preferences domains. General
> plist manipulation utilities will be folded into a different
> command-line program.

Fixes https://github.com/flutter/flutter/issues/37701
2019-08-16 17:10:07 -07:00
Dan Field
a3221667de
Kill dead code (#38652) 2019-08-16 10:10:23 -07:00
Andri Jasinski
267b858561 Disable xcode indexing in CI via COMPILER_INDEX_STORE_ENABLE=NO argument (#37378) 2019-08-16 08:29:45 -07:00
Todd Volkert
1d8deb1bb8
Handle case of a connected unpaired iOS device (#38629)
Fixes https://github.com/flutter/flutter/issues/36789
Fixes https://github.com/flutter/flutter/issues/37000

https://github.com/flutter/flutter/issues/36524
https://github.com/flutter/flutter/issues/24600
2019-08-15 17:59:37 -07:00
Jonah Williams
1df165ea13
Rename iOS arch for macOS release mode (macOS release mode 2 of 3) (#38645) 2019-08-15 17:38:35 -07:00
Jonah Williams
01feddbece
Support for macOS release mode (1 of 3) (#37425) 2019-08-15 16:36:45 -07:00
Zachary Anderson
0566971d29
[flutter_tool] Throw tool exit on malformed storage url override (#38637) 2019-08-15 14:59:46 -07:00
Zachary Anderson
e24a27d374
[flutter_tool] Flip create language defaults to swift and kotlin (#38339) 2019-08-15 12:13:28 -07:00
Jonah Williams
8d6dc620d6
fix rpc exception for real (#38575) 2019-08-15 12:13:12 -07:00
Zachary Anderson
a40ab895cf
[flutter_tool] Observatory connection error handling cleanup (#38353) 2019-08-15 12:13:03 -07:00
Alexander Aprelev
f5dcbdab3a Increase pattern that matches operation duration. (#36392)
On Flutter HHH buildbot some operations that over a second: 4 digits for milliseconds, rather than 3 that are currently allowed.
2019-08-15 10:16:30 -07:00
Ingo Reinhart
ed88d28d52 use common emulator/device list (#38296) 2019-08-15 10:13:18 -07:00
Jonah Williams
5ec039dd45
Don't reload if compilation has errors (#38586) 2019-08-15 09:08:19 -07:00
Dan Field
07f079a932
Improve bitcode check (#38587) 2019-08-14 23:30:26 -07:00
Jonah Williams
64add554d7
handle unexpected exit from frontend server (#38497) 2019-08-14 19:00:31 -07:00
Jonah Williams
388d69eb9b
Catch errors thrown into the Zone by json_rpc (#38486) 2019-08-14 13:10:41 -07:00
Jonah Williams
ec41ef5bf8
update build_runner and configure libraries (#38499) 2019-08-14 10:00:42 -07:00
Zachary Anderson
d220631eca
[flutter_tool] Fix bug in manifest yaml validation (#38472) 2019-08-14 07:57:30 -07:00
Christopher Fujino
cd1e55b58a
refactor flutter upgrade to be 2 part, with the second part re-entrant (#38325) 2019-08-13 15:53:54 -07:00
David Shuckerow
9615eb99aa
Tests for flutter test [some_directory] (#36866)
* Add a test for a directory instead of a single test.

* Add test data to a child directory to test the command.

* Add test data to a child directory to test the command.

* Add test data to a child directory to test the command.

* Correct test.
2019-08-13 14:57:43 -07:00
Jonah Williams
ca5411e3aa
Fix type error hidden by implicit downcasts (#38102) 2019-08-12 15:21:28 -07:00
Jonah Williams
aa758a3f02
remove bsdiff BUILD.ng (#38342) 2019-08-12 13:04:10 -07:00
Lau Ching Jun
cdefbef3ce
Remove no-constant-update-2018, the underlying issue has been resolved. (#37994) 2019-08-12 10:42:01 -07:00
Jonah Williams
4b73746aff
Catch filesystem exception from flutter create (#38101) 2019-08-12 09:51:03 -07:00
Emmanuel Garcia
83a8a575ee
Update dependencies (#37971) 2019-08-10 12:38:20 -07:00
Jonah Williams
2185825338
Catch FormatException caused by bad simctl output (#37958) 2019-08-10 00:57:23 -07:00
jmagman
78cca6250a
Always install the ephemeral engine copy instead of fetching from CocoaPods specs (#37906) 2019-08-09 17:37:11 -07:00
jmagman
0a58610ce7
Clean ephemeral directories (#37966) 2019-08-09 17:26:51 -07:00
Jonah Williams
77e15103da
Catch failure to create directory in cache (#37871) 2019-08-09 16:21:32 -07:00
David Martos
526339b63a Avoid killing Flutter tool process (#37471) (#37500) 2019-08-09 11:25:12 -07:00
Yegor
9bc298deb6
update dependencies; add a Web smoke test (#37816)
update dependencies; add a Web smoke test
2019-08-09 09:58:49 -07:00
liyuqian
218b113343
Listen to ExtensionEvent instead of TimelineEvent (#37900)
TimelineEvents may not be sent if there aren't enough to form a group.
Hence we should always use ExtensionEvent as the trigger.

See also https://github.com/flutter/flutter/pull/37503
2019-08-08 18:43:33 -07:00
Jonah Williams
f98df595f3
Restructure resident web runner usage to avoid SDK users that don't support dwds (#37815) 2019-08-08 16:36:27 -07:00
Mehmet Fidanboylu
41cc80c5be
Expose the timeline event names so they can be used in other systems that do tracing (#37863) 2019-08-08 15:23:08 -07:00
jmagman
5ed3b418a1
Add COMPILER_INDEX_STORE_ENABLE=NO to macOS build and tests (#37806) 2019-08-07 18:02:06 -07:00
Jonah Williams
8e6205fe1d
Handle thrown maps and rejects from fe server (#37743) 2019-08-07 17:00:36 -07:00
jmagman
e6d94ee40f
Use relative paths when installing module pods (#37738) 2019-08-07 12:59:11 -07:00
Jason Simmons
4f302dc18c
Remove unused no-build flag from the flutter run command (#37735)
The use-application-binary flag can be used to run a previously built
app package.
2019-08-07 12:44:02 -07:00
Emmanuel Garcia
6fb0325dd6
Remove dead flag (#37752) 2019-08-07 10:10:39 -07:00
Christopher Fujino
39a04dcd7f
Support macOS Catalina-style signing certificate names (#37733) 2019-08-07 09:18:11 -07:00
Emmanuel Garcia
c08a3c7a0a
Add metadata to indicate if the host app contains a Flutter module (#37731) 2019-08-06 22:38:09 -07:00
masashi-sutou
626ca086d0 Recommend to use the final version of CDN support for the CocoaPods trunk specs repo (#36237) 2019-08-06 13:19:42 -07:00
walsha2
107f36548a Closes #37593 Add flutter_export_environment.sh to gitignore (#37595) 2019-08-06 13:18:41 -07:00
sjindel-google
0564f0a812
Tests for Engine ensuring debug-mode apps are attached on iOS. (#37043)
This PR contains the tests for flutter/engine#10186.
2019-08-06 20:08:09 +02:00
Jonah Williams
91b8dcbc90
fix windows path for dwds (#37658) 2019-08-06 10:03:42 -07:00
Jonah Williams
fef69b2044
Partial macOS assemble revert (#37664) 2019-08-06 09:15:50 -07:00
Zachary Anderson
0bba472858
[flutter_tool] Remove unintended analytics screen send (#37514) 2019-08-06 09:08:43 -07:00
Liam Appelbe
0cd0c66021
Change priority of gen_snapshot search paths (#37647) 2019-08-06 08:45:08 -07:00
Emmanuel Garcia
f3690d153b
Update packages 2019-08-06 06:19:42 -07:00
Jonah Williams
64f1ac98f9
add missing library to build.gn (#37654) 2019-08-05 22:57:09 -07:00
Jonah Williams
caa56d6ac4
enable track widget creation on debug builds (#37512) 2019-08-05 22:07:35 -07:00
Jonah Williams
a785db78fb
Reland "Integrate dwds into flutter tool for web support (#34252)" (#37649)" (#37650) 2019-08-05 16:51:57 -07:00
Jonah Williams
433436e1ee
Revert "Integrate dwds into flutter tool for web support (#34252)" (#37649) 2019-08-05 15:58:04 -07:00
Zachary Anderson
500d7c50df
[flutter_tool] Additional flutter manifest yaml validation (#37422) 2019-08-05 13:14:57 -07:00
Jonah Williams
4ccd81199f
Integrate dwds into flutter tool for web support (#34252) 2019-08-05 12:41:58 -07:00
stuartmorgan
018d45dc06
Use macOS ephemeral directory for Pod env script (#37509)
On macOS, any file that isn't intended to be checked in should be in the
ephemeral directory.
2019-08-02 16:44:04 -07:00
Christopher Fujino
5fb2d2aeea
have xcodeSelectPath also catch ArgumentError (#37521) 2019-08-02 16:08:49 -07:00
Emmanuel Garcia
40c5cc9708
Find the app bundle when the flavor contains underscores (#37457) 2019-08-02 16:02:46 -07:00
Emmanuel Garcia
80ee3dd04c
Print message when HttpException is thrown after running flutter run (#37440) 2019-08-02 16:02:02 -07:00
Jenn Magder
975156e91c
If xcode_backend.sh script fails or substitute variables are missing, fail the host Xcode build (#37449) 2019-08-02 13:01:25 -07:00
Liam Appelbe
0cf4033404
Switch iOS gen_snapshot from multi-arch binary to multiple binaries (#37445)
* Switch iOS gen_snapshot from multi-arch binary to multiple binaries

* Make snapshotterPath mutable
2019-08-02 07:43:07 -07:00
stevemessick
93dd90fc1a
Add .android/Flutter/flutter.iml to module template. (#37405) 2019-08-01 15:47:00 -07:00
Chinmay Garde
9ea78d4488
Revert "Remove multi-arch check in iOS builds (#37407)" (#37413)
This reverts commit 5809219509.
2019-08-01 11:43:32 -07:00
Liam Appelbe
5809219509
Remove multi-arch check in iOS builds (#37407)
* Remove multi-arch check in iOS builds

* Manual roll of https://github.com/flutter/engine/pull/10010
2019-08-01 11:16:21 -07:00
GroovinChip
ced207836b Improve Windows build failure message (#36845)
* Improve Windows build failure message

* Undo dartfmt to match source formatting

* Removed prompt to file new issue per PR change request
2019-08-01 10:32:38 -07:00
Majid Hajian
7244cbb9b2 add line-length to flutter format commandline (#36679) 2019-08-01 10:27:41 -07:00
Jonah Williams
cf6613583d
only build macOS kernel in debug mode (#37365) 2019-08-01 09:23:40 -07:00
Zachary Anderson
2b03e2089d
[flutter_tool] Add missing toString() (#37331) 2019-08-01 09:23:05 -07:00
Zachary Anderson
2e183b6233
[flutter_tool] Include the local timezone in analytics timestamp (#37345) 2019-07-31 23:28:18 -07:00
Jonah Williams
602f76ca00
fix errors caught by roll of macOS assemble (#37351) 2019-07-31 21:14:40 -07:00
Jonah Williams
2ab469952b
Flutter assemble for macos take 2! (#36987) 2019-07-31 16:19:22 -07:00
Jenn Magder
dd1fb3bcb7
Build number (part after +) is documented as optional, use entire app version if not present (#37036) 2019-07-31 16:18:09 -07:00
Zachary Anderson
c7596da5a4
[flutter_tool] Re-try sending the first crash report (#37198) 2019-07-31 13:51:19 -07:00
Jenn Magder
1bcaa15018
Make podhelper.rb a template to avoid passing in the module name (#37276) 2019-07-31 11:34:22 -07:00
liyuqian
e77237d6d3
Reland "Fix the first frame logic in tracing and driver (#35297)" (#37192)
This relands https://github.com/flutter/flutter/pull/35297

The followings have been done to fix the broken tests:
  1. Add `didSendFirstFrameRasterizedEvent` extension and its tests
  2. Wait for `didSendFirstFrameRasterizedEvent` instead of
     `didSendFirstFrameEvent` during start up tests
  3. Mark missed (probably newly added) start up tests as flaky
2019-07-31 11:01:52 -07:00
Dan Field
a8fbe02a9d hide symbols from spotlight (#37217) 2019-07-30 14:24:58 -07:00
xster
dfad03952f
do not strip symbols when building profile (#37210) 2019-07-30 13:09:40 -07:00
Zachary Anderson
d208ce2dff
[flutter_tool] Usage refactor cleanup (#37186) 2019-07-30 12:18:15 -07:00
Zachary Anderson
a9aea962ab
[flutter_tool] Catch ProcessException from 'adb devices' (#37196) 2019-07-30 12:17:10 -07:00
Zachary Anderson
99d66f2709
[flutter_tool] Make a couple file operations synchronous (#37044) 2019-07-30 12:16:32 -07:00
Jenn Magder
bd47a31e32
Vend Flutter module App.framework as a local CocoaPod pod to be installed by a host app (#36793) 2019-07-30 09:58:39 -07:00
Zachary Anderson
a5d23d2a25
[flutter_tool] More gracefully handle Android sdkmanager failure (#37194) 2019-07-30 08:19:58 -07:00
Jonah Williams
c9a5f94372
Include flutter_runner in precache artifacts. (#36318) 2019-07-29 16:13:47 -07:00
Emmanuel Garcia
9f39cad4ed
Allow flavors and custom build types in host app (#36805)
Fixes these issues:
#30916
#34089
#36479
#29648
2019-07-29 09:26:41 -07:00
Zachary Anderson
ef146f63bb
[flutter_tool] Clean up usage events and custom dimensions (#36785) 2019-07-29 07:24:02 -07:00
Jonah Williams
51d2d3511c
Expose functionality to compile dart to kernel for the VM (#36598) 2019-07-26 19:50:57 -07:00
Jonah Williams
3068fc4f7c
Revert "Fix the first frame logic in tracing and driver (#35297)" (#37027)
This reverts commit 68fc7231b3.
2019-07-26 13:08:36 -07:00
liyuqian
68fc7231b3
Fix the first frame logic in tracing and driver (#35297)
This should fix https://github.com/flutter/flutter/issues/31442 and https://github.com/flutter/flutter/issues/34867
2019-07-26 09:38:12 -07:00
Michael Klimushyn
30eec11e7d Roll back the AAR build experiment (#36966)
* Roll back the AAR build experiment

This has been breaking flutter/plugins CI for the past day.

* Remove integration tests that rely on the AAR flag
2019-07-25 20:54:10 -07:00
Jonah Williams
188093c912
Rearrange flutter assemble implementation (#36240) 2019-07-25 08:50:03 -07:00
Emmanuel Garcia
c469b1fea9
Add annotation dependency to plugins (#36886)
Fixes #36817
2019-07-25 08:49:24 -07:00
Jonah Williams
76d058163b
Adjust phrasing of features (#36874)
* adjust phrasing of features

* word smithing

* more wordsmithing
2019-07-25 08:48:01 -07:00
Jonah Williams
16e484b179
Remove Chain terse parsing (#36860) 2019-07-25 08:47:39 -07:00
Siva
c15cfdd6af
flutter/engine@ef99738...72341ed (#36885)
flutter/engine@72341ed03 Roll fuchsia/sdk/core/linux-amd64 from gQ3ztEQmdEh3iE6n9EO6iGRdmDSX-edmP5WyE-Ui4BEC to gTG1jp04GzBudVJqRxulXYOEQgbYTUQgnqLDYAq7z3sC (#10115)
flutter/engine@d66031f2a Roll src/third_party/dart 82f657d7cb..0c97c31b6e (7 commits) (#10114)
flutter/engine@f742514a5 Cache font family lookups that fail to obtain a font collection (#10109)
flutter/engine@7c177724c Roll fuchsia/sdk/core/mac-amd64 from A21rwGAUjpjVTX8HgpT9Iyx6J_QZBRDhu-5GAclrf00C to UCAnzi4k9pA30l_iZ2Ru51Tc3Ke6iacIdjFMgVUVdRMC (#10107)
flutter/engine@c3165da09 Roll src/third_party/skia fdf4bfe6d389..b3956dc6ba6a (1 commits) (#10101)
flutter/engine@71702b3f8 Roll fuchsia/sdk/core/linux-amd64 from gPDgr6u-BPJTgV2Nf0tlg9MTY3JwGW0cETtsQcx365AC to gQ3ztEQmdEh3iE6n9EO6iGRdmDSX-edmP5WyE-Ui4BEC (#10103)
flutter/engine@f393da22d [fuchsia] copy over the cmx file (#10087)
flutter/engine@8ebd15d26 Roll src/third_party/skia f564f1515bde..fdf4bfe6d389 (1 commits) (#10100)
flutter/engine@f529a251b Roll fuchsia/sdk/core/mac-amd64 from lvLKs8Q4CKm_XLoZCQ72RO0RHI6yvJXnA9M_M8r4-aAC to A21rwGAUjpjVTX8HgpT9Iyx6J_QZBRDhu-5GAclrf00C (#10099)
flutter/engine@d409df823 Roll src/third_party/dart 9c148623c5..82f657d7cb (25 commits)
flutter/engine@acd139ce6 Roll src/third_party/skia 1cd1ed8976c4..f564f1515bde (1 commits) (#10097)
flutter/engine@f2c9da4a0 Roll src/third_party/skia 3ae30cc2e6e0..1cd1ed8976c4 (1 commits) (#10096)
flutter/engine@d2f0b9ef1 Roll fuchsia/sdk/core/linux-amd64 from MCDItwEzechMpZAiI0QOzuiTtNUGArUa4TprH0Er-7QC to gPDgr6u-BPJTgV2Nf0tlg9MTY3JwGW0cETtsQcx365AC (#10095)
flutter/engine@0f4db494a Roll fuchsia/sdk/core/mac-amd64 from EH_61w2lpSn0UmpJkynWM6tiT0nnKk1GhTRRKK2cGMwC to lvLKs8Q4CKm_XLoZCQ72RO0RHI6yvJXnA9M_M8r4-aAC (#10094)
flutter/engine@298799991 Roll src/third_party/skia 0f9c660aa939..3ae30cc2e6e0 (1 commits) (#10093)
flutter/engine@a4d2d3648 Roll fuchsia/sdk/core/linux-amd64 from tCzkXNr7cb5OAbS5NcJ4F_g0DgVj3w8rfbT14AcaTHoC to MCDItwEzechMpZAiI0QOzuiTtNUGArUa4TprH0Er-7QC (#10090)
flutter/engine@d27a6373d Roll fuchsia/sdk/core/mac-amd64 from xNAaLqZJk8Bkz00BaHGzE8hCpiohggO7KabM3g2wdsQC to EH_61w2lpSn0UmpJkynWM6tiT0nnKk1GhTRRKK2cGMwC (#10089)
flutter/engine@20dc17282 Roll src/third_party/skia d15571af2e1b..0f9c660aa939 (1 commits) (#10088)
flutter/engine@9e7260b9d Roll fuchsia/sdk/core/linux-amd64 from kU0OwJYlceN477ejdh9RXrl7Mp-wUTNvQozlaV96xmQC to tCzkXNr7cb5OAbS5NcJ4F_g0DgVj3w8rfbT14AcaTHoC (#10086)
flutter/engine@0e621d902 [fuchsia] Use the new far package model (#10085)
flutter/engine@bdc713695 [fuchsia] Add sysroot and clang libs to package (#10082)
flutter/engine@72f747ae4 Roll fuchsia/clang/linux-amd64 from apsjZJ9ZIwlS08divc0QwxuNgIFeN4X-52mKR9d8qacC to zHiuOGMDwdWPUkV1B2fHKyRy2fGWGcUgfa2z6dyGAZQC (#10084)
flutter/engine@bfe689ee8 Roll fuchsia/clang/mac-amd64 from USm3Qt9wen4bXoFF0T9Xt8NX-pyEfte2cTYi7geLAhQC to UYD9C8IEkWVi83ef4zwO1Ump2B8cP9Nd5WECjU8l3AUC (#10083)
flutter/engine@cf5d76c17 [fuchsia] Add support for libs in packages (#10081)
flutter/engine@c4c64896a Roll src/third_party/skia 829144cc76fe..d15571af2e1b (2 commits) (#10080)
flutter/engine@25e5d597e Roll fuchsia/sdk/core/linux-amd64 from S_24mhItBb7pfUof8zsJPPSctC7xdlfjDEXEtyO25GYC to kU0OwJYlceN477ejdh9RXrl7Mp-wUTNvQozlaV96xmQC (#10079)
flutter/engine@f7e0614b8 Change ParagraphBuilder to replace the parent style's font families with the child style's font families (#10074)
flutter/engine@eb74f2ce7 One more luci fix (#10078)
flutter/engine@6e732c7f1 Change flutter runner target for LUCI (#10075)
flutter/engine@44ec59b70 Roll src/third_party/dart fedd74669a..9c148623c5 (70 commits) (#10066)
flutter/engine@abf93699f Basic structure for flutter_jit_runner far (#10073)
flutter/engine@3c76b90b2 Track clusters and return cluster boundaries in getGlyphPositionForCoordinates (emoji fix) (#10063)
flutter/engine@e8fb641f6 Enable consts from environment in DDK for flutter_web (#10069)
flutter/engine@bd3870219 [macos] Revert check on FlutterCodecs and refactor message function] (#10009)
flutter/engine@d6e1a93e2 Roll src/third_party/skia e11dfd3da4d7..829144cc76fe (4 commits) (#10072)
flutter/engine@d595af681 Roll fuchsia/sdk/core/linux-amd64 from XqtWTBni4xpYCTr7gqU7rFTuXNY1TZ_zOqBJrZM8c_kC to S_24mhItBb7pfUof8zsJPPSctC7xdlfjDEXEtyO25GYC (#10071)
2019-07-24 22:44:12 -07:00
Jonah Williams
93f511cf77
Unbreak build_runner (#36884) 2019-07-24 16:12:56 -07:00
Matt Carroll
a7387b127d
Added demo projects for splash screen support on Android. (#35728) 2019-07-24 13:44:13 -07:00
Jonah Williams
40884af28e
check for directory instead of path separator (#36787) 2019-07-24 13:20:08 -07:00
Jonah Williams
15e322c0e5
Expose build-dir config option (#36773) 2019-07-24 12:13:51 -07:00
sjindel-google
6e963b9985
Remove flaky check for analyzer message. (#36832) 2019-07-24 20:21:31 +02:00
Jiahao
4de9b4461b
Parameterize CoverageCollector with a library name predicate (#36774)
An optimization to the coverage collection speed was added in #30811. This commit further expands on it to parameterize the CoverageCollector with a custom predicate, allowing internal use cases to filter the RPC calls to the Dart VM based on scripts of interest to coverage collection.
2019-07-24 10:58:37 -07:00
Ian Hickson
e8d7306828
Some minor cleanup for flutter_tools (#36569) 2019-07-24 10:58:09 -07:00
Zachary Anderson
6fe45fb1ac
[flutter_tool] Improve Windows flutter clean error message (#36784) 2019-07-24 10:56:06 -07:00
Jonah Williams
3b4d9f6780
more resident runner verification tests (#36595) 2019-07-23 15:38:52 -07:00
Jonah Williams
694d54ccac
Place build outputs under dart tool (#36585) 2019-07-23 15:36:55 -07:00
Jonah Williams
14aa4d0a45
fix analytics reporting test (#36556) 2019-07-23 11:02:02 -07:00
Zachary Anderson
ebdc2cf73b
[flutter_tool] Add some useful commands to the README.md (#36560) 2019-07-23 09:47:06 -07:00
Emmanuel Garcia
242a4225a1
Flutter build aar (#36732)
`flutter build aar`

This new build command works just like `flutter build apk` or `flutter build appbundle`, but for plugin and module projects.

This PR also refactors how plugins are included in app or module projects. By building the plugins as AARs, the Android Gradle plugin is able to use Jetifier to translate support libraries into AndroidX libraries for all the plugin's native code. Thus, reducing the error rate when using AndroidX in apps.

This change also allows to build modules as AARs, so developers can take these artifacts and distribute them along with the native host app without the need of the Flutter tool. This is a requirement for add to app.

`flutter build aar` generates POM artifacts (XML files) which contain metadata about the native dependencies used by the plugin. This allows Gradle to resolve dependencies at the app level. The result of this new build command is a single build/outputs/repo, the local repository that contains all the generated AARs and POM files.

In a Flutter app project, this local repo is used by the Flutter Gradle plugin to resolve the plugin dependencies. In add to app case, the developer needs to configure the local repo and the dependency manually in `build.gradle`:


repositories {
    maven {
        url "<path-to-flutter-module>build/host/outputs/repo"
    }
}

dependencies {
    implementation("<package-name>:flutter_<build-mode>:1.0@aar") {
       transitive = true
    }
}
2019-07-23 09:27:42 -07:00
Emmanuel Garcia
c9b466f9e2
Revert "Add flutter build aar (#35217)" (#36731)
This reverts commit 11460b8378.
2019-07-22 22:07:59 -07:00
Emmanuel Garcia
11460b8378
Add flutter build aar (#35217)
`flutter build aar`

This new build command works just like `flutter build apk` or `flutter build appbundle`, but for plugin and module projects.

This PR also refactors how plugins are included in app or module projects. By building the plugins as AARs, the Android Gradle plugin is able to use Jetifier to translate support libraries into AndroidX libraries for all the plugin's native code. Thus, reducing the error rate when using AndroidX in apps.

This change also allows to build modules as AARs, so developers can take these artifacts and distribute them along with the native host app without the need of the Flutter tool. This is a requirement for add to app.

`flutter build aar` generates POM artifacts (XML files) which contain metadata about the native dependencies used by the plugin. This allows Gradle to resolve dependencies at the app level. The result of this new build command is a single build/outputs/repo, the local repository that contains all the generated AARs and POM files.

In a Flutter app project, this local repo is used by the Flutter Gradle plugin to resolve the plugin dependencies. In add to app case, the developer needs to configure the local repo and the dependency manually in `build.gradle`:


repositories {
    maven {
        url "<path-to-flutter-module>build/host/outputs/repo"
    }
}

dependencies {
    implementation("<package-name>:flutter_<build-mode>:1.0@aar") {
       transitive = true
    }
}
2019-07-22 20:46:01 -07:00
Jonah Williams
e5ea996a1f
disable flaky windows test (#36722) 2019-07-22 18:14:43 -07:00
Jonah Williams
3fedb8cb5a
Reland: use flutter features for web and desktop (#36699) 2019-07-22 15:34:03 -07:00
Ian Hickson
542fbd4c71
Some minor fixes to the tool_coverage tool. (#36570)
Extracted from https://github.com/flutter/flutter/pull/36205
2019-07-22 13:02:02 -07:00
Danny Tuppeny
d42d0c5171
Re-enable flutter test expression evaluation tests (#36431)
Plus:

- Resume the app being run after expression has been evaluated to prevent the test run being forcefully terminated because it didn't end
- Skip non-JSON when waiting for JSON (eg. when running in verbose mode for debugging locally)
- Pass defaultTimeout in waitForJson (otherwise the assert in _timeoutWithMessages fails when it's not provided)

Closes https://github.com/flutter/flutter/issues/26518 (the original reason for skip was fixed in https://github.com/dart-lang/sdk/issues/34224).
2019-07-22 19:43:37 +01:00
Jonah Williams
8eae2dfb92
Revert "Use FlutterFeatures to configure web and desktop devices (#36465)" (#36654)
This reverts commit bd52a78c71.
2019-07-21 21:47:43 -07:00
Jonah Williams
bd52a78c71
Use FlutterFeatures to configure web and desktop devices (#36465) 2019-07-21 18:21:15 -07:00
Jonah Williams
9bd50c5459
Ensure fx flutter attach can find devices (#36564) 2019-07-21 10:24:04 -07:00
Zachary Anderson
76cbbeb627
[flutter_tool] Send the local time to analytics with screens and events (#36545) 2019-07-19 14:54:18 -07:00
Jonah Williams
6830edd0be
Clean up flutter driver device detection. (#36434) 2019-07-19 14:48:17 -07:00
Jenn Magder
5e650af7fa
Clean up host_app_ephemeral_cocoapods Profile build settings (#36498) 2019-07-19 12:49:26 -07:00
Christopher Fujino
9bd2e4000b
Throw exception if instantiating IOSDevice on non-mac os platform (#36288) 2019-07-19 12:20:45 -07:00
Todd Volkert
7b556dcc18
Fix the web builds by reverting version bump of build_modules (#36548) 2019-07-19 09:36:36 -07:00
Dan Field
c953cd19d2
Enable bitcode compilation for AOT (#36471) 2019-07-18 22:42:47 -07:00
Todd Volkert
e6128a0c14
Fix flutter pub -v (#36513)
When we were running `pub` within `flutter pub`, we were
unconditionally including the `--verbosity=warning` argument.
Then we were conditionally including `--verbose` if we were
running in verbose mode.  However, the former argument
supersedes the latter, and we were never able to run `pub`
in verbose mode.
2019-07-18 22:22:22 -07:00
Todd Volkert
1170105eae
flutter update-packages --force-upgrade (#36510) 2019-07-18 22:21:58 -07:00
Zachary Anderson
82a4ba40bb
[flutter_tool] Send analytics command before the command runs (#36490) 2019-07-18 18:05:44 -07:00
Jonah Williams
d1190b638f
remove unrelated code (#36481) 2019-07-18 16:49:39 -07:00
Todd Volkert
adb2aeebe3
Ensure that cache dirs and files have appropriate permissions (#28090)
This is a partial re-application of #24669, which was
reverted due to Fuchsia breakages.

https://github.com/flutter/flutter/issues/24413
2019-07-18 15:29:06 -07:00
Emmanuel Garcia
5a34e7981e
Catch exceptions thrown by runChecked* when possible (#36109) 2019-07-18 10:45:37 -07:00
Jonah Williams
7b0cc5051b
release lock in flutter pub context (#36218) 2019-07-18 10:41:39 -07:00
Jonah Williams
757b5365fa
Add missing test case for Usage (#36379) 2019-07-18 10:41:13 -07:00
Jonah Williams
1957c66300
add testing to screenshot and printDetails method (#36418) 2019-07-18 10:40:40 -07:00
Jonah Williams
962a3cfd1c
Add missing protobuf dependency (#36394) 2019-07-17 15:45:13 -07:00
Christopher Fujino
42a9c031e5
Fix invocations of ideviceinstaller not passing DYLD_LIBRARY_PATH (#36327)
* add failing tests

* fix tests

* be more specific with try-catch

* add further mocking to get tests to pass again

* fix analyzer failure
2019-07-17 13:44:49 -07:00
xster
03220cacd1
Make sure add-to-app build bundle from outer xcodebuild/gradlew sends analytics (#36122) 2019-07-17 11:17:04 -07:00
Tim Sneath
07735578af
Fix spelling error and clarify universal flag (#36331) 2019-07-17 10:46:48 -07:00
Todd Volkert
57efab6e58
FakeHttpClientResponse improvements (#36289)
Update `FakeHttpClientResponse` to be impervious to Dart SDK
changes to the `HttpClientResponse` stream type (between `List<int>`
and `Uint8List`).
2019-07-17 08:42:12 -07:00
Jonah Williams
36c37ccab5
Implement feature flag system for flutter tools (#36138) 2019-07-16 17:33:28 -07:00
Todd Volkert
aa9a115181
Move reporting files to reporting/ (#36017)
Slight cleanup of file locations in flutter_tools
to make it easier to see which files are responsible
for data reporting.
2019-07-16 13:21:06 -07:00
Christopher Fujino
540c747656
Revert "Keep LLDB connection to iOS device alive while running from CLI. (#36194)" (#36293)
This reverts commit 5501a1c1e7.
2019-07-16 12:34:49 -07:00
sjindel-google
5501a1c1e7
Keep LLDB connection to iOS device alive while running from CLI. (#36194)
## Description

Instead of detaching from the spawned App process on the device immediately, keep the LLDB client connection open (in autopilot mode) until the App quits or the server connection is lost.

This replicates the behavior of Xcode, which also keeps a debugger attached to the App after launching it.

## Tests

This change will be covered by all running benchmarks (which are launched via "flutter run"/"flutter drive"), and probably be covered by all tests as well.

I also tested the workflow locally -- including cases where the App or Flutter CLI is terminated first.

## Breaking Change

I don't believe this should introduce any breaking changes. The LLDB client automatically exits when the app dies or the device is disconnected, so there shouldn't even be any user-visible changes to the behavior of the tool (besides the output of "-v").
2019-07-16 19:15:15 +02:00
Zachary Anderson
fa65ddf51d
[flutter_tool] Allow analytics without a terminal attached (#36208) 2019-07-16 09:48:49 -07:00
chunhtai
1166015931
Enable widget load assets in its own package in test (#35991) 2019-07-16 09:47:42 -07:00
Jonah Williams
b257c33b69
Use DeviceManager instead of device to determine if device supports project (#36213) 2019-07-15 16:10:39 -07:00
Jonah Williams
6b17840cbf
Don't try to flutterExit if isolate is still paused (#36199) 2019-07-15 15:44:58 -07:00
Christopher Fujino
102ab1e6d9
Reland bundle ios deps (#36093)
This updates the flutter tool cache to download binary files for ideviceinstaller, ios-deploy, libimobiledevice, and dynamically linked dependencies from Flutter's GCP bucket.
2019-07-15 09:22:29 -07:00
Jonah Williams
e3ee5c6bbb
Add better handling of JSON-RPC exception (#36082) 2019-07-13 16:02:09 -07:00
Ian Hickson
d919e694b8
Move tools tests into a general.shard directory in preparation to changing how we shard tools tests (#36108) 2019-07-13 11:51:44 -07:00
Zachary Anderson
13382f41c0
[flutter_tool] Catch a yaml parse failure during project creation (#36105) 2019-07-12 23:24:04 -07:00
Jonah Williams
7056214151
Handle google3 version of pb (#36084) 2019-07-12 13:45:26 -07:00
Jonah Williams
0a97553e5e
Revert "Merge branches 'master' and 'master' of github.com:flutter/flutter into timsneath-precache2" (#36096) 2019-07-12 13:42:32 -07:00
Tim Sneath
67ab890b60 Merge branches 'master' and 'master' of github.com:flutter/flutter into timsneath-precache2 2019-07-12 12:59:08 -07:00
Tim Sneath
7349970462 Update comments to match precache help 2019-07-12 12:59:01 -07:00
Tim Sneath
b322fdd518 Update precache help 2019-07-12 12:57:28 -07:00
Christopher Fujino
e91822da24
Revert "Bundle ios dependencies (#34669)" (#36071)
This reverts commit 14d489adc5.
2019-07-12 09:03:34 -07:00
Jonah Williams
7b150f81c5
move reload and restart handling into terminal (#35846) 2019-07-12 08:48:14 -07:00
Christopher Fujino
14d489adc5
Bundle ios dependencies (#34669)
This updates the flutter tool to cache binary files for ideviceinstaller, ios-deploy, libimobiledevice, and dynamically linked dependencies from Flutter's GCP bucket.
2019-07-12 08:36:18 -07:00
Anoop B
90326b6184 [ImgBot] Optimize images (#35971) 2019-07-11 21:16:48 -07:00
Jonah Williams
e91b98a41f
Add initial implementation of flutter assemble (#32816) 2019-07-11 16:53:17 -07:00
Ben Konyi
8d81c30a7c [WIP] Use public _registerService RPC 2019-07-11 16:01:07 -07:00
Jonah Williams
ae8ff41abf
Revert "Keep LLDB connection to iOS device alive while running from CLI. (#35731)" (#35996)
This reverts commit d200dc150b.
2019-07-11 10:44:41 -07:00
sjindel-google
d200dc150b
Keep LLDB connection to iOS device alive while running from CLI. (#35731) 2019-07-11 18:56:48 +02:00
Ian Hickson
176ebfd53e
flutter/tests support (#33140)
This introduces a script that implements the conventions described in https://github.com/flutter/tests/pull/1.
2019-07-10 12:10:28 -07:00
Jenn Magder
ec2c3f2116
Disable CocoaPods input and output paths in Xcode build phase for ephemeral add2app (#35833) 2019-07-10 10:40:15 -07:00
Jonah Williams
2b20345bb8
use pub run for create test and remove [INFO] logs (#35839) 2019-07-10 08:48:01 -07:00
Jonah Williams
adf45d1e40
Refactor signal and command line handler from resident runner (#35406) 2019-07-09 13:10:26 -07:00
chunhtai
a76e39f984
Rendering errors with root causes in the widget layer should have a reference to the widget (#32511) 2019-07-09 10:18:30 -07:00
Alexandre Ardhuin
b041a589c8
enable lint prefer_if_null_operators (#35745) 2019-07-09 10:53:35 +02:00
Jenn Magder
559c9982dd
UIApplicationLaunchOptionsKey -> UIApplication.LaunchOptionsKey (#35763) 2019-07-08 16:55:27 -07:00
Dan Field
e3acb5ca71
Refactor keymapping for resident_runner (#35762) 2019-07-08 16:38:49 -07:00
Jenn Magder
f3150ed0b5
Remove Swift Obj-C Inference build setting (#35756) 2019-07-08 16:04:16 -07:00
Jonah Williams
1e26c41f17
Remove web, fuchsia, and unsupported devices from all (#35709) 2019-07-08 15:58:38 -07:00
Jonah Williams
bcd28e7e45
Don't pause on tool tests (#35657) 2019-07-08 13:14:48 -07:00
Lau Ching Jun
d3eee57c0b
Update the help message on precache command for less confusion (#35480) 2019-07-08 11:04:24 -07:00
Karen Rustad Tölva
9155795883 Fix typo in main.dart templates (#35684) 2019-07-08 10:36:44 -07:00
Jonah Williams
4f0f88b5ea
Disable incremental compiler in dartdevc (#35681) 2019-07-08 10:36:11 -07:00
Jonah Williams
34467289d6
Add timer checking and Fake http client to testbed (#35392) 2019-07-08 10:04:48 -07:00
Jonah Williams
e6a7419603
disable a test case in xcode_backend.sh (#35708) 2019-07-08 08:04:48 -07:00
Todd Volkert
3bf91b5436
Prepare for Socket implements Stream<Uint8List> (#35646)
An upcoming change in the Dart SDK changes `Socket` from
implementing `Stream<List<int>>` to implementing `Stream<Uint8List>`.
This forwards-compatible change in flutter_tools prepares for that
Dart SDK change.

https://github.com/dart-lang/sdk/issues/36900
2019-07-05 12:59:32 -07:00
Jonah Williams
93edc014ae
update packages (#35573) 2019-07-04 11:26:19 -07:00
Sam Rawlins
5b6ebf1230 Add type to StreamChannel in generated test code. (#35367)
This is necessary for those who wish to comply with static analysis like
`strict-raw-types: true`, which includes generated code within their package.
2019-07-03 14:11:11 -07:00
Jonah Williams
b8597f0a7e
Move usage flutter create tests into memory filesystem. (#35160) 2019-07-03 10:49:33 -07:00
Todd Volkert
4cd12fc8b7
Mark update-packages as non-experimental (#35467)
Marking it as experimental was breaking tests and packaging
scripts on stable branches.
2019-07-02 18:24:25 -07:00
Jonah Williams
556e374e02
fix default artifacts to exclude ios and android (#35303) 2019-07-02 17:40:55 -07:00
Siva
f496595773
Use the new service protocol message names (#35482)
* Use the new service protocol message names
  clearVMTimeline
  setVMTimelineFlags
  getVMTimeline
  getVMTimelineFlags

* Fix clearTimeline at another spot.
2019-07-02 16:10:04 -07:00
Alexandre Ardhuin
758009ba70
more ui-as-code (#35393)
* more ui-as-code

* address review comments
2019-07-02 21:11:56 +02:00
stuartmorgan
d6bd1c0584
Add --target support for Windows and Linux (#34660)
- Adds desktop projects to ApplicationPackageStore
- Plumbs target overrides through the desktop builds
2019-07-01 14:49:34 -07:00
Jenn Magder
95a1816698
Clean up host_app_ephemeral Profile build settings (#35307) 2019-07-01 11:02:25 -07:00
Zachary Anderson
97127730f2
[flutter_tool] Fill in Fuchsia version string (#34516) 2019-06-28 12:12:53 -07:00
David Shuckerow
df6e4d4872
Make it possible to override the FLUTTER_TEST env variable (#34301)
* Make it possible to override the FLUTTER_TEST env variable without unsetting it.

* Switch to using platform instead of Platform.

* Document the bindings, and introduce tests that initialize multiple WidgetsBindings with different environments.

* Add tests for the flutter platform test.

* Add license headers

* Fix lints

* Remove trailing whitespace

* Respond to Jonahs comments

* Respond to Ians comments

* Mock out the HttpServer in flutter_platform_test

* Mock out the HttpServer in flutter_platform_test

* Explain why we mock out the HttpServer in flutter_platform_test
2019-06-28 10:37:27 -07:00
Jonah Williams
a1d3edc446
Twiggle bit to exclude dev and beta from desktop and web (#35221) 2019-06-27 19:04:02 -07:00
Jonah Williams
3d77923b39
fix coverage collection to un-red build (#35231) 2019-06-27 17:47:20 -07:00
Todd Volkert
04e2f22650
Force-upgrade package deps (#35206) 2019-06-27 14:02:23 -07:00
Jonah Williams
c9b283386b
ensure test isolate is paused before collecting coverage (#35188) 2019-06-27 13:50:47 -07:00
Alexandre Ardhuin
919dcf53f3
enable lints prefer_spread_collections and prefer_inlined_adds (#35189) 2019-06-27 21:23:16 +02:00
Jonah Williams
a0b2878e76
Make tool coverage collection resilient to sentinel coverage data (#35186) 2019-06-27 11:17:58 -07:00
Jonah Williams
8532f4d08e
Allow multi-root web builds (#34896)
* fix multiroot builds

* remove shout

* add basic test

* Update web_compilation_delegate.dart

* Address review feedback

* Update multiroot_asset_reader_test.dart

* Update multiroot_asset_reader_test.dart

* remove unpassable test

* fix for windows

* facepalm
2019-06-27 06:01:41 -07:00
Todd Volkert
883d6eadcb
More HttpClientResponse implements Stream<Uint8List> fixes (#35149)
https://github.com/dart-lang/sdk/issues/36900
2019-06-26 16:56:10 -07:00
Jonah Williams
33ad5bac34
Attempt to enable tool coverage redux (#35074) 2019-06-26 16:02:49 -07:00
Dan Field
bb79ff3b49
More shards (#34877)
Shard tool_tests
2019-06-26 13:55:16 -07:00
Lau Ching Jun
cfe4d0d7b9
Add FlutterProjectFactory so that it can be overridden internally. (#35092)
Also update the comments since we don't return Future<FlutterProject>
anymore.
2019-06-26 13:29:53 -07:00
Lau Ching Jun
c8cefce300
Move findTargetDevices to DeviceManager (#35084)
This allows us to override the behavior internally.
2019-06-26 10:09:14 -07:00
Danny Tuppeny
f3be1d9d95
Add emulatorID field to devices in daemon (#34794)
* Add emulatorId to Android and iOS emulator devices

* Update docs

* Review tweaks

* Add tests for AndroidConsole for getting avd names

* Remove unused import

* Remove duplicated header

* Fix imports
2019-06-26 16:39:23 +01:00
Josh Burton
577c2fc48c Ensures flutter jar is added to all build types on plugin projects (#34573) 2019-06-25 10:40:55 -07:00
Alexandre Ardhuin
c7408be181
prepare for lint update of prefer_final_fields (#35059) 2019-06-25 19:39:34 +02:00
Emmanuel Garcia
2cf8213468
Break down flutter doctor validations and results (#34624) 2019-06-25 10:22:08 -07:00
Alexandre Ardhuin
fecf99ff1e
enable lint avoid_bool_literals_in_conditional_expressions (#35055) 2019-06-25 17:40:05 +02:00
Jonah Williams
25b5656969
Reland: rename web device (#34885) 2019-06-24 11:09:07 -07:00
Danny Tuppeny
8dbfc82bc7
Tweak the display name of emulators (#34785) 2019-06-24 11:41:02 +01:00
Todd Volkert
bb6c3f8131
Remove flutter_tools support for old AOT snapshotting (#34895)
Android now exclusively uses ELF shared libraries, and
iOS uses assembly.
2019-06-22 19:30:24 -07:00
Jonah Williams
d644015620
Revert "set web device name to Chrome (#34856)" (#34884) 2019-06-21 15:04:44 -07:00
Jonah Williams
19d7925f1f
set web device name to Chrome (#34856) 2019-06-21 14:26:25 -07:00
Jonah Williams
25a3121dfd
Prefer ephemeral devices from command line run (#34802) 2019-06-20 14:33:58 -07:00
Jason Simmons
300e8f842b
Remove flags related to dynamic patching (#34736) 2019-06-20 12:06:30 -07:00
Jenn Magder
1b176c5df1
Update Xcode projects to recommended Xcode 10 project settings (#34738) 2019-06-20 08:48:19 -07:00
Jenn Magder
fa491fc9fe
Close platform when tests are complete (dispose compiler and delete font files) (#34685) 2019-06-20 08:47:54 -07:00
Jonah Williams
b9932d55e7
Add linux doctor implementation (#34755) 2019-06-20 08:20:57 -07:00
Jonah Williams
d7e53d4816
move hack flag to common (#34754) 2019-06-19 16:29:11 -07:00
Jonah Williams
830fb38640
Revert "Add basic desktop linux checks (#31873)" (#34753)
This reverts commit f221ad1f92.
2019-06-19 16:03:05 -07:00
Jonah Williams
f221ad1f92
Add basic desktop linux checks (#31873) 2019-06-19 15:51:21 -07:00
Jonah Williams
d4d10dac61
Revert "Check whether FLUTTER_ROOT and FLUTTER_ROOT/bin are writable. (#34291)" (#34750)
This reverts commit 49449505b6.
2019-06-19 15:37:04 -07:00
Jonah Williams
0d9a1b201e
Remove environment variable guards for command line desktop and web (#33867) 2019-06-19 13:39:27 -07:00
Jonah Williams
5d3efbde80
unpin build daemon (#34686) 2019-06-19 11:43:38 -07:00