Kate Lovett
0379dd1c26
Updating cirrus fingerprint script to include goldens version ( #36690 )
2019-07-23 09:30:41 -07:00
Kate Lovett
8809f698cb
Revert "Part 1: Skia Gold Testing ( #33688 )" ( #36094 )
...
This reverts commit eb0b179028
2019-07-12 13:35:36 -07:00
Kate Lovett
eb0b179028
Part 1: Skia Gold Testing ( #33688 )
...
* Fresh PR for Gold integration.
* Nits
* WIP
* Artifacts from merge
* Changed some platform dependencies for web, added library prefix notation for Skia Gold test names.
* Updating for CI implementation
* Write out service account
* Writing to skip out
* WIP
* ++
* Fixing depot tools deps
* Windows depot_tools
* Fixing setup scripts
* ++
* depot tools
* ++
* WIP
* Tracing depot_tools clone
* WIP
* ++
* analyzer
* WIP
* chrome typo
* copy artifact
* Working on tests
* Code cleanup
* ++
* Code cleanup, updated tests
* ++ review feedback
* Review
* Analyzer
* Review feedback
* Nits from review
* PRogress
* ++
* Fixing tests
* ++
* Testing repo route
* Just needing documention around new structures.
* cleanup
* Analyzer
* Documentation updates
* Documentation updates
* Cirrus updates
* cirrus nit
* Review feedback
* Review feedback
* Fixing skip comparator
* Fix base directory for Skia Gold case
* ++
* Feedback
* ++
* Fixed uri assertion
* Made GoldensClient abstract, altered SkiaGoldClient constructor
* Analyzer
2019-07-12 12:23:04 -07:00
Chris Bracken
4d9923201b
Correct typos ( #33322 )
...
Corects a bnuch of typeos throuhgout teh Fluter codebsae.
Made use of the `misspell` tool:
https://github.com/client9/misspell
2019-05-24 19:12:45 -07:00
Kate Lovett
829bdeb426
Fixing accidental merge from WIP branch. ( #32520 )
...
Revert "Merge branch 'master' into master"
This reverts commit e3a03c04c46474982649
2019-05-10 15:53:41 -07:00
Kate Lovett
fdd554fb46
Anaalyzer fixes.
2019-04-25 15:59:48 -07:00
Kate Lovett
abb555fe94
Modified platform specific golden file test.
2019-04-25 15:50:53 -07:00
Kate Lovett
8861e9f3dc
Cleanup
2019-04-25 14:51:59 -07:00
Kate Lovett
e332ab859a
Changed implementation to incorpoarate new init feature for goldctl. Reduces redundant work as well.
2019-04-25 12:18:56 -07:00
Kate Lovett
a38311e6c8
Fixing duplicate test names.
2019-04-25 10:05:13 -07:00
Kate Lovett
ba011fd353
nits
2019-04-24 15:35:48 -07:00
Kate Lovett
1fcd1b02de
Changes for uploading baseline images.
2019-04-24 13:38:49 -07:00
Kate Lovett
7e542fc334
Committing progress.
2019-04-19 14:33:49 -07:00
Kate Lovett
9e3e44ee3d
Committing test progress.
2019-04-19 11:32:16 -07:00
Kate Lovett
4f29c31048
Updating inline documentation
2019-04-19 10:19:31 -07:00
Kate Lovett
b6a2efb7ab
Committing progress. Documentation and testing incomplete/in progress. Code cleanup needed as well.
2019-04-18 16:08:09 -07:00
Chris Bracken
52e4214dbb
Fix crash on flutter update-packages ( #28922 )
...
When running git update-packages, if the goldens repo is dirty, the
flutter tool currently crashes and logs the failure from git pull.
This adds a check for a dirty git client and emits a friendlier error
message in the case where it's not clean, and avoid the crash by
catching the NonZeroExitCode exception and rethrowing as toolExit
instead.
Fixes: https://github.com/flutter/flutter/issues/28915
2019-03-06 09:14:39 -08:00
Alexandre Ardhuin
d927c93310
Unnecessary new ( #20138 )
...
* enable lint unnecessary_new
* fix tests
* fix tests
* fix tests
2018-09-12 08:29:29 +02:00
Amir Hardon
592731f220
Clone goldens as part of flutter update-packages.
...
flutter_tools cannot depend on flutter_goldens (as flutter_goldens
depdends on the Flutter sdk), so this commit splits client.dart from
flutter_goldens to a pure-dart flutter_goldens_client package.
2018-08-20 14:29:26 -07:00
