Jonah Williams
a01f37245b
[flutter_tools] remove globals from terminal ( #77953 )
2021-03-12 12:53:05 -08:00
Jenn Magder
d6f5767ec8
Remove MockFlutterVersions ( #77962 )
2021-03-11 16:05:05 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint ( #77434 )
2021-03-05 18:38:15 -08:00
Jonah Williams
721702717d
[flutter_tools] replace MockFlutterVersion usage with fake where possible, move from context ( #77390 )
2021-03-05 14:04:03 -08:00
Sam Rawlins
ba58ad0385
Remove "unnecessary" imports in test/general.shard ( #75954 )
2021-02-18 13:38:24 -08:00
Jenn Magder
4436334f8a
Adopt TestUsage in flutter_command_test ( #76282 )
2021-02-18 12:52:04 -08:00
Jenn Magder
9236eefdff
MockPub -> FakePub ( #75759 )
2021-02-10 17:01:20 -08:00
Jonah Williams
021311ed8a
Revert "[flutter_tools] move process manager into tool ( #75350 )" ( #75639 )
...
This reverts commit 8b6baae44c
2021-02-08 09:21:46 -08:00
Jonah Williams
8b6baae44c
[flutter_tools] move process manager into tool ( #75350 )
...
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Ian Hickson
8acac060bf
Remove the timeout when launching DevTools ( #74859 )
2021-02-01 16:06:02 -08:00
Jonah Williams
e53c48968f
[flutter_tools] remove mock SystemClock ( #74994 )
2021-01-29 14:28:08 -08:00
Jenn Magder
ff87150ba9
Revert "Swap MockStdio to FakeStdio in tests ( #74838 )" ( #74867 )
...
This reverts commit 547ed88ab3
2021-01-27 19:35:16 -08:00
Jenn Magder
547ed88ab3
Swap MockStdio to FakeStdio in tests ( #74838 )
2021-01-27 17:33:47 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. ( #74832 )
...
* opt out the flutter tool
* oops EOF
* fix import
* Update tool_backend.dart
* Update daemon_client.dart
* fix more
2021-01-27 15:17:53 -08:00
Jenn Magder
912c3ab171
Revert "Revert "[flutter_tools] Serve DevTools at app start ( #73366 )" ( #73896 )" ( #73903 )
...
This reverts commit 388dcd2478
2021-01-13 15:36:43 -08:00
Jenn Magder
388dcd2478
Revert "[flutter_tools] Serve DevTools at app start ( #73366 )" ( #73896 )
...
This reverts commit 1cb0a24a46
2021-01-13 13:57:09 -08:00
Kenzie Schmoll
1cb0a24a46
[flutter_tools] Serve DevTools at app start ( #73366 )
...
* [flutter_tools] Serve DevTools at app start
2021-01-12 21:39:27 -08:00
Jonah Williams
7c618758bb
[flutter_tools] delegate first run message re-display to new class, only if changed ( #73353 )
2021-01-05 18:44:04 -08:00
Jonah Williams
c92cc25830
[flutter_tools] report basic analytics for null-safety ( #71487 )
2020-12-03 15:14:20 -08:00
Jonah Williams
613a959878
only use code single path for verification of target file existence ( #70962 )
2020-11-20 14:17:11 -08:00
Anurag Roy
05dadb0120
[flutter_tools] Make flutter upgrade --verify-only display framework version differences instead of commit hashes ( #69420 )
2020-11-19 18:03:05 -08:00
Jonah Williams
0b88269807
[flutter_tools] remove branch migration and standardize constructor style for version interface ( #70058 )
2020-11-12 15:29:03 -08:00
Jonah Williams
a40ee8a3fb
[flutter_tools] migrate .packages to package_config, partial ( #70200 )
2020-11-11 13:50:41 -08:00
Jonah Williams
0bbd9020ed
[flutter_tools] remove experiment tracking analytics for null safety ( #70183 )
2020-11-10 12:49:50 -08:00
Jonah Williams
2fb53d83f2
[flutter_tools] remove all globals from cache and cache_test ( #69505 )
2020-11-06 15:26:45 -08:00
Dan Field
cfcb9887c9
Do not use --first-parent when determining version on master ( #69726 )
2020-11-05 10:11:32 -08:00
Jonah Williams
9e5e763ebe
[flutter_tools] document flutter root initialization ( #67884 )
...
Moves the flutter root initialization to a static method on the cache. This is a small step towards making this functionality non-static and instead injected like normal members - however, completely removing all of the static-ness at once was too large of a change.
Instead document and add unit tests and change existing code as little as possible.
#47161
2020-10-27 15:20:07 -07:00
Jonah Williams
1271447bbe
[flutter_tools] remove globals from FlutterValidator, add documentation and move tests to new file ( #67234 )
...
Remove globals from the flutter validator class, and refactor the tests into a separate file. Applies some other cleanup like adding doc comments, and making the doctor validator work like it is documented to work - removing the gen_snapshot check if the artifact is not downloaded instead of downloading all android artifacts.
#47161
2020-10-05 17:58:56 -07:00
Jonah Williams
7f2ca5e532
[flutter_tools] refactor engine locator to its own class ( #67274 )
...
Make the logic for locating a local engine path part of its own class, add documentation, and update tests to cover engine source path locating too.
#47161
2020-10-05 16:25:47 -07:00
Jenn Magder
e8fbb43aac
Replace MockFile with memory file system files ( #66941 )
2020-09-29 17:50:33 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. ( #65568 )
2020-09-16 14:14:06 -07:00
Jonah Williams
bd3eee75f3
[flutter_tools] rethrow process exceptions as tool exit from gradle build ( #64745 )
...
The flutter tool is currently unable to detect missing permissions in gradle/gradle.bat that would cause a gradle build to fail via process exception. Rather than crashing and exiting, we can display the exception as an error message and tool exit.
While linux/macOS are able to add the +x bit, this is not possible on windows with our current file system/OS API. These crashes represent a substantial amount of crash reporting, but are otherwise not actionable on our end.
2020-09-03 11:55:55 -07:00
Christopher Fujino
8dcb4c338a
Fix version parsing to use git tag --points-at ( #63505 )
2020-08-11 17:29:35 -07:00
Chris Yang
c9cd825fca
[flutter_tools] flutter version reports picks up release versions ( #63019 )
2020-08-05 15:20:27 -07:00
Jonah Williams
e1538d1b88
[flutter_tools] last pass on general.shard unit tests ( #60263 )
...
Last batch of test fixes for general shard.
2020-06-26 13:36:06 -07:00
Jonah Williams
55abbb6be6
[flutter_tools] track null safety usage ( #59822 )
...
* [flutter_tools] track null safety usage
* Update flutter_command_test.dart
* cleanups
2020-06-22 17:05:01 -07:00
James D. Lin
c21b3233e4
[flutter tools] Don't return success if we trigger runZoned's error callback ( #58474 )
2020-06-15 09:35:04 -07:00
Jenn Magder
222c2cb0cc
Deprecate make-host-app-editable ( #59217 )
2020-06-11 11:37:15 -07:00
Jenn Magder
75fd73d818
Revert "[flutter_tools] inject output preferences at the top level ( #58875 )" ( #59197 )
...
This reverts commit dca6320fe4
2020-06-10 13:49:35 -07:00
Jonah Williams
dca6320fe4
[flutter_tools] inject output preferences at the top level ( #58875 )
...
The tool was setting the output preferences in a sub-context. Originally these were not injected before the arg parsers were created, though that was fixed by the lazy command creation. Once local engine is removed, the inner flutter_command Zone can be removed.
2020-06-10 12:13:06 -07:00
Jenn Magder
5eb4917d73
Release cache lock for commands after required artifacts are downloaded ( #59012 )
2020-06-08 17:18:02 -07:00
Jonah Williams
f5de6aadd4
[flutter_tools] remove zone level overrides of verbose and daemon logging ( #57448 )
...
Make it possible for all FlutterCommands to be global free, by moving instantiation to inside the Zone context. Additionally, provide VerboseLogger and NotifyLogger (daemon) at the top level and remove from command-specific overrides.
This allows removing a work around where web devices needed to look up directly from the context in non-test code.
Technically the output preferences are still zone injected, but these will be moved soon as they were not being used correctly by the top level command (the injection comes after ArgParser reads the overflow values, causing numerous wrap issues)
2020-06-04 16:35:36 -07:00
Zachary Anderson
533cd7a6d1
[flutter_tools] Delete system temp entries on fatal signals ( #55513 )
2020-05-14 14:27:02 -07:00
Zachary Anderson
6f0ed5e142
[flutter_tools] Restore base/platform.dart ( #56410 )
2020-05-06 08:15:39 -07:00
Jonah Williams
7b1d24216e
[flutter_tools] Make packages not required for local engine ( #55882 )
2020-04-28 14:53:53 -07:00
kwkr
1ac09088c3
Fix/use contains ignoring whitespace ( #55887 )
2020-04-28 13:12:12 -07:00
James D. Lin
b7fd24a7dc
[flutter tools] Move _informUserOfCrash into crash_reporting.dart ( #55614 )
2020-04-28 10:34:03 -07:00
Christopher Fujino
37ac9015ad
[flutter_tools] check first for stable tag, then dev tag ( #55342 )
2020-04-23 15:19:27 -07:00
Jonah Williams
d46da3ae11
[flutter_tools] remove PackageMap and finish PackageConfig migration ( #55244 )
2020-04-21 19:55:15 -07:00
Jenn Magder
8109dcc2b4
CrashReportSender dependency injection ( #54924 )
2020-04-20 15:23:09 -07:00
Jenn Magder
fc76fc2a96
Move GitHubTemplateCreator into reporting library ( #55002 )
2020-04-17 10:47:12 -07:00
Zachary Anderson
bec63a54bf
[flutter_tools] Provide global options with subcommand help text ( #54884 )
2020-04-17 08:54:48 -07:00
Jenn Magder
602475e56f
Sanitize error message sent to GitHub crash reporter ( #53936 )
2020-04-06 11:00:22 -07:00
Jenn Magder
85ad699865
Remove URL shortening from GitHub reporter similar issues URL ( #53882 )
2020-04-03 10:32:55 -07:00
Christopher Fujino
2396616e09
Support old and new git release tag formats ( #53715 )
2020-04-03 09:39:28 -07:00
Lasse R.H. Nielsen
af5194dbfd
Prepare Flutter for SDK changes to runZoned. ( #52953 )
...
The `runZoned` method deprecates the `onError` parameter.
Invocations using that parameter must use `runZonedGuarded` instead.
This prepares Flutter for the deprecation. The same places need to be migrated to using
`runZonedGuarded` when the SDK change has been ported to Flutter.
Then the deprecated member will be removed in a follow-up CL when the most important
packages have been migrated.
2020-03-24 08:34:17 -07:00
Jenn Magder
e0ab6fc00c
Move outputPreferences to globals ( #52846 )
2020-03-18 15:54:26 -07:00
Dmitry Ratushnyy
1b0fd265bd
[ISSUE-30478] Release cache dir lock acquired by a command on sigint or sigterm ( #52194 )
2020-03-12 09:11:01 -07:00
Dan Field
e13e17009d
Reland fix --version ( #52141 )
2020-03-06 21:38:35 -08:00
Jonah Williams
e7d70fbf75
Revert "Fix version command for certain git workflows ( #52062 )" ( #52128 )
...
This reverts commit 20bf43b9eb
2020-03-06 12:58:00 -08:00
Jenn Magder
f6a55125d2
Add usage event for failed iOS project migration ( #51879 )
2020-03-06 12:14:29 -08:00
Dan Field
20bf43b9eb
Fix version command for certain git workflows ( #52062 )
2020-03-05 23:51:02 -08:00
Zachary Anderson
b9ecebf101
Reland: [flutter_tools] Disable analytics for more bots ( #50641 )
2020-02-12 10:58:02 -08:00
Zachary Anderson
1903ce012e
Revert "[flutter_tools] Disable analytics for more bots ( #50579 )" ( #50622 )
...
This reverts commit 0a38f29c0d
2020-02-11 22:47:41 -08:00
Zachary Anderson
0a38f29c0d
[flutter_tools] Disable analytics for more bots ( #50579 )
2020-02-11 15:48:02 -08:00
Alexandre Ardhuin
b5f328e37e
remove unnecessary string interpolations ( #49622 )
2020-01-31 18:30:21 +01:00
Dan Field
fabeb2a16f
Revert string interp ( #49602 )
2020-01-28 07:56:51 -08:00
Jenn Magder
7f715628b0
Replace FlutterVersion.instance with FlutterVersion context fetch in global.dart ( #49462 )
2020-01-27 17:38:01 -08:00
Dan Field
8b2993337a
revert #48985 ( #49572 )
2020-01-27 14:36:02 -08:00
Jenn Magder
acdaffc493
Suppress upgrade message with --machine ( #49408 )
2020-01-24 10:50:54 -08:00
Alexandre Ardhuin
92cbaa3efe
remove unnecessary string interpolations ( #49352 )
2020-01-23 20:43:01 -08:00
Anthony
b67d5ec6e9
[a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set ( #48985 )
2020-01-17 15:13:01 -08:00
Alexandre Ardhuin
003541499b
use isA<Xxx>() matcher ( #48482 )
2020-01-16 12:43:03 -08:00
Dan Field
0a600e1ddc
Fix tool test order ( #48735 )
2020-01-13 17:11:32 -08:00
Emmanuel Garcia
ec2d58335a
Make subcommands return success instead of null ( #48100 )
2020-01-10 11:28:01 -08:00
Dan Field
d73b3682c9
Fix state in test ( #48269 )
2020-01-06 16:33:31 -08:00
Jonah Williams
ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable ( #47398 )
2020-01-06 11:04:20 -08:00
Zachary Anderson
895ffc80dc
[flutter_tool] Handling of certain unrecoverable filesystem errors ( #46617 )
2019-12-11 12:54:36 -08:00
Ian Hickson
449f4a6673
License update ( #45373 )
...
* Update project.pbxproj files to say Flutter rather than Chromium
Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
* Update the copyright notice checker to require a standard notice on all files
* Update copyrights on Dart files. (This was a mechanical commit.)
* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).
* Clean up the copyrights in non-Dart files. (Manual edits.)
Also, make sure templates don't have copyrights.
* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Jenn Magder
7d8f82051b
Suggest GitHub template when flutter tool crashes ( #45360 )
...
* On flutter tool crash suggest GitHub template
* Shorten GitHub URLs
* Whitespace
* Wording tweak from @InMatrix
* Review edits
2019-11-26 14:06:31 -08:00
Christopher Fujino
dc68d5700b
Fix flutter run cache ( #45267 )
2019-11-26 09:02:34 -08:00
Alexandre Ardhuin
980f14e0c5
implicit-casts:false on flutter_tools ( #45153 )
...
* implicit-casts:false on flutter_tools
* use castStringKeyedMap
* address review comments
* address review comments
* fix issues after rebase
2019-11-24 06:54:43 +01:00
Jonah Williams
4c677e4148
Extra defensive programming for pub modification time assert ( #43315 )
2019-10-22 22:05:00 -07:00
Jonah Williams
46ea99122b
Revert "Extra defensive programming for pub modification time assert ( #42491 )" ( #43235 )
...
This reverts commit 3597bae6a0
2019-10-21 20:54:02 -07:00
Ian Hickson
3597bae6a0
Extra defensive programming for pub modification time assert ( #42491 )
2019-10-21 20:15:20 -07:00
Ian Hickson
08643c41d7
Always fake ProcessManager when you fake Filesystem in tests ( #42369 )
...
...because otherwise, processes that think they're manipulating your
filesystem will be doing crazy things the test is ignoring, leading to
(at best) failures and (at worst) flakes or disk corruption.
2019-10-11 11:23:12 -07:00
Zachary Anderson
cf0d4979c7
[flutter_tool] Re-work analytics events to use labels and values ( #42016 )
2019-10-07 15:04:55 -07:00
Zachary Anderson
c7c8a6c498
[flutter_tools] Add more info to pub get failure event ( #41652 )
2019-10-03 11:08:42 -07:00
Zachary Anderson
45f3c8d060
[flutter_tool] Report to analytics when the tool is killed by a signal ( #41493 )
...
* [flutter_tool] Report to analytics when the tool is killed by a signal
* Fix analyzer lint
2019-09-30 07:38:11 -07:00
Zachary Anderson
5142238c85
[flutter_tool] Report rss high watermark in command analytics events ( #40988 )
2019-09-25 11:26:06 -07:00
Alexandre Ardhuin
b873162194
fix some bad indentations ( #41172 )
2019-09-24 21:03:37 +02:00
Alexandre Ardhuin
89427d672d
add missing trailing commas in flutter_tools ( #40968 )
2019-09-24 08:06:09 +02:00
∂ω∂
4277f364ff
flutter_tools/version: git log.showSignature=false ( #38576 )
2019-08-21 13:55:57 -07:00
Zachary Anderson
c7596da5a4
[flutter_tool] Re-try sending the first crash report ( #37198 )
2019-07-31 13:51:19 -07:00
Zachary Anderson
99d66f2709
[flutter_tool] Make a couple file operations synchronous ( #37044 )
2019-07-30 12:16:32 -07:00
Zachary Anderson
ef146f63bb
[flutter_tool] Clean up usage events and custom dimensions ( #36785 )
2019-07-29 07:24:02 -07:00
Jonah Williams
3fedb8cb5a
Reland: use flutter features for web and desktop ( #36699 )
2019-07-22 15:34:03 -07:00
Jonah Williams
8eae2dfb92
Revert "Use FlutterFeatures to configure web and desktop devices ( #36465 )" ( #36654 )
...
This reverts commit bd52a78c71
2019-07-21 21:47:43 -07:00
Jonah Williams
bd52a78c71
Use FlutterFeatures to configure web and desktop devices ( #36465 )
2019-07-21 18:21:15 -07:00
Zachary Anderson
82a4ba40bb
[flutter_tool] Send analytics command before the command runs ( #36490 )
2019-07-18 18:05:44 -07:00
