Commit Graph

568 Commits

Author SHA1 Message Date
Kate Lovett
eb0b179028
Part 1: Skia Gold Testing (#33688)
* Fresh PR for Gold integration.

* Nits

* WIP

* Artifacts from merge

* Changed some platform dependencies for web, added library prefix notation for Skia Gold test names.

* Updating for CI implementation

* Write out service account

* Writing to skip out

* WIP

* ++

* Fixing depot tools deps

* Windows depot_tools

* Fixing setup scripts

* ++

* depot tools

* ++

* WIP

* Tracing depot_tools clone

* WIP

* ++

* analyzer

* WIP

* chrome typo

* copy artifact

* Working on tests

* Code cleanup

* ++

* Code cleanup, updated tests

* ++ review feedback

* Review

* Analyzer

* Review feedback

* Nits from review

* PRogress

* ++

* Fixing tests

* ++

* Testing repo route

* Just needing documention around new structures.

* cleanup

* Analyzer

* Documentation updates

* Documentation updates

* Cirrus updates

* cirrus nit

* Review feedback

* Review feedback

* Fixing skip comparator

* Fix base directory for Skia Gold case

* ++

* Feedback

* ++

* Fixed uri assertion

* Made GoldensClient abstract, altered SkiaGoldClient constructor

* Analyzer
2019-07-12 12:23:04 -07:00
Jonah Williams
fb9ff9296e
fix linesplitter (#36006) 2019-07-11 16:52:14 -07:00
gaaclarke
3122786ad5
Fixed build of example code to use new binary messenger API. (#35825)
Fixed build of example code to use new binary messenger API.
2019-07-10 13:10:05 -07:00
Ian Hickson
176ebfd53e
flutter/tests support (#33140)
This introduces a script that implements the conventions described in https://github.com/flutter/tests/pull/1.
2019-07-10 12:10:28 -07:00
Jonah Williams
2b20345bb8
use pub run for create test and remove [INFO] logs (#35839) 2019-07-10 08:48:01 -07:00
Jenn Magder
2ad5376a06
Build all example projects in CI build smoke test (#35778) 2019-07-09 16:00:33 -07:00
Jonah Williams
93edc014ae
update packages (#35573) 2019-07-04 11:26:19 -07:00
Alexandre Ardhuin
758009ba70
more ui-as-code (#35393)
* more ui-as-code

* address review comments
2019-07-02 21:11:56 +02:00
Alexandre Ardhuin
9c31f9f41a
remove unnecessary ..toList() (#35263) 2019-07-01 07:05:42 +02:00
Todd Volkert
04e2f22650
Force-upgrade package deps (#35206) 2019-06-27 14:02:23 -07:00
Alexandre Ardhuin
919dcf53f3
enable lints prefer_spread_collections and prefer_inlined_adds (#35189) 2019-06-27 21:23:16 +02:00
Jonah Williams
33ad5bac34
Attempt to enable tool coverage redux (#35074) 2019-06-26 16:02:49 -07:00
Dan Field
bb79ff3b49
More shards (#34877)
Shard tool_tests
2019-06-26 13:55:16 -07:00
Dan Field
6d8a59c8ba
pass new users for release_smoke_tests (#35130) 2019-06-26 12:31:29 -07:00
Alexandre Ardhuin
fecf99ff1e
enable lint avoid_bool_literals_in_conditional_expressions (#35055) 2019-06-25 17:40:05 +02:00
Dan Field
3630525673
Shard gradle tests (#34857) 2019-06-21 12:05:06 -07:00
Dan Field
a0fc3f3150
Shard framework tests (#34812) 2019-06-20 14:35:33 -07:00
Dan Field
86c3ae7611
Revert "Backup docs (#34757)" (#34761)
This reverts commit 3ca7609810.
2019-06-19 19:39:49 -07:00
Dan Field
3ca7609810
Backup docs (#34757) 2019-06-19 18:30:39 -07:00
Jonah Williams
449d4b1ee5
disable widgets and material (#34739) 2019-06-19 15:51:31 -07:00
Jonah Williams
5d3efbde80
unpin build daemon (#34686) 2019-06-19 11:43:38 -07:00
Dan Field
4a60bee7c0
Release diagnostics (#34474)
Skip diagnostics on release mode, add test in firebase testlab
2019-06-18 11:06:09 -07:00
Ian Hickson
d310d31de3
Roll pub dependencies (#33677) 2019-06-13 18:07:16 -07:00
Jonah Williams
c1a2e44c78
Allow flaky tests to pass or fail and mark web tests as flaky (#34456) 2019-06-13 17:52:04 -07:00
Jonah Williams
3ae6abd9e8
Compatibility pass on flutter/material tests for JavaScript compilation. (9) (#33378) 2019-06-12 17:06:01 -07:00
Emmanuel Garcia
21a532698f
Split gradle_plugin_test.dart (#34282)
Fixes timeout when running gradle_plugin_test
2019-06-11 16:24:03 -07:00
Jonah Williams
9d724d4c44
Compatibility pass on flutter/widgets tests for JavaScript compilation. (8) (#33377) 2019-06-11 14:51:03 -07:00
Jonah Williams
7cc716187b
Compatibility pass on flutter/semantics tests for JavaScript compilation. (7) (#33360) 2019-06-11 11:22:37 -07:00
Jonah Williams
05e92c828b
Compatibility pass on flutter/physics tests for JavaScript compilation. (6) (#33359) 2019-06-11 09:09:13 -07:00
Jonah Williams
ca14af6b92
Compatibility pass on flutter/rendering tests for JavaScript compilation. (5) (#33355) 2019-06-10 17:29:46 -07:00
Jonah Williams
c88f64ed50
Compatibility pass on flutter/services tests for JavaScript compilation. (4) (#33354) 2019-06-10 15:46:36 -07:00
Jonah Williams
c05fa894e6
Compatibility pass on flutter/painting tests for JavaScript compilation. (3) (#33352) 2019-06-10 14:05:51 -07:00
Jonah Williams
980a574d4c
Compatibility pass on flutter/scheduler tests for JavaScript compilation. (2) (#33350) 2019-06-10 10:17:53 -07:00
Jonah Williams
7f7c00a4e9
Enable web foundation tests (#34032) 2019-06-09 11:03:46 -07:00
Jonah Williams
698d458dc8
Add chrome stable to dockerfile and web shard (#33787) 2019-06-06 21:10:24 -07:00
Jonah Williams
3f4ce34877
make sure version check includes hotfixes (#33459) 2019-06-06 15:28:20 -07:00
Jonah Williams
83986acbdb
Add a real-er web restart, doctor, workflow (#33786) 2019-06-03 23:19:42 -07:00
Ian Hickson
2767d37c96 RTL caret in text fields (#33461) 2019-06-03 10:25:54 -07:00
Chris Bracken
98ea501995
Revert "Add real-er restart for web using webkit inspection protocol (#33629)" (#33703)
Revert "fix devicelab manfiest (#33698)"

This reverts commit 5a6a00dc54.
This reverts commit 0d79f0fc79.
2019-05-31 21:53:30 -07:00
Jonah Williams
5a6a00dc54
Add real-er restart for web using webkit inspection protocol (#33629) 2019-05-31 17:37:01 -07:00
Jonah Williams
da600bacfe
Reland - Wire up hot restart and incremental rebuilds for web (#33533) 2019-05-29 22:46:28 -07:00
Jason Simmons
311cde98a6
Reland "Clean up some flutter_tools tests and roll dependencies" (#33225)
This relands flutter/flutter#33163 with a fix to the integration_ui test.
2019-05-29 19:04:35 -07:00
Jonah Williams
925f5f1c53
Revert "Wire up hot restart and incremental rebuilds for web (#33197)" (#33529)
This reverts commit 52ae99682e.
2019-05-29 12:09:01 -07:00
Jonah Williams
52ae99682e
Wire up hot restart and incremental rebuilds for web (#33197) 2019-05-29 09:49:16 -07:00
Chris Bracken
4d9923201b
Correct typos (#33322)
Corects a bnuch of typeos throuhgout teh Fluter codebsae.

Made use of the `misspell` tool:
https://github.com/client9/misspell
2019-05-24 19:12:45 -07:00
Greg Spencer
c99ed8fed9
Add unpublish_package script. (#33267)
This adds a maintenance script that will allow us to "unpublish" a release: basically remove it from the cloud storage so that we're no longer serving it from the website.

Obviously, gsutil access to the cloud storage server is required for this to function.
2019-05-24 08:56:52 -07:00
Jonah Williams
a30ffb60ad
Revert "Clean up some flutter_tools tests and roll dependencies (#33163)" (#33206) 2019-05-22 12:20:02 -07:00
Ian Hickson
e5f81e1048
Clean up some flutter_tools tests and roll dependencies (#33163)
* Clean up some flutter_tools tests

* Remove arbitrary retry that happens even for fundamental errors, and generally clean up _DevFSHttpWriter.

* Update dependencies (requires fixes; see next commit)

* Fixes for new dependencies.
2019-05-22 09:31:37 -07:00
Michael Thomsen
7ae3caf309
Rename flutter packages to flutter pub (#33041) 2019-05-21 16:38:58 +02:00
Emmanuel Garcia
cc7ec6d624
Bump multicast_dns version 2019-05-06 11:14:41 -07:00
Jonah Williams
6a250c8d65
update packages and unpin build (#32066) 2019-05-03 16:54:35 -07:00
Jonah Williams
c1c15dd702
Revert "update packages and unpin build (#31736)" (#31795) 2019-04-29 09:56:55 -07:00
Jonah Williams
41b18422df
update packages and unpin build (#31736) 2019-04-29 09:10:01 -07:00
Dan Field
1db5d66932
Capture JSON RPC errors that presently get swallowed (#31584)
* Update packages
* Capture JSON RPC errors that presently get swallowed
2019-04-25 08:27:00 -07:00
xster
c7a09a415d
Cupertino localization step 8: create a gen_cupertino_localizations and generate one for cupertino english and french (#29824) 2019-04-24 12:40:17 -07:00
Sam Rawlins
24158686df Bump dartdoc to 0.28.3+2 (#31148)
This version of dartdoc properly escapes fenced code block "info strings."
2019-04-16 15:02:18 -07:00
xster
054e8870eb
Fix iTunes Transporter quirk (#30883) 2019-04-10 18:33:43 -07:00
xster
d0f89c1190
Fix gallery deploy on iOS (#22810) 2019-04-05 18:55:33 -07:00
Michael Goderbauer
f7048b696d
Bump dartdocs to 0.28.3+1 (#30570) 2019-04-05 14:01:27 -07:00
Michael Goderbauer
194babfb42
Bump dartdocs to 0.28.3 (#30451) 2019-04-03 11:56:41 -07:00
LongCatIsLooong
712195b559
update sample code analyzer regexp & test case (#30201)
updates the regex the analyzer uses, so it should be able to recognize expressions such as
const Foo a = Foo(); as "other code" rather than a constructor call.
2019-04-01 17:27:29 -07:00
xster
f2d671c15c
Cupertino localization step 3: in-place move some material tools around to make room for cupertino (#29644) 2019-03-29 15:57:09 -07:00
Jonah Williams
1bfa2f2311
Intercept errors thrown by synchronous Completers in image resolution. (#30139) 2019-03-29 10:05:18 -07:00
Jonah Williams
3c93b65a9b
Update to latest matcher (#30019) 2019-03-27 17:21:10 -07:00
Jonah Williams
0a2175f133
Pass FLUTTER_TOOL_ARGS to snapshot command. (#29938) 2019-03-27 15:24:08 -07:00
Jonah Williams
44b22c7b04
Fix cache location, artifacts, and re-enable dart2js test (#29783) 2019-03-25 18:47:37 -07:00
Jonah Williams
55a2ee588d
make build runner configurable (#29568) 2019-03-18 15:50:11 -07:00
Jonah Williams
72605d2406
Switch flutter_tools from script to app-jit snapshot. (#27749) 2019-03-15 19:33:24 -07:00
Jonah Williams
cd803ac7f2
Improve hot reload performance (#28152) 2019-03-15 15:02:45 -07:00
Dan Field
4906c7ea56 Update README.md (#29369) 2019-03-15 08:58:13 -07:00
Brian Wilkerson
439fbbe69e
Update SDK constraints to reflect the fact that set literals are being used (#29389) 2019-03-15 07:53:27 -07:00
Jonah Williams
7bed378e22
Only run codegen at start of flutter_test (#29171) 2019-03-14 17:12:40 -07:00
Dan Field
97a8120969
guard new formatter behind env var (#29340)
* guard new formatter behind env var
2019-03-14 08:26:59 -07:00
Dan Field
dcc965a38e
Revert "Speculative fix for #29262 (#29273)" (#29319)
This reverts commit 53d45258dc.
2019-03-13 12:58:10 -07:00
Dan Field
53d45258dc
Speculative fix for #29262 (#29273)
* Avoid writing to stderr before process has finished streaming
2019-03-13 12:27:05 -07:00
Shi-Hao Hong
1ddd15ff49
Update README.md 2019-03-12 18:15:23 -07:00
Dan Field
b9f013c044
Make sure test reporter prints out stderr, and disables Bigquery for non-contributors (#29073)
* print stderr to stderr, no bq if not contributor

* let test continue of bigquery fails
2019-03-10 11:26:17 -07:00
Dan Field
2a644f301e
Run non-perf sensitive tests on Cirrus (#27971)
* Run non-perf sensisitive tests on Cirrus
2019-03-10 07:52:44 -07:00
Dan Field
3af88c5550
add heartbeat (#29056) 2019-03-08 16:12:27 -08:00
Dan Field
4be4830c2f
update readme for LUCI (#29023)
* update readme for LUCI

* Update README.md
2019-03-08 09:25:13 -08:00
Jonah Williams
77142b8257
Revert "re-enable dart2js test (#29010)" (#29030)
This reverts commit 6a7f231d89.
2019-03-07 22:18:15 -08:00
Jonah Williams
6a7f231d89
re-enable dart2js test (#29010) 2019-03-07 21:56:02 -08:00
Dan Field
a3b484d0da
make coverage work again (#29016) 2019-03-07 18:59:43 -08:00
Dan Field
f67a529e6d
Fix coverage shard and print summary after test run (#28970)
* Fix coverage shard

* clarify

* Make sure we print test results

* Actually report test results before exiting

* revert unintended changes
2019-03-07 11:31:35 -08:00
Dan Field
e5b1ed7a7f
Fix for post submit on cirrus (#28963)
* Fix for post submit on cirrus
2019-03-06 14:23:37 -08:00
Dan Field
20e0f13cc9
Test reporter (#28297)
* Wrap test.main with a custom processor
* Report test results to bigquery table
2019-03-06 13:13:45 -08:00
Phil Quitslund
802eca29d2
set literal conversions (#27811) 2019-03-06 11:05:16 -08:00
Jonah Williams
d91cfffa50
switch tool tests to build runner (#28759) 2019-03-01 19:18:38 -08:00
Dan Field
c704d42897
Update README.md (#28734)
@xster
2019-03-01 14:43:57 -08:00
Greg Spencer
7ab3bc71f9
Be more strict about finding version number attached to a revision. (#28527)
When we package Flutter, we used to find the "current" tag (which is the version number) by starting at the revision we are building on and looking backwards in time to find the most recent tag. This causes problems on release builds when we failed to tag properly.

This PR makes the packaging script be more strict by requiring the given revision to itself have a tag, but only when we're publishing the result. When we're not publishing the result, it's more lenient, since otherwise we couldn't test packaging on non-release commits.

I also renamed ProcessRunnerException to PreparePackageException, since we were using that exception more generally than just for processes.
2019-03-01 14:38:40 -08:00
Alexandre Ardhuin
387f885481
Add missing trailing commas (#28673)
* add trailing commas on list/map/parameters

* add trailing commas on Invocation with nb of arg>1

* add commas for widget containing widgets

* add trailing commas if instantiation contains trailing comma

* revert bad change
2019-03-01 08:17:55 +01:00
Jonah Williams
ec93468a14
Add capability to run build_runner tests for engine (#28684) 2019-02-28 20:06:14 -08:00
Jonah Williams
6350d0b48f
disable dart2js test (#28555) 2019-02-27 12:37:39 -08:00
liyuqian
dd5559a5b8
Add LICENSE test to presubmit checks (#28369)
## Description

Also update the existing dart files with missing licenses.

Without the fix, we'll emit the following error message
```
License headers cannot be found at the beginning of the following files.

/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/lib/src/animation/tween_sequence.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/material/raw_material_button_test.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/async_lifecycle_test.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/sliver_constraints_test.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/app_test.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/test_border.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/physical_model_test.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/inherited_model.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/lib/src/base/user_messages.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/src/pubspec_schema.dart
/usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/ios/simulators_test.dart
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
```

## Related Issues

Fixes https://github.com/flutter/flutter/issues/28368

## Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.

- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] My PR includes tests for *all* changed/updated/fixed behaviors (See [Test Coverage]).
- [x] All existing and new tests are passing.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.
- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I am willing to follow-up on review comments in a timely manner.

## Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

- [ ] Yes, this is a breaking change (Please read [Handling breaking changes]).
- [x] No, this is *not* a breaking change.

<!-- Links -->
[issue database]: https://github.com/flutter/flutter/issues
[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter
[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
2019-02-26 17:38:21 -08:00
Greg Spencer
c940088985
Add SHA256 checksums to published metadata (#28472)
Adds SHA256 checksums to the released package database, in preparation for showing them on the download website. (I'll update the existing data by hand).

Fixes #28465
2019-02-26 12:02:01 -08:00
Jonah Williams
d2a76414f4
remove json_schema dep again (#28517) 2019-02-26 12:01:22 -08:00
Dan Field
0e984fb237
update packages (#28400) 2019-02-23 10:08:53 -08:00
Dan Field
b484a9129c
add2app test (#27712)
* add2app test
2019-02-23 09:56:27 -08:00
Stanislav Baranov
3837ec9e96
Reland #27754, now that bsdiff has moved to flutter/packages. (#28291) 2019-02-21 21:59:41 -08:00
Ray Rischpater, KF6GPE
d39a72516a
deploy to .dev firebase projects. (#28171)
* deploy to .dev firebase projects.

* Updated secrets for .dev web sites.

* Fixed missing docs.*.io references.
2019-02-21 21:21:43 -08:00