Commit Graph

136 Commits

Author SHA1 Message Date
Ian Hickson
0cbe597540
Align more closely with package:test (#77118) 2021-03-15 16:28:02 -07:00
Michael Goderbauer
807bb29888
enable prefer_function_declarations_over_variables lint (#77398) 2021-03-05 18:29:04 -08:00
Casey Hillers
b0afe3464e
Create BuildTestTask (#77307) 2021-03-04 18:49:03 -08:00
Casey Hillers
7ed797b053
Revert "[devicelab] Separate build and test from Flutter gallery tests (#76415)" (#77086)
This reverts commit 297c7b5cf2.
2021-03-02 12:17:18 -08:00
Casey Hillers
297c7b5cf2
[devicelab] Separate build and test from Flutter gallery tests (#76415) 2021-03-02 11:49:02 -08:00
Michael Goderbauer
fc99e7c0d7
Enable missing_whitespace_between_adjacent_strings (#77027) 2021-03-01 18:30:17 -08:00
godofredoc
f506aa93a3
Move a second batch of mac/ios tests to prod. (#76732)
Bug: https://github.com/flutter/flutter/issues/73392
2021-02-24 15:40:50 -08:00
Casey Hillers
5cac7c3b15
Add expectation test for upload metrics (#76642) 2021-02-23 16:11:03 -08:00
chunhtai
713fa8e360
Reland "add a benchmark test for stack size (#75039)" (#75434)
* Reland "add a benchmark test for stack size (#75039)"

This reverts commit de683de9d5.

* fix typo
2021-02-04 12:16:31 -08:00
Shi-Hao Hong
de683de9d5
Revert "add a benchmark test for stack size (#75039)" (#75383)
This reverts commit 9d9109aa6f.
2021-02-04 10:26:04 +08:00
chunhtai
9d9109aa6f
add a benchmark test for stack size (#75039) 2021-02-03 15:16:03 -08:00
Jenn Magder
f4f33fd108
Dump logs on failing devicelab test to recipe artifact location (#74378) 2021-02-01 15:00:38 -08:00
Casey Hillers
849784e262
[devicelab] Add results path flag to test runner (#72765) 2020-12-22 16:45:38 -08:00
keyonghan
bb0e6ce9b0
Unflaky remaining linux tasks (#72563)
* remove flaky flag

* remove from manifest

* fix test
2020-12-17 17:23:35 -08:00
Casey Hillers
2565062df3
git branch flag (#71886) 2020-12-08 15:53:05 -08:00
Jim Graham
61460d255a
preserve detailFiles entry in TaskResult JSON (#70668)
* preserve detailFiles entry in TaskResult JSON
2020-11-17 16:05:54 -08:00
Casey Hillers
a228a17c57
[devicelab] LUCI builder flag (#70702) 2020-11-17 11:28:03 -08:00
Casey Hillers
ce3ce20b14
[devicelab] Upload git branch (#68541) 2020-10-23 08:02:02 -07:00
Casey Hillers
1c35091a13
[devicelab] Cocoon client (#68333) 2020-10-19 13:12:04 -07:00
Casey Hillers
9e206a0c93
Refactor devicelab logic to use TaskResult instead of JSON (#67550) 2020-10-07 16:37:09 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. (#65568) 2020-09-16 14:14:06 -07:00
Tong Wu
aa0125387c
[devicelab] This no-op change marks 3 tests to run on LUCI builders. (#61257) 2020-07-10 21:49:40 -07:00
Ming Lyu (CareF)
99f5eebc6b
Add --device-id option for devicelab/bin/run.dart (#59276)
* Implement device selection for devicelab/run.dart

* Add test to --device-id option for devicelab/run

* Update dev/devicelab/bin/run.dart by jonahwilliam

* Rename deviceOperatingSystem enum mock -> fake

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-06-26 09:29:46 -04:00
Greg Spencer
ab68721a5d
Add Android device build/OS/API Level information to logs. (#58747)
This adds some information about the chosen device to the output log so that we can tell what type of device/OS Level/API Level the test is running on when doing a postmortem on a failed test.
2020-06-05 14:02:07 -07:00
Jim Graham
3519bec6c4
Save results of A/B test runs in a JSON file for future processing (#56416) 2020-05-08 00:34:02 -07:00
Yegor
20803507fd
print intermediate and raw A/B results when not silent (#54676)
* print intermediate A/B results when not silent
* print raw A/B results when in loud mode
* add tests; handle missing metrics more gracefully
* use less fancy section header on Windows
2020-04-16 14:36:42 -07:00
Jonah Williams
e21266294f
Revert "Do not wait for connections after process has exited (#54497)" (#54618)
This reverts commit 283ec9e2a1.
2020-04-13 11:04:31 -07:00
Yegor
283ec9e2a1
Do not wait for connections after process has exited (#54497) 2020-04-10 16:54:10 -07:00
Kate Lovett
bcc7961d00
Skip Audits (2) (#53837) 2020-04-08 12:37:03 -07:00
Alexandre Ardhuin
f5a9902577
enable avoid_equals_and_hash_code_on_mutable_classes (#52507) 2020-04-06 13:36:01 -07:00
Erik Ernst
d99ab6aa2c
Update utils.dart to work with the breaking change of SDK issue 40678 (#53093) 2020-03-24 14:21:01 -07:00
Alexandre Ardhuin
7d7ac7c32b
start multiline strings with newline (#50825) 2020-02-20 10:16:28 +01:00
Dan Field
8b2993337a
revert #48985 (#49572) 2020-01-27 14:36:02 -08:00
Anthony
b67d5ec6e9 [a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set (#48985) 2020-01-17 15:13:01 -08:00
Alexandre Ardhuin
003541499b use isA<Xxx>() matcher (#48482) 2020-01-16 12:43:03 -08:00
Alexandre Ardhuin
4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Alexandre Ardhuin
ec1a015045
implicit-casts:false in dev (#45787) 2019-12-05 22:34:06 +01:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Ian Hickson
1ce4a4f36f
Make sure all our .dart files have license headers (#44467) 2019-11-08 16:53:21 -08:00
Jonah Williams
d2f70a6d20
kill leaked chrome processes (#39514) 2019-08-29 14:28:37 -07:00
Alexandre Ardhuin
758009ba70
more ui-as-code (#35393)
* more ui-as-code

* address review comments
2019-07-02 21:11:56 +02:00
Alexandre Ardhuin
919dcf53f3
enable lints prefer_spread_collections and prefer_inlined_adds (#35189) 2019-06-27 21:23:16 +02:00
Ben Konyi
3764cb8515
Added support for authentication codes for the VM service. (#30857)
* Added support for authentication codes for the VM service.

Previously, a valid web socket connection would use the following URI:

`ws://127.0.0.1/ws`

Now, by default, the VM service requires a connection to be made with a
URI similar to the following:

`ws://127.0.0.1:8181/Ug_U0QVsqFs=/ws`

where `Ug_U0QVsqFs` is an authentication code generated and shared by
the
service.

This behavior can be disabled with the `--disable-service-auth-codes`
flag.
2019-04-18 21:01:50 -07:00
Dan Field
ecfdd7e1ea
Detect and cleanup leaky processes (#29196)
* Detect and cleanup leaky processes
* Add flaky tests for detecting leaked processes
2019-03-22 14:32:36 -07:00
Alexandre Ardhuin
387f885481
Add missing trailing commas (#28673)
* add trailing commas on list/map/parameters

* add trailing commas on Invocation with nb of arg>1

* add commas for widget containing widgets

* add trailing commas if instantiation contains trailing comma

* revert bad change
2019-03-01 08:17:55 +01:00
Jonah Williams
23a7535a39
Revert "Remove package:test dependency from flutter_test (#23755)" (#24004)
This reverts commit 71e9bd6f25.
2018-11-06 09:12:48 -08:00
Jonah Williams
71e9bd6f25
Remove package:test dependency from flutter_test (#23755) 2018-11-06 08:39:27 -08:00
Alexandre Ardhuin
d340e2f229
apply lint prefer_void_to_null in dev/ (#22661) 2018-10-04 18:44:23 +02:00
Alexandre Ardhuin
e2d0b062d9
remove unnecessary ignore prefer_const_constructors (#21934) 2018-09-18 05:54:03 +02:00
Alexandre Ardhuin
a07d3719a1
enable lint prefer_generic_function_type_aliases (#21680) 2018-09-14 21:06:19 +02:00
Alexandre Ardhuin
d927c93310
Unnecessary new (#20138)
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
2018-09-12 08:29:29 +02:00
Ian Hickson
686d8f8a22 Shim package:test to avoid matcher issues (#20602)
* Upgrade everything except matcher.
* Roll matcher (and test)
* Adjust tests that depend on flutter:test directly to depend on a shim
* Require use of package:test shim and remove other references to package:test
2018-08-14 20:33:58 -07:00
Ian Hickson
872e88cec7
Reduce noise on the memory benchmarks (#19630) (#20163)
- Check memory usage in release builds, not profile.
- Use multiple runs and average the results.
2018-08-06 12:46:51 -07:00
Ian Hickson
a2ca14d71e
Revert "Reduce noise on the memory benchmarks" (#20158)
* Revert "Add pub cache, artifacts, pkgs to Cirrus cache (#20080)"

This reverts commit 07e93b385c.

* Revert "Reduce noise on the memory benchmarks (#19630)"

This reverts commit 8eb5cb7dc0.
2018-08-02 13:56:44 -07:00
Ian Hickson
8eb5cb7dc0
Reduce noise on the memory benchmarks (#19630)
- Check memory usage in release builds, not profile.
- Use multiple runs and average the results.
2018-08-02 12:22:15 -07:00
Alexandre Ardhuin
eda03e2586
re-re-enable lint unnecessary_const (#20103) 2018-08-02 12:02:32 +02:00
Todd Volkert
00aac68e2d
Revert flutter/flutter#19592 (#19861)
It was causing problems rolling Flutter into Fuchsia
2018-07-27 08:44:39 -07:00
Alexandre Ardhuin
27018359d2
re-enable lint unnecessary_const (#19592)
* re-enable lint unnecessary_const

* remove trailling whitespaces

* remove unnecessary const (after merge)
2018-07-23 08:31:48 +02:00
Ian Hickson
f630f90d6d
Revert "enable lint unnecessary_const (#19342)" (#19423)
This reverts commit cc1cf13eec.
2018-07-16 13:30:27 -07:00
Alexandre Ardhuin
cc1cf13eec
enable lint unnecessary_const (#19342) 2018-07-16 21:43:48 +02:00
Danny Tuppeny
0329f0c179
Include stdout/stderr in failure messages for devicelab's tests (#18990)
* Include stdout/stderr in failure messages

Sometimes some of these tests unexpectedly fail with a non-zero exit code. This ensures stdout/stderr is included in the test failure message when this happens so that we can track down the issue.

* Remove redundant info about exit code

* Remove unnecessary indenting

The [markers] make it fairly clear so this just makes the test code noisy.
2018-07-03 07:37:34 +01:00
Chris Bracken
2ae48845a8
Revert elimination of Dart 1 (#18460)
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
from source, flutter_platform.dart automatically runs a kernel compile when
operating in Dart 2 mode, but this assumes a functional Dart SDK is available
in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
directory with an empty temp dir.

Remaining work is:
1. Get the frontend server building as a dependency on Fuchsia.
2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.

This also reverts migration to Dart 2 typedef syntax.

This reverts commit 6c56bb2. (#18362)
This reverts commit 3daebd0. (#18316)
2018-06-13 12:46:39 -07:00
Greg Spencer
6c56bb2420
Update typedef syntax to use Function notation and turn on lint for old notation. (#18362)
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.

Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.

No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
2018-06-11 15:51:45 -07:00
Ian Hickson
e3427550e9
Be less verbose in the logs. (#17401)
Now that we have thousands of tests, it doesn't make sense to display a separate line for each test. The result is just megabytes of logs that you have to scrub through to find error messages.
2018-06-04 15:22:19 -07:00
Greg Spencer
b921fdc58e
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041)
This reverts commit 3258602073.
2018-05-30 13:51:14 -07:00
Greg Spencer
3258602073
Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)
Fixes #18028

Just changes typedef declarations, no logic changes.
2018-05-30 12:13:58 -07:00
Alexandre Ardhuin
3c379aaf43
whitespace cleanup (#14458) 2018-02-05 22:20:21 +01:00
Alexandre Ardhuin
841d5d7bd5
prefer_const_declarations on local variables (#14358) 2018-02-01 07:51:26 +01:00
Alexandre Ardhuin
8a88e2efca Bump Dart SDK to 1.25.0-dev.9.0 (#11509)
* Bump Dart SDK to 1.25.0-dev.9.0

* add link to sdk bug
2017-08-09 14:45:55 +02:00
Ian Hickson
8f56f6fdd1 Add documentation and clean up code. (#11330)
Mainly, this adds documentation to members that were previously
lacking documentation.

It also adds a big block of documentation about improving performance
of widgets.

This also removes some references to package:collection and adds
global setEquals and listEquals methods in foundation that we can use.
(setEquals in particular should be much faster than the
package:collection equivalent, though both should be faster as they
avoid allocating new objects.) All remaining references now qualify
the import so we know what our remaining dependencies are.

Also lots of code reordering in Flutter driver to make the code
consistent and apply the style guide more thoroughly.
2017-07-21 16:39:04 -07:00
Yegor
148565eed5 check existence of task files (#10959) 2017-06-23 22:12:30 -07:00
Yegor
06deba25ee move more tests to Linux hosts (#10413)
* move more tests to Linux hosts

* fix test
2017-05-31 15:13:08 -07:00
Ian Hickson
3eb87830e9 Constants! Constants everywhere! (#9286)
Aggressively apply the const lint.
2017-04-07 12:24:32 -07:00
Yegor
1182eb18c5 add "flaky" and "timeout_in_minutes" devicelab task options (#9168) 2017-04-04 10:46:07 -07:00
Alexandre Ardhuin
a0769f2488 apply the upcoming rule unnecessary_this (#8838) 2017-03-17 08:05:42 +01:00
Michael Goderbauer
d87f19817f devicelab benchmarks run on Windows (#8814)
* devicelab benchmarks run on Windows

* fix analyzer issue

* fix test

* fix pubspec
2017-03-15 16:33:10 -07:00
Chris Bracken
6c97dd2c6c Declare locals as final where not reassigned (dev) (#8574) 2017-03-03 18:06:08 -08:00
Michael Goderbauer
7231fd3ed6 Enable flutter drive on Windows (#8146)
... and run some more tests on Windows.
2017-02-14 13:14:52 -08:00
Michael Goderbauer
723489de02 Make dev/bots/test.dart pass on Windows (#7998)
* disables all `flutter test` and `flutter drive` tests on Windows as those two commands are not fully implemented on Windows yet
* fixes other failures on Windows
2017-02-08 15:57:31 -08:00
Ian Hickson
aff4e82891 Technical Debt tracker (#7667) 2017-01-26 17:04:37 -08:00
Yegor
4145f5fcfd allow passing file path as reference to devicelab task (#6877) 2016-11-16 13:54:06 -08:00
Yegor
4f8da89dc4 Revert "reenable dev/devicelab/test/run_test.dart (#6364)" (#6378)
This reverts commit 8f273e49de.
2016-10-19 18:43:19 -04:00
Yegor
8f273e49de reenable dev/devicelab/test/run_test.dart (#6364)
I ran the test 10 times on Linux and Mac and it succeeded
consistently. Let's reenable until there are new reports that it's
flaky.

Fixes #5901
2016-10-17 19:31:58 -07:00
Yegor
6cdab85d28 Sync test code with Cocoon (#6129)
* fix flutter watch benchmark

Syncs d2d7950ecd

* Split Android/iOS impl behind a unified interface

Syncs db87e10fa5

* Switch from pub get to flutter packages get

Syncs b378005cbb

* "silent" option in test runner; fix analysis errors;
2016-09-29 10:19:15 -07:00
Ian Hickson
4f0eff31bc Fix crash when a RenderObject tree is rooted in a non-RenderObject environment (#5933) 2016-09-20 14:14:05 -07:00
Yegor
1ba1562293 move CI tests into the main repo (#5758) 2016-09-14 13:22:53 -07:00