Commit Graph

295 Commits

Author SHA1 Message Date
pq
d3b4186744 Review nits. 2016-06-14 15:32:42 -07:00
pq
d81212a387 Cleanup. 2016-06-14 15:21:42 -07:00
pq
f5a4e63237 Added asserts. 2016-06-14 15:19:14 -07:00
Hans Muller
3f7dd71057 Shrine Tweaks (#4558) 2016-06-14 12:15:41 -07:00
pq
7a95548746 Add missing returns.
As of `1.18.0-dev-0`, these cases will get flagged.  In the meantime, the
2016-06-14 12:13:56 -07:00
Hans Muller
ebaf9e29a0 Gallery shrine demo uses image assets (#4544) 2016-06-13 14:48:24 -07:00
Hans Muller
187ff00294 New gallery app bar background (#4539) 2016-06-13 12:41:29 -07:00
Adam Barth
1d5d7f4ad3 Reorganize the calculator demo (#4536)
This patch is a warmup to improving the visuals in the calculator demo.

Related to #4535
2016-06-13 11:44:46 -07:00
Adam Barth
1a3adae101 Use @required for onPressed and onChanged (#4534)
We now use the `@required` annotation to encourage developers to
explicitly set onPressed and onChanged callbacks to null when that would
disable the widget.

Fixes #287
2016-06-12 13:25:06 -07:00
Matt Perry
2315432d2f Pesto polish fixes. (#4514)
- Fix the background color and AppBar transparency on the Recipe page.
- Use a Hero animation for the recipe card.
- Draw the background image under the status bar on the recipe page.
- Added instructional text on favorites page when there are no favorites.

BUG=https://github.com/flutter/flutter/issues/4403
BUG=https://github.com/flutter/flutter/issues/4405
BUG=https://github.com/flutter/flutter/issues/4436
BUG=https://github.com/flutter/flutter/issues/4399
2016-06-10 16:33:50 -04:00
Ian Hickson
f75fd5c389 Header for PaginatedDataTable (#4468)
Also renames ButtonTheme.footer to ButtonTheme.bar.
2016-06-08 17:29:26 -07:00
Ian Hickson
1fe57277cf Improve interactivity of the Contacts demo (#4479)
We're explicitly saying that making these icons do anything useful is
out of scope, so the best we'll do here is show a snackbar.
2016-06-08 17:27:24 -07:00
Matt Perry
479c7da9f1 Add a 'Return to Gallery' drawer option to Pesto. (#4472)
* Add a 'Return to Gallery' drawer option to Pesto.

BUG=https://github.com/flutter/flutter/issues/4402

* oops
2016-06-08 17:04:40 -04:00
Matt Perry
3e0e6b9997 Smoothly scale the Pesto logo as the app bar resizes. (#4465)
Also update the assets version to pull in better quality logo images.

BUG=https://github.com/flutter/flutter/issues/4407
2016-06-08 15:49:21 -04:00
Adam Barth
6e530ea862 Make pesto demo scroll fast (#4443)
We can viewport the content using a ScrollableGrid. Also, we can use the
padding mechanisms of the grid to avoid extra padding widgets.
2016-06-07 19:52:03 -07:00
Ian Hickson
68f92d4f34 Provide UI to paginate PaginatedDataTable (#4382)
Also:
* Make PaginatedDataTable able to scroll itself horizontally.
* Make drop down buttons support having an explicit text style and icon
  size given.
* Fix a bug with drop-down buttons asserting when opened partly
  off-screen.
* Make sure to pop the drop-down button's route if the drop-down button
  is discarded while the route is up.
* Remove extraneous padding on drop-down buttons. (Couldn't figure out
  why it was there, and it breaks alignment when a drop-down is mixed
  with other text.)
* Some docs improvements.
* Add Route.isActive
* Add a setState() method to ModalRoutes.
2016-06-07 16:11:30 -07:00
Ian Hickson
5e6baf4a26 Correct grammar in shrine demo (#4381)
I was also going to implement sorting and emptying the cart but the
current data model doesn't make that easy, so I gave up on that. That's
why the TODOs are moved around though.
2016-06-07 16:05:39 -07:00
Todd Volkert
7ac0ce7938 Add API for specifying the system overlay style. (#4422)
Fixes 3544
2016-06-07 14:39:15 -07:00
Adam Barth
130f77177d Make Shrine scroll fast (#4408)
This fix isn't completely statisfying because it has a scaling limit. The ideal
fix would actually viewport the tiles in the grid. However, this fix is much
easier at the moment.

Fixes #4395
2016-06-06 20:23:40 -07:00
Ian Hickson
ed48c70aa0 Remove the redundant drop-down button demo (#4380)
Turns out we have the same demo in the "Buttons" section now.
We don't need both.
2016-06-04 09:31:32 -07:00
Hans Muller
df1c158e0b Updated calculator demo (#4363) 2016-06-03 14:10:50 -07:00
Matt Perry
60e7535b58 Pesto demo for the Flutter Gallery app. (#4328)
* Pesto demo for the Flutter Gallery app.

* pesto.special.case
2016-06-03 17:05:01 -04:00
Hans Muller
1d516f0e94 Update gallery demo list (again) (#4339) 2016-06-03 08:37:16 -07:00
Hans Muller
dd27a489fa Update gallery demo list (#4335) 2016-06-02 16:12:54 -07:00
Hans Muller
309b9f8010 Version 0.0 of a gallery demo of the Material Design "Shrine" app (#4327) 2016-06-02 14:23:20 -07:00
Adam Barth
0679da0a23 Remove fancy lines demo from Gallery (#4323)
This demo burns battery continuously even when there's no change to the visual
appearance. This patch removes this demo to avoid giving the impression that
Flutter burns battery.

Related to #4120
2016-06-02 09:54:03 -07:00
Ian Hickson
0618da7ca2 PaginatedDataTable (part 1) (#4306)
This introduces the key parts of a paginated data table, not including
the built-in pagination features.

* Provide more data for the data table demo, so there's data to page.

* Introduce a ChangeNotifier class which abstracts out
  addListener/removeListener/notifyListeners. We might be able to use
  this to simplify existing classes as well, though this patch doesn't
  do that.

* Introduce DataTableSource, a delegate for getting data for data
  tables. This will also be used by ScrollingDataTable in due course.

* Introduce PaginatedDataTable, a widget that wraps DataTable and only
  shows N rows at a time, fed by a DataTableSource.
2016-06-01 16:13:40 -07:00
Adam Barth
36d01c3541 "Swipe items to dismiss" demo needs full-bleed dividers (#4231)
Remove spurious padding.

Fixes #3980
Fixes #3560
2016-05-26 17:06:10 -07:00
Adam Barth
474ff67556 Polish sliders (#4176)
Address feedback from material design team.

Fixes #4144
Fixes #4145
Fixes #4146
2016-05-24 17:53:23 -07:00
Hans Muller
487234db02 TabPageSelector demo: use chevron icons instead of arrows (#4153) 2016-05-24 09:57:33 -07:00
Hans Muller
cf83a81329 Correct layout (#4115) 2016-05-23 14:24:10 -07:00
Devon Carew
65bed96103 move the calculator files around (#4112) 2016-05-23 12:55:09 -07:00
Hans Muller
5b8677d15d Allow tab bars in flexible app bars (#4086) 2016-05-20 18:07:15 -07:00
Hans Muller
1f06dc44cd ScrollConfiguration (#4026) 2016-05-20 16:59:09 -07:00
Adam Barth
8283d05eb5 Tabs and scrolling has odd card text (#4019)
Looks like our intent here was to show the tab label rather than
"Instance of '_Page'".

Also, fix an issue where the scrollableKey wasn't being forwarded to the
actual scrollable.

Fixes #3090
2016-05-19 14:13:43 -07:00
Matt Perry
0628c64b79 Use KeyboardType.phone for the Gallery app's text demo. (#3983)
BUG=https://github.com/flutter/flutter/issues/3970
2016-05-17 15:36:59 -04:00
Hans Muller
bec3fdefd1 Add a Scrollable builder, refactor ScrollableList, et al (#3950)
* Add a Scrollable builder, refactor ScrollableList, et al

* Add space between the dialog demo buttons

* removed vestigial code
2016-05-16 17:32:01 -07:00
Ian Hickson
3252701753 Make it possible to run tests live on a device (#3936)
This makes it possible to substitute 'flutter run' for 'flutter test'
and actually watch a test run on a device.

For any test that depends on flutter_test:

1. Remove any import of 'package:test/test.dart'.

2. Replace `testWidgets('...', (WidgetTester tester) {`
      with `testWidgets('...', (WidgetTester tester) async {`

3. Add an "await" in front of calls to any of the following:
    * tap()
    * tapAt()
    * fling()
    * flingFrom()
    * scroll()
    * scrollAt()
    * pump()
    * pumpWidget()

4. Replace any calls to `tester.flushMicrotasks()` with calls to
   `await tester.idle()`.

There's a guarding API that you can use, if you have particularly
complicated tests, to get better error messages. Search for
TestAsyncUtils.
2016-05-16 12:53:13 -07:00
Ian Hickson
c5ff156f24 Revert "Rename DefaultTextStyle constructor to explicit (#3920)" (#3930)
This reverts commit 55f9145ef4.

Turns out that this commit breaks apps that use the material library,
because of the _errorTextStyle DefaultTextStyle which has inherit:true.
Just setting it to false doesn't work, unfortunately, because then you
hit some sort of issue with merging that text style with others that
have inherit:true.
2016-05-16 11:08:07 -07:00
Adam Barth
55f9145ef4 Rename DefaultTextStyle constructor to explicit (#3920)
To make it clear that this constructor requires an explicit style. Also
throw a descriptive error recommending the inherit constructor for
styles with the inherit bit set.

Fixes #3842
2016-05-16 10:35:35 -07:00
Hans Muller
ac4ad3bc98 Flexible space bar demo needs to occupy more vertical space, etc (#3890) 2016-05-12 16:45:45 -07:00
Phil Quitslund
616d9e2ea8 Merge pull request #3880 from pq/void_setters
Turn on `avoid_return_types_on_setters` and cleanup annotated setters.
2016-05-12 12:28:15 -07:00
Hans Muller
5bacc9f8e8 GridTileBar uses ellipsis, etc (#3881) 2016-05-12 12:27:49 -07:00
pq
e54196d7fc Turn on avoid_return_types_on_setters and cleanup annotated setters.
It's safe to remove the unneeded `void`s from setters since the blocking issues in the
`always_declare_return_types` lint have been fixed (https://github.com/dart-lang/linter/).  We can also safely flip the bit on  `avoid_return_types_on_setters`.
2016-05-12 11:45:30 -07:00
Hans Muller
74c3e74fba Call it Flutter Gallery (#3801) 2016-05-09 11:00:54 -07:00