Alexandre Ardhuin
eda03e2586
re-re-enable lint unnecessary_const ( #20103 )
2018-08-02 12:02:32 +02:00
Todd Volkert
00aac68e2d
Revert flutter/flutter#19592 ( #19861 )
...
It was causing problems rolling Flutter into Fuchsia
2018-07-27 08:44:39 -07:00
Alexandre Ardhuin
27018359d2
re-enable lint unnecessary_const ( #19592 )
...
* re-enable lint unnecessary_const
* remove trailling whitespaces
* remove unnecessary const (after merge)
2018-07-23 08:31:48 +02:00
Ian Hickson
f630f90d6d
Revert "enable lint unnecessary_const ( #19342 )" ( #19423 )
...
This reverts commit cc1cf13eec
2018-07-16 13:30:27 -07:00
Alexandre Ardhuin
cc1cf13eec
enable lint unnecessary_const ( #19342 )
2018-07-16 21:43:48 +02:00
Mehmet Fidanboylu
226f2c1e99
Fix broken asset uris ( #18336 )
2018-06-09 20:11:08 -07:00
Will Larche
326caa5d22
[Gallery] Updated assets and copy ( #18324 )
2018-06-09 00:39:27 -07:00
Alexandre Ardhuin
09276bea25
enable lint prefer_equal_for_default_values ( #18156 )
2018-06-05 08:50:40 +02:00
Greg Spencer
3c5a7a3005
Make non-global constants have consistent naming (with just _ instead of _k) ( #17584 )
...
Our style guide says the k's are not necessary, and it seems like a good idea to make all the code be consistent on this.
Only naming changes to private vars: no logic changes.
2018-05-17 23:04:41 -07:00
Konstantin Scheglov
9fe53b0d2b
Export @required from src/widgets/framework.dart ( #17208 )
2018-05-03 08:50:40 -07:00
Ian Hickson
aba0379dcc
Clean up the existing Navigator API. ( #15718 )
...
This is not a grand refactor yet, it's just cleaning up what we have
already, so that people who keep using this API (e.g. dialogs) have
something coherent to deal with.
The major changes are that Navigator and NavigatorState have the same
API now, that most of the examples use `<void>` instead of `<Null>`,
that the navigator observer can see replaces, and that the `settings`
is moved from ModalRoute to Route. I also cleaned up some of the API
documentation.
2018-03-22 13:21:07 -07:00
Alexandre Ardhuin
cc1cf9e12a
apply upcomming lint avoid_renaming_method_parameters ( #15526 )
2018-03-20 12:53:41 +01:00
Alexandre Ardhuin
7667db6362
apply upcomming prefer_const_declarations ( #15498 )
2018-03-14 06:24:49 +01:00
Josh Soref
c5a5945e92
Spelling ( #15229 )
...
* spelling: accommodate
* spelling: allotted
* spelling: anonymous
* spelling: artificial
* spelling: associated
* spelling: asset
* spelling: button
* spelling: canvas
* spelling: compatibility
* spelling: coverage
* spelling: condition
* spelling: decoration
* spelling: deferring
* spelling: diameter
* spelling: direction
* spelling: displacement
* spelling: dropdown
* spelling: needing
* spelling: environment
* spelling: exited
* spelling: expansion
* spelling: explore
* spelling: families
* spelling: horizontal
* spelling: increment
* spelling: indices
* spelling: internationalization
* spelling: labrador
* spelling: localizations
* spelling: midflight
* spelling: milliseconds
* spelling: minimum
* spelling: multiple
* spelling: multiplication
* spelling: navigator
* spelling: overridden
* spelling: package
* spelling: performance
* spelling: platform
* spelling: porsche
* spelling: position
* spelling: preceded
* spelling: precede
* spelling: precedence
* spelling: print
* spelling: property
* spelling: readily
* spelling: reproducibility
* spelling: rounded
* spelling: scroll
* spelling: separate
* spelling: separator
* spelling: services
* spelling: specific
* spelling: specify
* spelling: synchronously
* spelling: through
* spelling: timeout
* spelling: triangle
* spelling: trivial
* spelling: unusual
* spelling: then
* spelling: vertically
* spelling: visible
* spelling: visited
* spelling: voice
2018-03-06 21:36:03 -08:00
Chris Bracken
6494dde364
Apply media padding in Gallery Shrine demo ( #14506 )
...
Applies horizontal and bottom safe area insets to the Shrine demo in the
Gallery. Top insets are not applied due to the presence of the
omnipresent sliver app bar. Specifically, this ensures that the grid
cards are inset inside the iPhone X notch in horizontal mode, and that
the bottom of the grid is positioned above the iOS home indicator.
2018-02-06 15:54:10 -08:00
Ian Hickson
e810bee6e5
Fix scrolling of multiple SliverLists and SliverGrids ( #14449 )
...
* Fix scrolling of multiple SliverLists and SliverGrids
* Update sliver_fixed_extent_list.dart
* Update sliver_grid.dart
2018-02-05 13:56:28 -08:00
Alexandre Ardhuin
c02b6a8bcf
some whitespace cleanup ( #14443 )
2018-02-02 23:27:29 +01:00
Alexandre Ardhuin
841d5d7bd5
prefer_const_declarations on local variables ( #14358 )
2018-02-01 07:51:26 +01:00
Alexandre Ardhuin
10f721c8a5
use const instead of final with const declarations ( #14253 )
2018-01-25 19:28:22 +01:00
Chris Bracken
8a77036b35
Center Shrine demo title with centerTitle ( #13586 )
...
Rather than use a Center widget, center the title using AppBar's
centerTitle property. This ensures the title is horizontally centred
with respect to the screen rather than centred in the space between the
leading and trailing app bar widgets, which are asymmetrical in Shrine.
2017-12-14 16:53:30 -08:00
Adam Barth
0044ea2dbb
Replace usage of FractionalOffset with Alignment ( #12348 )
...
Alignment will eventually replace FractionalOffset.
2017-10-02 00:06:24 -07:00
Sarah Zakarias
a0e91bf9e8
Update Flutter Gallery to use new asset api for package assets ( #12254 )
2017-09-26 15:21:01 +02:00
Michael Goderbauer
0e1b652d53
Make Demos in flutter_gallery more accessible ( #10832 )
...
Remaining known issues are #10831 and #10830 .
2017-06-20 11:09:57 -07:00
Alexandre Ardhuin
1eaefe1837
more const for immutables ( #10563 )
2017-06-08 22:04:18 +02:00
Alexandre Ardhuin
7d71326363
apply prefer_asserts_in_initializer_list lint ( #10540 )
2017-06-07 21:39:47 +02:00
stevemessick
cc91b159c0
Fix typo ( #10111 )
2017-05-16 10:19:21 -07:00
Jason Simmons
b586a97ad2
Enable physical model shadows (with animation) and change elevation to a double ( #9756 )
...
Fixes https://github.com/flutter/flutter/issues/9342
2017-05-03 12:11:01 -07:00
Ian Hickson
36052e68dd
BoxDecoration API changes: backgroundColor -> color et al ( #9648 )
...
backgroundColor -> color
backgroundImage -> image
BackgroundImage -> DecorationImage
2017-04-27 14:19:01 -07:00
Alexandre Ardhuin
31828609dc
add @required ( #9579 )
2017-04-25 08:59:43 +02:00
Alexandre Ardhuin
83fce211a3
More const immutable classes ( #9544 )
...
* more widget const constructors
* prefer const constructors
* address review comments
2017-04-23 22:37:29 +02:00
Alexandre Ardhuin
9541848272
make @immutable const classes ( #9532 )
...
* make @immutable const
* fix build
2017-04-21 23:09:42 +02:00
Alexandre Ardhuin
03c54abd5f
make some widgets const ( #9477 )
2017-04-20 08:59:05 +02:00
xster
89a7fdfc56
Rename State.config to widget everywhere ( #9273 )
...
Rename State.config to State.widget
Rename State.didUpdateConfig to State.didUpdateWidget
Renamed all State subclasses' local variables named config to something else
2017-04-10 18:32:24 -07:00
Ian Hickson
3eb87830e9
Constants! Constants everywhere! ( #9286 )
...
Aggressively apply the const lint.
2017-04-07 12:24:32 -07:00
Alexandre Ardhuin
2de61a0853
add @required when there's an assert not null ( #9124 )
...
* add @required when there's an assert not null
* address review comments
2017-03-31 18:34:13 +02:00
Hans Muller
9192f67252
Shrine gallery demo: support for landscape layout ( #9025 )
2017-03-27 15:07:24 -07:00
Adam Barth
269538df58
Add a constant for padding in a Material ListView ( #8918 )
...
Fixes #8235
2017-03-20 16:18:41 -07:00
Adam Barth
5cf04b6141
Rename ImageFit to BoxFit ( #8871 )
...
This machinery is useful for arbitrary boxes (e.g., with FittedBox).
Fixes #6463
2017-03-17 15:21:55 -07:00
Alexandre Ardhuin
2166ea5b7f
apply partially the upcoming unnecessary_lambdas ( #8810 )
2017-03-15 23:09:58 +01:00
Adam Barth
fd51093146
Rename SliverPadding.child to SliverPadding.sliver ( #8757 )
...
The new name follows the pattern of the name suggesting which layout
protocol the parent expects the child to speak.
Fixes #8664
2017-03-14 14:07:13 -07:00
Hans Muller
859da8d28b
Rename ListItem to ListTile, document ListTile fixed height geometry ( #8769 )
2017-03-14 11:46:30 -07:00
Chris Bracken
96eea437b2
Declare locals final where not reassigned (gallery) ( #8571 )
2017-03-03 17:51:21 -08:00
Alexandre Ardhuin
69b6bb87d1
prefer_is_empty and prefer_is_not_empty ( #8474 )
2017-03-01 22:17:30 -08:00
Ian Hickson
2f002885cc
Allow two shrine order pages to be on the screen at the same time. ( #8507 )
...
This happens when, for instance, you go back then forward quickly.
2017-03-01 22:07:37 -08:00
Alexandre Ardhuin
e9a775bf38
prefer const constructors ( #8316 )
2017-02-21 14:54:29 -08:00
Alexandre Ardhuin
da925c7d71
Replace @checked with covariant ( #8300 )
...
Fixes #7734
2017-02-21 09:30:22 -08:00
Adam Barth
e0b12ca17e
Two becomes one ( #8253 )
...
Rename all the "2" classes related to scrolling to remove the "2". Now that the
old scrolling code is gone, we don't need to use the suffix.
2017-02-17 14:06:15 -08:00
Adam Barth
547f89d0c0
Remove two clients of MaterialList ( #8076 )
...
Clients should use ListView instead.
2017-02-11 23:33:56 -08:00
Ian Hickson
83a4cf269f
Port AppBar to Scrollable2 ( #7996 )
...
Move the back button and drawer opening logic into the app bar.
Move the tap-status-bar-to-scroll-to-top logic to using
ScrollControllers. Provide a PrimaryScrollController and a `primary`
flag on scroll views.
Make it possible to track when a route becomes or stops being poppable.
2017-02-08 18:16:19 -08:00
Adam Barth
0bcecef5de
Convert ShrineHome to use CustomScrollView ( #7887 )
...
This patch converts the Shrine home page to using a sliver-based grid.
This required using a CustomScrollView to mix the block at the top with
the grid below.
2017-02-04 16:43:02 -08:00
