Commit Graph

1367 Commits

Author SHA1 Message Date
gaaclarke
f35de0c803
Adds wide gamut saveLayer integration test (#120131)
* Added wide gamut integration test that uses save layers.

* updated the test to support bgra too

* analysis errors

* switched blend mode to multiply to avoid future optimizations
2023-02-15 18:18:14 +00:00
Loïc Sharma
ed5bd17794
Fix tree by updating dependencies (#120707)
Fixes this PR: https://github.com/flutter/flutter/pull/120628
Reverting was rejected due to merge conflicts(?): https://github.com/flutter/flutter/pull/120705
2023-02-14 10:10:53 -08:00
Flutter GitHub Bot
b9b4d3e43e
roll packages (#120628) 2023-02-14 17:33:48 +00:00
gaaclarke
ddebe833b0
Added integration test for wide gamut support. (#119657)
* Added integration test for wide gamut support.

* cleaned up

* deleted files that can be generated

* switched back to standard flutter in the shell script

* added devicelab task

* removed analysis options

* analyzer

* Fixed task

* made local_run.sh not executable

* analyzer

* removed the logo asset

* added task to ci

* updated pubspec

* analysis errors fixed

* updated pubspec
2023-02-13 22:33:19 +00:00
Tomasz Gucio
98576cef58
Avoid null terminating characters in strings from Utf8FromUtf16() (#109729)
---------
Co-authored-by: schectman <schectman@google.com>
2023-02-13 19:22:37 +01:00
Flutter GitHub Bot
d63c54c9c2
roll packages (#120493) 2023-02-10 23:11:53 +00:00
Christopher Fujino
1089588863
un-pin package:intl (#119900) 2023-02-07 12:10:18 -08:00
Flutter GitHub Bot
cfdc35859e
roll packages (#119865) 2023-02-02 23:59:49 +00:00
Christopher Fujino
d820aec786
Manual pub roll with dwds fix (#119575)
* roll packages

* fix dwds

* empty

---------

Co-authored-by: fluttergithubbot <fluttergithubbot@gmail.com>
2023-02-02 21:38:08 +00:00
Michael Goderbauer
b0f1714b7b
Make Flex,Row,Column const for real (#119673)
* Make Flex,Row,Column const for real

* dart fix --apply

* fix snippets

* fix integration test

* add comment
2023-02-02 19:33:57 +00:00
Michael Goderbauer
6a5405925d
Make MultiChildRenderObjectWidget const (#119195) 2023-01-31 11:13:59 -08:00
Chris Bracken
d272a3ab80
Reland: [macos] add flavor options to tool commands (#119564)
* Reland: [macos] add flavor options to tool commands

Adds --flavor option to flutter run and flutter build. Running against
preexisting devicelab flavor tests for feature parity between macOS,
iOS, and Android.

This relands #118421 by alex-wallen which was reverted in #118858 due to
the following test failures:

The bail-out with "Host and target are the same. Nothing to install."
added in `packages/flutter_tools/lib/src/commands/install.dart`
triggered failures in the following tests, which unconditionally attempt
to install the built app, which is unsupported on desktop since the
host and target are the same:

* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout

Fixes #64088

* Partial revert: eliminate install check on desktop

The original flavour support patch included a check that triggered a
failure when flutter install is run on desktop OSes. This was
intentional, since the host and target devices are the same and
installation is unnecessary to launch the app on currently-supported
desktop OSes.

Note that Windows UWP apps *do* require installation to run, and we used
to have an install command for those apps, though UWP is no longer
supported.

Since that part of the change was orthogonal to flavour support itself,
I'm reverting that component of the change and we can deal with it
separately if so desired.
2023-01-31 17:37:46 +00:00
Michael Goderbauer
5b6572f96d
Add debug diagnostics to channels integration test (#119579) 2023-01-31 02:55:01 +00:00
Camille Simon
59d80dc876
[Android] Add explicit exported tag to Linux_android flavors test (#117542)
* Add exported tag

* Undo testing changes
2023-01-30 18:47:51 +00:00
Flutter GitHub Bot
b68cebd9ce
roll packages (#119530) 2023-01-30 18:46:35 +00:00
Flutter GitHub Bot
df8ad3d2cb
roll packages (#119370) 2023-01-30 17:34:10 +00:00
Danny Tuppeny
0b57596712
Run "flutter update-packages --force-upgrade" (#119340) 2023-01-27 17:20:18 +00:00
Todd Volkert
b319938ecd
Add more flexible image API (#118966)
This updates the framework to provide higher level wrappers around ui.instantiateImageCodecWithSize(). Functionally, this doesn't change anything (other than deprecating the older loadBuffer() method in favor of loadImage()), but it sets the stage for a simpler change that will allow us to provide a more flexible way to load sized images.

#118543
2023-01-25 21:21:28 -08:00
Flutter GitHub Bot
9037e3fe26
roll packages (#119192) 2023-01-25 23:53:42 +00:00
yaakovschectman
455e6aca50
Test integration test apps' runner files against current template app (#118646)
* Create template file test

* Add to .ci.yaml

* Add to TESTOWNERS

* Organize test script

* Push license to top of file

* Equals sign

* Utilize path.join

* Expand error message

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Fix missing newline string

* Move template file test to analyze.dart

* Fix newline

* Var name

* Fix extension length

* Use ignore-list for filenames

* Update dev/bots/analyze.dart

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Indentation

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-01-24 17:00:22 -05:00
Christopher Fujino
64b4c69bcc
roll pub deps and remove archive, crypto, typed_data from allow-list (#119018)
* roll pub deps and remove archive, crypto, typed_data from allow-list

* un-comment code
2023-01-24 01:55:06 +00:00
yaakovschectman
5e50ed972b
Test Utf8FromUtf16 (#118647) 2023-01-23 16:07:55 -05:00
Michael Goderbauer
70cecf6c9e
Remove unnecessary null checks in dev/*_tests (#118844) 2023-01-21 01:36:12 +00:00
Jenn Magder
030288d33b
Revert "[macos] add flavor options to commands in the flutter_tool (#118421)" (#118858)
This reverts commit 73096fd96e.
2023-01-20 03:46:45 +00:00
Alex Wallen
73096fd96e
[macos] add flavor options to commands in the flutter_tool (#118421)
* Add new macos target configured for flavors

* Rename Free App copy-Info.plist to Free App Info.plist

* Remove bogus entitlements

* Remove Generated.xcconfig

* Audit project.pbxproj

* Remove unused configs

* share one info.plist

* Modify scheme so that paid app works

* Codesign automatic

* Pipe flavor as scheme into xcodebuild

* Ignore incoming flavor string

* pipe flavor for flutter run to work

* Add devicelab tests

* Error if host and target device are same for flutter install desktop

* Avoid bang (!) by promoting a local.

Co-authored-by: Jenn Magder <magder@google.com>

* Add supportsInstall property

* Override  in test classes

* Add install test on macOS

* Refactor application_package and add tests for package directory

Co-authored-by: a-wallen <stephenwallen@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
2023-01-19 23:52:16 +00:00
Danny Tuppeny
06909ccfa4
Update packages + fix tests for javascript mime change (#118617)
Update test expectations from application/javascript -> text/javascript

`package:mime` now uses `text/javascript` and not `application/javascript`.

See https://github.com/dart-lang/mime/pull/76.
See https://datatracker.ietf.org/doc/html/rfc9239.

> This document defines equivalent processing requirements for the various script media types. The most widely supported media type in use is `text/javascript`; all others are considered historical and obsolete aliases of `text/javascript`.
2023-01-19 09:54:40 -05:00
Alex Wallen
3348987546
Add new macos target configured for flavors (#117352)
Co-authored-by: Jenn Magder <magder@google.com>
Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-18 07:50:25 -08:00
Victoria Ashworth
b4d72752bd
Add Info.plist from build directory as input path to Thin Binary build phase (#118209)
* Add Info.plist from build directory as input path to Thin Binary build phase

* fix directive ordering

* migrate benchmark, integration, and example tests
2023-01-13 13:41:08 -06:00
Loïc Sharma
cea55d99d0
[Linux] Add a 'flutter run' console output test (#118279)
* Add Linux support for the UI integration test project

* Add Linux run console test
2023-01-13 19:17:12 +00:00
Andrew Kolos
5630d531b1
[tool] Generate a binary version of the asset manifest (#117233)
* initial

* update asset_bundle_package_test

* Update asset_bundle_test.dart

* Update asset_bundle_package_fonts_test.dart

* update pubspec checksum for smc dependency

* flutter update-packages --force-upgrade

* prefer += 1 over ++

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* add regexp comment

* rescope int list comparison function

* update packages

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2023-01-12 19:33:30 +00:00
Flutter GitHub Bot
01583b7486
roll packages (#118272) 2023-01-10 23:03:04 +00:00
Jonah Williams
1d2e62b764
remove unsound mode web test (#118256) 2023-01-10 19:03:27 +00:00
Camille Simon
873cf51763
[Android] Increase timeout duration for spell check integration test (#117989)
* Add timeout

* Add library directive

* Add comment, remove testing only changes
2023-01-05 01:46:35 +00:00
Flutter GitHub Bot
341ae18f6e
roll packages (#118001) 2023-01-04 22:49:16 +00:00
Michael Goderbauer
fdc25a1700
Reland "Remove single-view assumption from ScrollPhysics (#117503)" (#117916)
This reverts commit c956121ac0.
2023-01-03 21:34:08 +00:00
Xilai Zhang
c956121ac0
Revert "Remove single-view assumption from ScrollPhysics (#117503)" (#117647)
This reverts commit 999356b776.
2022-12-27 21:22:16 +00:00
Xilai Zhang
4b4783d1f0
[flutter roll] Revert both #117338 and #117547 (#117557)
* Revert "Exposed tooltip longPress action when available (#117338)"

This reverts commit 38e3930f39.

* Revert "fixes android_semantics_integration_test to expect long press for tootip"
2022-12-23 22:46:45 +00:00
Michael Goderbauer
999356b776
Remove single-view assumption from ScrollPhysics (#117503)
* Remove single-view assumption from ScrollPhysics

* fix scrollable_dispose_test.dart

* add deprecated method back
2022-12-22 21:54:09 +00:00
Kenzie Davisson
725c1415df
Fix screenshot testing for flutter web integration_test (#117114)
* Fix screenshot testing for flutter web integration_test

* update packages

* fix method signature and todo

* Run tests on CI

* fix type

* remove silences

* Add docs

* fix comment

* fix whitespace

* review comments
2022-12-22 21:34:04 +00:00
chunhtai
bd482ebc54
fixes android_semantics_integration_test to expect long press for tooltip (#117547) 2022-12-22 21:32:03 +00:00
Camille Simon
9fb1ae839e
[iOS] Add task for spell check integration test (#116222)
* Add fix and test

* Add test owner

* Print error for testing

* Make sure locale is the problem

* Test capitalization fix

* Take out Android specific test

* Verify eng fix

* Test fix

* Empty-Commit

* Test all tests

* Up string size for testing

* Remove test

* Undo ci.yaml testing changes

* Test android variant:

* Change to testwidgets

* Add widget tester

* Remove android only attempt

* Revert ci.yaml changes
2022-12-22 02:47:11 +00:00
alanwutang11
1970bc919b
cacheWidth cacheHeight support for canvaskit on web (#117423)
* cacheWidth cacheHeight support for web canvaskit

* comments

* clarifying comment for loadTestImageProvider class

Co-authored-by: alanwutang11 <alpwu@google.com>
2022-12-21 21:06:06 +00:00
Michael Thomsen
400b05ac0c
Manual package roll (#117439) 2022-12-21 18:30:50 +00:00
Michael Goderbauer
fdd2d7d64a
Sync analysis_options.yaml & cleanups (#117327) 2022-12-20 14:15:39 -08:00
Michael Goderbauer
81bc54be75
Enable use_colored_box lint (#117370) 2022-12-20 14:09:55 -08:00
Flutter GitHub Bot
4591f057fb
roll packages (#117357) 2022-12-20 22:04:23 +00:00
Zachary Anderson
c64dcbefa6
Revert "Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372)" (#117396)
This reverts commit 61fb6ea2d5.
2022-12-20 09:04:05 -08:00
Siva
61fb6ea2d5
Manual roll Flutter Engine from 339791f190fa to 7ee3bf518036 (1 revision) #117367 (#117372) 2022-12-20 08:31:22 -08:00
Michael Goderbauer
1adc27503f
Bump min SDK to 2.19.0-0 (#117345)
* Bump min SDK to 2.19.0-0

* fix
2022-12-20 00:46:14 +00:00
alanwutang11
c0dddacb81
Fix is canvas kit bool (#116944)
* isCanvasKit implement and test

* isCanvasKit implement and test

* ++

* forgot license

* make isCanvasKit a getter

* addressed comments

* forgot to change names of integration test files

* typo

* simplified tests

* comments
2022-12-17 23:33:32 -08:00
Christopher Fujino
c7cb5f3f5b
[flutter_tools] pin package intl and roll pub packages (#117168)
* pin package intl and roll pub packages

* add test

* fix analysis
2022-12-16 00:34:51 +00:00
Alexander Markov
c63d797f94
Upgrade dependencies (#117007) 2022-12-14 13:13:05 -08:00
Daniel Flores Medina
ba917d6159
Remove workaround because issue is closed (#110854) 2022-12-14 00:25:07 +00:00
Christopher Fujino
7a743c8816
[flutter_tools] Pin and roll pub (#116745)
* pin path_provider_android

* make path_provider_android non-transitive

* roll
2022-12-12 21:02:07 +00:00
Siva
7c8e171320
Manual Roll of Flutter Engine from 67254d6e4b03 to 8d83b98c55b3 (#116635)
* Roll Flutter Engine from 67254d6e4b03 to 8d83b98c55b3

* Roll Dart SDK from 35a9facce191 to e517487c5679 (Dart 3.0) (#38105)

* Bump SDK versions.

* Bump Dart SDK version constraints

* Update shrine package to 2.0.1 (null safe version)

* Fix more tests.

* Include patches from Jason for min android sdk version

* Fix analyzer warning
2022-12-08 18:03:51 -08:00
Loïc Sharma
bebea0cc6c
[Windows] Add a flutter run console output test (#116626)
Adds a test to verify the console output of `flutter run --release` on Windows.

Part of: https://github.com/flutter/flutter/issues/111577
2022-12-08 14:05:53 -08:00
Alexander Thomas
3f1fb1b960
Update assets_for_android_views git dependency pins (#116639)
* Unpin assets_for_android_views git dependency

It needs to pick-up changes made to the pubspec.yaml to be Dart 3.0 compatible and dev/integration_tests/android_views/pubspec.yaml already uses the same dependency unpinned.

* Also unpin hybrid_android_views

* Pin android_views to the new flutter/goldens ref

* Pin hybrid_android_views to newer flutter/goldens
2022-12-07 12:33:59 -08:00
Casey Hillers
7673108d7e
Revert "Speed up first asset load by encoding asset manifest in binary rather than JSON (#113637)" (#116662)
This reverts commit 56cad89b1e.
2022-12-07 17:29:05 +00:00
Gary Qian
06e7c7a618
Incrementally update gradle to AGP 7.2.0 and 7.3.3 in some integration_tests (#116201) 2022-12-05 12:27:29 -08:00
Andrew Kolos
56cad89b1e
Speed up first asset load by encoding asset manifest in binary rather than JSON (#113637) 2022-12-05 10:39:10 -08:00
Zachary Anderson
7c0f882a92
Revert "[flutter_tools] Pin path_provider_android and roll pub packages (#116377)" (#116424)
This reverts commit ce94230281.
2022-12-02 08:30:14 -08:00
Christopher Fujino
ce94230281
[flutter_tools] Pin path_provider_android and roll pub packages (#116377)
* pin path_provider_android

* remove constraint that only explicit dependencies can be pinned

* roll packages
2022-12-02 03:13:07 +00:00
Gary Qian
6e8ebb3771
Reland "Upgrade targetSdkVersion and compileSdkVersion to 33" (#116146) 2022-12-01 07:12:47 -08:00
Christopher Fujino
dfdec8984f
[flutter_tools] Remove package:image (#115848)
* remove ciyaml targets

* remove screenshot_test and package:image

* update-packages

* remove TESTOWNERS entries
2022-11-22 21:49:57 +00:00
Flutter GitHub Bot
14754a261f
roll packages (#115764) 2022-11-22 21:49:53 +00:00
Camille Simon
7045a8b570
Add Spell Check to Editable Text (iOS) (#110193)
* Add ios to integration test and comments

* Add licenses

* Fix integration test for ios

* Delete pngs

* Undo changes to integration test

* Undo error

* Add ios task

* Fix task for landing
2022-11-21 19:11:48 +00:00
Christopher Fujino
0fc4a3efa8
Revert "Remove package:image dependency (#115674)" (#115680)
This reverts commit cf2c9f6ed4.
2022-11-18 18:22:23 -08:00
Christopher Fujino
cf2c9f6ed4
Remove package:image dependency (#115674)
* delete screenshot_test.dart

* remove image dep

* pub get
2022-11-18 23:50:23 +00:00
Christopher Fujino
459391708e
[flutter_tools] Pin package:archive and manual roll (#115662)
* add package:archive to pins

* roll
2022-11-18 19:28:10 +00:00
Devon Carew
0344407614
Rev package:pub_semver to the latest version (#115570)
* rev package:pub_semver to the latest version

* revert update_packages.dart changes
2022-11-17 18:29:37 +00:00
Chris Bracken
3c9288c6d3
Increase minimum supported macOS version from 10.13 to 10.14 (#114713)
Increases the minimum macOS deployment target from macOS 10.13 (High Sierra) to 10.14 (Mojave) in the macOS app templates.

Includes:
* Update migration for macOS 10.11 apps to upgrade to 10.14
* Adds migration for macOS 10.13 apps to upgrade to 10.14
* Apply migration to all examples, and integration tests

This does not increase version in the plugin templates since those will need to wait until the 10.14 framework rolls to stable channel, so new plugins can build with apps created with `flutter create` on stable channel.

Issue: https://github.com/flutter/flutter/issues/114445
See RFC: http://flutter.dev/go/flutter-drop-macOS-10.13-2022-q4
See previous patch: https://github.com/flutter/flutter/pull/107689
2022-11-07 11:32:42 +01:00
Flutter GitHub Bot
91a56cf15f
roll packages (#114366) 2022-11-04 22:27:56 +00:00
Greg Spencer
37b72342b0
Add maybeOf for all the cases where of returns nullable. (#114120) 2022-10-31 23:09:09 +00:00
Flutter GitHub Bot
ef1236e038
Roll pub packages (#114189) 2022-10-28 19:15:08 +00:00
Flutter GitHub Bot
f60b44dae5
Roll pub packages (#113838) 2022-10-27 22:07:37 +00:00
Victoria Ashworth
8aad1190b7
Check for watch companion in build settings (#114078) 2022-10-27 22:05:05 +00:00
Jenn Magder
9f5c6553bc
Revert "Check for watch companion in build settings (#113956)" (#114035)
This reverts commit e13372188f.
2022-10-25 13:33:35 -07:00
Victoria Ashworth
e13372188f
Check for watch companion in build settings (#113956) 2022-10-25 20:08:19 +00:00
Camille Simon
694b25355d
[Android] Fix spell check integration test guarded function conflict (#113541) 2022-10-24 22:54:18 +00:00
Flutter GitHub Bot
1ebe53c209
Roll pub packages (#113799) 2022-10-21 16:38:18 +00:00
David Iglesias
883469229e
[web] Use TrustedTypes in flutter.js and other tools (#112969) 2022-10-21 16:03:51 +00:00
Flutter GitHub Bot
37af038303
Roll pub packages (#113574) 2022-10-20 21:39:12 +00:00
Jenn Magder
49405135d7
Update macOS gallery display name (#113658) 2022-10-20 03:23:12 +00:00
Flutter GitHub Bot
d20129b64a
Roll pub packages (#113331) 2022-10-17 22:03:08 +00:00
Camille Simon
abca8976e6
[Android] Bump Kotlin and Android Gradle plugin versions in tests (#112728) 2022-10-07 12:30:27 +00:00
Flutter GitHub Bot
a454c6d03b
Roll pub packages (#112986) 2022-10-06 21:18:08 +00:00
Camille Simon
b94b584298
[Android] Fix spell_check integration test flakiness (#112109) 2022-10-04 19:05:39 +00:00
Flutter GitHub Bot
2ae6f536af
Roll pub packages (#112668) 2022-09-29 22:09:25 +00:00
joshualitt
c66049fcef
Reland "Migrate package/flutter to JS static interop. (#111315)" (#112418) 2022-09-29 08:36:51 -07:00
Andrew Kolos
cb5b5c3459
Tighten asset variant detection criteria to only include device-pixel-ratio variants (#110721) 2022-09-27 20:57:33 +00:00
Flutter GitHub Bot
2adee31ce8
Roll pub packages (#112408) 2022-09-26 21:21:58 +00:00
Alex Wallen
b22388ee68
Add a flutter app that can resize itself as integration test app. (#112297) 2022-09-26 17:45:19 +00:00
Casey Hillers
4aa27d844e
Revert "Migrate package/flutter to JS static interop. (#111315)" (#112247) 2022-09-23 04:00:22 +00:00
Flutter GitHub Bot
a24b50ba8f
Roll pub packages (#112225) 2022-09-22 21:18:22 +00:00
Flutter GitHub Bot
f16fe11ecf
Roll pub packages (#112021) 2022-09-22 20:23:42 +00:00
gaaclarke
5a7b0bdf13
macos isolate platform channels (#110882) 2022-09-21 09:30:06 -07:00
Flutter GitHub Bot
d5946021e5
Roll pub packages (#112004) 2022-09-20 22:07:57 +00:00
joshualitt
6906493a94
Migrate package/flutter to JS static interop. (#111315) 2022-09-19 10:28:37 -07:00
gaaclarke
a7166e7a4e
Reland isolate platform channels with conditional compilation (#111712) 2022-09-19 16:52:33 +00:00
gaaclarke
12506ed978
Revert isolate platform channels because of google integration tooling (#111702)
* Revert "turned on background isolate platform channel tests for android (#111279)"

This reverts commit 71b47975a9.

* Revert "Reland: Started handling messages from background isolates. (#111320)"

This reverts commit 1ad2757042.
2022-09-15 16:46:08 -07:00