Chris Bracken
d0670f0591
[macOS,iOS] CocoaPods recommended version: 1.13.0 ( #135447 )
...
Due to changes in Xcode 15, several variables such as `DT_TOOLCHAIN_DIR`
have been eliminateed in favour of others such as `TOOLCHAIN_DIR`. This
broke CocoaPods support under Xcode 15, as reported in:
https://github.com/CocoaPods/CocoaPods/issues/12012
@vashworth worked around this in Flutter in:
https://github.com/flutter/flutter/pull/132803
The CocoaPods issue was resolved by the following PR to their repo:
https://github.com/CocoaPods/CocoaPods/pull/12009
and was released in CocoaPods 1.13.0.
Also switches from an if-else chain to a switch for CocoaPodsStatus
handling.
Related: https://github.com/flutter/flutter/issues/133584
Related: https://github.com/flutter/flutter/issues/132755
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
2023-12-15 11:16:52 -08:00
stuartmorgan
d628a6ff97
Give an actionable error message when a Pod requires a higher minimum OS version ( #138097 )
...
Checks `pod install` output for the case where a pod requires a higher minimum OS deployment target version than the app is set to use, and attempts to turn it into a more actionable error message. This isn't foolproof since we are parsing the Ruby rather than actually executing it, but I would expect that the vast majority of cases would end up in the most useful version (and even those that don't are still much clearer with this as the final error message text than without it).
Fixes https://github.com/flutter/flutter/issues/113762
2023-11-27 16:22:54 +00:00
Elias Yishak
48187028c1
Add commandHasTerminal parameter + apple usage event + sendException events for package:unified_analytics ( #138806 )
...
Relates to tracker issue:
- https://github.com/flutter/flutter/issues/128251
This PR includes 3 major updates:
- Adding the `commandHasTerminal` parameter for `Event.flutterCommandResult`
- In `packages/flutter_tools/lib/src/runner/flutter_command.dart`
- Adding the new event for `sendException` from package:usage to be `Event.exception` (this event can be used by all dash tools)
- In `packages/flutter_tools/lib/runner.dart`
- Migrating the generic `UsageEvent` which was only used for Apple related workflows for iOS and macOS. I did an initial analysis in this [sheet](https://docs.google.com/spreadsheets/d/11KJLkHXFpECMX7tw-trNkYSr5MHDG15XNGv6TgLjfQs/edit?resourcekey=0-j4qdvsOEEg3wQW79YlY1-g#gid=0 ) to identify all the call sites
- Found in several files, highlighted in the sheet above
2023-11-22 12:25:10 +00:00
Jenn Magder
d4934fb6ab
Add readlink -f flag to CocoaPods script to workaround Xcode 14.3 issue ( #124062 )
2023-04-03 16:55:00 -07:00
Todd Volkert
c4ef072369
Cocoapods ffi error can be in stdout or stderr ( #121470 )
...
Cocoapods ffi error can be in stdout or stderr
2023-02-28 00:11:29 +00:00
Ian Hickson
6205c110d6
Remove "note that" in our documentation (as per style guide) ( #120842 )
...
* lerp documentation
* Remove Note, Note That from repo
* Improve BorderSide documentation.
* apply review comments
2023-02-17 22:27:33 +00:00
Jonah Williams
db829c1e20
[flutter_tools] migrate more unit tests to null safety ( #106153 )
2022-06-17 21:34:27 -07:00
Michael Goderbauer
3fa355c97d
Remove dead code in tools tests ( #104567 )
2022-05-25 12:48:17 -07:00
Jenn Magder
bf7a32628e
Up CocoaPods minumum to 1.10 ( #103655 )
2022-05-16 17:42:19 -07:00
Jenn Magder
2e1c146eec
Update ffi gem installation instructions ( #103008 )
2022-05-04 13:24:08 -07:00
Jenn Magder
c9825d24dd
Handle CocoaPods ffi stderr ( #102327 )
2022-04-21 15:49:08 -07:00
Jenn Magder
fe11f57c61
Detect ARM ffi CocoaPods bus error ( #101796 )
2022-04-14 14:34:10 -07:00
Jenn Magder
320d2cff64
Increase recommended CocoaPods version to 1.11 ( #98621 )
2022-02-24 12:11:21 -08:00
Jenn Magder
f7bd20fc09
Detect additional ARM ffi CocoaPods error ( #94385 )
2021-12-07 15:29:03 -08:00
Greg Spencer
52ae102f18
Adds tool warning log level and command line options to fail on warning/error output ( #92031 )
2021-11-10 16:13:04 -08:00
Jenn Magder
aff69e43ef
Add integration_test to flavor test project ( #92520 )
2021-10-27 12:53:05 -07:00
Hattomo (TomohiroHattori)
08a70e7ac8
Enable avoid_escaping_inner_quotes lint ( #81153 )
2021-05-19 09:54:02 -07:00
Jenn Magder
db3f49b1b4
Use cached Xcode build settings during iOS build ( #80904 )
2021-04-27 17:20:11 -07:00
Jenn Magder
56c0002c47
Adopt FakeProcessManager.empty ( #80480 )
2021-04-15 14:19:02 -07:00
Jenn Magder
d40cc5af8f
Migrate flutter_tool plugins.dart to null safety ( #80304 )
2021-04-13 13:52:58 -07:00
Jenn Magder
ba764ebc38
Update Podfile.lock modified timestamp when pod install is run ( #78823 )
2021-04-06 15:54:02 -07:00
Jenn Magder
8ddc27e607
Split globals.dart into null sound and unsound libraries ( #79016 )
2021-03-31 16:55:20 -07:00
Jenn Magder
5a6d2a0a8e
Check for outdated Podfile before running pod install ( #79343 )
2021-03-30 12:42:39 -07:00
Jenn Magder
0cf1007276
Remove mocks from cocoapods_test ( #78279 )
2021-03-16 13:53:04 -07:00
Sam Rawlins
ba58ad0385
Remove "unnecessary" imports in test/general.shard ( #75954 )
2021-02-18 13:38:24 -08:00
Jonah Williams
04182572f7
[flutter_tools] allow bypassing context for FlutterProject creation, remove fromPath ( #76258 )
2021-02-18 12:36:04 -08:00
Jenn Magder
ba5e237e24
Avoid duplicating Pods-Runner xcconfig #includes ( #75822 )
2021-02-11 14:11:15 -08:00
Jonah Williams
021311ed8a
Revert "[flutter_tools] move process manager into tool ( #75350 )" ( #75639 )
...
This reverts commit 8b6baae44c
2021-02-08 09:21:46 -08:00
Jonah Williams
8b6baae44c
[flutter_tools] move process manager into tool ( #75350 )
...
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Jenn Magder
dc30327a4d
Replace MockProcessManager with FakeProcessManager in cocoapods_test ( #74956 )
2021-01-29 14:32:33 -08:00
Jonah Williams
b926c7b696
[flutter_tools] rewrite Usage.test to capture objects instead of print logs ( #74829 )
2021-01-28 12:41:14 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. ( #74832 )
...
* opt out the flutter tool
* oops EOF
* fix import
* Update tool_backend.dart
* Update daemon_client.dart
* fix more
2021-01-27 15:17:53 -08:00
Jenn Magder
6891928a1f
Optionally include CocoaPods xcconfig ( #73112 )
2021-01-06 13:55:23 -08:00
Jenn Magder
1c18cf3da8
Move macOS Podfile logic into the tool ( #72020 )
2020-12-17 11:48:16 -08:00
Jenn Magder
23f5fbc69d
Update CocoaPods minimum version to 1.9 ( #71170 )
2020-12-17 10:22:50 -08:00
Jenn Magder
a8bed5e405
Add sysctl file fallbacks ( #71623 )
2020-12-03 08:53:07 -08:00
Jenn Magder
37f4f1f281
Detect ARM ffi CocoaPods error, suggest gem install ( #70801 )
2020-11-19 13:17:57 -08:00
Jenn Magder
e26c7f98ff
Force regeneration of old Podfile ( #70735 )
2020-11-18 13:33:04 -08:00
Jenn Magder
bc2a4a6498
Update CocoaPods recommended version to 1.9 ( #69809 )
2020-11-05 15:13:22 -08:00
Jenn Magder
5e17a240bd
Generate only requested platform directories on create ( #68376 )
2020-10-19 14:17:43 -07:00
Jonah Williams
9e70180f63
[flutter_tools] do not measure progress timeout ( #67959 )
...
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
2020-10-13 13:05:47 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. ( #65568 )
2020-09-16 14:14:06 -07:00
Jonah Williams
5d61bff294
[flutter_tools] even more test fixes ( #60156 )
...
Fix tests broken under tester
2020-06-24 10:23:59 -07:00
Jonah Williams
e34c591252
[flutter_tools] fix root directory tests ( #60060 )
...
* fix test compiler test
* fix project test
* fix flutter_platform_test
* fix cocoapods test
2020-06-23 11:14:38 -07:00
Jenn Magder
0093c6a4c6
Add Podfile migration warning to support federated plugins ( #59201 )
2020-06-12 12:44:14 -07:00
Jenn Magder
9c87b32477
Remove Runner target check, prefer schemes ( #56620 )
2020-05-11 11:56:44 -07:00
Zachary Anderson
6f0ed5e142
[flutter_tools] Restore base/platform.dart ( #56410 )
2020-05-06 08:15:39 -07:00
Jenn Magder
86389be66e
Convert CocoaPods tests to testWithoutContext ( #53291 )
2020-03-25 13:27:10 -07:00
Christopher Fujino
7d1fbcae1a
Refactor exits happy ( #52916 )
2020-03-20 13:05:19 -07:00
Jenn Magder
a14ac4e3c8
Bump recommended CocoaPods version to 1.8 ( #52071 )
2020-03-06 12:14:42 -08:00
