Commit Graph

844 Commits

Author SHA1 Message Date
Taha Tesser
f9cd87e60a
[flutter_tools] Add documentation to "cmdline-tools component is missing" doctor validation error (#83356) 2021-05-26 10:59:02 -07:00
Jenn Magder
a04f45f97b
Migrate deferred_components_gen_snapshot_validator to null safety (#83311) 2021-05-25 11:14:03 -07:00
Jonah Williams
0f929f9f13
[flutter_tools] require cmdline-tools for android licenses (#82560) 2021-05-22 15:54:03 -07:00
Emmanuel Garcia
8a7f2dee51
Move AndroidX error handler to the end (#83135) 2021-05-21 18:29:03 -07:00
Emmanuel Garcia
fa5883b78e
Add Gradle lockfiles and tool to generate them (#83067) 2021-05-21 13:04:03 -07:00
nt4f04uNd
80a2b6b015
Fix typos (#82589) 2021-05-20 17:19:09 -07:00
Marian Triebe
2d283504e6
Add cold boot option to emulator launch command (#82647) 2021-05-19 10:54:04 -07:00
Hattomo (TomohiroHattori)
08a70e7ac8
Enable avoid_escaping_inner_quotes lint (#81153) 2021-05-19 09:54:02 -07:00
Taha Tesser
3c72ef374d
Fix Android Studio 4.2 detection on Windows (#82484) 2021-05-13 22:54:04 -07:00
Jonah Williams
0f8a6ab4dd
[flutter_tools] make failures to unforward android port non-fatal (#82477) 2021-05-13 21:39:03 -07:00
Emmanuel Garcia
93c87e92b3
[flutter_tool] Suggest fix for transform input (#82309) 2021-05-13 21:24:04 -07:00
Emmanuel Garcia
60633b609c
[flutter_tool] Suggest how to increase the Android minSdkVersion (#82372) 2021-05-13 11:59:04 -07:00
Michael Goderbauer
b8a2456737
Enable library_private_types_in_public_api lint (#81578) 2021-05-10 16:26:16 -07:00
Alexandre Ardhuin
9bca38c5e5
remove unnecessary String.toString() (#81859) 2021-05-07 14:54:02 -07:00
Ian Hickson
33b183e6c9
Fix extra blank lines in logger output (#81607) 2021-05-03 09:19:02 -07:00
Jonah Williams
d4e48a1537
[flutter_tools] remove mocks from android emulator tests (#81548) 2021-04-30 17:39:03 -07:00
Jenn Magder
ba4177f6da
Find Android Studio installations with Spotlight query on macOS (#80475) 2021-04-28 19:09:03 -07:00
Jenn Magder
16c73829a6
Migrate reporting library to null safety (#80320) 2021-04-15 17:01:34 -07:00
Jenn Magder
23404dfa74
Remove flutter_command dependency from reporting library (#80159) 2021-04-12 16:45:03 -07:00
Jenn Magder
beec6106fa
Migrate template to null safety (#80016) 2021-04-08 15:19:03 -07:00
Jenn Magder
026ee9756c
Allow null config values (#79917) 2021-04-06 21:52:35 -07:00
Jenn Magder
eb9a2f0ca5
Move cache from globals to globals_null_migrated (#79900) 2021-04-06 17:57:40 -07:00
Jenn Magder
f5c268a794
Migrate android_workflow to null safety (#79806) 2021-04-06 10:33:52 -07:00
Jenn Magder
30370c9f99
Migrate some workflows and doctor validators to null safety (#79807) 2021-04-05 14:00:36 -07:00
Jenn Magder
79f1689f6a
Migrate doctor_validator to null safety (#79682) 2021-04-05 11:54:54 -07:00
Jenn Magder
b083bc143d
Migrate android_sdk and application_package to null safety (#79611) 2021-04-02 14:39:53 -07:00
Jenn Magder
fb68d07477
Migrate android_studio to null safety (#79504) 2021-04-01 20:24:04 -07:00
Jenn Magder
a83abaa3e3
Migrate fingerprint to null safety (#79587) 2021-04-01 18:29:51 -07:00
Chris Bracken
3e7e06512c
Correct misspellings throughout the codebase (#79500) 2021-04-01 10:04:03 -07:00
Jenn Magder
152af5aba7
Fix device_port_forwarder file name typo (#79481) 2021-03-31 18:14:03 -07:00
Jenn Magder
8ddc27e607
Split globals.dart into null sound and unsound libraries (#79016) 2021-03-31 16:55:20 -07:00
Jonah Williams
29207e4f78
[flutter_tools] split application package factory dependencies (#79461) 2021-03-31 15:11:58 -07:00
Gurjinder Partola
fed35b4d9c
[flutter_tools] Add support for versioned Android cmdline tools (#78253) 2021-03-25 13:42:39 -07:00
Jenn Magder
8893e89d11
Migrate device_port_forwarder to null safety (#78949) 2021-03-24 16:56:14 -07:00
Jenn Magder
63d6ec56af
Migrate deferred_components_validator to null safety (#78934) 2021-03-24 15:20:05 -07:00
Jenn Magder
ce31d4ff7e
Migrate android_console to null safety (#78923) 2021-03-24 15:18:00 -07:00
Jia Hao
aa1df71c20
[flutter_tools] throwToolExit should return Never (#78954) 2021-03-24 10:40:03 -07:00
Jenn Magder
d165ea5c42
Migrate os to null safety (#78901) 2021-03-23 17:28:09 -07:00
Jenn Magder
0bde67e734
Migrate flutter_tool tool helper files to null safety (#78845) 2021-03-23 10:02:59 -07:00
Gary Qian
2a8b296ae9
[flutter_tools] Deferred components: Encode base module loading units in manifest metadata (#78079) 2021-03-15 15:58:06 -07:00
Gurjinder Partola
2e17a8e676
Fix avdmanager path detection (#78166) 2021-03-15 11:18:04 -07:00
Jonah Williams
a01f37245b
[flutter_tools] remove globals from terminal (#77953) 2021-03-12 12:53:05 -08:00
Gary Qian
ee41782732
[flutter_tools] Deferred components build system (#76192) 2021-03-04 18:09:02 -08:00
Jonah Williams
90f353f9b1
[flutter_tools] dont crash when looking for AS4.1 on windows with no LOCALAPPDATA (#77261) 2021-03-04 11:29:20 -08:00
William Oprandi
679b8c2982
Fix Android Studio detection and plugins on Linux (#75612) 2021-03-03 08:29:03 -08:00
Gary Qian
9df362a73f
[flutter_tools] Refactor DeferredComponents validator and add build target (#76400) 2021-02-24 17:51:03 -08:00
Jonah Williams
bbaced6d12
[flutter_tools] cache adb path (#76650) 2021-02-23 17:26:02 -08:00
Jonah Williams
b678d0adec
[flutter_tools] remove globals and mocks from android gradle builder and test (#76416) 2021-02-19 21:07:43 -08:00
Jonah Williams
75470a0051
[flutter_tools] unify gradle/android sdk reinitialize checks in cache.dart (#76342) 2021-02-19 13:47:12 -08:00
Jonah Williams
6b14558a68
[flutter_tools] remove global usage of flutterUsage from gradle (#76330) 2021-02-18 15:52:00 -08:00
Gary Qian
ba5cc2cba4
[flutter_tools] Deferred components setup validator (#75739) 2021-02-18 12:01:03 -08:00
Jonah Williams
bfcb43d2fc
[flutter_tools] remove local engine from globals in gradle (#76277) 2021-02-18 11:30:44 -08:00
Jonah Williams
555721de24
[flutter_tools] remove mock process manager from gradle tests (#76252) 2021-02-17 17:00:12 -08:00
Jonah Williams
93e7d34dc4
[flutter_tools] Remove globals/mocks from GradleUtils (#76020) 2021-02-17 14:26:57 -08:00
Jonah Williams
65599e2825
[flutter_tools] use less path manipulation in the Android SDK (#75930) 2021-02-16 13:54:44 -08:00
Jonah Williams
dce8f71228
[flutter_tools] do not use context logger in gradle (#75940) 2021-02-12 17:38:52 -08:00
Hidenori Matsubayashi
4cc0ab2d19
[flutter_tools] Add ARM64 Linux host and cross-building option support (#61221) 2021-02-12 14:25:30 -08:00
Jonah Williams
97a9f2ae93
[flutter_tools] move gradle helper methods into AndroidBuilder class body, split unit tests (#75931) 2021-02-12 14:24:13 -08:00
mx1up
cc95c972b7
properly pass on gradle exit code (#71484) (#71582) 2021-02-11 14:11:03 -08:00
Jonah Williams
021311ed8a
Revert "[flutter_tools] move process manager into tool (#75350)" (#75639)
This reverts commit 8b6baae44c.
2021-02-08 09:21:46 -08:00
Jonah Williams
8b6baae44c
[flutter_tools] move process manager into tool (#75350)
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Jonah Williams
44d5950d27
[flutter_tools] switch dart defines to base64 to avoid windows control characters (#75027)
= gets escaped into %3D which seems to be tripping up cmake on windows since % is a control character. Switch to base64 encoding, since this does not have % nor , in the output character set.

This change is not trivially cherry pickable, and isn't tested on windows aside from my local, manual tests due to the planned CI work not being complete yet.

Fixes #75017
Fixes #74705
2021-02-02 09:10:48 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. (#74832)
* opt out the flutter tool

* oops EOF

* fix import

* Update tool_backend.dart

* Update daemon_client.dart

* fix more
2021-01-27 15:17:53 -08:00
Jonah Williams
efcf2c664e
[flutter_tools] check if process manager can find adb (#74672) 2021-01-25 14:15:23 -08:00
xster
e0dcb787dc
groovy escaping was wrong for aar (#72554) 2021-01-07 11:43:27 -08:00
Jenn Magder
cdacae89e1
Revert "Launch named iOS simulators (#72323)" (#72447)
This reverts commit 84a7a611b0.
2020-12-16 11:52:59 -08:00
Jenn Magder
84a7a611b0
Launch named iOS simulators (#72323) 2020-12-15 15:06:47 -08:00
Kenzie Schmoll
94a30ddcbb
Add text to --analyze-size command output to launch DevTools with size data (#72295)
* Add text to --analyze-size command output to launch DevTools with size data.
2020-12-15 11:06:10 -08:00
Jason Simmons
2c3ba5b635
Create symlinks for local engine Maven metadata files required by the Android Gradle plugin (#71600) 2020-12-03 15:28:06 -08:00
Jonah Williams
81e1f7d1ed
[flutter_tools] mode code size output to ~/.flutter-devtools (#71601) 2020-12-02 17:19:57 -08:00
Emmanuel Garcia
8dd0de7f58
Relands: Migrate template to Gradle 6.7 and AGP 4.1.0 (#71446) 2020-12-01 19:01:09 -08:00
Jonah Williams
f8883445ca
Revert "[flutter_tools] post process the gradle log output (#71499)" (#71527)
This reverts commit d688b52a93.
2020-12-01 17:53:14 -08:00
Jonah Williams
d688b52a93
[flutter_tools] post process the gradle log output (#71499) 2020-12-01 17:13:33 -08:00
Amir Hardon
7df04fdbd3
Revert "Migrate template to Gradle 6.7 and AGP 4.1.0 (#70808)" (#71096)
This reverts commit 8e73bab94c.
2020-11-23 12:27:36 -08:00
Emmanuel Garcia
8e73bab94c
Migrate template to Gradle 6.7 and AGP 4.1.0 (#70808) 2020-11-20 13:05:35 -08:00
Mokusesei
6269abb75b
Reland: fix android studio 4.1 plugin path for mac (#69954) 2020-11-06 10:57:04 -08:00
Jonah Williams
e18533e7ab
[flutter_tools] remove globals from android_workflow (#69548) 2020-11-06 10:55:52 -08:00
Vyacheslav Egorov
4c24eb10b8
Revert "Fix: fix android studio 4.1 plugin path for macOS" (#69870)
This reverts commit 422a97d1e5 due to https://github.com/flutter/flutter/issues/69863
2020-11-05 11:18:00 +01:00
Mokusesei
422a97d1e5
Fix: fix android studio 4.1 plugin path for macOS (#69364) 2020-11-04 17:25:53 -08:00
Jonah Williams
fb90544cab
[flutter_tools] remove unused or no longer useful code (#69547) 2020-11-02 22:48:03 -08:00
Jonah Williams
e0ec9a06dc
[flutter_tools] Make ApplicationPackageFactory inject dependencies for Android Builds (#67827)
* [flutter_tools] simplication of application store logic

* maybe return null

* fix install tests

* Clean up imports

* revert windows test

* remove unused import
2020-10-26 16:51:32 -07:00
Jonah Williams
183fe75d58
[flutter_tools] reland: drive service (#68887)
Overhaul of flutter drive in order to deliver a better experience, namely:

* flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive.
* Removes web-initialize-platform as this is no longer used
* flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service.
* VM service connection now provides access to memory info without launching devtools (only for debug/profile mode)

Web changes

* Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible

Additional NNBD related bug fixes:

No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
2020-10-26 10:11:30 -07:00
Jonah Williams
1edec6fc20
Revert "[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)" (#68845)
This reverts commit 2e75f52ae4.
2020-10-22 19:39:33 -07:00
Jonah Williams
2e75f52ae4
[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)
Overhaul of flutter drive in order to deliver a better experience, namely:

flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive.
Removes web-initialize-platform as this is no longer used
flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service.
VM service connection now provides access to memory info without launching devtools (only for debug/profile mode)
Web changes

Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible

Additional NNBD related bug fixes:

No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
2020-10-22 15:07:02 -07:00
Jonah Williams
e422d5c724
[flutter_tools] reland: --no-android-gradle-daemon in devicelab (#68491)
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.

Example:

flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
2020-10-19 10:27:58 -07:00
Jonah Williams
ed5482de19
Revert "[flutter_tools] add --android-gradle-daemon option, use in devicelab (#68409)" (#68489)
This reverts commit ddab72e79f.
2020-10-19 09:33:52 -07:00
Jonah Williams
ddab72e79f
[flutter_tools] add --android-gradle-daemon option, use in devicelab (#68409)
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.

Example:

flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
2020-10-19 09:12:21 -07:00
Jonah Williams
27936e9f22
Revert "[flutter_tools] ensure android log reader works in flutter drive (#68131)" (#68222)
This reverts commit d962c8f2a2.
2020-10-15 10:50:56 -07:00
Jonah Williams
2321b72dfb
[flutter_tools] move gradle download failure handling into tool (#68140)
This crash affects anyone using flutter, so move it into the tool where it can be tested and documented. Ensure it works on windows devicelab too.
2020-10-15 09:20:52 -07:00
Jonah Williams
d962c8f2a2
[flutter_tools] ensure android log reader works in flutter drive (#68131) 2020-10-14 14:04:33 -07:00
Jenn Magder
537cf33a21
Move processUtils to globals (#67976) 2020-10-14 13:12:46 -07:00
Jonah Williams
9e70180f63
[flutter_tools] do not measure progress timeout (#67959)
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
2020-10-13 13:05:47 -07:00
Jonah Williams
1c976933f3
[flutter_tools] support Android Studio 4.1 on Windows (#67992)
Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes #67986
2020-10-13 11:33:26 -07:00
Jonah Williams
fd11d149f7
[flutter_tools] teach flutter drive to uninstall if install fails (#67936)
Work towards #39925

Currently flutter run will uninstall and reinstall if the initial install fails and the APK was previously installed. Allow drive to share this same logic by moving it into installApp and out of startApp.

This should reduce the occurrence of the error in the devicelab.
2020-10-12 12:49:36 -07:00
Jonah Williams
08576cb671
[flutter_tools] HACKTOBERFEST (#67882)
HACKTOBERFEST
2020-10-12 09:31:02 -07:00
Jonah Williams
6180a4c179
[flutter_tools] fix documentation, globals, and todos in the android codebase (#66980)
Cleans up some undocumented classes and re-organizes the AndroidDevices class to avoid the need for the static testing only member. Adds a script for tracking globals.
2020-10-05 15:47:57 -07:00
Danny Tuppeny
fdd1bf2944
Handle missing Android SDKs in getEmulators() (#67295) 2020-10-05 08:57:04 -07:00
Jonah Williams
ddb8177018
[flutter_tools] remove globals from desktop configuration (#67146)
Refactors the desktop devices and workflow to remove unnecessary usage of global variables. This should make it easier to test and continue enhancing the desktop functionality of the tooling

#47161
2020-10-02 21:52:53 -07:00
Jenn Magder
becaf4913f
Replace MockCache with Cache.test() (#66946) 2020-09-30 14:53:57 -07:00
Jonah Williams
9bc533c9e5
[flutter_tools] do not error flutter doctor on missing AS/intellij plugins (#66782)
In cases where the Intellij/AS plugins are not located, display links to where they can be downloaded but do not surface an error. This should generally reduce confusion about whether the plugins are required for every installed IDE. For example, frequently users may only install AS so that they can install the Android SDK - or they may have multiple copies of Intellij installed.

For example: #66762
2020-09-29 16:51:28 -07:00