Commit Graph

125 Commits

Author SHA1 Message Date
Casey Hillers
d2af134578
Revert "Fix Slider semantic node size (#115285)" (#116294)
This reverts commit 8473da22cd.
2022-11-30 11:21:39 -08:00
Taha Tesser
8473da22cd
Fix Slider semantic node size (#115285) 2022-11-30 02:27:45 +00:00
Taha Tesser
97d0247d59
Add Material 3 support for Slider - Part 1 (#114079) 2022-11-01 19:31:00 -07:00
Greg Spencer
37b72342b0
Add maybeOf for all the cases where of returns nullable. (#114120) 2022-10-31 23:09:09 +00:00
Taha Tesser
400136b007
Fix Slider overlay and value indicator interactive behavior on desktop. (#113543) 2022-10-25 07:25:16 +00:00
Taha Tesser
ad2005c485
Add overlay MaterialStateProperty property to Slider (#112922) 2022-10-06 07:44:30 +00:00
Akshdeep Singh
519a5783c0
add material slider secondary value (#109808) 2022-08-28 23:26:32 +00:00
Jonah Williams
0d3d8d4bfd
[framework] respect debugDisableShadows in slider thumbs (#105467) 2022-06-06 16:38:07 -07:00
xubaolin
5a9196737d
[Slider]The initial value of discrete slider should respect the discrete values (#103966)
Fixes #103965
2022-05-25 12:55:13 -07:00
Pierre-Louis
cb9a1d623c
Use curly_braces_in_flow_control_structures for material (#104499)
* Use `curly_braces_in_flow_control_structures` for `material`

* include test/material

* add back removed comments
2022-05-25 13:17:06 +02:00
Tong Mu
23bc3d64eb
[Mouse] Remove all pointers at the end of tests (#102694) 2022-05-19 17:48:10 -07:00
Jonah Williams
496049263e
[framework] fix slider regression due to touch slop changes (#103569) 2022-05-11 23:14:11 -07:00
Eric egramond
ae7fcc7e51
Updating the Slider Widget to allow up and down arrow keys to navigate out of the slider when in directional NavigationMode. (#103149) 2022-05-07 03:39:06 -07:00
Jonah Williams
fba9214d11
[framework] remove usage and deprecate physical model layer (#102274) 2022-04-26 16:14:04 -07:00
xubaolin
2381657394
Fix a Slider widget accessibility bug (#102129) 2022-04-25 18:24:07 -07:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. (#89451) 2022-02-03 14:55:15 -08:00
Hans Muller
c24b2c3c6e
Slider: add themeable mouse cursor v2 (#96623) 2022-01-13 17:07:02 -08:00
Chris Bracken
ed4dae3c27
Windows: Focus slider on gaining a11y focus (#95295)
Microsoft Active Accessibility (MSAA) does not include
increment/decrement keyboard shortcuts for manipulating sliders and
other similar controls. To make up for this, we give the slider keyboard
focus when it gains accessibility focus so that the user can use the
arrow keys to manipulate the slider.

Issue: https://github.com/flutter/flutter/issues/77838
2021-12-14 17:40:36 -08:00
Ian Hickson
5ddc00cc03
Use EnumName.name where possible. (#94496) 2021-12-03 16:39:04 -08:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
nt4f04uNd
d8cdaba085
init (#82348) 2021-07-20 16:06:03 -07:00
Ren You
3dea9f0251
Revert "Clean up the bindings APIs (#86438)" (#86484)
This reverts commit d056500bfe.
2021-07-15 09:29:16 -07:00
Ian Hickson
d056500bfe
Clean up the bindings APIs (#86438) 2021-07-14 14:41:24 -07:00
Zachary Anderson
7f741e9181
Revert "Clean up the bindings APIs (#86388)" (#86404)
This reverts commit 31de052e3f.
2021-07-13 21:32:29 -07:00
Ian Hickson
31de052e3f
Clean up the bindings APIs (#86388) 2021-07-13 18:31:11 -07:00
Ian Hickson
c800b9c3e4
Revert "Clean up the bindings APIs (#83843)" (#86386)
This reverts commit e2490f2906.
2021-07-13 15:47:40 -07:00
Ian Hickson
e2490f2906
Clean up the bindings APIs (#83843) 2021-07-13 12:41:03 -07:00
nohli
fb664702be
Add slider adaptive cupertino thumb color (#81647) 2021-06-11 10:14:02 -07:00
nt4f04uNd
0902576aba
Fix slider notifies start and end twice when participates in gesture arena (#82152) 2021-05-20 16:44:02 -07:00
Alexandre Ardhuin
fa19b3d3bd
add missing trailing commas (#81329) 2021-04-27 17:09:03 -07:00
Alexandre Ardhuin
d546e1d311
fix for upcoming lint use_named_constants (#74788) 2021-01-27 20:20:44 +01:00
Greg Spencer
de884f1afe
Remove the nullOk parameter from Navigator.of and add Navigator.maybeOf (#70726)
Adds Navigator.maybeOf to replace calling Navigator.of(context, nullOk: true), and removes the nullOk parameter. Also changes Navigator.of to return a non-nullable value, and removes many (120!) instances of the ! operator, reducing the possible places where a null dereference could occur.
2020-11-20 09:10:46 -08:00
Michael Goderbauer
0490fd75aa
Make Theme.of non-nullable (#68922) 2020-11-02 09:20:42 -08:00
Xavier Chrétien
f26fbb6bdd
Set slider semantics flag for sliders (#68019) 2020-10-19 08:12:03 -07:00
Darren Austin
4e3f4bb625
Migrated the Slider widget and tests to null safety. (#68232) 2020-10-15 15:47:04 -07:00
xubaolin
73194cd9f2
Fix bug when updating the divisions and value of the slider at the same time (#65998) 2020-09-18 14:52:03 -07:00
xubaolin
c7353bc414
Slider and RangeSlider can be painted in a narrower constraint like other Material Wi… (#64627) 2020-09-02 11:20:03 -07:00
Chris Bracken
c0ea00ed3f
Prefer moreOrLessEquals over closeTo (#64915)
Flutter's `moreOrLessEquals` has a few advantages over `closeTo` from
the `matcher` package:

   * It emits the epsilon value in the test result on failure.
   * It uses a named parameter for epsilon, which improves readability
     at the call site.
   * It has a reasonable default for epsilon in cases where something
     more specific isn't required.

Using it also has the nice property that it aids in its own discovery
when when people go looking for such functionality in new tests.

This change also includes a couple unrelated whitespace formatting cleanups.
2020-08-30 22:20:16 -07:00
xubaolin
c26c2363a0
Slider paint incorrectly when the track shape is rectangular (#64534) 2020-08-28 16:08:10 -07:00
LongCatIsLooong
53e25a61c9
Reland "Prevent material switch from recreating its render object when it becomes disabled (#61398)", reverted in #64062 (#64354) 2020-08-21 14:52:08 -07:00
LongCatIsLooong
90908b0beb
Revert "Prevent material switch from recreating its render object when it becomes disabled (#61398)" (#64062) 2020-08-21 10:34:08 -07:00
LongCatIsLooong
579cab8a86
Prevent material switch from recreating its render object when it becomes disabled (#61398) 2020-08-17 11:36:02 -07:00
Darren Austin
d169880278
Updated references to the old button classes to the new ones in comments and documentation for tests in the material and cupertino libraries. (#62164) 2020-07-28 11:01:04 -07:00
Kate Lovett
01ac509620
Skip Audit - Last Leftovers (#60940) 2020-07-09 17:01:01 -07:00
chunhtai
5623fea53c
Reverse the semantics order of modal barrier and modal scope (#59290)
* Add semantics sort key for modal scope and modal barrier

* fix test

* fix test

* fix test

* fix space

* fix more tests

* addressing comments
2020-06-24 10:37:53 -07:00
Alexandre Ardhuin
4d7525f05c
Opt out nnbd in packages/flutter (#59186)
* add language version 2.8 in packages/flutter

* enable non-nullable analyzer flag
2020-06-11 14:11:30 +02:00
Jose Alba
76de30edc8
Updated Slider test (#58630) 2020-06-10 12:10:02 -07:00
Greg Spencer
d7321d92b8
Make _RenderSlider not be a semantics container (#58535)
This PR makes _RenderSlider not be a semantics container. This is so that the FocusableActionDetector in the Slider widget will get to aggregate the semantics information, since otherwise Talkback won't focus the slider because it thinks that the focus node doesn't have anything to say (which it doesn't but the _RenderSlider child does). If the _RenderSlider is a semantics container, then it keeps its speakable information to itself, but it isn't the Focus widget, so when the keyboard focus goes to the focus node, the accessibility focus doesn't move.

Since the _RenderSlider is always wrapped by the Slider widget, there's nothing lost in making it not be a container.
2020-06-08 14:04:45 -07:00