Commit Graph

20 Commits

Author SHA1 Message Date
Alexandre Ardhuin
758009ba70
more ui-as-code (#35393)
* more ui-as-code

* address review comments
2019-07-02 21:11:56 +02:00
Alexandre Ardhuin
919dcf53f3
enable lints prefer_spread_collections and prefer_inlined_adds (#35189) 2019-06-27 21:23:16 +02:00
Ian Hickson
686d8f8a22 Shim package:test to avoid matcher issues (#20602)
* Upgrade everything except matcher.
* Roll matcher (and test)
* Adjust tests that depend on flutter:test directly to depend on a shim
* Require use of package:test shim and remove other references to package:test
2018-08-14 20:33:58 -07:00
Alexandre Ardhuin
eda03e2586
re-re-enable lint unnecessary_const (#20103) 2018-08-02 12:02:32 +02:00
Todd Volkert
00aac68e2d
Revert flutter/flutter#19592 (#19861)
It was causing problems rolling Flutter into Fuchsia
2018-07-27 08:44:39 -07:00
Alexandre Ardhuin
27018359d2
re-enable lint unnecessary_const (#19592)
* re-enable lint unnecessary_const

* remove trailling whitespaces

* remove unnecessary const (after merge)
2018-07-23 08:31:48 +02:00
Ian Hickson
f630f90d6d
Revert "enable lint unnecessary_const (#19342)" (#19423)
This reverts commit cc1cf13eec.
2018-07-16 13:30:27 -07:00
Alexandre Ardhuin
cc1cf13eec
enable lint unnecessary_const (#19342) 2018-07-16 21:43:48 +02:00
Danny Tuppeny
0329f0c179
Include stdout/stderr in failure messages for devicelab's tests (#18990)
* Include stdout/stderr in failure messages

Sometimes some of these tests unexpectedly fail with a non-zero exit code. This ensures stdout/stderr is included in the test failure message when this happens so that we can track down the issue.

* Remove redundant info about exit code

* Remove unnecessary indenting

The [markers] make it fairly clear so this just makes the test code noisy.
2018-07-03 07:37:34 +01:00
Alexandre Ardhuin
841d5d7bd5
prefer_const_declarations on local variables (#14358) 2018-02-01 07:51:26 +01:00
Ian Hickson
3eb87830e9 Constants! Constants everywhere! (#9286)
Aggressively apply the const lint.
2017-04-07 12:24:32 -07:00
Michael Goderbauer
d87f19817f devicelab benchmarks run on Windows (#8814)
* devicelab benchmarks run on Windows

* fix analyzer issue

* fix test

* fix pubspec
2017-03-15 16:33:10 -07:00
Chris Bracken
6c97dd2c6c Declare locals as final where not reassigned (dev) (#8574) 2017-03-03 18:06:08 -08:00
Michael Goderbauer
7231fd3ed6 Enable flutter drive on Windows (#8146)
... and run some more tests on Windows.
2017-02-14 13:14:52 -08:00
Michael Goderbauer
723489de02 Make dev/bots/test.dart pass on Windows (#7998)
* disables all `flutter test` and `flutter drive` tests on Windows as those two commands are not fully implemented on Windows yet
* fixes other failures on Windows
2017-02-08 15:57:31 -08:00
Yegor
4145f5fcfd allow passing file path as reference to devicelab task (#6877) 2016-11-16 13:54:06 -08:00
Yegor
4f8da89dc4 Revert "reenable dev/devicelab/test/run_test.dart (#6364)" (#6378)
This reverts commit 8f273e49de.
2016-10-19 18:43:19 -04:00
Yegor
8f273e49de reenable dev/devicelab/test/run_test.dart (#6364)
I ran the test 10 times on Linux and Mac and it succeeded
consistently. Let's reenable until there are new reports that it's
flaky.

Fixes #5901
2016-10-17 19:31:58 -07:00
Ian Hickson
4f0eff31bc Fix crash when a RenderObject tree is rooted in a non-RenderObject environment (#5933) 2016-09-20 14:14:05 -07:00
Yegor
1ba1562293 move CI tests into the main repo (#5758) 2016-09-14 13:22:53 -07:00