Kate Lovett
b6a2efb7ab
Committing progress. Documentation and testing incomplete/in progress. Code cleanup needed as well.
2019-04-18 16:08:09 -07:00
chunhtai
b275e11170
fix issue 12999: Make assets available during tests ( #31207 )
2019-04-18 15:31:47 -07:00
Dan Field
330dc94c0f
Check that ErrorWidget.builder is not modified after test ( #30898 )
2019-04-15 12:38:51 -07:00
Jonah Williams
715cb5132e
Fix bugs in contrast guideline and improve heuristic ( #31000 )
2019-04-15 09:01:09 -07:00
Sam Rawlins
83ddd98849
Fix additional @mustCallSuper indirect overrides and mixins ( #30667 )
2019-04-10 14:54:51 -07:00
Alexandre Ardhuin
32f1b810ae
shorter nullable list duplications ( #30305 )
2019-04-05 10:23:35 -07:00
Jonah Williams
1bfa2f2311
Intercept errors thrown by synchronous Completers in image resolution. ( #30139 )
2019-03-29 10:05:18 -07:00
Jonah Williams
3c93b65a9b
Update to latest matcher ( #30019 )
2019-03-27 17:21:10 -07:00
Alexandre Ardhuin
bfa1d25bf9
some formatting of map, parameters and spaces ( #29760 )
2019-03-23 00:02:21 +01:00
Alexandre Ardhuin
a6af422874
some spaces formatting ( #29452 )
...
* some space formattings
* always use blocks in if-else if a block is used
* format spaces in for and while
* allow multiline if conditions
* fix missing space
2019-03-20 23:23:31 +01:00
Dan Field
5e27ebbe8d
Add semantic label finders ( #29342 )
...
* Add semantic label finders
2019-03-18 20:32:03 -07:00
Dan Field
8e14c227eb
Make it easier to ensure semantics in widgetTests ( #29387 )
...
* Make it easier to ensure semantics
2019-03-18 10:08:23 -07:00
Brian Wilkerson
439fbbe69e
Update SDK constraints to reflect the fact that set literals are being used ( #29389 )
2019-03-15 07:53:27 -07:00
Jonah Williams
275769b89d
Add skip to group in test_compat ( #29236 )
2019-03-13 10:13:51 -07:00
Michael Goderbauer
816ae4b193
Include platformViewId in semantics tree ( #28953 )
2019-03-12 07:44:39 -07:00
stuartmorgan
5922a40e6a
Add support for scrollwheels ( #22762 )
...
Adds support for discrete scroll events, such as those sent by a scroll wheel.
Includes the plumbing to convert, dispatch, and handle these events, as well as
Scrollable support for consuming them.
2019-03-11 10:08:12 -07:00
Alexandre Ardhuin
a0d1f93b07
fix block formatting ( #29051 )
2019-03-09 09:03:11 +01:00
Gary Qian
8f1a430557
Initialize the lifecycle state with initial state in window. Roll engine (19 commits) ( #28688 )
...
git log --oneline --no-merges f4951df193a7966f9ed4da43d555eee0913d84d1..a48cd16e077778a7aa5908e4faa4da07714260f2
a48cd16e0 Update a11y word forward/back enum names (https://github.com/flutter/engine/pull/8073 )
b5f59ed89 Delay the vsync callback till the frame start time specified by embedder. (https://github.com/flutter/engine/pull/8072 )
7426305f5 Mark const extern (https://github.com/flutter/engine/pull/8077 )
d3f6d7a21 only partial rule revert (https://github.com/flutter/engine/pull/8078 )
d71bfe58d Only build a full Dart SDK when building for the host system (https://github.com/flutter/engine/pull/8071 )
de90dbff7 Refactor web configuration/ Add dartdevc (https://github.com/flutter/engine/pull/7978 )
ff46dd38f Roll src/third_party/skia 4c1ea43a79b5..88b8d1124b72 (8 commits) (https://github.com/flutter/engine/pull/8070 )
80c6dd286 Roll src/third_party/skia 692122e3ef23..4c1ea43a79b5 (3 commits) (https://github.com/flutter/engine/pull/8069 )
68ed654ea Roll src/third_party/skia 3c957d575c58..692122e3ef23 (6 commits) (https://github.com/flutter/engine/pull/8067 )
ca0bac4fb Revert "add signal to pointer kinds" (https://github.com/flutter/engine/pull/8066 )
3fb627f2c add signal to pointer kinds (https://github.com/flutter/engine/pull/8065 )
5a06afa2a Roll src/third_party/skia 801a9c16d81e..3c957d575c58 (19 commits) (https://github.com/flutter/engine/pull/8063 )
a93d99db9 A11y callback (https://github.com/flutter/engine/pull/8005 )
3661d5e43 Re-land "Buffer lifecycle in WindowData" (https://github.com/flutter/engine/pull/8032 )
471a2c89a Send scroll events from the macOS shell (https://github.com/flutter/engine/pull/8056 )
2fe9c9b5f Roll src/third_party/skia 72542816cadb..801a9c16d81e (46 commits) (https://github.com/flutter/engine/pull/8060 )
3335764ae Skip skp files in license check (https://github.com/flutter/engine/pull/8050 )
7f16789b2 Remove redundant thread checker in FML. (https://github.com/flutter/engine/pull/8053 )
840c5233a Correct URL for Cirrus CI build status badge (https://github.com/flutter/engine/pull/8054 )
57c120a29 remove extra source files (https://github.com/flutter/engine/pull/8052 )
4773375c6 Used named conditionals for platform specific dependencies and suppress Android and Windows hooks on Mac. (https://github.com/flutter/engine/pull/8051 )
70a18b515 Add clang static analysis support to gn wrapper (https://github.com/flutter/engine/pull/8047 )
b30f9897b Improve elevation bounds for physical shape layers (https://github.com/flutter/engine/pull/8044 )
e37bd27b4 Fix weak pointer use violations in shell and platform view. (https://github.com/flutter/engine/pull/8046 )
dd80fc9ff Add engine support for scrollwheel events (https://github.com/flutter/engine/pull/7494 )
2019-03-07 20:05:42 -08:00
Alexandre Ardhuin
440ce8fde6
Fix indentations of statements in BlockFunctionBody ( #28933 )
...
* fix indentof statements in BlockFunctionBody
* fix indentof statements in BlockFunctionBody in tests
2019-03-07 21:09:28 +01:00
TruongSinh Tran-Nguyen
0c7fe40e37
fix #19175 How should addTime be used from a test? ( #25202 )
2019-03-06 15:32:33 -08:00
Phil Quitslund
802eca29d2
set literal conversions ( #27811 )
2019-03-06 11:05:16 -08:00
Alexandre Ardhuin
4c1f4d14e1
fix some formatting issues ( #28809 )
...
* fix some formatting issues
* address review comments
* fix indent
2019-03-06 09:37:32 +01:00
Danny Tuppeny
740fb2a8bb
Fix the test annotation used for test groups ( #28638 )
2019-03-02 13:19:49 +00:00
Mouad Debbar
b94bf87c70
Text selection via mouse ( #28290 )
2019-03-01 13:57:10 -08:00
Alexandre Ardhuin
387f885481
Add missing trailing commas ( #28673 )
...
* add trailing commas on list/map/parameters
* add trailing commas on Invocation with nb of arg>1
* add commas for widget containing widgets
* add trailing commas if instantiation contains trailing comma
* revert bad change
2019-03-01 08:17:55 +01:00
Jonah Williams
ec93468a14
Add capability to run build_runner tests for engine ( #28684 )
2019-02-28 20:06:14 -08:00
Anthony
338581b866
add await to fix analyzer ( #28157 )
2019-02-28 19:17:18 -05:00
jslavitz
47724f97fa
Breaks the moveBy call from drag and dragFrom into two separate calls and changes the default behavior of DragStartBehavior to DragStartBehavior.start ( #26438 )
...
* Breaking change which sets the default DragStartBehavior to DragStartBehavior.start and changes WidgetTester.drag and WidgetTester.dragFrom by breaking the moveBy function call into multiple pieces.
2019-02-25 14:15:31 -08:00
Stanislav Baranov
3837ec9e96
Reland #27754 , now that bsdiff has moved to flutter/packages. ( #28291 )
2019-02-21 21:59:41 -08:00
Alexandre Ardhuin
5169ab5974
format parameter list ( #27261 )
2019-02-21 09:27:07 +01:00
jslavitz
2c558fdb21
Adds fix for NAN value and pressure values outside of device reported min and max ( #26659 )
...
* Fix for nan pressure values and values outside min and max pressure ranges
2019-02-20 16:15:53 -08:00
Jonah Williams
3205736fcf
add ui.Window fallback to TestViewConfiguration ( #27987 )
2019-02-14 22:49:49 -08:00
Todd Volkert
f1a8eed083
Revert "Clean up matters related to "offstageness". ( #27425 )" ( #27915 )
...
This reverts commit 1d93e924b7
2019-02-13 20:58:41 -05:00
Ian Hickson
1d93e924b7
Clean up matters related to "offstageness". ( #27425 )
...
In particular, make debugVisitOnstageChildren only work in debug mode, and add documentation.
2019-02-13 15:36:47 -08:00
Matt Carroll
a13fdbcf32
Implemented Dark Mode for Android ( #25525 ) ( #26605 )
2019-02-06 16:52:47 -08:00
Matt Carroll
914f77f88f
Bugfix: Add platformBrightness to TestWindow. ( #27569 )
...
* Bugfix: Add platformBrightness to TestWindow.
* Manual engine roll:
cc27cafb8 Implemented Dark Mode for Android (#25525 ) ([flutter/engine#7488 ](https://github.com/flutter/engine/pull/7488 ))
9c05cbcfb Roll src/third_party/dart b53dceadaa..5823be65af (5 commits) 5823be65af [vm/compiler] Continued graph checker development (reland) 8231cdb7a3 [gardening] Update status for issue 35854 db7f848632 [vm] Remove dead BigInt code. 35ab1755f4 Support more type propagation for code-as-ui features 569ee07f91 [vm] Cleanup class finalization checks
ec5e6f6ef Ensure dart2js and kernel worker snapshots are copied out of gen dir ([flutter/engine#7692 ](https://github.com/flutter/engine/pull/7692 ))
8b5fa65c4 Roll src/third_party/skia 50ea3c06b80f..2d35a1c87553 (6 commits) ([flutter/engine#7693 ](https://github.com/flutter/engine/pull/7693 ))
2019-02-05 15:52:22 -08:00
Danny Tuppeny
7e445a1732
Add @isTest to Flutter's wrappers over group/test ( #27532 )
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/1421 .
2019-02-05 15:43:33 +00:00
Matt Carroll
92125ed38f
Enable dependency injection of Window instead of using static property ( #27389 )
2019-02-04 16:46:04 -08:00
Konstantin Scheglov
39289b83ac
Update additionalTime in TestWidgetsFlutterBinding.runAsync() to 1000. ( #27256 )
2019-01-30 07:31:00 -08:00
Alexandre Ardhuin
ef276ffea5
format initializer list of constructors ( #27111 )
2019-01-29 21:47:16 +01:00
Jonah Williams
ca92efecae
Add module checking ( #27122 )
2019-01-29 12:26:48 -08:00
Konstantin Scheglov
4fe41abfcc
Add default values for optional parameters. ( #27197 )
2019-01-29 11:49:57 -08:00
Greg Spencer
1811d57445
Implement hover support for mouse pointers. ( #24830 )
...
This implements support for hovering mouse pointers, so that mice connected to Android devices, and ChromeOS devices running Android apps will work properly.
It teaches flutter_test about hover events, which required changing how they are created and used.
Also modifies AnnotatedRegion to allow a region that can be located someplace other than just the origin.
Along with tests for all of the above.
Fixes #5504
2019-01-29 11:34:26 -08:00
Dan Field
bb5663d2d8
Add docs and sample for takeException ( #27140 )
...
* Add docs and sample for takeException
* fix sample
2019-01-27 09:43:09 -08:00
Dan Field
496c57386b
Update packages ( #27046 )
...
* Update packages
* Change test for isFile
2019-01-24 16:02:45 -08:00
jslavitz
cf4fc966f4
Transition Curve Fix ( #25488 )
...
* Changes Cupertino page transition curves to make paging animations more similar to those of native iOS
2019-01-22 12:46:39 -08:00
sjindel-google
4881777203
Fix behavior of handleDrawFrame() in benchmark mode. ( #25049 )
2019-01-22 11:46:14 +01:00
Michael Goderbauer
e4c8f1b993
3D SemanticsTree ( #25670 )
2019-01-16 10:29:00 -08:00
Michael Goderbauer
e8bfa81b70
Roll engine to 5983e34a3c0e1217da7e8bbe9f2fe685048fe259 ( #26596 )
2019-01-15 19:00:05 -08:00
Alexandre Ardhuin
868ff42821
fix doc-comment snippets ( #25579 )
2019-01-07 21:44:16 +01:00
Hans Muller
4857267e65
Updated Shrine demo ( #25674 )
2018-12-21 17:47:25 -08:00
jslavitz
3d8aec2b99
Adds force press gesture detector and recognizer ( #24554 )
...
* adds Force Press gesture detector and recognizer
2018-12-19 20:09:07 -08:00
Alexandre Ardhuin
32d65fef1c
fix some formatting issues ( #25474 )
2018-12-18 10:05:12 +01:00
Jonah Williams
f30029bae1
Run flutter tests through mini test engine when run directly (flutter run -t test_file) ( #24930 )
2018-12-12 12:51:16 -08:00
Gary Qian
dfd0229560
New locale resolution algorithm to use full preferred locale list, include scriptCode in Locale. ( #23583 )
2018-11-09 11:33:42 -08:00
Jonah Williams
9ecb4ce9a6
remove deprecated testing members ( #24115 )
2018-11-09 10:05:11 -08:00
Jonah Williams
2fc2581be4
unpin mockito ( #24021 )
2018-11-06 17:24:39 -08:00
Jonah Williams
ab2d0323a7
cleanup accessibility test skips in gallery ( #23977 )
2018-11-06 13:29:23 -08:00
Jonah Williams
a43e3a4a2f
Retry remove package:test from flutter ( #24007 )
2018-11-06 10:48:34 -08:00
Jonah Williams
23a7535a39
Revert "Remove package:test dependency from flutter_test ( #23755 )" ( #24004 )
...
This reverts commit 71e9bd6f25
2018-11-06 09:12:48 -08:00
Jonah Williams
71e9bd6f25
Remove package:test dependency from flutter_test ( #23755 )
2018-11-06 08:39:27 -08:00
Alexandre Ardhuin
344ebe02ff
avoid returning null for Future ( #23784 )
2018-11-05 16:38:23 +01:00
Hans Muller
dd30efa190
Revert "Restore "Flutter gallery: updated Shrine demo" ( #23878 )" ( #23888 )
...
This reverts commit 76a1abd4c7
2018-11-02 15:32:02 -07:00
Hans Muller
76a1abd4c7
Restore "Flutter gallery: updated Shrine demo" ( #23878 )
2018-11-02 14:33:10 -07:00
Jonah Williams
0b35937b13
Revert "Flutter gallery: updated Shrine demo ( #23539 )" ( #23848 )
...
This reverts commit 949cfcf172
2018-11-01 19:30:11 -07:00
Hans Muller
949cfcf172
Flutter gallery: updated Shrine demo ( #23539 )
2018-11-01 12:48:24 -07:00
Dinesh Ahuja
7fbb5b9f32
Create WidgetTester.ensureVisible(Finder) ( #22620 )
...
This is just a shorthand for
Scrollable.ensureVisible(tester.element(finder))
Fixes #8185
2018-10-18 12:17:47 -07:00
Alexandre Ardhuin
7ce28d1277
use Duration.zero ( #23218 )
2018-10-18 13:57:52 +02:00
Yegor
3fbd140e77
Use new mixin syntax for super-mixins ( #22870 )
...
This re-lands 3c56e6c
2018-10-17 13:10:05 -07:00
Alexandre Ardhuin
8b0de38ef8
fix upcoming lint avoid_returning_null_for_void ( #23190 )
2018-10-17 11:01:37 +02:00
Alexandre Ardhuin
936dea28da
enable lint prefer_void_to_null ( #23174 )
...
* enable lint prefer_void_to_null
* replace last Null by void
2018-10-17 08:09:29 +02:00
Alexandre Ardhuin
0fb84e96c7
Prefer void to null ( #22977 )
...
* Future<void> main
* Future<void>.delayed
* prefer_void_to_Null
* address review comments
2018-10-16 22:03:06 +02:00
Gary Qian
bdc3dda5f2
Add support for text shadows and roll engine (26 commits) ( #22449 )
...
* Add support for shadows in text.
* Use dart:ui Shadow as base class for Shadows
* Update lerp definition
* Roll engine 3ffa3629523..84fe4a9f7e24e4 - Text Shadows and update goldens for skia roll.
git log 50c2e69daff4e207c54e463d2304139985c7511c..32f417db0d566d354605305cb29c251276fa65ee --oneline --no-merges
32f417db0 Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (#6541 )
4ee77256c Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515 )" (#6537 )
964acafeb Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (#6536 )
d4bae4ca4 Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (#6535 )
ff93ccf47 Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (#6534 )
a4161c895 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (#6532 )
116072e46 Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (#6531 )
ef0b0f6e9 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (#6530 )
f46b7b971 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (#6529 )
9033c3902 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (#6528 )
e6887a412 Add missing imports for unicode/utf16.h (#6524 )
1242f6dfe Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (#6527 )
a1bbea77c Add a no-op platform view layer. (#6505 )
2bb3afad8 Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (#6526 )
75e875240 Fix the Mac embedder build (#6525 )
436f9707b Add version check for dismissable (#6522 )
7767c785b Provide a default GL function resolver in the embedder (#6523 )
32841dd89 Case-insensitive matching of family names for custom fonts (#6519 )
a9076c7e6 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (#6520 )
f2e7441b5 An API for loading fonts from a buffer provided by the application (#6508 )
05aac0f27 fix ResourceExtractor npe. (#6461 )
cf5a2a145 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (#6517 )
84fe4a9f7 Re-revert invalid line height tests (#6516 )
5f529566c Add support for text shadows (#6385 )
e44c10c96 Reland "Share engine layers with the framework" (#6412 ) (#6468 )
ba0449971 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515 )
2018-10-15 15:03:02 -07:00
Jonah Williams
313059cdb6
Add labeled tappable target guideline and gallery tests ( #22824 )
2018-10-11 15:05:10 -07:00
Alexandre Ardhuin
0e76cb4c10
prefer_void_to_null in flutter_test ( #22847 )
...
* prefer_void_to_null in flutter_test
* fix CI
2018-10-11 18:00:46 +02:00
Jonah Williams
fb7a5937ba
Basic scroll semantics support ( #21764 )
2018-10-09 14:16:28 -07:00
Andrew Davies
9ceb9ab305
[flutter_driver] Adds fuchsia compat for connect() ( #22633 )
...
Adds a Fuchsia compatibility function that allows for connecting to a
specific Isolate by name when running Flutter Driver on a Fuchsia
device. This will check over multiple Dart VM's in an attempt to find
an Isolate by its name.
2018-10-08 11:09:07 -07:00
Jonah Williams
cdf1cec902
add ability to match child semantics data ( #22001 )
2018-10-05 17:44:26 -07:00
Yegor
3184b7cb66
Revert "Use mixin syntax for Flutter's super-mixins ( #22435 )" ( #22748 )
...
This reverts commit 3c56e6c77d
2018-10-05 15:09:38 -07:00
Yegor
3c56e6c77d
Use mixin syntax for Flutter's super-mixins ( #22435 )
...
* first pass
* revert WidgetsBindingObserver
* disable prefer_mixin
* docs and more mixins
* newer engine; binding fixes
* upgrade dependencies
* fix test binding
* remove whitespace
* remove the obsolete `enableSuperMixins: true`
* upgrade dartdoc to 0.22.0
* temporarily use git version of dartdoc
* fix pub global activate syntax
* use dartdoc 0.23.0
2018-10-05 14:54:41 -07:00
Yegor
d91f1608c5
upgrade packages ( #22524 )
2018-10-01 14:42:53 -07:00
Alexandre Ardhuin
f62afdcf57
add missing type parameter on methods ( #22096 )
2018-10-01 21:29:08 +02:00
Dan Field
ea5435c2ef
Widgets app refactor ( #22269 )
...
* Refactor of cupertino/material/widgets app
* update docs
* Update tests for const
2018-09-25 13:57:12 -04:00
Dan Field
a52bd81560
Revert "Refactor of cupertino/material/widgets app ( #22161 )" ( #22249 )
...
This reverts commit 61cf946ba8
2018-09-25 00:25:50 -04:00
Dan Field
61cf946ba8
Refactor of cupertino/material/widgets app ( #22161 )
...
* Make CupertinoApp and MaterialApp both use WidgetsApp for Navigator
* Make CupertinoApp and MaterialApp const constructors
* Make WidgetsApp routes aware
* Update tests
2018-09-24 23:55:03 -04:00
Jonah Williams
8e70421913
Revert "Add RichText support to find.text" ( #22046 )
2018-09-19 13:51:35 -07:00
Jonah Williams
ff1f8dd143
Add RichText support to find.text ( #21964 )
2018-09-19 10:01:34 -07:00
Jacob Richman
ccd070a5b4
Add back screenshot extension that was temporarily disabled. ( #21828 )
...
Add back screenshot extension that was temporarily disabled.
Add matchesReferenceImage matcher to test that the screenshot extension
generates equivalent images to InspectorService.instance.screenshot.
2018-09-18 09:32:39 -04:00
Alexandre Ardhuin
e2d0b062d9
remove unnecessary ignore prefer_const_constructors ( #21934 )
2018-09-18 05:54:03 +02:00
Alexandre Ardhuin
a07d3719a1
enable lint prefer_generic_function_type_aliases ( #21680 )
2018-09-14 21:06:19 +02:00
Alexandre Ardhuin
d927c93310
Unnecessary new ( #20138 )
...
* enable lint unnecessary_new
* fix tests
* fix tests
* fix tests
2018-09-12 08:29:29 +02:00
Jonah Williams
fa0a857d02
Add material tap target size and text contrast test to gallery ( #21581 )
2018-09-11 08:27:32 -07:00
Alexandre Ardhuin
774ca2f197
enable lint avoid_void_async ( #21652 )
2018-09-11 07:14:04 +02:00
Jacob Richman
a2acc6a3e5
Revert "Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… ( #20637 )" ( #21395 )" ( #21448 )
...
This reverts commit 5b5a5b8228
2018-09-07 10:02:05 -07:00
Jonah Williams
908de76c17
Remove value listener from semantics bindings ( #21296 )
2018-09-07 09:24:08 -07:00
Jonah Williams
5b5a5b8228
Revert "Enable taking screenshots of arbitrary RenderObjects from a running a… ( #20637 )" ( #21395 )
...
This reverts commit 3306fc1042
2018-09-04 12:40:40 -07:00
Jacob Richman
3306fc1042
Enable taking screenshots of arbitrary RenderObjects from a running a… ( #20637 )
...
Enable taking screenshots of arbitrary RenderObjects from a running application from within the inspector.
Key functionality is in the added _ScreenshotPaintingContext class.
2018-09-04 10:50:04 -07:00
Todd Volkert
2f32166f4b
Update packges ( #21241 )
...
https://github.com/flutter/flutter/issues/19578
2018-08-30 18:16:23 -07:00
Jonah Williams
0e9cfe7df1
Address follow up to https://github.com/flutter/flutter/pull/20354 ( #21181 )
2018-08-29 16:48:23 -07:00
Ian Hickson
53b635817c
Re-enable missing_return ( #20844 )
2018-08-28 11:22:57 -07:00
