github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
NaN Commits 822 Branches 1,017 Tags 2 GiB
d3e0e03e2e
Commit Graph

6494 Commits

Author SHA1 Message Date
Ben Konyi
c3de901538
Serve DevTools when running flutter test (#123607) 
Also clean up messaging output by `flutter test` when `--start-paused` is provided.
 2023-03-30 11:51:08 -04:00
Sigurd Meldgaard
7b54a30e31
Notify about existing caches when preloading (#122592) 2023-03-30 16:20:33 +02:00
Jackson Gardner
b57c59b4a7
Invalidate the WebStaticAssets target if the web sdk changes. (#123739) 
Invalidate the `WebStaticAssets` target if the web sdk changes.
 2023-03-30 02:20:19 +00:00
Loïc Sharma
9f2ac97174
[Windows] Add version info migration (#123414) 
[Windows] Add version info migration
 2023-03-29 20:11:18 +00:00
Victoria Ashworth
fa01649a59
Update device selection to wait for wireless devices to load (#122932) 
Update device selection to wait for wireless devices to load
 2023-03-29 17:58:07 +00:00
Christopher Fujino
820ec70a8d
[flutter_tools] Remove --no-sound-null-safety #3 (#123297) 
[flutter_tools] Remove --no-sound-null-safety #3
 2023-03-29 17:56:23 +00:00
Jenn Magder
6e5a530737
Add flags to make App.framework work in app extension (#123618) 
Add flags to make App.framework work in app extension
 2023-03-28 23:10:06 +00:00
stuartmorgan
80cee59878
Don't rethrow Dart plugin registration exceptions (#122111) 
Don't rethrow Dart plugin registration exceptions
 2023-03-28 15:08:57 +00:00
Loïc Sharma
8f62e34267
[Focus] Add run key command to dump the focus tree (#123473) 
[Focus] Add run key command to dump the focus tree
 2023-03-28 00:33:39 +00:00
Andrew Kolos
66e6acbe9f
throw ToolExit when --web-port is an integer outside the valid TCP port range (#123269) 
throw `ToolExit` when `--web-port` is an integer outside the valid TCP port range
 2023-03-27 19:58:37 +00:00
Harry Terkelsen
2379b18f8d
Turn on --web-resources-cdn by default (#123425) 2023-03-24 14:33:58 -07:00
Janice Collins
81e9060968
Suppress analytics flag pass through to analysis server (#123235) 
Suppress analytics flag pass through to analysis server
 2023-03-24 19:59:15 +00:00
Dan Field
6fd59890c3
Ignore spam from SurfaceSyncer (#123262) 
Ignore spam from SurfaceSyncer
 2023-03-23 21:55:39 +00:00
Michael Goderbauer
31798757e7
replace some ._() constructors with class modifiers (#122765) 2023-03-23 12:29:18 -07:00
Ben Konyi
5a36bddd2b
Stop serving Observatory by default (#122419) 
Observatory can still be enabled by providing `--serve-observatory` or
invoking the `_serveObservatory` private service RPC via web socket or
HTTP.

Related to https://github.com/dart-lang/sdk/issues/50233
 2023-03-23 12:52:30 -04:00
Harry Terkelsen
897e3db40c
Inject the gstatic CanvasKit CDN URL by default in flutter build web (#122772) 2023-03-23 09:17:25 -07:00
Christopher Fujino
3736274a6d
Revert "[flutter_tools] Remove sound null safety flag (#123031)" (#123280) 
Revert "[flutter_tools] Remove sound null safety flag (#123031)"
 2023-03-22 22:53:49 +00:00
Michael Goderbauer
fda9ecfef7
Remove 1745 decorative breaks (#123259) 
Remove 1745 decorative breaks
 2023-03-22 21:12:22 +00:00
Lasse R.H. Nielsen
520cf363b3
Make custom Utf8Decoder replacement not extend platform class. (#123211) 
* Make custom `Utf8Decoder` replacement not extend platform class.

The Dart 3.0 class modifiers will make `Utf8Decoder`, and other
pure implementation classes, be `final`.

This replacement class does not need to extend the original
class, just like the `Utf8Codec` in the same file doesn't
extend the `Ut8Codec` from the platform libraries.

Instead it can just forward to a single `const` instance of the
original class.

* Forgot one constant

* Fix merge conflict.

---------

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
 2023-03-22 07:53:56 -07:00
Jason Simmons
d81e915780
Provide an ApplicationPackage to the flutter_tools logs command (#123149) 
Provide an ApplicationPackage to the flutter_tools logs command
 2023-03-22 14:51:39 +00:00
Christopher Fujino
28d707693b
toolexit on malformed yaml (#123167) 
[flutter_tools] toolexit on malformed yaml during gen-l10n
 2023-03-22 02:05:24 +00:00
Bartek Pacia
c40dd27681
Fix Gradle warning in a freshly flutter createed Android project (#122290) 
Fix Gradle warning in a freshly `flutter create`ed Android project
 2023-03-21 23:41:49 +00:00
Michael Goderbauer
06ed8e65a7
Enable prefer_mixin (#123159) 
Enable prefer_mixin
 2023-03-21 23:12:26 +00:00
Lau Ching Jun
7e4822d5d6
Use DeviceDiscoveryFilter correctly in ProxiedDevices. (#123144) 
Use DeviceDiscoveryFilter correctly in ProxiedDevices.
 2023-03-21 22:52:16 +00:00
Michael Goderbauer
25e38a2a87
Bump lower Dart SDK constraints to 3.0 & add class modifiers (#122546) 
Bump lower Dart SDK constraints to 3.0 & add class modifiers
 2023-03-21 20:21:58 +00:00
Christopher Fujino
7d767270b2
[flutter_tools] replace --no-analytics with --suppress-analytics (#123133) 
[flutter_tools] replace --no-analytics with --suppress-analytics
 2023-03-21 19:18:57 +00:00
Victoria Ashworth
9136a47458
Set plugin template minimum iOS version to 11.0 (#122625) 
Set plugin template minimum iOS version to 11.0
 2023-03-21 16:40:50 +00:00
Zachary Anderson
7e88acfb0e
[flutter_tool] Adds a flag to disable Impeller (#122960) 2023-03-20 22:23:23 -07:00
Christopher Fujino
f4c3facfdd
Revert "Revert "[flutter_tools] Remove sound null safety flag (#120936)" (#122909)" (#123031) 
[flutter_tools] Remove sound null safety flag #2
 2023-03-20 22:32:07 +00:00
Loïc Sharma
2312097731
[Tool] [Windows] Output app path on build completion (#122928) 
[Tool] [Windows] Output app path on build completion
 2023-03-20 20:11:07 +00:00
Loïc Sharma
3635a3048e
Revert "[Tool] [Windows] Output app path on build completion (#122858)" (#122926) 
Revert "[Tool] [Windows] Output app path on build completion"
 2023-03-17 21:29:12 +00:00
Loïc Sharma
80d6c10596
[Tool] [Windows] Output app path on build completion (#122858) 
[Tool] [Windows] Output app path on build completion
 2023-03-17 20:53:40 +00:00
Christopher Fujino
f6bc147c91
Revert "[flutter_tools] Remove sound null safety flag (#120936)" (#122909) 
This reverts commit 7c3088cf22.
 2023-03-17 11:31:48 -07:00
Christopher Fujino
7c3088cf22
[flutter_tools] Remove sound null safety flag (#120936) 
[flutter_tools] Remove sound null safety flag
 2023-03-17 17:48:35 +00:00
Christopher Fujino
69921495eb
Revert "Fix hot restart flake" (#122855) 
Landing revert on red to fix the build.
 2023-03-16 22:40:42 -07:00
Jackson Gardner
be97d03a25
Use depfile with dart2wasm to determine when to rebuild. (#122817) 
Use depfile with dart2wasm to determine when to rebuild.
 2023-03-16 23:13:04 +00:00
Christopher Fujino
7e151b4641
[flutter_tools] throw tool exit on invocation of flutter format (#121646) 
[flutter_tools] throw tool exit on invocation of flutter format
 2023-03-16 21:40:26 +00:00
Anna Gringauze
62171dfe38
Fix hot restart flake (#122776) 2023-03-16 13:11:55 -07:00
Greg Spencer
c2f5bf99f1
Add macos project auto migration code for FlutterApplication (#122336) 
Add macos project auto migration code for FlutterApplication
 2023-03-16 01:01:03 +00:00
Victoria Ashworth
27248d4b64
Separate attached and wireless devices (#122615) 
Separate attached and wireless devices
 2023-03-15 16:35:05 +00:00
Yegor
091104f8bc
[web] stop using deprecated jsonwire web-driver protocol (#122560) 
[web] stop using deprecated jsonwire web-driver protocol
 2023-03-14 18:25:23 +00:00
Bartek Pacia
37fc9ed260
[flutter_tools] Clean up boolArgDeprecated and stringArgDeprecated (#122184) 
[flutter_tools] Clean up `boolArgDeprecated` and `stringArgDeprecated`
 2023-03-13 21:20:19 +00:00
Victoria Ashworth
ee42a302ec
Move target devices logic to its own classes and file (#121903) 
Move target devices logic to its own classes and file
 2023-03-13 16:14:21 +00:00
Sigurd Meldgaard
1fd84f88e9
Always use user-level pub cache (#121802) 
Use the pub cache resolved by pub itself.
To add packages to the flutter.zip download they are packaged as tar.gz and added to the pub-cache on first run by using  `pub cache preload`.
 2023-03-13 08:38:17 +01:00
sigmundch
aaa9cead70
[tool][web] Pass invoker flag to dart2js. (#122344) 
[tool][web] Pass invoker flag to dart2js.
 2023-03-11 03:24:34 +00:00
Jim Graham
3f2cca8eeb
Adjust the minimum sdk version in the synthetic pkg for new Dart requirements (#122380) 
Manually landing to fix the Engine rolls. The change will not affect Google Testing.
 2023-03-10 09:23:33 -08:00
Tim Maffett
2e8c3468e7
fix devtool instructional messages after flutter build ... --analyze-size . Fixes #122229 (#122230) 
fix devtool instructional messages after `flutter build ... --analyze-size `.  Fixes #122229
 2023-03-09 22:29:50 +00:00
Navaron Bracke
57171a3fef
[flutter_tools] Add namespace getter in Android project; use namespace as fallback (#121416) 
[flutter_tools] Add namespace getter in Android project; use namespace as fallback
 2023-03-09 22:19:04 +00:00
stuartmorgan
62116f998b
Improve Dart plugin registration handling (#122046) 
Improve Dart plugin registration handling
 2023-03-09 21:33:38 +00:00
Jonas Uekötter
b9e925ab24
Use type promotion instead of access through a map (#122178) 
Use variable instead of multiple accesses through a map
 2023-03-08 20:35:50 +00:00
Reid Baker
fe9e819143
Create configOnly flag for android (#121904) 
Create configOnly flag for android
 2023-03-08 19:46:52 +00:00
Mouad Debbar
a9700ffdd5
Revert "[web:tools] always use CanvasKit from the cache when building web apps (#93002)" (#117693) 
Revert "[web:tools] always use CanvasKit from the cache when building web apps (#93002)"
 2023-03-08 19:45:51 +00:00
Bartek Pacia
f8524ead7c
delete FlutterCommand.intArg(), which is not used anywhere in the codebase (#122124) 
Delete `FlutterCommand.intArg()`, which is not used anywhere
 2023-03-08 00:19:06 +00:00
Mouad Debbar
95c2ad5047
[web] Ensure CanvasKit is served from the correct location (#121902) 
[web] Ensure CanvasKit is served from the correct location
 2023-03-07 21:38:35 +00:00
chunhtai
026adb8cc7
Adds vmservices for getting iOS build options (#121736) 
Adds vmservices for getting iOS build options
 2023-03-06 22:37:55 +00:00
Christopher Fujino
b1641749fc
pin flutter_plugin_android_lifecycle and roll other pub deps (#122043) 
pin flutter_plugin_android_lifecycle and roll other pub deps
 2023-03-06 21:51:07 +00:00
Lau Ching Jun
3e96dfc03e
Add backward compatibility in proxied_devices. (#122040) 
Add backward compatibility in proxied_devices.
 2023-03-06 21:46:57 +00:00
Seiya Kokushi
acc840e574
[tool] Proposal to multiple defines for --dart-define-from-file (#120878) 
[tool] Proposal to multiple defines for --dart-define-from-file
 2023-03-06 18:16:14 +00:00
Sigurd Meldgaard
7a28078509
Use dart pub instead of dart __deprecated pub (#121605) 2023-03-06 11:23:12 +01:00
Christopher Fujino
26b7456f88
[flutter_tools] remove late from update-packages command (#121891) 
[flutter_tools] remove late from update-packages command
 2023-03-03 22:38:19 +00:00
Chris Yang
b81b1e28a3
[flutter_tool] add enable-embedder-api flag (#121895) 
[flutter_tool] add enable-embedder-api flag
 2023-03-03 21:13:54 +00:00
Victoria Ashworth
cc26a1aa0c
Update device filtering and introduce isConnected and connectionInterface (#121359) 
Update device filtering and introduce isConnected and connectionInterface
 2023-03-03 18:06:16 +00:00
Danny Tuppeny
3494c08448
[flutter_tools/dap] Inform DAP client whether restart is supported (#121610) 
[flutter_tools/dap] Inform DAP client whether restart is supported
 2023-03-03 12:54:23 +00:00
Christopher Fujino
902dac4763
ensure no pub output while caching PubDependencies artifact (#121831) 
[flutter_tools] ensure no pub output while caching PubDependencies artifact
 2023-03-03 02:40:14 +00:00
Kevin Moore
a7f9ebcc49
Reorganize CLI flags for build web (#121837) 
Reorganize CLI flags for `build web`
 2023-03-03 00:59:16 +00:00
Kevin Moore
a8cc95e36d
flutter_tool: only enable wasm compile in master channel (#121755) 
flutter_tool: only enable wasm compile in master channel
 2023-03-02 22:21:50 +00:00
Kevin Moore
14b3f740c7
flutter_tool: DRY up features that are fully enabled (#121754) 
flutter_tool: DRY up features that are fully enabled
 2023-03-02 01:14:48 +00:00
Kevin Moore
0cd6f1fbdb
[flutter_tool] advertise the default value for --dart2js-optimization (#121621) 
[flutter_tool] advertise the default value for --dart2js-optimization
 2023-03-01 01:17:56 +00:00
Ben Konyi
ecd7518df5
Reland "Remove references to Observatory (#118577)" (#121606) 
This reverts commit 275ab9c69b.
 2023-02-28 11:57:04 -05:00
Nabeel Parkar
e5a382ec92
Migrate activation issue template to Github form issues (#119916) 
Migrate activation issue template to Github form issues
 2023-02-28 08:08:01 +00:00
Flutter GitHub Bot
cf4ef28b94
Roll pub packages (#121569) 
Roll pub packages
 2023-02-28 03:10:07 +00:00
Todd Volkert
c4ef072369
Cocoapods ffi error can be in stdout or stderr (#121470) 
Cocoapods ffi error can be in stdout or stderr
 2023-02-28 00:11:29 +00:00
Michael Goderbauer
275ab9c69b
Revert "Reland "Remove references to Observatory (#118577)" (#121215)" (#121555) 
Revert "Reland "Remove references to Observatory (#118577)""
 2023-02-27 23:46:53 +00:00
Danny Tuppeny
06952ba254
[flutter_tools] Add support for URI formats like ?line=x for "flutter test" (#119740) 
* [flutter_tools] Add support for URI formats like ?line=x for "flutter test"

* Remove unnecessary function

* Handle parsing absolute paths on Windows

* Use Windows-style paths when running on Windows

* Fix paths in isFile

* Remove unnecessary clear
 2023-02-27 19:13:00 +00:00
Christopher Fujino
5c334d10df
Revert "show web-server in flutter devices (#121373)" (#121532) 
Revert "[flutter_tools] show web-server in flutter devices"
 2023-02-27 18:44:09 +00:00
Greg Price
516b60bda1
Give error on too many arguments to flutter config (#121494) 
Give error on too many arguments to `flutter config`
 2023-02-27 17:22:20 +00:00
Ben Konyi
fbae472fc3
Reland "Remove references to Observatory (#118577)" (#121215) 
This reverts commit 298d8c76ba.
 2023-02-27 09:26:43 -05:00
Christopher Fujino
6b3f95832a
show web-server in flutter devices (#121373) 
[flutter_tools] show web-server in flutter devices
 2023-02-24 23:52:06 +00:00
Lioness100
26b6c1bedd
Fix typos (#121171) 
* Fix typos

* lowercase animated & opacity

* Undo typo fix

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
 2023-02-23 19:43:21 +00:00
David Iglesias
a463bb82c4
[tool][web] Makes flutter.js more G3 friendly. (#120504) 
* Allow any JS file in flutter loader.

* Nag only if service worker API is completely unavailable.

* Add info about Secure Contexts if that may be the reason why serviceworker is not available.

* Update sanity test.

* If service worker settings are null, do not even check if the API is available.
 2023-02-21 20:51:37 +00:00
Enguerrand ARMINJON
6259b690f6
feature/clean-a-specific-scheme: Add this-scheme new flag for clean command (#116733) 
Co-authored-by: Enguerrand_ARMINJON_MAC_2 <earminjon@sqli.com>
 2023-02-21 17:35:13 +00:00
Mateus Felipe C. C. Pinto
ebbc94bc2b
allow passing --file-reporter option to test running refs #69425 (#120716) 
* allow passing --file-reporter option to test running refs #69425

* Add trailing comma to help to meet style requirements

* Add space between tests for clarity

---------

Co-authored-by: daniel-v <dvarga@skawa.hu>
 2023-02-21 17:24:11 +00:00
Ian Hickson
6205c110d6
Remove "note that" in our documentation (as per style guide) (#120842) 
* lerp documentation

* Remove Note, Note That from repo

* Improve BorderSide documentation.

* apply review comments
 2023-02-17 22:27:33 +00:00
Jenn Magder
9fe556705b
Print sub process that failed to run in tool (#120999) 2023-02-17 22:02:51 +00:00
Casey Hillers
298d8c76ba
Revert "Remove references to Observatory (#118577)" (#120929) 
This reverts commit 2df140f40d.
 2023-02-16 21:28:30 -08:00
Christopher Fujino
c6b636fa51
[flutter_tools] Replace Future.catchError() with Future.then(onError: ...) (#120637) 
* wip run_local_linter.dart

* get run_local_linter.dart working

* slow working implementation

* speed up run_local_linter.dart

* fix run_local_linter.dart

* remove catchError

* another fix

* fix another

* fix

* more fixes

* fix moar

* fix moar

* fix

* finish

* fix tests

* clean up further

* code review

* delete run_local_linter.dart
 2023-02-15 19:03:00 +00:00
Jason Simmons
8d150833b0
Use the impellerc GLES output flag when compiling shaders for Android (#120647) 2023-02-15 19:01:00 +00:00
Ian Hickson
d29668ddb2
Improve network resources doctor check (#120417) 
...and various other minor cleanup:

* Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing.

* Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too.

* Made the logger delete the slow warning when it's finished.

* Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'.

* Added a debug toString to ValidationResult for debugging purposes (not used).

* In http_host_validator:

  - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev).
  - Added GitHub as a tested host since when you run `flutter` we hit that immediately.
  - Renamed the check "Network resources".
  - Updated the `slowWarning` of the check to say which hosts are pending.
  - Removed all timeout logic. Timeouts violate our style guide.
  - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient.
  - Replaced the `_HostValidationResult` class with `String?` for simplicity.
  - Improved the error messages to be more detailed.
  - Removed all checks that dependened on the stringification of exceptions. That's very brittle.
  - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks).
  - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result.
  - Replaced a lot of list-filtering logic with just a single for loop to check the results.
  - Replaced code that added a constant to a known-empty list with just returning a constant list.
  - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
 2023-02-15 00:02:09 +00:00
godofredoc
9d94a51b60
Move linux-x64-flutter-gtk.zip to linux-x64-debug location. (#120658) 
* Move linux-x64-flutter-gtk.zip to linux-x64-debug location.

linux-x64-flutter-gtk.zip is being uploaded twice to linux-x64-debug
and linux-x64 as part of making a soft transition to use linux-x64-debug
location. This PR starts using the copy inside linux-x64-debug to later
remove the duplicated upload.

* Also move arm64.

* Do not override output dir.
 2023-02-15 00:00:23 +00:00
Tae Hyung Kim
becb6bd00a
Fix message type inconsistency between locales (#120129) 
* init

* fix error handling

* fix issue

* lint?

* error handling tests

* lint
 2023-02-13 23:05:57 +00:00
Ben Konyi
2df140f40d
Remove references to Observatory (#118577) 
Observatory is being deprecated for Dart 3.0 so it should no longer be
referenced in tooling messaging / flags.

See https://github.com/dart-lang/sdk/issues/50233
 2023-02-13 14:29:30 -05:00
Mouad Debbar
d5dbcb7085
Revert "Revert "[web] Move JS content to its own .js files (#117691)" (#120275)" (#120363) 
This reverts commit 0fb4406c30.
 2023-02-10 21:24:08 +00:00
Pascal Welsch
25c2c22d29
Delete Chrome temp cache after closing (#119062) 
* Delete Chrome temp cache after closeing

* Update packages/flutter_tools/lib/src/web/chrome.dart

Co-authored-by: Christopher Fujino <fujino@google.com>

---------

Co-authored-by: Christopher Fujino <fujino@google.com>
 2023-02-10 17:39:58 +00:00
Ivan Dlugos
f945ad99c3
Resolve dwarf paths to enable source-code mapping of stacktraces (#114767) 
* feat: add "--resolve-dwarf-paths" to gen_snapshot

* chore: update tests
 2023-02-09 23:05:44 +00:00
Michael Thomsen
c8c8621416
Clean up null safety messages (#120350) 2023-02-09 19:40:32 +01:00
Christopher Fujino
1546fa08d3
[flutter_tools] toolExit on sdkmanager exit during doctor --android-licenses (#120330) 
* tool exit on sdk manager exit and add test

* be more specific about error message
 2023-02-09 18:34:02 +00:00
Daco Harkes
0521c60cd2
Support --local-engine=ios_debug_sim (#119524) 
Fixes:

* https://github.com/flutter/flutter/issues/119523
 2023-02-09 18:32:52 +00:00
Kevin Chisholm
0fb4406c30
Revert "[web] Move JS content to its own .js files (#117691)" (#120275) 
This reverts commit e03029ef6a.
 2023-02-08 18:17:29 -06:00
Loïc Sharma
ef854a3db0
[Tool] [Windows] Output build duration (#120311) 
* [Tool][Windows] Output build duration

* Tweak

* Format
 2023-02-08 23:24:42 +00:00
Andrew Kolos
4a9660881e
Reland "Stop recursively including assets from asset directories" (#120312) 
* stop recursively including assets from asset directories

* remove unused imports

* lint
 2023-02-08 21:41:19 +00:00
Mouad Debbar
7f578fb01f
Revert "Stop recursively including assets from asset folders (#120167)" (#120283) 
This reverts commit da36bd6fc0.
 2023-02-08 10:42:02 -05:00
Christopher Fujino
aed9b4adce
Revert "Revert "Fix unable to find bundled Java version (#119244)" (#119981)" (#120107) 
This reverts commit f7c2bd05f0.
 2023-02-07 21:42:20 +00:00
Christopher Fujino
1089588863
un-pin package:intl (#119900) 2023-02-07 12:10:18 -08:00
Andrew Kolos
da36bd6fc0
Stop recursively including assets from asset folders (#120167) 
* add test

* fix

* use preexisting testFileSystem

* fix variant tests

* Revert "use preexisting testFileSystem"

This reverts commit b6df288ef4.

* nit: grammar
 2023-02-07 16:20:23 +00:00
Mouad Debbar
e03029ef6a
[web] Move JS content to its own .js files (#117691) 2023-02-07 10:51:52 -05:00
林洵锋
ec524ed068
Fix flutter_tools stuck when using custom LLDB prompt (#119443) 
* Fix flutter_tools stuck when using custom LLDB prompt

* Remove trailing space character

* Fix local variable name

* Add comment

* Remove trailing space character

* Update packages/flutter_tools/lib/src/ios/ios_deploy.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Update packages/flutter_tools/lib/src/ios/ios_deploy.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Remove trailing space character

---------

Co-authored-by: Jenn Magder <magder@google.com>
 2023-02-06 22:50:07 +00:00
Ben Konyi
47a0674651
Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119737) 
This reverts commit 254a796bc3.
 2023-02-06 09:23:35 -05:00
Christopher Fujino
b8f5394a5c
[flutter_tools] Fix Future error handling ArgumentError in doctor --android-licenses (#119977) 
* wip

* write test

* make error handling printError

* remove diff
 2023-02-05 07:06:19 +00:00
godofredoc
f7c2bd05f0
Revert "Fix unable to find bundled Java version (#119244)" (#119981) 
This reverts commit 57fd50f84e.
 2023-02-04 02:57:53 +00:00
crasowas
57fd50f84e
Fix unable to find bundled Java version (#119244) 2023-02-03 18:04:04 -08:00
Christopher Fujino
9a7e18701e
[flutter_tools] fix Cannot delete file ENOENT from fuchsia_asset_builder (#119867) 
* fix

* add test
 2023-02-03 19:24:41 +00:00
Kevin Moore
a27802e2db
flutter_tool: remove explicit length header in HTTP response (#119869) 
This is already handled by pkg:shelf
There is some subtlety with String here, since String.length might not
align with the size in bytes over the wire, depending on the contents
and the encoding

Best to just let pkg:shelf handle it
 2023-02-03 01:27:23 +00:00
Christopher Fujino
d820aec786
Manual pub roll with dwds fix (#119575) 
* roll packages

* fix dwds

* empty

---------

Co-authored-by: fluttergithubbot <fluttergithubbot@gmail.com>
 2023-02-02 21:38:08 +00:00
Danny Tuppeny
8387c2388b
[flutter_tools] Use base DAP detach and ensure correct output (#119076) 2023-02-02 13:28:12 -08:00
Mouad Debbar
d4b6898478
[web] Put all index.html operations in one place (#118188) 
* [web] Put all index.html operations in one place

* review comments

* fix build

* change quotes

* fix test
 2023-02-02 19:49:18 +00:00
Sigurd Meldgaard
ca0596e41d
Fix pub get --unknown-flag (#119622) 2023-02-02 16:22:39 +01:00
Jesús S Guerrero
f767f860eb
check if directory exists before listing content (#119748) 2023-02-02 03:02:11 +00:00
Ian Hickson
4c99da6c56
Avoid printing blank lines between "Another exception was thrown:" messages. (#119587) 2023-02-01 23:57:54 +00:00
Alex Li
4ae2d3b6df
🔥 Do not format the messages file for gen-l10n (#119596) 
* 🔥 Do not format the messages file

* ✅ Add test

* ✅ Add the link to the test

* ✅ Respect the path separator from the file system

* ✅ Add the untranslated messages file existence test
 2023-02-01 23:45:38 +00:00
Zachary Anderson
254a796bc3
Revert "Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)" (#119729) 
This reverts commit 7477d7ac79.
 2023-02-01 09:19:48 -08:00
Alex Li
8d0af36798
🥅 Produce warning instead of error for storage base url overrides (#119595) 
* 🥅 Only log warning for storage base url

* ✅ Add test

* ✅ Add the link to the test

* ✅ Remove the test

* ✅ Remove the extra import
 2023-02-01 03:49:31 +00:00
Tae Hyung Kim
3884381415
Make gen-l10n error handling independent of logger state (#119644) 
* init

* lint

* lint again
 2023-01-31 15:28:27 -08:00
Victoria Ashworth
f6b0c6ddef
Use first Dart VM Service found with mDNS if there are duplicates (#119545) 
* fix when duplicate mdns results are found

* put mdns auth code in it's own function and update tests

* add comments, refactor auth code parsing, other small tweaks
 2023-01-31 17:48:19 +00:00
Chris Bracken
d272a3ab80
Reland: [macos] add flavor options to tool commands (#119564) 
* Reland: [macos] add flavor options to tool commands

Adds --flavor option to flutter run and flutter build. Running against
preexisting devicelab flavor tests for feature parity between macOS,
iOS, and Android.

This relands #118421 by alex-wallen which was reverted in #118858 due to
the following test failures:

The bail-out with "Host and target are the same. Nothing to install."
added in `packages/flutter_tools/lib/src/commands/install.dart`
triggered failures in the following tests, which unconditionally attempt
to install the built app, which is unsupported on desktop since the
host and target are the same:

* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout

Fixes #64088

* Partial revert: eliminate install check on desktop

The original flavour support patch included a check that triggered a
failure when flutter install is run on desktop OSes. This was
intentional, since the host and target devices are the same and
installation is unnecessary to launch the app on currently-supported
desktop OSes.

Note that Windows UWP apps *do* require installation to run, and we used
to have an install command for those apps, though UWP is no longer
supported.

Since that part of the change was orthogonal to flavour support itself,
I'm reverting that component of the change and we can deal with it
separately if so desired.
 2023-01-31 17:37:46 +00:00
Danny Tuppeny
67d07a6de4
[flutter_tools] Fix parsing of existing DDS URIs from exceptions (#119506) 
* [flutter_tools] Fix parsing of existing DDS URIs from exceptions

Fixes #118609.

* Fix formatting

Co-authored-by: Christopher Fujino <fujino@google.com>

* Fix formatting

Co-authored-by: Christopher Fujino <fujino@google.com>

---------

Co-authored-by: Christopher Fujino <fujino@google.com>
 2023-01-31 17:36:44 +00:00
Loïc Sharma
18c7f8a278
Fix typo in --machine help text (#119563) 2023-01-30 22:46:48 +00:00
Ben Konyi
7477d7ac79
Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529) 
* Reland "Add --serve-observatory flag to run, attach, and test (#118402)"

This reverts commit 86ab01d2bd.

* Fix flaky failures

* Fix VM service disappearing failure
 2023-01-30 21:00:18 +00:00
Elias Yishak
458b298f98
Refactoring to use ver command instead of systeminfo (#119304) 
* refactoring to use `ver` command instead of `systeminfo`

* fix tests to match new approach

* adding another valid validator using brazil locale text

* refactor tests to use generic fake class `ver` arg + showing output from `ver` if unsuccessful

* update reason text in test

* fix reason text to be hard coded
 2023-01-30 19:29:13 +00:00
Jonah Williams
4dbb573ff0
[flutter_tools] remove usage of remap samplers arg (#119346) 2023-01-27 18:49:49 +00:00
Zachary Anderson
86ab01d2bd
Revert "Add --serve-observatory flag to run, attach, and test (#118402)" (#119302) 
This reverts commit 6cd4fa45e2.
 2023-01-26 16:43:39 -08:00
Harry Terkelsen
42bd5f2bd1
Download platform-agnostic Flutter Web SDK in the flutter_tool (#118654) 2023-01-26 14:21:05 -08:00
godofredoc
c9affdba9d
Move windows-x64-flutter.zip to windows-x64-debug location. (#119177) 
The dependency is currently uploaded to two different locations. This
change is required to remove the duplicate uploads and their
corresponding tech debt.
 2023-01-26 05:25:02 +00:00
Tae Hyung Kim
02a9c151f6
Fix lexer issue where select/plural/other/underscores cannot be in identifier names. (#119190) 2023-01-25 15:31:38 -08:00
Ahmed Ashour
1fd71de0c5
Remove superfluous words from comments (#119055) 
* Remove superfluous words from comments.

* Revert `win32_window.h`

Which seems to come from `gallery`
 2023-01-25 20:23:24 +00:00
Ben Konyi
6cd4fa45e2
Add --serve-observatory flag to run, attach, and test (#118402) 
This flag will allow for Observatory to be served by the VM service once it is disabled by default in the Dart SDK.
 2023-01-25 12:46:08 -05:00
Victoria Ashworth
81052a7d36
Add usage event to track when a iOS network device is used (#118915) 
* Add usage event to track when a iOS network device is used

* update usage event to track percentage of iOS network vs usb devices, update and fix tests

* refactor tracking to happen in usageValues with a custom dimension
 2023-01-25 10:57:12 -06:00
Gary Qian
5dabe102a2
Fix path name to discover debug apk on add2app builds (#117999) 2023-01-24 13:19:09 -08:00
Nicholas Shahan
3735231841
Cleanup old Dart SDK layout compatibility (#118819) 
The changes to the Dart SDK have rolled so the backward compatibility
is no longer needed.
 2023-01-24 09:22:13 -08:00
Ahmed Ashour
c35efdaa68
Remove superfluous words. (#119008) 
* Remove superfluous words.

* Update packages/flutter/lib/src/widgets/slotted_render_object_widget.dart

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
 2023-01-24 01:57:00 +00:00
Michael Goderbauer
38630b6bd1
Remove unnecessary null checks in flutter_tool (#118857) 
* dart fix --apply

* manual fixes

* fix after merge conflicts

* review
 2023-01-23 21:43:08 +00:00
Mouad Debbar
3bf79607dd
[web] Fix paths fetched by flutter.js (#118684) 2023-01-23 15:02:58 +00:00
Victoria Ashworth
a07e8a6ac4
[reland] Support wireless debugging (#118895) 
* Reland "Support iOS wireless debugging (#118104)"

This reverts commit cbf2e16892.

* Remove device loading status
 2023-01-20 19:02:37 +00:00
Alexander Markov
492d57262f
Cleanup obsolete --compact-async compiler option (#118894) 2023-01-20 09:48:26 -08:00
Jenn Magder
030288d33b
Revert "[macos] add flavor options to commands in the flutter_tool (#118421)" (#118858) 
This reverts commit 73096fd96e.
 2023-01-20 03:46:45 +00:00
Alex Wallen
73096fd96e
[macos] add flavor options to commands in the flutter_tool (#118421) 
* Add new macos target configured for flavors

* Rename Free App copy-Info.plist to Free App Info.plist

* Remove bogus entitlements

* Remove Generated.xcconfig

* Audit project.pbxproj

* Remove unused configs

* share one info.plist

* Modify scheme so that paid app works

* Codesign automatic

* Pipe flavor as scheme into xcodebuild

* Ignore incoming flavor string

* pipe flavor for flutter run to work

* Add devicelab tests

* Error if host and target device are same for flutter install desktop

* Avoid bang (!) by promoting a local.

Co-authored-by: Jenn Magder <magder@google.com>

* Add supportsInstall property

* Override  in test classes

* Add install test on macOS

* Refactor application_package and add tests for package directory

Co-authored-by: a-wallen <stephenwallen@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
 2023-01-19 23:52:16 +00:00
Danny Tuppeny
09bd0f6613
Support logging 'flutter run' communication to DAP clients (#118674) 
* Support logging 'flutter run' communication to DAP clients

Fixes https://github.com/Dart-Code/Dart-Code/issues/4266.

* Fix test
 2023-01-19 23:50:33 +00:00
David Landeros
c5ceff11dd
[flutter_tools] Ensure service worker starts caching assets since first load (#116833) 
* [Flutter_tools] Ensure service worker starts caching assets since the first launch

* [flutter_tools] add comment to give some context on self.clients.claim()

* [flutter_tools] add comment to give some context on self.clients.claim()
 2023-01-19 21:52:52 +00:00
Alex Wallen
1dd7f45bfb
Add build macos --config-only option. (#118649) 
Co-authored-by: a-wallen <stephenwallen@google.com>
 2023-01-19 21:29:17 +00:00
Jenn Magder
cbf2e16892
Revert "Support iOS wireless debugging (#118104)" (#118826) 
This reverts commit 5cd2d4c61e.
 2023-01-19 12:31:53 -08:00
Victoria Ashworth
5cd2d4c61e
Support iOS wireless debugging (#118104) 
* setup wireless debugging to use device IP

* fix tests

* fix unused var and missing annotation

* remove unneeded try catch

* remove commented out line, change null to package id

* better way to get package id

* update mDNS lookup to continously check for server, add messaging if takes too long to find observatory url, update flutter drive to enable publish-port if using network device

* Refactor mDNS Discovery to poll for observatories and better handle multiple instances of the same app. Update drive command to make publish-port more stable. Update attach for iOS to only use Protocol Discovery if applicable, run mDNS and Protocol Discovery simultaneously, handle --debug-port/--debug-url/--device-vmservice-port, continously poll for obseravtories with mDNS, include port in error message when mutliple available

* add and update comments, use logger spinner intead of timer in flutter attach, other small improvements

* add newline to message so next log won't be on same line

* fix install/waiting for permission status progress so it doens't double print the time it took.

* only print backtrace if observatory times out on a physical usb connected device

* fix test

* Update related references from Observatory to Dart VM Service

* fix test
 2023-01-19 20:00:21 +00:00