Ian Hickson
f630f90d6d
Revert "enable lint unnecessary_const ( #19342 )" ( #19423 )
...
This reverts commit cc1cf13eec
2018-07-16 13:30:27 -07:00
Alexandre Ardhuin
cc1cf13eec
enable lint unnecessary_const ( #19342 )
2018-07-16 21:43:48 +02:00
Chris Bracken
2ae48845a8
Revert elimination of Dart 1 ( #18460 )
...
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
from source, flutter_platform.dart automatically runs a kernel compile when
operating in Dart 2 mode, but this assumes a functional Dart SDK is available
in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
directory with an empty temp dir.
Remaining work is:
1. Get the frontend server building as a dependency on Fuchsia.
2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
This also reverts migration to Dart 2 typedef syntax.
This reverts commit 6c56bb2#18362 )
This reverts commit 3daebd0#18316 )
2018-06-13 12:46:39 -07:00
Alexandre Ardhuin
e45836f271
enable lint avoid_field_initializers_in_const_classes ( #18415 )
2018-06-13 07:20:18 +02:00
Greg Spencer
6c56bb2420
Update typedef syntax to use Function notation and turn on lint for old notation. ( #18362 )
...
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
2018-06-11 15:51:45 -07:00
Alexandre Ardhuin
09276bea25
enable lint prefer_equal_for_default_values ( #18156 )
2018-06-05 08:50:40 +02:00
Alexandre Ardhuin
6e06fd2d1b
update some lints comments ( #18058 )
2018-05-31 17:49:28 +02:00
Alexandre Ardhuin
b7fd1d8b8d
add missing lints available in 0.1.51 ( #18034 )
2018-05-31 08:33:13 +02:00
Greg Spencer
b921fdc58e
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. ( #18035 )" ( #18041 )
...
This reverts commit 3258602073
2018-05-30 13:51:14 -07:00
Greg Spencer
3258602073
Update typedef syntax to use Function notation and turn on lint for old notation. ( #18035 )
...
Fixes #18028
Just changes typedef declarations, no logic changes.
2018-05-30 12:13:58 -07:00
Devon Carew
09dec7f508
re-write flutter analyze to use the analysis server ( #16979 )
...
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server
2018-05-10 09:48:40 -07:00
Alexandre Ardhuin
c103fd0c02
disable avoid_private_typedef_functions lint ( #16495 )
2018-04-16 22:43:47 +02:00
Devon Carew
071485258f
Revert "re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server ( #16281 )" ( #16482 )
...
This reverts commit 2f41ea546f
2018-04-11 16:49:38 -07:00
Devon Carew
2f41ea546f
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server ( #16281 )
...
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server
2018-04-11 14:50:36 -07:00
Alexandre Ardhuin
f8998091c8
Add new lints added by linter-0.1.45 and linter-0.1.46 ( #16094 )
...
* add new lints from linter-0.1.45
* add new lints from linter-0.1.46
2018-04-03 08:51:23 +02:00
Alexandre Ardhuin
061352918b
enable lint avoid_relative_lib_imports ( #15780 )
2018-03-22 07:56:18 +01:00
Alexandre Ardhuin
217b2bdaa1
add new lints of linter-0.1.44 and enable unnecessary_parenthesis ( #15585 )
2018-03-21 07:10:14 +01:00
Alexandre Ardhuin
3961306bad
enable lints prefer_const_declarations and prefer_const_literals_to_create_immutables ( #14848 )
2018-03-09 14:37:06 -08:00
Alexandre Ardhuin
fe26c9d87b
complete lint list for linter-0.1.43 ( #14707 )
2018-02-16 07:44:24 +01:00
Alexandre Ardhuin
b8fcc96265
activate lint prefer_bool_in_asserts ( #14708 )
2018-02-15 06:14:13 +01:00
Michael Thomsen
62ea62a729
Remove enableAssertInitializer from analysis options as it's not needed in Dart 2 ( #14042 )
2018-01-11 16:52:34 +01:00
Alexandre Ardhuin
c358898a76
try lint avoid_unused_constructor_parameters ( #13250 )
2017-11-30 09:20:53 +01:00
Alexandre Ardhuin
1d7a22fba0
sort lints to make maintenance easier ( #13231 )
2017-11-29 07:54:44 +01:00
Michael Thomsen
5ecbc92b1a
Update tools reference ( #13151 )
2017-11-23 09:17:29 +01:00
Alexandre Ardhuin
aefc62f8f3
try some lints ( #12719 )
...
* try some lints
* remove avoid_returning_this rule
2017-11-10 07:49:44 +01:00
Alexandre Ardhuin
436aa93086
enable lint avoid_classes_with_only_static_members ( #12602 )
2017-11-09 07:12:36 +01:00
Alexandre Ardhuin
15601fe55c
Enable lint prefer asserts in initializer lists ( #12903 )
...
* enable lint prefer_asserts_in_initializer_lists
* enable --assert-initializer
2017-11-08 22:59:49 +01:00
Alexandre Ardhuin
c9b94e1412
enable lint prefer_const_constructors_in_immutables ( #12693 )
...
* enable lint prefer_const_constructors_in_immutables
* remove LabeledGlobalKey._
2017-10-25 11:20:36 +02:00
Alexandre Ardhuin
28366002d9
enable lint prefer_foreach ( #12674 )
...
* enable lint prefer_foreach
* fix tests
2017-10-25 08:25:44 +02:00
Alexandre Ardhuin
872d83a3c5
enable lint prefer_conditional_assignment ( #12694 )
2017-10-25 08:18:26 +02:00
Alexandre Ardhuin
1fce14a31c
enable lint prefer_single_quotes ( #12665 )
2017-10-22 18:11:36 +02:00
Alexandre Ardhuin
ce6f8d3a83
comment some lint exclusions ( #12601 )
2017-10-19 08:33:01 +02:00
Alexandre Ardhuin
700dc9f752
enable lint avoid_function_literals_in_foreach_calls ( #12607 )
2017-10-19 08:16:16 +02:00
Alexandre Ardhuin
0783ec906b
Enable lints ( #11891 )
...
* enable lint prefer_final_fields
* enable lint recursive_getters
* enable lint unnecessary_overrides
2017-09-01 22:18:51 +02:00
Alexandre Ardhuin
bb4f4070f9
Prefer const constructors ( #11853 )
...
* upgrade to linter-0.1.35
* re-enable lint prefer_const_constructors
* address review comments
2017-08-31 08:55:21 +02:00
Dan Rubel
3a31c35ba0
Rename .analysis_options to analysis_options.yaml ( #11594 )
2017-08-15 08:46:42 -04:00
