Mouad Debbar
e03029ef6a
[web] Move JS content to its own .js files ( #117691 )
2023-02-07 10:51:52 -05:00
林洵锋
ec524ed068
Fix flutter_tools stuck when using custom LLDB prompt ( #119443 )
...
* Fix flutter_tools stuck when using custom LLDB prompt
* Remove trailing space character
* Fix local variable name
* Add comment
* Remove trailing space character
* Update packages/flutter_tools/lib/src/ios/ios_deploy.dart
Co-authored-by: Jenn Magder <magder@google.com>
* Update packages/flutter_tools/lib/src/ios/ios_deploy.dart
Co-authored-by: Jenn Magder <magder@google.com>
* Remove trailing space character
---------
Co-authored-by: Jenn Magder <magder@google.com>
2023-02-06 22:50:07 +00:00
Ben Konyi
47a0674651
Reland "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119737 )
...
This reverts commit 254a796bc3
2023-02-06 09:23:35 -05:00
Christopher Fujino
b8f5394a5c
[flutter_tools] Fix Future error handling ArgumentError in doctor --android-licenses ( #119977 )
...
* wip
* write test
* make error handling printError
* remove diff
2023-02-05 07:06:19 +00:00
Brandon DeRosier
f10e625eb2
De-flake adapter integration test ( #120016 )
2023-02-04 15:29:59 -08:00
godofredoc
f7c2bd05f0
Revert "Fix unable to find bundled Java version ( #119244 )" ( #119981 )
...
This reverts commit 57fd50f84e
2023-02-04 02:57:53 +00:00
crasowas
57fd50f84e
Fix unable to find bundled Java version ( #119244 )
2023-02-03 18:04:04 -08:00
Christopher Fujino
9a7e18701e
[flutter_tools] fix Cannot delete file ENOENT from fuchsia_asset_builder ( #119867 )
...
* fix
* add test
2023-02-03 19:24:41 +00:00
Kevin Moore
a27802e2db
flutter_tool: remove explicit length header in HTTP response ( #119869 )
...
This is already handled by pkg:shelf
There is some subtlety with String here, since String.length might not
align with the size in bytes over the wire, depending on the contents
and the encoding
Best to just let pkg:shelf handle it
2023-02-03 01:27:23 +00:00
Flutter GitHub Bot
cfdc35859e
roll packages ( #119865 )
2023-02-02 23:59:49 +00:00
Christopher Fujino
d820aec786
Manual pub roll with dwds fix ( #119575 )
...
* roll packages
* fix dwds
* empty
---------
Co-authored-by: fluttergithubbot <fluttergithubbot@gmail.com>
2023-02-02 21:38:08 +00:00
Danny Tuppeny
8387c2388b
[flutter_tools] Use base DAP detach and ensure correct output ( #119076 )
2023-02-02 13:28:12 -08:00
Mouad Debbar
d4b6898478
[web] Put all index.html operations in one place ( #118188 )
...
* [web] Put all index.html operations in one place
* review comments
* fix build
* change quotes
* fix test
2023-02-02 19:49:18 +00:00
Michael Goderbauer
b0f1714b7b
Make Flex,Row,Column const for real ( #119673 )
...
* Make Flex,Row,Column const for real
* dart fix --apply
* fix snippets
* fix integration test
* add comment
2023-02-02 19:33:57 +00:00
Sigurd Meldgaard
ca0596e41d
Fix pub get --unknown-flag ( #119622 )
2023-02-02 16:22:39 +01:00
Jesús S Guerrero
f767f860eb
check if directory exists before listing content ( #119748 )
2023-02-02 03:02:11 +00:00
Greg Spencer
2ecf4ae962
Update the counter app to enable Material 3 ( #118835 )
...
* Update the counter app to enable Material 3
* Fix tools tests
* Update some wording
* Revert all but useMaterial3
* Update comments
2023-02-02 00:08:11 +00:00
Ian Hickson
4c99da6c56
Avoid printing blank lines between "Another exception was thrown:" messages. ( #119587 )
2023-02-01 23:57:54 +00:00
Alex Li
4ae2d3b6df
🔥 Do not format the messages file for gen-l10n ( #119596 )
...
* 🔥 Do not format the messages file
* ✅ Add test
* ✅ Add the link to the test
* ✅ Respect the path separator from the file system
* ✅ Add the untranslated messages file existence test
2023-02-01 23:45:38 +00:00
Zachary Anderson
254a796bc3
Revert "Reland "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119529 )" ( #119729 )
...
This reverts commit 7477d7ac79
2023-02-01 09:19:48 -08:00
Alex Li
8d0af36798
🥅 Produce warning instead of error for storage base url overrides ( #119595 )
...
* 🥅 Only log warning for storage base url
* ✅ Add test
* ✅ Add the link to the test
* ✅ Remove the test
* ✅ Remove the extra import
2023-02-01 03:49:31 +00:00
Tae Hyung Kim
3884381415
Make gen-l10n error handling independent of logger state ( #119644 )
...
* init
* lint
* lint again
2023-01-31 15:28:27 -08:00
Victoria Ashworth
f6b0c6ddef
Use first Dart VM Service found with mDNS if there are duplicates ( #119545 )
...
* fix when duplicate mdns results are found
* put mdns auth code in it's own function and update tests
* add comments, refactor auth code parsing, other small tweaks
2023-01-31 17:48:19 +00:00
Chris Bracken
d272a3ab80
Reland: [macos] add flavor options to tool commands ( #119564 )
...
* Reland: [macos] add flavor options to tool commands
Adds --flavor option to flutter run and flutter build. Running against
preexisting devicelab flavor tests for feature parity between macOS,
iOS, and Android.
This relands #118421 by alex-wallen which was reverted in #118858 due to
the following test failures:
The bail-out with "Host and target are the same. Nothing to install."
added in `packages/flutter_tools/lib/src/commands/install.dart`
triggered failures in the following tests, which unconditionally attempt
to install the built app, which is unsupported on desktop since the
host and target are the same:
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout
Fixes #64088
* Partial revert: eliminate install check on desktop
The original flavour support patch included a check that triggered a
failure when flutter install is run on desktop OSes. This was
intentional, since the host and target devices are the same and
installation is unnecessary to launch the app on currently-supported
desktop OSes.
Note that Windows UWP apps *do* require installation to run, and we used
to have an install command for those apps, though UWP is no longer
supported.
Since that part of the change was orthogonal to flavour support itself,
I'm reverting that component of the change and we can deal with it
separately if so desired.
2023-01-31 17:37:46 +00:00
Danny Tuppeny
67d07a6de4
[flutter_tools] Fix parsing of existing DDS URIs from exceptions ( #119506 )
...
* [flutter_tools] Fix parsing of existing DDS URIs from exceptions
Fixes #118609 .
* Fix formatting
Co-authored-by: Christopher Fujino <fujino@google.com>
* Fix formatting
Co-authored-by: Christopher Fujino <fujino@google.com>
---------
Co-authored-by: Christopher Fujino <fujino@google.com>
2023-01-31 17:36:44 +00:00
Loïc Sharma
18c7f8a278
Fix typo in --machine help text ( #119563 )
2023-01-30 22:46:48 +00:00
Ben Konyi
7477d7ac79
Reland "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119529 )
...
* Reland "Add --serve-observatory flag to run, attach, and test (#118402 )"
This reverts commit 86ab01d2bd
2023-01-30 21:00:18 +00:00
Elias Yishak
458b298f98
Refactoring to use ver command instead of systeminfo ( #119304 )
...
* refactoring to use `ver` command instead of `systeminfo`
* fix tests to match new approach
* adding another valid validator using brazil locale text
* refactor tests to use generic fake class `ver` arg + showing output from `ver` if unsuccessful
* update reason text in test
* fix reason text to be hard coded
2023-01-30 19:29:13 +00:00
Flutter GitHub Bot
b68cebd9ce
roll packages ( #119530 )
2023-01-30 18:46:35 +00:00
Flutter GitHub Bot
df8ad3d2cb
roll packages ( #119370 )
2023-01-30 17:34:10 +00:00
Jonah Williams
4dbb573ff0
[flutter_tools] remove usage of remap samplers arg ( #119346 )
2023-01-27 18:49:49 +00:00
Danny Tuppeny
0b57596712
Run "flutter update-packages --force-upgrade" ( #119340 )
2023-01-27 17:20:18 +00:00
Zachary Anderson
86ab01d2bd
Revert "Add --serve-observatory flag to run, attach, and test ( #118402 )" ( #119302 )
...
This reverts commit 6cd4fa45e2
2023-01-26 16:43:39 -08:00
Harry Terkelsen
42bd5f2bd1
Download platform-agnostic Flutter Web SDK in the flutter_tool ( #118654 )
2023-01-26 14:21:05 -08:00
godofredoc
c9affdba9d
Move windows-x64-flutter.zip to windows-x64-debug location. ( #119177 )
...
The dependency is currently uploaded to two different locations. This
change is required to remove the duplicate uploads and their
corresponding tech debt.
2023-01-26 05:25:02 +00:00
Tae Hyung Kim
02a9c151f6
Fix lexer issue where select/plural/other/underscores cannot be in identifier names. ( #119190 )
2023-01-25 15:31:38 -08:00
Ahmed Ashour
1fd71de0c5
Remove superfluous words from comments ( #119055 )
...
* Remove superfluous words from comments.
* Revert `win32_window.h`
Which seems to come from `gallery`
2023-01-25 20:23:24 +00:00
Ben Konyi
6cd4fa45e2
Add --serve-observatory flag to run, attach, and test ( #118402 )
...
This flag will allow for Observatory to be served by the VM service once it is disabled by default in the Dart SDK.
2023-01-25 12:46:08 -05:00
Victoria Ashworth
81052a7d36
Add usage event to track when a iOS network device is used ( #118915 )
...
* Add usage event to track when a iOS network device is used
* update usage event to track percentage of iOS network vs usb devices, update and fix tests
* refactor tracking to happen in usageValues with a custom dimension
2023-01-25 10:57:12 -06:00
Gary Qian
5dabe102a2
Fix path name to discover debug apk on add2app builds ( #117999 )
2023-01-24 13:19:09 -08:00
stuartmorgan
e3c51a2f2a
Add Windows unit tests to plugin template ( #118638 )
...
* Add Windows unit tests to plugin template
Adds an example native unit test to the plugin template for Windows,
matching the format we use for our 1P plugin example app unit tests.
Once these have been added for all platforms+languages, they will be
documented on a new plugin development page to explain their use.
Since we don't appear to be running our current plugin e2e tests for
Windows, this adds a new configuration to run them. I haven't
`led`-tested this, so it may not work, but this will give a starting
point for getting them running.
Part of https://github.com/flutter/flutter/issues/82458
* Minor fix
* Add test owner
* Fix typo
* Fix test feature flag
2023-01-24 18:23:57 +00:00
Nicholas Shahan
3735231841
Cleanup old Dart SDK layout compatibility ( #118819 )
...
The changes to the Dart SDK have rolled so the backward compatibility
is no longer needed.
2023-01-24 09:22:13 -08:00
Ahmed Ashour
c35efdaa68
Remove superfluous words. ( #119008 )
...
* Remove superfluous words.
* Update packages/flutter/lib/src/widgets/slotted_render_object_widget.dart
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-01-24 01:57:00 +00:00
Christopher Fujino
64b4c69bcc
roll pub deps and remove archive, crypto, typed_data from allow-list ( #119018 )
...
* roll pub deps and remove archive, crypto, typed_data from allow-list
* un-comment code
2023-01-24 01:55:06 +00:00
Michael Goderbauer
38630b6bd1
Remove unnecessary null checks in flutter_tool ( #118857 )
...
* dart fix --apply
* manual fixes
* fix after merge conflicts
* review
2023-01-23 21:43:08 +00:00
Mouad Debbar
3bf79607dd
[web] Fix paths fetched by flutter.js ( #118684 )
2023-01-23 15:02:58 +00:00
Victoria Ashworth
a07e8a6ac4
[reland] Support wireless debugging ( #118895 )
...
* Reland "Support iOS wireless debugging (#118104 )"
This reverts commit cbf2e16892
2023-01-20 19:02:37 +00:00
Alexander Markov
492d57262f
Cleanup obsolete --compact-async compiler option ( #118894 )
2023-01-20 09:48:26 -08:00
Jenn Magder
030288d33b
Revert "[macos] add flavor options to commands in the flutter_tool ( #118421 )" ( #118858 )
...
This reverts commit 73096fd96e
2023-01-20 03:46:45 +00:00
Alex Wallen
73096fd96e
[macos] add flavor options to commands in the flutter_tool ( #118421 )
...
* Add new macos target configured for flavors
* Rename Free App copy-Info.plist to Free App Info.plist
* Remove bogus entitlements
* Remove Generated.xcconfig
* Audit project.pbxproj
* Remove unused configs
* share one info.plist
* Modify scheme so that paid app works
* Codesign automatic
* Pipe flavor as scheme into xcodebuild
* Ignore incoming flavor string
* pipe flavor for flutter run to work
* Add devicelab tests
* Error if host and target device are same for flutter install desktop
* Avoid bang (!) by promoting a local.
Co-authored-by: Jenn Magder <magder@google.com>
* Add supportsInstall property
* Override in test classes
* Add install test on macOS
* Refactor application_package and add tests for package directory
Co-authored-by: a-wallen <stephenwallen@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
2023-01-19 23:52:16 +00:00
