Matan Lurey
dee15f56bb
Re-land #162644 : Remove --verbose from devicelab task executions. ( #163017 )
...
Re-lands https://github.com/flutter/flutter/pull/162644 .
Reverts 7569fbfce5
2025-02-10 21:53:55 +00:00
auto-submit[bot]
7569fbfce5
Reverts "Remove --verbose from devicelab task executions. ( #162644 )" ( #162853 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#162644
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: At least one post-submit test depends on the
output of `--verbose`.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {cbracken, reidbaker, jonahwilliams}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
These can be useful, but were probably left in past the point where they
are always useful:
- https://github.com/flutter/flutter/pull/58018
- https://github.com/flutter/flutter/pull/56342
- https://github.com/flutter/flutter/pull/74080
... compared to the cost of reading these logs with 1000s of lines of
`stdout: ` output.
Will ask the CI gods if any of this was load-bearing before sending out
for review.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-02-07 01:27:47 +00:00
Matan Lurey
fdeb7b93aa
Remove --verbose from devicelab task executions. ( #162644 )
...
These can be useful, but were probably left in past the point where they
are always useful:
- https://github.com/flutter/flutter/pull/58018
- https://github.com/flutter/flutter/pull/56342
- https://github.com/flutter/flutter/pull/74080
... compared to the cost of reading these logs with 1000s of lines of
`stdout: ` output.
Will ask the CI gods if any of this was load-bearing before sending out
for review.
2025-02-07 00:25:20 +00:00
auto-submit[bot]
05899f84c6
Reverts "[SwiftPM] Turn on by default ( #161275 )" ( #161339 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#161275
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: loic-sharma
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: failing post submit check
`[build_ios_framework_module_test](https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20build_ios_framework_module_test )
```
[2025-01-08 14:19:48.853336] [STDOUT] stdout: ** BUILD SUCCEEDED **
[2025-01-08 14:19:50.360684] [STDOUT] stdout: [+1522 ms] ├─Building plugins... (completed in 4.8s)
[2025-01-08 14:19:50.360824] [STDOUT] stdout: [
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: loic-sharma
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {cbracken, vashworth, jmagman}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
This turns on Swift Package Manager by default:
1. New apps will have Swift Package Manager integration
2. New plugins will support Swift Package Manager
3. Existing apps will continue to use CocoaPods. They can migrate to SwiftPM using `flutter config --enable-swift-package-manager-migration`.
See this mini design doc: https://github.com/flutter/flutter/issues/151567#issuecomment-2455941279
Here's the PR that updates the SwiftPM docs: https://github.com/flutter/website/pull/11495
Part of https://github.com/flutter/flutter/issues/151567
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is [test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on [Discord].
<!-- Links -->
[Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-01-08 22:54:47 +00:00
Loïc Sharma
d8c4fc0bc6
[SwiftPM] Turn on by default ( #161275 )
...
This turns on Swift Package Manager by default:
1. New apps will have Swift Package Manager integration
2. New plugins will support Swift Package Manager
3. Existing apps will continue to use CocoaPods. They can migrate to
SwiftPM using `flutter config --enable-swift-package-manager-migration`.
See this mini design doc:
https://github.com/flutter/flutter/issues/151567#issuecomment-2455941279
Here's the PR that updates the SwiftPM docs:
https://github.com/flutter/website/pull/11495
Part of https://github.com/flutter/flutter/issues/151567
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-08 21:15:57 +00:00
Michael Goderbauer
5491c8c146
Auto-format Framework ( #160545 )
...
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.
**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2024-12-19 20:06:21 +00:00
Victoria Ashworth
6981fe6fd3
Remove workarounds for plugin_lint_mac needed for older version of Cocoapods ( #140395 )
...
CI has been updated to Cocoapods 1.13, which fixes previous issues with the `plugin_lint_mac` test. Remove workarounds added previously.
Fixes https://github.com/flutter/flutter/issues/125812 .
See also https://github.com/flutter/flutter/issues/133584 .
2023-12-19 20:19:52 +00:00
Victoria Ashworth
c175cf87a6
Ignore macOS Cocoapods linting failure on DT_TOOLCHAIN_DIR error ( #133588 )
...
Xcode 15 introduced an [error](https://github.com/flutter/flutter/issues/132755 ) into Cocoapods when building macOS apps.
When `pod lib lint` runs, it under the covers is building the app with `xcodebuild`, which is why this error occurs when linting.
A fix has been made in Cocoapods, but is not in an official release so we can't upgrade Cocoapods yet. This is to temporarily ignore lint failure due to that error.
Fixes https://github.com/flutter/flutter/issues/132980 .
Tracking issue to upgrade Cocoapods when fix is in a release: https://github.com/flutter/flutter/issues/133584
Since Xcode 15 isn't in CI, I tested it in a one-off led test:
* [Pre-fix failure](https://chromium-swarm.appspot.com/task?id=6431f228ecf98e10 )
* [Post-fix success](https://chromium-swarm.appspot.com/task?id=645ba7ebdab97210 )
2023-08-31 14:57:07 +00:00
Chris Yang
9fcb42d0dd
Update xcode to 14e222b ( #125716 )
...
Framework part of https://github.com/flutter/flutter/issues/125814
2023-05-02 19:56:17 +00:00
Jenn Magder
86e510137b
Update pod repo to pull the latest Flutter pods in plugin_lint_mac ( #112237 )
2022-09-28 18:14:52 +00:00
Jenn Magder
60c6cbf0ca
Remove Apple Silicon workarounds from plugin lint test ( #111432 )
2022-09-20 21:12:39 +00:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Jenn Magder
ac708f1cb8
Pin url_launcher to federated version in plugin_lint_mac ( #98171 )
2022-02-10 18:53:01 -08:00
Jenn Magder
ea6025ca49
Revert "Update plugin lint test for federated url_launcher plugin ( #94374 )" ( #98166 )
...
This reverts commit 86b80d1cfe
2022-02-10 14:59:20 -08:00
Jenn Magder
86b80d1cfe
Update plugin lint test for federated url_launcher plugin ( #94374 )
2021-11-29 12:19:21 -08:00
Jenn Magder
ab6f2fc8ce
Set BUILD_DIR when determining if plugins support arm64 simulators ( #90088 )
2021-09-15 18:37:04 -07:00
Darren Austin
0c81077582
Migrate devicelab tasks i-z to null safety. ( #85998 )
2021-07-13 16:41:06 -07:00
Jenn Magder
64056a1a52
Fix integration_test podspecs warnings ( #84602 )
2021-06-15 10:29:03 -07:00
Jenn Magder
94a41cde83
Mixed null safety in dev/devicelab ( #84017 )
2021-06-05 02:29:03 -07:00
Alexandre Ardhuin
34059eec2c
enable lint prefer_interpolation_to_compose_strings ( #83407 )
2021-06-01 11:14:06 -07:00
Jenn Magder
8050bd6132
Turn on iOS podspec linting in test ( #77028 )
2021-03-02 10:29:08 -08:00
Jenn Magder
3cbe0ff1b1
Output unexpected Podfile.lock contents on test failure ( #76223 )
2021-02-17 12:56:03 -08:00
Jenn Magder
1c18cf3da8
Move macOS Podfile logic into the tool ( #72020 )
2020-12-17 11:48:16 -08:00
Jenn Magder
53119af105
Add macOS to lint plugins integration test ( #71953 )
2020-12-09 13:35:39 -08:00
Jenn Magder
2529e358b6
Move Flutter.framework to build directory instead of ios/Flutter ( #70224 )
2020-11-17 10:09:29 -08:00
Casey Hillers
9e206a0c93
Refactor devicelab logic to use TaskResult instead of JSON ( #67550 )
2020-10-07 16:37:09 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. ( #65568 )
2020-09-16 14:14:06 -07:00
Jenn Magder
bd7e2eeee9
Bump Cirrus image Xcode version ( #63252 )
2020-08-25 10:34:33 -07:00
Jenn Magder
e960d773ee
Change iOS plugin simulator archs from allow list to deny list ( #64504 )
2020-08-24 17:48:05 -07:00
Chris Yang
2e63b7d4f8
Add --platforms to flutter create -t plugin command ( #59507 )
2020-06-23 17:38:03 -07:00
Jenn Magder
3744b82d8c
Support .flutter-plugins-dependencies ( #59209 )
2020-06-11 13:25:01 -07:00
Jenn Magder
319a61fd81
Move iOS Podfile logic into tool ( #59044 )
2020-06-10 14:12:48 -07:00
Dan Field
088fa24463
Set the LANG when invoking cocoapods ( #45710 )
2019-12-02 13:26:32 -08:00
Ian Hickson
449f4a6673
License update ( #45373 )
...
* Update project.pbxproj files to say Flutter rather than Chromium
Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
* Update the copyright notice checker to require a standard notice on all files
* Update copyrights on Dart files. (This was a mechanical commit.)
* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).
* Clean up the copyrights in non-Dart files. (Manual edits.)
Also, make sure templates don't have copyrights.
* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Jenn Magder
856a90e67c
Add swift_versions to plugin template podspec, include default CocoaPod version ( #44324 )
2019-11-08 18:00:01 -08:00
Jenn Magder
4331c172d7
Set DEFINES_MODULE=YES in plugin templates ( #41828 )
2019-10-03 18:35:20 -07:00
