Commit Graph

21 Commits

Author SHA1 Message Date
Danny Tuppeny
5d31b07ed5
[flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (#108310)
* [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate

Fixes an issue where the flutter_tester device may not be cleaned up correctly if we just terminate the Flutter process.

* Update integration test expectations

* Revert accidental commit
2022-07-26 10:48:38 +01:00
Danny Tuppeny
2f4299ad35
[flutter_tools] Remove unused parameter when connected DAP to VM Service (#108285)
Since 02d9c3e6a5 this flag does absolutely nothing. The behaviour it controlled is now automatic and the flag is not required.

The flag will be removed from the Dart SDK in the future after Flutter is no longer using it.
2022-07-25 18:28:12 +01:00
Danny Tuppeny
c67d2587d5
Provide more useful error message if a non-compliant DAP tool (or user) sends bad input to DAP server (#107827) 2022-07-19 11:48:05 -07:00
Danny Tuppeny
78d924af1d
[flutter_tools] [dap] Add support for passing env variables to spawned processes (#107415)
* [flutter_tools] [dap] Add support for passing env variables to spawned processes

* Use named args

* Use in-memory fs and FakePlatform

* Pass filesystem style to MemoryFileSystem
2022-07-12 10:04:08 +01:00
Danny Tuppeny
e2ef8cfe44
Pass app.started events to the DAP client + dart.debuggerUris for Profile mode (#106337) 2022-06-21 12:09:06 -07:00
Danny Tuppeny
147020366a
Fix issues running integration tests through DAP debug adapter (#104618)
* Fix issues running integration tests through DAP

These adapters were incorrectly trying to connect a DDS instance even when Flutter would create its own. This change disables DDS in the DAP layer and leaves it to Flutter (although it passes `--no-dds` on to Flutter if provided to the DAP process).

Also fixes an issue where we would unnecessarily connect the VM Service for tests even in 'noDebug' mode because of a change/fix that now includes a 'vmServiceUri' in the `test.startedProcess` event.
2022-05-26 09:36:30 +01:00
Michael Goderbauer
d5cbb36c91
Migrate remaining files to super parameters (#101919) 2022-04-14 12:04:07 -07:00
Danny Tuppeny
675b961573
Unpause and remove breakpoints when detaching from Flutter process with DAP (#101695) 2022-04-11 21:15:37 +01:00
Michael Goderbauer
296221a90d
Partial revert of super params in tools (#101436) 2022-04-06 11:04:38 -07:00
Michael Goderbauer
dcde8163ce
migrate to super params (#100509) 2022-03-31 11:46:47 -07:00
Danny Tuppeny
801ad5cd5a
Don't terminate Dart process pids from VM Service, record flutter_tools VM pid (#100223)
* Don't terminate Dart process pids from VM Service

These processes may be on another device, and in the case of attach the debugee should not be terminated anyway.
2022-03-23 16:31:31 +00:00
Danny Tuppeny
ea8aeb7427
[dap] Remove some code that's not longer required (#98928) 2022-03-22 14:20:12 -07:00
Danny Tuppeny
b39a9473f8
Handle Flutter.Error events and disable structure errors for noDebug mode (#100149) 2022-03-17 16:05:21 -07:00
Danny Tuppeny
76758ef960
[dap] Don't use --start-paused when running in Profile/Release mode (#98926) 2022-02-24 17:06:24 -08:00
Ben Konyi
50c4720913
Update dependencies to pull in new vm_service, dds, dwds, coverage, etc (#98513) 2022-02-18 12:32:08 -08:00
Danny Tuppeny
c659ad6ace
Add support for attachRequest in DAP, running "flutter attach" (#97652)
* Add support for attachRequest in DAP, which runs "flutter attach"

* Update DAP docs for attachRequest

* Improve doc comments

* Fix comments

* Remove noDebug from attach + create a getter for `debug`

* Fix indent
2022-02-07 18:54:07 +00:00
Michael Goderbauer
5684b9f69e
Enable no_leading_underscores_for_local_identifiers (#96422) 2022-01-21 14:43:59 -08:00
Danny Tuppeny
7e1e98c356
Add support for executing custom tools in place of Flutter for DAP (#94475) 2021-12-15 13:29:05 -08:00
Danny Tuppeny
77fca35877
[DAP] Add a custom event to pass flutter.serviceExtensionStateChanged… (#93870) 2021-11-22 20:12:33 -08:00
Danny Tuppeny
57dbf7f7e7
Add support for running tests through debug-adapter (#92587)
* Add support for running tests through debug-adapter

* Improve comments about stdout + remove pedantic
2021-10-28 11:34:05 +01:00
Danny Tuppeny
de966d8a49
Add a "flutter debug_adapter" command that runs a DAP server (#91802) 2021-10-27 06:48:06 -07:00