Arpit Gandhi
428bff1dde
#60704 : Pass cert for TLS localhost connection ( #106635 )
...
*Pass locally generated certificate via command line*
*Fixes: #60704*
Added ARGS:
- web-tls-cert-path
- web-tls-cert-key-path
Passing the path of local certificate and the key to cert will allow flutter tool to create a secure debugging session on chrome
**Pre-launch Checklist**
â
I read the [Contributor Guide](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview ) and followed the process outlined there for submitting PRs.
â
I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene ) wiki page, which explains my responsibilities.
â
I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo ), including [Features we expect every widget to implement](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement ).
â
I signed the [CLA](https://cla.developers.google.com/ ).
â
I listed at least one issue that this PR fixes in the description above.
â
I updated/added relevant documentation (doc comments with ///).
â
I added new tests to check the change I am making.
â
All existing and new tests are passing.
2023-11-16 21:19:07 +00:00
Yegor
371aadd822
[tool] fallback to sigkill when closing Chromium ( #135521 )
...
This implements https://github.com/flutter/flutter/issues/132654#issuecomment-1738221257 , namely:
Make `Chromium.close` more robust:
* Send `SIGTERM` and wait up to 5 seconds, if the process exited, great! Return from the function.
* If the process has not exited, then send a `SIGKILL`, which is a much firmer way to exit a process. Same as before, wait up to 5 seconds, if the process exited, great! Return from the function.
* If it still hasn't exited then give up trying to exit Chromium, just print a warning to the console and return from the function.
Bonus: a few nullability fixes and extra `-v` logging.
Fixes https://github.com/flutter/flutter/issues/132654
2023-09-28 22:28:31 +00:00
Lioness100
26b6c1bedd
Fix typos ( #121171 )
...
* Fix typos
* lowercase animated & opacity
* Undo typo fix
---------
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
Michael Goderbauer
38630b6bd1
Remove unnecessary null checks in flutter_tool ( #118857 )
...
* dart fix --apply
* manual fixes
* fix after merge conflicts
* review
2023-01-23 21:43:08 +00:00
Michael Goderbauer
b308555ed1
Enable dangling_library_doc_comments and library_annotations lints ( #117365 )
2022-12-20 16:03:21 -08:00
Nehal Patel
3b15d6a501
Removes retries from "dart pub get" and un-buffers its stdout/stderr output ( #115801 )
...
* Removes retries from "pub get" and proxies its stdout output
* Fix issue where ErrorHandlingProcessManager does not forward "mode" parameter to backing ProcessManager's "start" method
* Make "pub get" use ProcessStartMode.inheritStdio instead of forwarding bytes to stdout and stderr
* Fix tests
* Remove unused env var
* Add back 'Running "flutter pub get"...' status log
* Fix indent
* Add Pub.test() constructor which lets tests mock stdio
2022-12-01 19:30:17 +00:00
Alexandre Ardhuin
ccd33631e3
enable combinators_ordering ( #107847 )
2022-07-18 22:04:07 +00:00
Michael Goderbauer
dcde8163ce
migrate to super params ( #100509 )
2022-03-31 11:46:47 -07:00
Ian Hickson
f25b833f27
Enable avoid_print lint. ( #91444 )
2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231
Revert "Enable avoid_print lint. ( #91332 )" ( #91438 )
...
This reverts commit cb378edc9e
2021-10-07 16:16:17 -04:00
Ian Hickson
cb378edc9e
Enable avoid_print lint. ( #91332 )
2021-10-07 09:53:03 -07:00
Anis Alibegić
c99ed373b3
Fixed large amount of spelling errors ( #83744 )
2021-06-02 10:14:06 -07:00
xster
ff2dde2c7f
Reland double gzip wrapping NOTICES to reduce on-disk installed space ( #80897 )
2021-04-26 22:35:45 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations ( #80817 )
2021-04-21 13:49:03 -07:00
Jenn Magder
83980ef246
Migrate event_printer and test_config to null safety ( #79346 )
2021-03-30 16:59:05 -07:00
Jonah Williams
72ff553af3
[flutter_tools] migrate io, process, logger, terminal ( #78816 )
2021-03-23 10:10:37 -07:00
Jonah Williams
9f420ffb3e
[flutter_tools] io cleanups to simplify null safety migration ( #77955 )
2021-03-12 16:21:14 -08:00
Ian Hickson
b1cc48748d
Only write the pid-file while listening to SIGUSR signals. ( #74533 )
2021-02-10 16:06:05 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. ( #74832 )
...
* opt out the flutter tool
* oops EOF
* fix import
* Update tool_backend.dart
* Update daemon_client.dart
* fix more
2021-01-27 15:17:53 -08:00
xster
ca82c572b7
Revert "let NOTICES be double gzip wrapped to reduce on-disk installed space ( #71899 )" ( #72438 )
2020-12-16 10:58:19 -08:00
xster
4ed3432e8f
let NOTICES be double gzip wrapped to reduce on-disk installed space ( #71899 )
2020-12-15 13:29:14 -08:00
Zachary Anderson
533cd7a6d1
[flutter_tools] Delete system temp entries on fatal signals ( #55513 )
2020-05-14 14:27:02 -07:00
Zachary Anderson
090fc5cc53
[flutter_tools] Use gzip level 1 for devfs transfer compression ( #54123 )
2020-04-08 09:07:02 -07:00
Zachary Anderson
0cd2ece539
[flutter_tools] Hanlde OSError in places where we've seen it thrown ( #52491 )
2020-03-12 14:01:01 -07:00
Zachary Anderson
914bd76979
[flutter_tools] Handle errors on the std{out,err}.done future ( #51660 )
2020-02-28 22:31:01 -08:00
Zachary Anderson
bf32974189
[flutter_tools] Handle asynchronous errors writing to stdio ( #50779 )
2020-02-14 10:38:02 -08:00
Zachary Anderson
68ed5c2baf
[flutter_tool] Hide unsafe std{out,err} operations ( #49561 )
2020-01-28 07:58:02 -08:00
Zachary Anderson
93a5b7d419
[flutter_tool] Don't crash on a failure to write to std{out,err} ( #49380 )
2020-01-25 01:23:01 -08:00
Zachary Anderson
29490887e0
Reland: [flutter_tools] File system utilities ( #48757 )
...
* Reland: [flutter_tools] File system utilities
* Remove unused imports
2020-01-14 09:40:39 -08:00
Zachary Anderson
ef62092b9b
Revert "[flutter_tools] File system utilities ( #48738 )" ( #48755 )
...
This reverts commit 0349660622
2020-01-13 14:30:37 -08:00
Zachary Anderson
0349660622
[flutter_tools] File system utilities ( #48738 )
2020-01-13 13:17:45 -08:00
Jonah Williams
f7b8d62cbc
[flutter_tool] Refactor Logger and Terminal to (mostly) no longer depend directly on context ( #47269 )
2020-01-08 12:35:12 -08:00
Jonah Williams
ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable ( #47398 )
2020-01-06 11:04:20 -08:00
Zachary Anderson
a72cca137d
[flutter_tool] Print a helpful message on some mDNS failures ( #47157 )
2019-12-16 14:57:29 -08:00
Jonah Williams
8b88c8296f
remove test_api dependency from flutter_tools/base/io ( #46796 )
2019-12-11 13:31:30 -08:00
Jonah Williams
d0526d3f92
[flutter_tool] Prevent accidental calls to io.exit in unit tests ( #46639 )
2019-12-09 18:58:29 -08:00
Jonah Williams
63cc4ad3aa
Revert "[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests ( #46210 )" ( #46630 )
...
This reverts commit b698c9d72e
2019-12-09 13:13:59 -08:00
Jonah Williams
b698c9d72e
[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests ( #46210 )
2019-12-09 13:01:37 -08:00
Ian Hickson
449f4a6673
License update ( #45373 )
...
* Update project.pbxproj files to say Flutter rather than Chromium
Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
* Update the copyright notice checker to require a standard notice on all files
* Update copyrights on Dart files. (This was a mechanical commit.)
* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).
* Clean up the copyrights in non-Dart files. (Manual edits.)
Also, make sure templates don't have copyrights.
* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Alexandre Ardhuin
adc7351046
implicit-casts:false on flutter_tools/lib ( #44447 )
...
* implicit-casts:false on flutter_tools/lib
* address review comments
* use castStringKeyedMap
* introduce {bool,string,strings}Arg
* fix ci
2019-11-19 07:57:42 +01:00
Jonah Williams
4c47fdadd4
Add devfs for incremental compiler JavaScript bundle ( #43219 )
2019-10-25 15:03:13 -07:00
Jonah Williams
016ca1a0f1
Catch io.StdinException from failure to set stdin echo/line mode ( #43225 )
2019-10-22 20:35:43 -07:00
Jonah Williams
c8b3c9b727
use IOOverrides to allow inject file system, write test, find bug ( #40066 )
2019-09-30 08:41:12 -07:00
Zachary Anderson
5142238c85
[flutter_tool] Report rss high watermark in command analytics events ( #40988 )
2019-09-25 11:26:06 -07:00
Zachary Anderson
e2340c641d
[flutter_tool] Use curly braces around single statment control structures ( #40446 )
2019-09-13 14:51:35 -07:00
Ian Hickson
e8d7306828
Some minor cleanup for flutter_tools ( #36569 )
2019-07-24 10:58:09 -07:00
Alexandre Ardhuin
fecf99ff1e
enable lint avoid_bool_literals_in_conditional_expressions ( #35055 )
2019-06-25 17:40:05 +02:00
Jonah Williams
a772d4d314
retry on HttpException ( #34526 )
2019-06-17 10:48:01 -07:00
Todd Volkert
8163c0aebb
Re-apply compressionState changes. ( #34341 )
...
This re-applies the changes that were made in #33697 and #33729 ,
but which were reverted in #33792 and #33790 , respectively due to
the Dart SDK not having received the update within Google yet.
The SDK has now rolled, so these changes can be re-applied.
https://github.com/flutter/flutter/issues/32374
https://github.com/flutter/flutter/issues/33791
2019-06-12 13:47:47 -07:00
Todd Volkert
1b3fc53595
Consider all non-interactive terminals to be bots ( #34179 )
2019-06-10 16:32:08 -07:00
