auto-submit[bot]
cc4e07954d
Reverts "Improve build output for all platforms" ( #143125 )
...
Reverts flutter/flutter#128236
Initiated by: vashworth
Reason for reverting: Causing `Mac_pixel_7pro run_release_test` and `Mac_arm64_android run_release_test` to fail: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_pixel_7pro%20run_release_test/547/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_android%20run_release_test/10516/overview
Original PR Author: guidezpl
Reviewed By: {christopherfujino, loic-sharma}
This change reverts the following previous change:
Original Description:
Improves the build output:
1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained)
### `apk`, `appbundle`
<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d ">
<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436 ">
### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.
<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257 ">
<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50 ">
<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698 ">
### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).
<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b ">
<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2 ">
<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5 ">
### Size reporting
When applicable, the printed size matches the OS reported size.
- macOS
<img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce ">
- Windows
<img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7 ">
- Linux
<img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b ">
## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401
2024-02-07 22:44:19 +00:00
Pierre-Louis
2fceeb0e3c
Improve build output for all platforms ( #128236 )
...
Improves the build output:
1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained)
### `apk`, `appbundle`
<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d ">
<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436 ">
### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.
<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257 ">
<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50 ">
<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698 ">
### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).
<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b ">
<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2 ">
<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5 ">
### Size reporting
When applicable, the printed size matches the OS reported size.
- macOS
<img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce ">
- Windows
<img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7 ">
- Linux
<img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b ">
## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401
2024-02-07 22:22:25 +00:00
Pierrick Bouvier
37c3978b34
Enable native compilation for windows-arm64 ( #141930 )
...
It's now possible to natively compile a flutter app for windows-arm64. Cross-compilation is not yet implemented.
Uses arm64 artifacts now available for Dart/Flutter. Platform detection is based on Abi class, provided by Dart. Depending if Dart is an arm64 or x64 binary, the Abi is set accordingly. Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking PROCESSOR_ARCHITECTURE environment variable, which is the way to detect host architecture on Windows.
This is available only for master channel (on other channels, it fallbacks to windows-x64).
On windows-x64, it produces an x64 app. On windows-arm64, it produces an arm64 app.
2024-01-26 00:08:20 +00:00
auto-submit[bot]
1901d6fa10
Reverts "Enable native compilation for windows-arm64 " ( #141809 )
...
Reverts flutter/flutter#137618
Initiated by: Jasguerrero
This change reverts the following previous change:
Original Description:
It's now possible to natively compile a flutter app for
windows-arm64. Cross-compilation is not yet implemented.
Uses arm64 artifacts now available for Dart/Flutter.
Platform detection is based on Abi class, provided by Dart. Depending if
Dart is an arm64 or x64 binary, the Abi is set accordingly.
Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking
PROCESSOR_ARCHITECTURE environment variable, which is the way to detect
host architecture on Windows.
This is available only for master channel (on other channels, it
fallbacks to windows-x64).
On windows-x64, it produces an x64 app. On windows-arm64, it produces an
arm64 app.
2024-01-18 22:48:16 +00:00
Pierrick Bouvier
540559204e
Enable native compilation for windows-arm64 ( #137618 )
...
It's now possible to natively compile a flutter app for
windows-arm64. Cross-compilation is not yet implemented.
Uses arm64 artifacts now available for Dart/Flutter.
Platform detection is based on Abi class, provided by Dart. Depending if
Dart is an arm64 or x64 binary, the Abi is set accordingly.
Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking
PROCESSOR_ARCHITECTURE environment variable, which is the way to detect
host architecture on Windows.
This is available only for master channel (on other channels, it
fallbacks to windows-x64).
On windows-x64, it produces an x64 app. On windows-arm64, it produces an
arm64 app.
2024-01-18 19:15:23 +00:00
Victoria Ashworth
555326b228
Revert "Replace rsync when unzipping artifacts on a Mac ( #126703 )" ( #127430 )
...
This reverts commit 2b3cd7f4d9https://github.com/flutter/flutter/issues/127281 .
2023-05-24 19:21:05 +00:00
Victoria Ashworth
2b3cd7f4d9
Replace rsync when unzipping artifacts on a Mac ( #126703 )
...
Instead of using rsync, which has caused errors in the past (https://github.com/flutter/flutter/issues/99785 ), delete the file/directory/link prior to moving it.
Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files
Part of https://github.com/flutter/flutter/issues/126016 .
2023-05-16 16:58:06 +00:00
Tomasz Gucio
99c7e9f088
Add spaces after flow control statements ( #126320 )
2023-05-15 11:07:30 +02:00
Kevin Moore
f9d455134a
tool: replace top-level functions with enum properties ( #126167 )
2023-05-05 19:10:07 +00:00
Kevin Moore
0f9d66aad6
tool: use switch expressions ( #125930 )
2023-05-03 21:00:08 +00:00
Lioness100
26b6c1bedd
Fix typos ( #121171 )
...
* Fix typos
* lowercase animated & opacity
* Undo typo fix
---------
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
Michael Goderbauer
38630b6bd1
Remove unnecessary null checks in flutter_tool ( #118857 )
...
* dart fix --apply
* manual fixes
* fix after merge conflicts
* review
2023-01-23 21:43:08 +00:00
Jesús S Guerrero
fc015f52c6
Use directory exists instead of path.dirname ( #112219 )
2022-09-28 22:24:24 +00:00
Zachary Anderson
c6ec84e978
[flutter_tools] Pull more arm64 artifacts on Apple Silicon ( #110291 )
2022-08-29 10:33:24 -07:00
Jenn Magder
839a183ea6
Add note to doctor validator if script is running Rosetta ( #101309 )
2022-04-05 10:37:35 -07:00
Michael Goderbauer
dcde8163ce
migrate to super params ( #100509 )
2022-03-31 11:46:47 -07:00
Christopher Fujino
610b41e88c
[flutter_tools] add validation of paths of contained files to os_utils _unpackArchive() ( #96565 )
2022-01-25 18:10:12 -08:00
Spt
7de1e225de
fix rsync output utf8decode bug ( #95881 )
2022-01-13 10:20:20 -08:00
Ian Hickson
9c73e91f7f
Add more detail to error messages ( #94820 )
2021-12-09 11:29:14 -08:00
Jenn Magder
40428fa0ea
macOS unzip then rsync to delete stale artifacts ( #85075 )
2021-06-22 17:10:56 -07:00
Jonah Williams
53e0c50a7c
[flutter_tools] use ProcessManager.canRun instead of checking for ArgumentErrors ( #83845 )
2021-06-03 08:24:04 -07:00
Hattomo (TomohiroHattori)
08a70e7ac8
Enable avoid_escaping_inner_quotes lint ( #81153 )
2021-05-19 09:54:02 -07:00
Anurag Roy
6e08ea0a2c
[flutter_tools] Show linux distribution and kernel release in flutter doctor ( #81368 )
2021-05-10 10:04:02 -07:00
Jia Hao
aa1df71c20
[flutter_tools] throwToolExit should return Never ( #78954 )
2021-03-24 10:40:03 -07:00
Jenn Magder
d165ea5c42
Migrate os to null safety ( #78901 )
2021-03-23 17:28:09 -07:00
Hidenori Matsubayashi
4cc0ab2d19
[flutter_tools] Add ARM64 Linux host and cross-building option support ( #61221 )
2021-02-12 14:25:30 -08:00
Jonah Williams
021311ed8a
Revert "[flutter_tools] move process manager into tool ( #75350 )" ( #75639 )
...
This reverts commit 8b6baae44c
2021-02-08 09:21:46 -08:00
Jonah Williams
8b6baae44c
[flutter_tools] move process manager into tool ( #75350 )
...
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. ( #74832 )
...
* opt out the flutter tool
* oops EOF
* fix import
* Update tool_backend.dart
* Update daemon_client.dart
* fix more
2021-01-27 15:17:53 -08:00
Jenn Magder
a8bed5e405
Add sysctl file fallbacks ( #71623 )
2020-12-03 08:53:07 -08:00
Alexandre Ardhuin
17cdf5559d
enable unnecessary_string_escapes and use_raw_strings ( #68302 ) ( #69025 )
2020-10-26 12:42:05 -07:00
Zachary Anderson
cbcd1321ed
Revert "enable unnecessary_string_escapes and use_raw_strings ( #68302 )" ( #68714 )
...
This reverts commit ae06c19a37
2020-10-21 08:16:13 -07:00
Alexandre Ardhuin
ae06c19a37
enable unnecessary_string_escapes and use_raw_strings ( #68302 )
2020-10-21 16:34:24 +02:00
Jenn Magder
a82807d782
Run Xcode command lines tools in native ARM ( #68050 )
2020-10-14 15:24:32 -07:00
Jenn Magder
4dffc851bc
Detect ARM macOS arch with sysctl hw.optional.arm64 ( #67970 )
2020-10-13 12:05:04 -07:00
Jonah Williams
18bb4d7254
Revert "[flutter_tools] reland: fold process resolution logic into the flutter tool ( #67957 )" ( #67968 )
...
This reverts commit bd8138797e
2020-10-12 15:53:16 -07:00
Jonah Williams
bd8138797e
[flutter_tools] reland: fold process resolution logic into the flutter tool ( #67957 )
...
Reland of #67669
The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable.
So that we can adjust/modify this logic, fold it into flutter and add some additional logging.
caches the resolved executable per target directory, to avoid repeated look ups.
Instead of throwing an argument error, attempts to run the executable as given if an exact path can't be found
Accept files or symlinks for the executable path.
user where/which to resolve path instead of package:process logic.
2020-10-12 15:37:02 -07:00
Jonah Williams
354e2a57b1
Revert "[flutter_tools] fold executable resolution into flutter ( #67669 )" ( #67954 )
...
This reverts commit 10c78c264a
2020-10-12 13:15:39 -07:00
Jonah Williams
10c78c264a
[flutter_tools] fold executable resolution into flutter ( #67669 )
...
The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. Fold the resolution logic into the tool and use where/which instead of the package:process specific logic.
2020-10-12 12:51:37 -07:00
Christopher Fujino
ccdaa37043
Remove the .zip method from OSUtils, as it was not used ( #67367 )
...
We used to use zip to verify the integrity of downloaded zip archives, but we now use unzip. This removes the .zip method from OperatingSystemUtils.
2020-10-08 13:40:01 -07:00
Jonah Williams
6f20c8a83f
[flutter_tools] handle missing zip/unzip argument errors ( #66685 )
...
it is possible for users that download the prebuilt SDKs to run the tool without unzip installed. Rather than crashing with an unclear argument error, exit the tool with a message on how to install that mirrors the message in the update_dart_sdk.sh script.
Also applied to zip for completeness
2020-09-29 07:58:09 -07:00
gaaclarke
fa646339d6
Added the machine's architecture to macos doctor results. ( #65978 )
2020-09-16 17:47:04 -07:00
Jonah Williams
d3fd62c843
[flutter_tools] exit with helpful message if where is missing on windows ( #65112 )
2020-09-02 16:50:04 -07:00
Jonah Williams
15d18b9e42
[flutter_tools] remove unused zip verification ( #64970 )
...
This is no longer used, in favor of just attempting to unzip and handling the exception.
2020-08-31 13:26:38 -07:00
Christopher Fujino
f796e047fd
Verbose process exceptions ( #61552 )
2020-07-16 11:31:03 -07:00
Jonah Williams
3b0c84b906
Revert "use Expand-Archive and Compress-Archive in windows os utils ( #58390 )" ( #58719 )
...
This reverts commit bbe18f7580
2020-06-04 14:22:10 -07:00
Jonah Williams
bbe18f7580
use Expand-Archive and Compress-Archive in windows os utils ( #58390 )
...
Work towards removal of package:archive and ideally more stable unzipping of artifacts. These commands are available in Powershell 5+, which we already require for windows.
2020-06-04 14:00:33 -07:00
Zachary Anderson
6f0ed5e142
[flutter_tools] Restore base/platform.dart ( #56410 )
2020-05-06 08:15:39 -07:00
Zachary Anderson
57dd045cef
[flutter_tools] Handle empty gzip file on Windows ( #54679 )
...
* [flutter_tools] Handle empty gzip file on Windows
* Update packages/flutter_tools/test/general.shard/base/os_test.dart
Co-Authored-By: Jonah Williams <jonahwilliams@google.com>
* Update packages/flutter_tools/test/general.shard/base/os_test.dart
Co-Authored-By: Jonah Williams <jonahwilliams@google.com>
* Update packages/flutter_tools/test/general.shard/base/os_test.dart
Co-Authored-By: Jonah Williams <jonahwilliams@google.com>
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-04-14 09:42:26 -07:00
Zachary Anderson
090fc5cc53
[flutter_tools] Use gzip level 1 for devfs transfer compression ( #54123 )
2020-04-08 09:07:02 -07:00
