Ian Hickson
989f864497
Enable avoid_setters_without_getters ( #91067 )
2021-10-01 00:58:05 -07:00
Christopher Fujino
738a7747cc
[flutter_tools] Handle disk device not found ( #90996 )
2021-09-30 17:28:57 -07:00
Greg Spencer
01af8e5987
Make flutter update-packages run in parallel ( #91006 )
...
This modifies the flutter update-packages and flutter update-packages --force-upgrade commands so that the many invocations of "dart pub get" in each repo project run in parallel instead of in series.
2021-09-30 10:26:31 -07:00
Christopher Fujino
61bce1d83b
[flutter_tools] remove non-null check from AndroidValidator ( #90090 )
2021-09-25 16:53:06 -07:00
Jenn Magder
58944e6b88
Revert "Enable caching of CPU samples collected at application startup ( #89600 )" ( #89704 )
...
This reverts commit 619121b095
2021-09-08 19:37:34 -07:00
Ben Konyi
619121b095
Enable caching of CPU samples collected at application startup ( #89600 )
2021-09-08 17:22:04 -07:00
Anis Alibegić
a753d09cc9
Fixed several typos ( #89485 )
2021-09-07 14:56:04 -07:00
Jenn Magder
2d55032939
Migrate dds.dart to null safety ( #88382 )
2021-08-17 21:12:03 -07:00
Zachary Anderson
3572a7e8b7
Revert "feat: migrate base/dds.dart to null-safety ( #88015 )" ( #88367 )
2021-08-17 11:52:05 -07:00
Jenn Magder
325cfb0f4c
Make doctor Xcode version requirement clearer ( #88137 )
2021-08-13 17:07:03 -07:00
嘟囔
d2f9c6c752
feat: migrate base/dds.dart to null-safety ( #88015 )
2021-08-11 14:47:06 -07:00
Jonah Williams
7f26dbe0d4
[flutter] remove elevation checker ( #86837 )
2021-07-21 21:51:06 -07:00
Jonah Williams
63a4013160
Revert "[flutter_tools] let the logger know about machine mode ( #86116 )" ( #86363 )
...
This reverts commit 53d8cba3ec
2021-07-13 10:39:35 -07:00
Jonah Williams
53d8cba3ec
[flutter_tools] let the logger know about machine mode ( #86116 )
2021-07-12 10:41:03 -07:00
Hannes Winkler
a1e9f2057f
[custom-devices] general improvements, add custom-devices subcommand, better error handling ( #82043 )
2021-07-07 09:16:04 -07:00
Dan Field
e36e62e9a6
Revert "Revert "Audit hashCode overrides outside of packages/flutter ( #85370 )" ( #85451 )" ( #85567 )
...
This reverts commit 2be0d57fa2
2021-06-30 09:46:54 -07:00
Jenn Magder
e028d0f046
Split project.dart into CMake and Xcode projects ( #85359 )
2021-06-28 11:31:04 -07:00
Ren You
2be0d57fa2
Revert "Audit hashCode overrides outside of packages/flutter ( #85370 )" ( #85451 )
...
This reverts commit 9846fa5145
2021-06-28 09:55:31 -07:00
Dan Field
9846fa5145
Audit hashCode overrides outside of packages/flutter ( #85370 )
2021-06-26 17:36:04 -07:00
Jenn Magder
0de6bd41ba
Migrate iOS app deployment target from 8.0 to 9.0 ( #85174 )
2021-06-24 10:21:05 -07:00
Jenn Magder
40428fa0ea
macOS unzip then rsync to delete stale artifacts ( #85075 )
2021-06-22 17:10:56 -07:00
Jenn Magder
53f5b90209
Use -miphonesimulator-version-min when building App.framework for simulator ( #84729 )
2021-06-16 15:54:38 -07:00
Greg Spencer
88f3811055
Turn on avoid_dynamic_calls lint, except packages/flutter tests, make appropriate changes. ( #84476 )
...
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated.
Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
2021-06-14 14:16:57 -07:00
Lau Ching Jun
89a3c353e6
Add more analytics for hot reload in flutter_tools. ( #83972 )
2021-06-07 18:51:47 -07:00
Jenn Magder
3477df744d
Migrate iOS project migrations to null safety ( #83855 )
2021-06-03 10:24:04 -07:00
Jonah Williams
53e0c50a7c
[flutter_tools] use ProcessManager.canRun instead of checking for ArgumentErrors ( #83845 )
2021-06-03 08:24:04 -07:00
Anis Alibegić
c99ed373b3
Fixed large amount of spelling errors ( #83744 )
2021-06-02 10:14:06 -07:00
Alexandre Ardhuin
34059eec2c
enable lint prefer_interpolation_to_compose_strings ( #83407 )
2021-06-01 11:14:06 -07:00
Jenn Magder
00263c4f8a
Migrate build system build.dart to null safety ( #83381 )
2021-05-26 12:04:02 -07:00
Taha Tesser
f9cd87e60a
[flutter_tools] Add documentation to "cmdline-tools component is missing" doctor validation error ( #83356 )
2021-05-26 10:59:02 -07:00
Lau Ching Jun
fdb1fb184d
Add MultiRootFileSystem to better support using --filesystem-root. ( #82991 )
2021-05-24 22:04:02 -07:00
Hattomo (TomohiroHattori)
08a70e7ac8
Enable avoid_escaping_inner_quotes lint ( #81153 )
2021-05-19 09:54:02 -07:00
Taha Tesser
0f03147138
remove unnecessary comment ( #82650 )
2021-05-17 11:59:02 -07:00
Taha Tesser
99472cf072
fix pkg typos ( #82544 )
2021-05-14 13:09:03 -07:00
Kenzie Schmoll
766b4509c6
Add 'v' hotkey to open DevTools in the browser ( #82227 )
...
* Add 'v' hotkey to open DevTools in the browser
2021-05-13 09:54:10 -07:00
Jenn Magder
c1c12aa365
Add posix permission chown suggestion to io error handling ( #81942 )
2021-05-11 14:54:02 -07:00
Michael Goderbauer
b8a2456737
Enable library_private_types_in_public_api lint ( #81578 )
2021-05-10 16:26:16 -07:00
Anurag Roy
6e08ea0a2c
[flutter_tools] Show linux distribution and kernel release in flutter doctor ( #81368 )
2021-05-10 10:04:02 -07:00
Ian Hickson
33b183e6c9
Fix extra blank lines in logger output ( #81607 )
2021-05-03 09:19:02 -07:00
Matej Knopp
f6726b425d
Add support for DarwinArchs when assembling macOS App.framework ( #81243 )
2021-04-28 11:33:36 -07:00
Ian Hickson
6beafa7b16
Apply style guide regarding createTempSync pattern ( #81090 )
2021-04-27 14:59:03 -07:00
xster
ff2dde2c7f
Reland double gzip wrapping NOTICES to reduce on-disk installed space ( #80897 )
2021-04-26 22:35:45 -07:00
Jenn Magder
8d3bc1846f
Migrate analyze_size to null safety ( #81002 )
2021-04-26 16:46:14 -07:00
Jonah Williams
52661bc713
[flutter_tools] skip copying 1GB of data from chrome cache dirs ( #81170 )
...
* [flutter_tools] skip copying 1GB of data from chrome cache dirs
* Update chrome.dart
2021-04-26 13:02:42 -07:00
Ian Hickson
598737adf2
Clean up the command line tool interactive help output. ( #80903 )
2021-04-22 19:34:02 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations ( #80817 )
2021-04-21 13:49:03 -07:00
Jonah Williams
9904a7f472
Refactor core resident runner logic ( #80462 )
2021-04-16 17:27:35 -07:00
Jenn Magder
72976f552c
Migrate xcodeproj to null safety ( #80549 )
2021-04-16 17:22:46 -07:00
Jonah Williams
b7214a9a43
[flutter_tools] fix null check in crash reporter ( #80382 )
2021-04-13 14:04:25 -07:00
Anurag Roy
ce3c3d2a21
[flutter_tools] Show upstream remote in flutter doctor -v ( #80101 )
2021-04-13 14:04:08 -07:00
Jenn Magder
f09eb8af7f
Migrate first_run and bot_detector to null safety ( #80096 )
2021-04-09 13:56:52 -07:00
Jonah Williams
be2c68c85c
[flutter_tools] cache for UWP artifacts ( #80069 )
2021-04-09 10:59:01 -07:00
Jenn Magder
4a730509fc
Migrate persistent_tool_state to null safety ( #80085 )
2021-04-08 19:14:03 -07:00
Jenn Magder
fdb16cd787
Cast config values to dynamic values instead of Object ( #80011 )
2021-04-08 15:18:28 -07:00
Jenn Magder
3e5f620a00
Convert some general.shard base tests to null safety ( #79985 )
2021-04-08 14:55:19 -07:00
Jenn Magder
12ba9046d7
Migrate tool version to null safety ( #79911 )
2021-04-07 16:49:23 -07:00
Jenn Magder
a2f67720ef
Migrate test/src/common to null safety ( #79907 )
2021-04-06 22:55:03 -07:00
Jenn Magder
026ee9756c
Allow null config values ( #79917 )
2021-04-06 21:52:35 -07:00
Jonah Williams
304448af8c
[flutter_tools] consume package:process exceptions ( #79657 )
2021-04-02 12:08:29 -07:00
Jenn Magder
a83abaa3e3
Migrate fingerprint to null safety ( #79587 )
2021-04-01 18:29:51 -07:00
Jonah Williams
e870f5d123
[flutter_tools] use Url path.Context for joining URI ( #79566 )
2021-04-01 11:32:49 -07:00
Hannes Winkler
e8ad03099f
[flutter_tools] Add support for custom devices ( #78113 )
2021-03-31 18:09:02 -07:00
Jenn Magder
8ddc27e607
Split globals.dart into null sound and unsound libraries ( #79016 )
2021-03-31 16:55:20 -07:00
Jonah Williams
6b3093b6af
[flutter_tools] remove globals from Device and separate FlutterDeviceManager ( #79454 )
2021-03-31 12:59:00 -07:00
Jenn Magder
83980ef246
Migrate event_printer and test_config to null safety ( #79346 )
2021-03-30 16:59:05 -07:00
Jonah Williams
430626d0f3
[flutter_tools] use existing service implementations for web ( #78995 )
2021-03-29 21:44:03 -07:00
Michael Goderbauer
99023f0686
Fix missed ignores ( #79071 )
2021-03-25 13:02:12 -07:00
Jenn Magder
b804117802
Removed unnecessary ! in net.dart ( #79010 )
2021-03-24 15:36:12 -07:00
Jenn Magder
63d6ec56af
Migrate deferred_components_validator to null safety ( #78934 )
2021-03-24 15:20:05 -07:00
Jenn Magder
ce31d4ff7e
Migrate android_console to null safety ( #78923 )
2021-03-24 15:18:00 -07:00
Jenn Magder
7148cc61f3
Migrate flutter_tool net.dart to null safety ( #78922 )
2021-03-24 15:16:13 -07:00
Jenn Magder
d79b16689d
Migrate error_handling_io to null safety ( #78932 )
2021-03-24 14:56:26 -07:00
Jia Hao
aa1df71c20
[flutter_tools] throwToolExit should return Never ( #78954 )
2021-03-24 10:40:03 -07:00
Jonah Williams
9cc61b0f90
[flutter_tools] handle concurrent modification in signal callback ( #78913 )
2021-03-23 17:30:09 -07:00
Jenn Magder
d165ea5c42
Migrate os to null safety ( #78901 )
2021-03-23 17:28:09 -07:00
Jenn Magder
46c99809b4
Migrate flutter_tools file_system to null safety ( #78896 )
2021-03-23 13:36:34 -07:00
Jenn Magder
5a6bac3037
Migrate command_help to null safety ( #78892 )
2021-03-23 12:47:48 -07:00
Jenn Magder
7f3c5deb7e
Migrate signals.dart to null safety ( #78893 )
2021-03-23 12:46:26 -07:00
Jonah Williams
72ff553af3
[flutter_tools] migrate io, process, logger, terminal ( #78816 )
2021-03-23 10:10:37 -07:00
Jenn Magder
5a21e2d877
Make version and time in flutter_tool null safe ( #78836 )
2021-03-23 10:03:23 -07:00
Jenn Magder
0bde67e734
Migrate flutter_tool tool helper files to null safety ( #78845 )
2021-03-23 10:02:59 -07:00
Jonah Williams
cf903d7392
[flutter_tools] remove globals from process, filesystem ( #78357 )
2021-03-22 10:35:40 -07:00
Michael Goderbauer
197b440e96
Migrate out custom ignore syntax to flutter_ignore ( #78497 )
2021-03-19 15:33:05 -07:00
Jonah Williams
d27666e058
[flutter_tools] migrate context to null safety ( #78359 )
2021-03-18 10:18:20 -07:00
Jonah Williams
cdfe39556b
[flutter_tools] handle OSError 2 from current working directory ( #78380 )
2021-03-18 09:49:25 -07:00
Marcus Tomlinson
01c772cc8d
Revert "Add libblkid / liblzma / libgcrypt as an explicit dependancy on Linux" ( #78415 )
...
* Revert "Add libgcrypt as an explicit dependancy on Linux"
This reverts commit bf65b3d03c
2021-03-18 09:14:44 -07:00
Jonah Williams
4807f806e2
[flutter_tools] remove globals from logger ( #78353 )
2021-03-16 16:46:21 -07:00
Jonah Williams
9f420ffb3e
[flutter_tools] io cleanups to simplify null safety migration ( #77955 )
2021-03-12 16:21:14 -08:00
Jonah Williams
a01f37245b
[flutter_tools] remove globals from terminal ( #77953 )
2021-03-12 12:53:05 -08:00
Marcus Tomlinson
82675474ea
Add libgcrypt as an explicit dependancy on Linux ( #77926 )
2021-03-12 07:50:03 -08:00
Jonah Williams
2daac9201a
[flutter_tools] simplify shutdown hooks ( #77969 )
2021-03-11 22:18:15 -08:00
Jonah Williams
0cc087c2ae
[flutter_tools] migrate some base libraries to null safety ( #77738 )
2021-03-10 12:15:04 -08:00
Jonah Williams
233015572c
[flutter_tools] simplify platform null safety ( #77727 )
2021-03-09 12:52:57 -08:00
Jonah Williams
d39d450594
[flutter_tools] remove most globals from resident web runner ( #77432 )
2021-03-08 14:38:26 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint ( #77434 )
2021-03-05 18:38:15 -08:00
Gary Qian
ee41782732
[flutter_tools] Deferred components build system ( #76192 )
2021-03-04 18:09:02 -08:00
Jonah Williams
81b9845041
[flutter_tools] migrate async_guard.dart to null safety ( #76748 )
2021-03-04 16:00:14 -08:00
Michael Goderbauer
7b251f5f37
Enable use_function_type_syntax_for_parameters lint ( #77163 )
2021-03-04 08:59:17 -08:00
Jenn Magder
f5903a91e0
Remove dead ensureDirectoryExists ( #76829 )
2021-02-25 18:11:01 -08:00
Jonah Williams
93e7d34dc4
[flutter_tools] Remove globals/mocks from GradleUtils ( #76020 )
2021-02-17 14:26:57 -08:00
Jonah Williams
dce8f71228
[flutter_tools] do not use context logger in gradle ( #75940 )
2021-02-12 17:38:52 -08:00
Hidenori Matsubayashi
4cc0ab2d19
[flutter_tools] Add ARM64 Linux host and cross-building option support ( #61221 )
2021-02-12 14:25:30 -08:00
Ian Hickson
b1cc48748d
Only write the pid-file while listening to SIGUSR signals. ( #74533 )
2021-02-10 16:06:05 -08:00
Jonah Williams
8df58eb650
[flutter_tools] use a single fake implementation of HttpClient ( #75471 )
2021-02-09 15:32:03 -08:00
Gary Qian
81530744bf
flutter_tool: DeferredComponent and LoadingUnit classes, Manifest deferred-components parsing ( #75394 )
2021-02-09 10:02:13 -08:00
Jonah Williams
021311ed8a
Revert "[flutter_tools] move process manager into tool ( #75350 )" ( #75639 )
...
This reverts commit 8b6baae44c
2021-02-08 09:21:46 -08:00
Jonah Williams
8b6baae44c
[flutter_tools] move process manager into tool ( #75350 )
...
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Jonah Williams
dcd061c70b
[flutter_tools] experiment with skipping process resolution ( #74447 )
2021-02-03 10:56:22 -08:00
Vyacheslav Egorov
4ba26191ea
Add support for producing unstripped AOT snapshots. ( #75243 )
2021-02-02 09:16:04 -08:00
Jenn Magder
73506f36f7
Replace MockConfig with TestConfig ( #75044 )
2021-02-01 18:16:05 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. ( #74832 )
...
* opt out the flutter tool
* oops EOF
* fix import
* Update tool_backend.dart
* Update daemon_client.dart
* fix more
2021-01-27 15:17:53 -08:00
Jonah Williams
fa8bf67cb6
[flutter_tools] catch errors when getting cwd ( #74744 )
2021-01-26 12:49:03 -08:00
Ben Konyi
92427f260a
Handle 'Existing VM service clients' error from old VM service instances ( #74665 )
2021-01-25 12:29:05 -08:00
Ian Hickson
5d8dfa44b6
Don't crash on narrow window widths ( #74365 )
2021-01-25 11:39:45 -08:00
J-P Nurmi
e1ff62a78c
[flutter_tools] propagate build errors from the backend ( #72196 )
2021-01-14 13:39:05 -08:00
Jonah Williams
abb48f495b
[flutter_tools] add error handling wrapping for File.createSync ( #73890 )
2021-01-13 14:25:37 -08:00
Jenn Magder
7c75c01fc3
Add recommended Xcode version to doctor ( #73808 )
2021-01-12 19:01:18 -08:00
Jonah Williams
25dd8684b1
[flutter_tools] add 483 to non-recoverable errors ( #73579 )
2021-01-08 11:56:13 -08:00
Jenn Magder
45d71e25ab
Build iOS apps using Swift Packages ( #73508 )
2021-01-07 15:59:09 -08:00
Jenn Magder
74d58105d1
Revert "Build iOS apps using Swift Packages ( #72761 )" ( #73437 )
...
This reverts commit 28db5a0fae
2021-01-06 15:04:16 -08:00
Jenn Magder
28db5a0fae
Build iOS apps using Swift Packages ( #72761 )
2021-01-06 13:54:53 -08:00
Ben Konyi
620a8284f8
Catch StateError and output more useful error message when DDS fails to start ( #72736 )
2020-12-22 10:24:04 -08:00
Jenn Magder
23f5fbc69d
Update CocoaPods minimum version to 1.9 ( #71170 )
2020-12-17 10:22:50 -08:00
xster
ca82c572b7
Revert "let NOTICES be double gzip wrapped to reduce on-disk installed space ( #71899 )" ( #72438 )
2020-12-16 10:58:19 -08:00
xster
4ed3432e8f
let NOTICES be double gzip wrapped to reduce on-disk installed space ( #71899 )
2020-12-15 13:29:14 -08:00
Jenn Magder
aa7be00d4b
Rename IOSMigrator -> ProjectMigrator ( #71757 )
2020-12-04 18:34:59 -08:00
Ben Konyi
89ef88c64f
Ensure attaching to an application with an existing DDS instance is not treated as a fatal error ( #70847 )
2020-12-04 17:16:30 -08:00
Martin Kustermann
625ecda083
Remove left-overs from causal async stacks. ( #71663 )
2020-12-03 11:03:07 -08:00
Jenn Magder
a8bed5e405
Add sysctl file fallbacks ( #71623 )
2020-12-03 08:53:07 -08:00
Jonah Williams
81e1f7d1ed
[flutter_tools] mode code size output to ~/.flutter-devtools ( #71601 )
2020-12-02 17:19:57 -08:00
Jia Hao
8de72126e9
[flutter_tools] Don't fail copying files if the destination is not writable ( #71215 )
2020-11-25 15:48:03 -08:00
Jonah Williams
1efb36035e
[flutter_tools] display message for current null safety mode ( #70718 )
2020-11-20 11:53:02 -08:00
Pierre-Louis
598627cd3b
Fix typo ( #70834 )
2020-11-19 16:43:09 -08:00
Ben Konyi
4cbafda853
Roll package:dds to 1.5.1 and add isCompleted guards around completers in base/dds.dart ( #70712 )
2020-11-17 16:03:18 -08:00
Marcus Tomlinson
343577afb6
Add liblzma as an explicit dependancy on Linux ( #70617 )
2020-11-16 14:48:02 -08:00
Jenn Magder
53410c4bb9
Compile snapshot_assembly with sdk root set in Xcode ( #69731 )
2020-11-04 10:32:01 -08:00
Jonah Williams
fb90544cab
[flutter_tools] remove unused or no longer useful code ( #69547 )
2020-11-02 22:48:03 -08:00
Danny Tuppeny
e71655b7e9
Include VS Code + Android Studio URLs in the No IDE message ( #69194 )
2020-10-28 11:17:06 -07:00
Jonah Williams
2e54c4a8ea
[flutter_tools] implement safe file copy with multiple fallbacks ( #69000 )
...
The tool observes a large number of unhandled exceptions during the file copy portion of flutter create. it is difficult to tell whether the permission issue is caused by the source/destination, or whether it is due to a bug in dart:io.
To work around this, implement a permission check for both the source and dest files. If either fails, the tool can exit with a more specific message.
If these checks pass, then perform the actual copy. If the copy fails, fallback to manually copying the bytes
2020-10-26 15:49:07 -07:00
Alexandre Ardhuin
17cdf5559d
enable unnecessary_string_escapes and use_raw_strings ( #68302 ) ( #69025 )
2020-10-26 12:42:05 -07:00
Jonah Williams
cb67513f29
[flutter_tools] Reland: simplify pub cache logic ( #67589 )
...
There have been some more additional reports of a missing 'package:characters' import after upgrading flutter. This has me concerned that our pub caching logic is incorrect. Instead of the tool attempting to guess when pub should be run, always delegate to pub.
Also takes an opportunity to fix the kernel snapshot depending on the .packages or package_config. Due to the generated: date field this causes extra rebuilds. Instead when pub get is run, write out an additional file with just the package contents and version.
Fixes #66777
Fixes #65723
2020-10-23 10:00:56 -07:00
Jenn Magder
f63d56e455
App.framework must support iOS 8 for older Flutter projects ( #68729 )
...
* App.framework must support iOS 8 for older Flutter projects
* Fix test
2020-10-22 13:50:54 -07:00
Jenn Magder
f877266139
Add CocoaPods sudo installation note ( #68542 )
...
* Add CocoaPods sudo installation note
* Refer to instructions
2020-10-22 13:33:35 -07:00
Zachary Anderson
cbcd1321ed
Revert "enable unnecessary_string_escapes and use_raw_strings ( #68302 )" ( #68714 )
...
This reverts commit ae06c19a37
2020-10-21 08:16:13 -07:00
Alexandre Ardhuin
ae06c19a37
enable unnecessary_string_escapes and use_raw_strings ( #68302 )
2020-10-21 16:34:24 +02:00
Jenn Magder
a82807d782
Run Xcode command lines tools in native ARM ( #68050 )
2020-10-14 15:24:32 -07:00
Jenn Magder
537cf33a21
Move processUtils to globals ( #67976 )
2020-10-14 13:12:46 -07:00
Jonah Williams
9e70180f63
[flutter_tools] do not measure progress timeout ( #67959 )
...
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
2020-10-13 13:05:47 -07:00
Jenn Magder
4dffc851bc
Detect ARM macOS arch with sysctl hw.optional.arm64 ( #67970 )
2020-10-13 12:05:04 -07:00
Jonah Williams
18bb4d7254
Revert "[flutter_tools] reland: fold process resolution logic into the flutter tool ( #67957 )" ( #67968 )
...
This reverts commit bd8138797e
2020-10-12 15:53:16 -07:00
Jonah Williams
bd8138797e
[flutter_tools] reland: fold process resolution logic into the flutter tool ( #67957 )
...
Reland of #67669
The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable.
So that we can adjust/modify this logic, fold it into flutter and add some additional logging.
caches the resolved executable per target directory, to avoid repeated look ups.
Instead of throwing an argument error, attempts to run the executable as given if an exact path can't be found
Accept files or symlinks for the executable path.
user where/which to resolve path instead of package:process logic.
2020-10-12 15:37:02 -07:00
Jonah Williams
354e2a57b1
Revert "[flutter_tools] fold executable resolution into flutter ( #67669 )" ( #67954 )
...
This reverts commit 10c78c264a
2020-10-12 13:15:39 -07:00
Jonah Williams
10c78c264a
[flutter_tools] fold executable resolution into flutter ( #67669 )
...
The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. Fold the resolution logic into the tool and use where/which instead of the package:process specific logic.
2020-10-12 12:51:37 -07:00
Jonah Williams
08576cb671
[flutter_tools] HACKTOBERFEST ( #67882 )
...
HACKTOBERFEST
2020-10-12 09:31:02 -07:00
James D. Lin
e4206ac5dd
[flutter tools] Add a DelegatingLogger class ( #67581 )
...
[flutter tools] Add a DelegatingLogger class
Move most of `DelegateLogger` `from test/src/testbed.dart` to
`lib/src/base/logger.dart` to better formalize the common practice of
chaining `Logger`s together. I renamed the class since it isn't
itself the delegate and to better match the `Delegating...` classes
from `package:collection`.
Additionally, add a freestanding `asLogger<T>` function to "cast" a
`Logger` into a matching delegate if possible. This will allow
`Logger` chains to be ordered a *bit* more freely (e.g.
`NotifyingLogger` and `AppRunLogger` will no longer required to be
at the end of the chain, an unwritten rule that has led to breakage in
google3). Chain order still matters since lack of virtual dispatch
means that parent `Logger`s can never invoke child methods, however.
I made `asLogger<T>` a freestanding function because I didn't want to
make it part of the `Logger` interface (and I thought that making it
an extension method might be weird).
Bonus cleanup:
There no longer appears to be a way to construct an `AppRunLogger`
with a null parent, so remove all of code paths for that case and
make the `parent` construction parameter required.
2020-10-09 15:55:24 -07:00
Christopher Fujino
ccdaa37043
Remove the .zip method from OSUtils, as it was not used ( #67367 )
...
We used to use zip to verify the integrity of downloaded zip archives, but we now use unzip. This removes the .zip method from OperatingSystemUtils.
2020-10-08 13:40:01 -07:00
Jonah Williams
30c0fc1bce
[flutter_tools] remove globals from compile and devices ( #67485 )
...
Remove global variables from compile.dart and devices.dart (except for dds which needs more changes).
#47161
2020-10-08 12:28:58 -07:00
Jonah Williams
c8466d0430
[flutter_tools] handle case where file is deleted by other program or running on read only volume ( #66708 )
...
* [flutter_tools] handle case where file is deleted by other program
* Add test cases
* Update file_system.dart
* Update file_system_test.dart
* fix import
* make a static on ErrorHandligFS
* add support for no exit on failure
* address comments
* update doc comment to file or directory
2020-10-05 17:00:07 -07:00
Jesse
60d7bb2588
Use XDG_CONFIG_HOME dir by default for config files ( #66645 )
...
This PR changes the Config class in flutter_tools to use the XDG Base directory specification instead of putting files directly in the user's home directory. If those files are already present in the home directory, they are used instead.
2020-10-03 08:40:09 -07:00
Ben Konyi
65a81c7cd3
Roll package:dds to 1.4.0 and update error handling ( #66836 )
2020-09-29 10:28:17 -07:00
Jonah Williams
6f20c8a83f
[flutter_tools] handle missing zip/unzip argument errors ( #66685 )
...
it is possible for users that download the prebuilt SDKs to run the tool without unzip installed. Rather than crashing with an unclear argument error, exit the tool with a message on how to install that mirrors the message in the update_dart_sdk.sh script.
Also applied to zip for completeness
2020-09-29 07:58:09 -07:00
Jonah Williams
549de844ed
[flutter_tools] add a mechanism to turn off immediate tool exit ( #66787 )
...
Instead of always exiting the tool, provide a mechanism to turn off this behavior for non-critical functionality like configuration and analytics settings.
Fixes #66786 Fixes #4674
2020-09-28 13:04:38 -07:00
Jenn Magder
65159afb55
Force plugins to inherit minimum iOS version from Flutter app ( #66590 )
2020-09-28 10:14:47 -07:00
Jonah Williams
ec40df9576
[flutter_tools] dont mention git clone of flutter in run message ( #66691 )
...
This message is displayed if we do not find a pubspec.yaml
99% of the time this additional advice is going to have nothing to do with the actual error. Just remove it because it will cause more confusion than it could clear up
2020-09-25 21:27:22 -07:00
Jonah Williams
19fbe98df3
[flutter_tools] pass existsSync through error handling io ( #66704 )
...
Crash reporting shows at least one instance of EACCES during an existsSync cache call. Add this to the list of error handling io methods. Did not add the async exists method since we lint against its usage.
2020-09-25 20:17:39 -07:00
Jonah Williams
99d0954857
[flutter_tools] ensure ErrorHandlingFileSystem wraps current directory ( #66680 )
...
The lack of current directory wrapping was letting some of the already handled errors through
Fixes #66675
2020-09-25 14:29:22 -07:00
Jonah Williams
2c6f862bf8
[flutter_tools] add EPERM to set of immediate exit errors ( #66159 )
2020-09-21 11:32:07 -07:00
Daniel Edrisian
3a5e45404d
Updated androidMissingSdkInstructions error message ( #65964 )
2020-09-17 15:57:06 -07:00
gaaclarke
fa646339d6
Added the machine's architecture to macos doctor results. ( #65978 )
2020-09-16 17:47:04 -07:00
Ben Konyi
a17b330980
Reland "Re-enable the Dart Development Service (DDS) ( #64671 )" ( #65873 )
...
This reverts commit 66b01c1f29
2020-09-16 16:27:42 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. ( #65568 )
2020-09-16 14:14:06 -07:00
Jonah Williams
039f1cf853
[flutter_tools] handle terminals that do not support single char mode in Terminal.promptForCharInput ( #65418 )
...
Some terminals stdin do not support single char mode (like an emacs terminal buffer apparently). If this is the case, then the presented choice values would always have an appended newline \n which would prevent us from finding the value in the listed index (or using it as a signal for the default choice). To fix, treat '' as the default choice and always trim the choice value.
While this has seemingly always been broken, it wasn't noticeable until the multi-device selection prompt was added a few months ago.
Fixes #65267
2020-09-14 17:57:04 -07:00
Jonah Williams
6acea15f22
[flutter_tools] fix failure to create ansi spinner if download needs to be retried ( #65797 )
...
Because the Status spinner was only created on setup, the second stop would asset/crash.
Fixes #65449
2020-09-14 17:55:11 -07:00
Jonah Williams
0ea0e9d0b3
[flutter_tools] remove advice about running sdkmanager directly ( #65426 )
2020-09-10 13:05:03 -07:00
Jonah Williams
9248fda410
[flutter_tools] add EACCES to list of immediate exit tool conditions ( #65125 )
...
Similar to the permission denied error on Windows, this is not resolvable by the tool.
2020-09-03 16:08:01 -07:00
Jonah Williams
bd3eee75f3
[flutter_tools] rethrow process exceptions as tool exit from gradle build ( #64745 )
...
The flutter tool is currently unable to detect missing permissions in gradle/gradle.bat that would cause a gradle build to fail via process exception. Rather than crashing and exiting, we can display the exception as an error message and tool exit.
While linux/macOS are able to add the +x bit, this is not possible on windows with our current file system/OS API. These crashes represent a substantial amount of crash reporting, but are otherwise not actionable on our end.
2020-09-03 11:55:55 -07:00
includecmath
6d46ff7e9b
[flutter_tools] flutter run should allow exit when make choose for devices. ( #64403 )
2020-09-02 17:30:04 -07:00
Jonah Williams
d3fd62c843
[flutter_tools] exit with helpful message if where is missing on windows ( #65112 )
2020-09-02 16:50:04 -07:00
Mehmet Fidanboylu
66b01c1f29
Revert "Reland "Re-enable the Dart Development Service (DDS) ( #64671 )" ( #64847 )" ( #64981 )
...
This reverts commit c8f234d365
2020-08-31 16:09:02 -07:00
Jonah Williams
15d18b9e42
[flutter_tools] remove unused zip verification ( #64970 )
...
This is no longer used, in favor of just attempting to unzip and handling the exception.
2020-08-31 13:26:38 -07:00
Ben Konyi
c8f234d365
Reland "Re-enable the Dart Development Service (DDS) ( #64671 )" ( #64847 )
...
This reverts commit 2436de1391
2020-08-31 12:14:32 -07:00
Jonah Williams
2436de1391
Revert "Reland "Re-enable the Dart Development Service (DDS) ( #64671 )" ( #64802 )" ( #64845 )
...
This reverts commit eef0050d08
2020-08-28 18:02:15 -07:00
Ben Konyi
eef0050d08
Reland "Re-enable the Dart Development Service (DDS) ( #64671 )" ( #64802 )
...
* Reland "Re-enable the Dart Development Service (DDS) (#64671 )"
This reverts commit 2ae25cc2d7
2020-08-28 16:18:35 -07:00
Ben Konyi
2ae25cc2d7
Revert "Re-enable the Dart Development Service (DDS) ( #64671 )" ( #64797 )
...
This reverts commit d7d12412e5
2020-08-28 09:00:53 -07:00
Jonah Williams
5a4fa220e2
[flutter_tools] handle OsError thrown during azure detector ( #64749 )
2020-08-27 17:13:04 -07:00
Ben Konyi
d7d12412e5
Re-enable the Dart Development Service (DDS) ( #64671 )
...
This change re-enables DDS and outputs the DDS URI in place of the VM
service URI on the console. If --disable-dds is not provided,
--host-vmservice-port will be used to determine the port for DDS rather
than the host port for the VM service, which will instead be randomly
chosen.
2020-08-27 16:35:00 -07:00
Jonah Williams
d3515f5fb6
[flutter_tools] add analytics to code size, add more testing ( #64578 )
...
* [flutter_tools] add analytics to code size, add more testing
* add gradle case
* Update build_macos_test.dart
* move analytics to code size tooling
* Update analyze_size.dart
* fix analysis
2020-08-27 09:45:10 -07:00
Jonah Williams
23032d772d
[flutter_tools] refactor artifact downloading to retry zip exceptions. ( #64512 )
2020-08-25 10:06:04 -07:00
Jonah Williams
059de1537e
[flutter_tools] support code size tooling on iOS, linux, windows, macOS, and Android on Windows ( #63610 )
...
Adds support for size analysis on iOS, macOS, linux, and Windows - using an uncompressed directory based approach. The output format is not currently specified.
Adds support for size analysis on android on windows, switching to package:archive
Updates the console format to display as a tree, allowing longer paths. Increases the number of dart libraries shown (to avoid only ever printing the flutter/dart:ui libraries, which dominate the size)
2020-08-25 10:00:24 -07:00
Jonah Williams
302f9f751b
[flutter_tools] remove globals from utils ( #63831 )
2020-08-24 15:26:03 -07:00
Jonah Williams
ee12d7c3fc
[flutter_tools] check for permission issues when copying file ( #63540 )
2020-08-21 11:11:04 -07:00
Jonah Williams
a42c56791b
[flutter_tools] shrink fingerprinter API to currently used subset ( #63840 )
2020-08-18 17:01:06 -07:00
stuartmorgan
70bd819c52
Separate blkid in the Linux library checks ( #63810 )
2020-08-17 10:51:03 -07:00
stuartmorgan
6f0cfc9524
Surface Windows build errors in non-verbose mode ( #63707 )
2020-08-13 19:46:02 -07:00
Jonah Williams
9225d8d5b7
[flutter_tools] move to fake_async, skip failing tests ( #63536 )
2020-08-11 19:36:05 -07:00
James D. Lin
ec58182b3b
[flutter tools] Make SizeAnalyzer support .apk files that don't use libapp.so ( #63250 )
2020-08-10 21:06:05 -07:00
Nolan Scobie
43c1b34cf5
Add punctuation for unterminated sentences in doc comments ( #62755 )
...
* Add punctuation for unterminated sentences in doc comments
* Addressing review nit
2020-08-06 19:18:52 -04:00
Jenn Magder
0aafdf9aa9
Change minimum iOS version from 8.0 to 9.0 ( #62902 )
2020-08-06 13:46:15 -07:00
Peter Lee
8b39af2ea7
Implement size analyzer to unzip & parse APK and AOT size snapshot to generate analysis json ( #62495 )
...
* Implement size analyzer to unzip & parse APK and AOT size snapshot to generate analysis json
2020-07-31 13:25:29 -04:00
Ben Konyi
d6a25ae699
Temporarily disable Dart Development Service in flutter_tools ( #62508 )
...
Devtools doesn't currently support connections to DDS. Disable DDS
temporarily while a solution is worked on. See https://github.com/flutter/flutter/issues/62507
2020-07-29 12:32:10 -07:00
