Commit Graph

5496 Commits

Author SHA1 Message Date
Justin Hutchins
db528a24a3
Improve WebDriver error message (#81107)
* Add link to documentation in error message

The current WebDriver message is incomplete. Add link to
the documentation on WebDrivers for different browsers
to help troubleshooting.
2021-06-10 08:52:42 -07:00
Jonah Williams
10840352ce
[flutter_tools] switch flutter sdk to dart format (#84273) 2021-06-10 07:54:03 -07:00
Jenn Magder
e6fe1ed73a
Migrate android application_package to null safety (#84227) 2021-06-09 16:09:04 -07:00
Alexandre Ardhuin
e467018d06
alignment of doc comments and annotations (#84256) 2021-06-09 07:54:02 -07:00
Alex Melnyk
23d705c30b
Fix typo in create.dart (#82454) 2021-06-08 15:58:01 -07:00
Jonah Williams
6a75e48607
[flutter_tools] remove substantial mocking from version test (#84007) 2021-06-08 10:47:03 -07:00
Lau Ching Jun
89a3c353e6
Add more analytics for hot reload in flutter_tools. (#83972) 2021-06-07 18:51:47 -07:00
Jenn Magder
4c6a9dcb40
Migrate a few tool libraries to null safety (#83862) 2021-06-04 10:49:04 -07:00
Dan Field
febce13a94
Make retry logic more permissive for network errors (#83965) 2021-06-03 23:44:03 -07:00
Jonah Williams
ca789bf5a1
[flutter_tools] bail from printing if devtools launch fails (#83934) 2021-06-03 18:19:05 -07:00
Jenn Magder
c6359dc93f
Remove globals from android application_package (#83852) 2021-06-03 18:14:04 -07:00
Jenn Magder
f41fa9dd48
Migrate deferred_components_prebuild_validator to null safety (#83854) 2021-06-03 17:54:05 -07:00
ruskryzhanovskiy
a42159316b
Additional flags for xcodebuild (#83128) 2021-06-03 17:39:05 -07:00
Alexandre Ardhuin
32540774c0
enable lint noop_primitive_operations (#83930) 2021-06-03 17:34:10 -07:00
Aliaksei Chorny
871b0ce363
Double we typo fixed (#82933) 2021-06-03 17:34:06 -07:00
Jenn Magder
3477df744d
Migrate iOS project migrations to null safety (#83855) 2021-06-03 10:24:04 -07:00
Jonah Williams
1625befc36
[flutter_tools] check for empty host in protocol_discovery (#83847) 2021-06-03 08:29:05 -07:00
Jonah Williams
53e0c50a7c
[flutter_tools] use ProcessManager.canRun instead of checking for ArgumentErrors (#83845) 2021-06-03 08:24:04 -07:00
Jenn Magder
c4a2a3e92d
Migrate project.dart and all dependencies to null safety (#83817) 2021-06-02 18:41:12 -07:00
Jonah Williams
f666f93dbb
[flutter_tools] always use device.stopApp (#83803) 2021-06-02 17:34:02 -07:00
stuartmorgan
15317b9e8d
Disable clang format in the plugin registrants (#83285) 2021-06-02 10:29:10 -07:00
Anis Alibegić
c99ed373b3
Fixed large amount of spelling errors (#83744) 2021-06-02 10:14:06 -07:00
Jenn Magder
b947121f00
Clean up null assumptions for project.dart dependencies (#83445) 2021-06-01 13:14:03 -07:00
Jason Simmons
59f6cc7ac9
Add a trace-skia-allowlist flag for filtering Skia trace events (#83507) 2021-06-01 11:29:03 -07:00
Jay Zhuang
41ced7b5c3
[asset] Include assets in input files (#83416) 2021-06-01 11:24:04 -07:00
Alexandre Ardhuin
34059eec2c
enable lint prefer_interpolation_to_compose_strings (#83407) 2021-06-01 11:14:06 -07:00
Marian Triebe
722a493f3a
Add coldBoot parameter to JSON-RPC interface of daemon (#83488) 2021-05-28 09:14:03 -07:00
Jenn Magder
6d03cb65cb
Clean up null assumptions for Gradle classes (#83443) 2021-05-27 18:54:04 -07:00
Lau Ching Jun
a9d6131df8
Allow passing --initialize-from-dill to flutter run and flutter attach (#83454)
To specify the dill file that will be used to initialize the resident
compiler, instead of the default cached version.
2021-05-26 23:06:38 -07:00
Lau Ching Jun
27a6796233
Fix benchmark regression from #83427 (#83437) 2021-05-26 17:59:02 -07:00
Jonah Williams
025a3a7da3
[versions] roll package test redux (#83367) 2021-05-26 17:22:28 -07:00
stuartmorgan
57fcee28c7
Allow platform variants for Windows plugins (#82816)
Windows plugins are designed to share implementations between Win32 and
UWP, but not all plugins will support both. This adds a new
'supportedVariants' key to Windows plugins that allows specifying
'win32' and/or 'uwp' (and potentially others in the future in case that
becomes necessary).

Plugins without any supported variants will be assumed to be Win32 for
backward compatibility.

This will allow compiling Windows projects that use Win32-only Windows
plugins (which is currently all of them) in UWP mode. The plugins will
of course throw missing implementation exceptions at runtime, but tehy
won't prevent being able to build as they currently do.

Fixes https://github.com/flutter/flutter/issues/82815
2021-05-26 16:20:21 -07:00
Jenn Magder
cbc7ce0884
Clean up null assumptions for Xcode and CocoaPods classes (#83442) 2021-05-26 16:04:03 -07:00
Jenn Magder
00263c4f8a
Migrate build system build.dart to null safety (#83381) 2021-05-26 12:04:02 -07:00
Taha Tesser
f9cd87e60a
[flutter_tools] Add documentation to "cmdline-tools component is missing" doctor validation error (#83356) 2021-05-26 10:59:02 -07:00
Christopher Fujino
b9377f358c
Revert "[flutter_tools] Make flutter upgrade only work with standard remotes (#79372)" (#83423)
This reverts commit c835ad4362.
2021-05-26 10:04:47 -07:00
Jonah Williams
03a3e7b1e4
Revert "[flutter_tools] fix top web crasher (#83272)" (#83376) 2021-05-25 17:49:04 -07:00
Anurag Roy
c835ad4362
[flutter_tools] Make flutter upgrade only work with standard remotes (#79372) 2021-05-25 13:19:03 -07:00
Jenn Magder
a04f45f97b
Migrate deferred_components_gen_snapshot_validator to null safety (#83311) 2021-05-25 11:14:03 -07:00
Jenn Magder
2bf0627dea
Migrate localizations and generate_synthetic_packages to null safety (#83310) 2021-05-25 11:09:02 -07:00
Lau Ching Jun
fdb1fb184d
Add MultiRootFileSystem to better support using --filesystem-root. (#82991) 2021-05-24 22:04:02 -07:00
Jonah Williams
a8ec764609
[flutter_tools] fix top web crasher (#83272) 2021-05-24 18:04:02 -07:00
Jonah Williams
302e992ca7
[flutter_tools] throw a tool exit if pub cannot be run (#83293) 2021-05-24 14:34:02 -07:00
Jenn Magder
4bcf8fb40d
Migrate compile to null safety (#83153) 2021-05-24 11:24:02 -07:00
Jenn Magder
19eab105a5
Migrate build_system, exceptions, and source to null safety (#83147) 2021-05-24 10:29:04 -07:00
Michael Goderbauer
ee17ebe51f
Use type:int without format in gen_l10n (#83132) 2021-05-24 09:54:02 -07:00
Dan Field
a6b9c404f3
Remove dead code from attach.dart (#83187)
* Remove dead code from attach.dart

Remove dead code (see https://github.com/flutter/flutter/pull/30857/files#diff-70164e71957eed4bf8b4119543e779e808e3ddfedeceef98d4a24ab23efc99ecR214)
2021-05-23 10:02:26 -07:00
Jonah Williams
0f929f9f13
[flutter_tools] require cmdline-tools for android licenses (#82560) 2021-05-22 15:54:03 -07:00
Michael Goderbauer
485c409184
import pkg:intl when DateFormat or NumberFormat is used (#83122) 2021-05-21 19:04:04 -07:00
Jenn Magder
0d79013a81
Move globals.artifacts to globals_null_migrated, update imports (#83137) 2021-05-21 18:35:02 -07:00
Emmanuel Garcia
8a7f2dee51
Move AndroidX error handler to the end (#83135) 2021-05-21 18:29:03 -07:00
Michael Goderbauer
f7bcfa8e95
Be more helpful when l10n generation fails (#83134) 2021-05-21 17:19:02 -07:00
Emmanuel Garcia
fa5883b78e
Add Gradle lockfiles and tool to generate them (#83067) 2021-05-21 13:04:03 -07:00
Jonah Williams
b891adb4bd
[flutter_tools] migrate artifacts to null safety (#83073) 2021-05-21 11:54:03 -07:00
nt4f04uNd
80a2b6b015
Fix typos (#82589) 2021-05-20 17:19:09 -07:00
Jonah Williams
24bfc46d89
[flutter_tools] allow passing properties directly to gradle (#82941) 2021-05-20 16:19:03 -07:00
Balvinder Singh Gambhir
4a33813b35
[flutter_tools] added base-href command in web (#80519) 2021-05-19 12:39:02 -07:00
Marian Triebe
2d283504e6
Add cold boot option to emulator launch command (#82647) 2021-05-19 10:54:04 -07:00
Hattomo (TomohiroHattori)
08a70e7ac8
Enable avoid_escaping_inner_quotes lint (#81153) 2021-05-19 09:54:02 -07:00
Jonah Williams
84734ecc54
[flutter_tools] pin shelf (#82869) 2021-05-18 23:09:03 -07:00
Jonah Williams
666675078c
[flutter_tools] adjust some feature settings (#82851) 2021-05-18 20:49:03 -07:00
Jenn Magder
8f536ec17b
Default --no-tree-shake-icons to false for 'flutter build bundle' (#82773) 2021-05-18 20:34:04 -07:00
Lau Ching Jun
2acd0007d6
Refactor CustomDimensions in analytics to be type safe (#82531) 2021-05-18 20:29:03 -07:00
Jay Zhuang
f512ebfd06
[fuchsia_asset_builder] Write depfile (#82469) 2021-05-18 20:24:04 -07:00
Jonah Williams
5c09eecd0d
[flutter_tools] remove special casing of web listview requests (#82826) 2021-05-18 13:19:03 -07:00
Jonah Williams
a3863b6592
[flutter_tools] support memory profiles from flutter drive (#82739) 2021-05-17 17:39:03 -07:00
Taha Tesser
0f03147138
remove unnecessary comment (#82650) 2021-05-17 11:59:02 -07:00
Chris Bracken
e364e30c90
[tool] Prefer installing multi-arch Win32 binaries (#82668)
Depending on the user's build configuration, we may output
multi-architecture or single-architecture binaries. Prefer to install
the multi-architecture binary if built, otherwise fall back to the
single-architecture binary.
2021-05-16 19:40:00 -07:00
Chris Bracken
7c5857d3b0
[tool] Improve Windows install process (#82659)
This eliminates the use of the Install.ps1 script during Windows app
installation and instead uses uwptool install. Install.ps1 was the
slowest part of app install, and had resource contention issues that
frequently caused it to fail.
2021-05-16 17:21:18 -07:00
Chris Bracken
40bb2b293d
Add missed package version bump override (#82593)
In https://github.com/flutter/flutter/pull/82577, I landed a version
bump of package shelf and package flutter_template_images. This local
override should have been part of that patch but was missed in the
checkin.

The version bumps themselves happened in the previous patch; this just
ensures we don't accidentally 'upgrade' back to version 1.0.2.
2021-05-14 18:00:27 -07:00
Chris Bracken
90d978f8fb
Add windowsIdentifier template parameter (#82588)
Windows package identifiers are globally unique strings, typically a
GUID. These are required for templates that require a Windows package
name as described in
https://docs.microsoft.com/en-us/windows/win32/appxpkg/appx-portal

Fixes https://github.com/flutter/flutter/issues/82587
2021-05-14 17:48:30 -07:00
Jenn Magder
ea21938ccc
Remove symroot from generated iOS Xcode build settings (#82576) 2021-05-14 17:09:04 -07:00
Jonah Williams
5d7b40190a
[flutter_tools] remove mocks from downgrade and devices test (#82579) 2021-05-14 16:28:39 -07:00
Taha Tesser
99472cf072
fix pkg typos (#82544) 2021-05-14 13:09:03 -07:00
Abhishek Ghaskata
b554f893bd
Enable unnecessary_null_checks lint (#82084) 2021-05-14 10:44:03 -07:00
Gary Roumanis
e3fd8dbfd5
Update loader style (#82485) 2021-05-13 22:59:03 -07:00
Taha Tesser
3c72ef374d
Fix Android Studio 4.2 detection on Windows (#82484) 2021-05-13 22:54:04 -07:00
Jonah Williams
ed85dd49c7
[flutter_tools] use try to delete in web cache (#82478) 2021-05-13 21:44:02 -07:00
Jonah Williams
0f8a6ab4dd
[flutter_tools] make failures to unforward android port non-fatal (#82477) 2021-05-13 21:39:03 -07:00
Jenn Magder
8334fb0a1e
Tool exit on xcodebuild -list when Xcode project is corrupted (#82476) 2021-05-13 21:34:04 -07:00
Emmanuel Garcia
93c87e92b3
[flutter_tool] Suggest fix for transform input (#82309) 2021-05-13 21:24:04 -07:00
Chris Bracken
14546bfad1
Support uninstall, install status query for UWP (#82481)
Adds UwpTool.install and UwpTool.uninstall methods. Refactors the
PowerShell-based install code to move the powershell-related bits out of
the Device class and into UwpTool so that when we swap out the
PowerShell-based install for the uwptool-based install, it's transparent
to the WindowsUWPDevice class.

Adds implementations for:
* WindowsUWPDevice.isAppInstalled
* WindowsUWPDevice.uninstallApp

Refactors:
* WindowsUWPDevice.installApp
2021-05-13 16:15:09 -07:00
Jonah Williams
344f3ab7d9
[flutter_tools] swap web debugging protocol to ws (#82456) 2021-05-13 16:04:03 -07:00
Emmanuel Garcia
60633b609c
[flutter_tool] Suggest how to increase the Android minSdkVersion (#82372) 2021-05-13 11:59:04 -07:00
Kenzie Schmoll
766b4509c6
Add 'v' hotkey to open DevTools in the browser (#82227)
* Add 'v' hotkey to open DevTools in the browser
2021-05-13 09:54:10 -07:00
Chris Bracken
53c2f7086b
[flutter_tools] support flutter run -d winuwp (#82373)
Allow flutter run to work end-to-end with a UWP device.

Uses win32/ffi for the actual launch of the application, injected via
the native API class. This is structured to avoid a g3 dependency.

Install and amuid require powershell scripts for now.

Actually connecting to the observatory requires running a command in an
elevated prompt. Instructions are presented to the user if a terminal is
attached.

This is a rebased version of https://github.com/flutter/flutter/pull/79684
by @jonahwilliams, updated to remove `NativeApi` and replace is with calls
to `uwptool`.

Part of https://github.com/flutter/flutter/issues/82085
2021-05-12 20:45:30 -07:00
Alexandre Ardhuin
c03e7488b4
remove noop primitive operations (#82297) 2021-05-12 00:04:02 -07:00
Shi-Hao Hong
633edb649f
[gen-l10n] Cleans up formatting of the generated file (#79517) 2021-05-11 17:19:05 -07:00
Renan
293756455c
Re-land: Allow users to pass in Xcode build settings as env variables to flutter build macos FLUTTER_XCODE_ (#82298) 2021-05-11 17:09:09 -07:00
Taha Tesser
0d50604a56
[reland] Adding vscode path installed via snap (#81989) 2021-05-11 17:04:03 -07:00
Jenn Magder
c1c12aa365
Add posix permission chown suggestion to io error handling (#81942) 2021-05-11 14:54:02 -07:00
Dan Field
111c6ab136
Fix reuseApplication when ws URI does not end with / (#82066) 2021-05-10 16:29:03 -07:00
Michael Goderbauer
b8a2456737
Enable library_private_types_in_public_api lint (#81578) 2021-05-10 16:26:16 -07:00
Anurag Roy
6e08ea0a2c
[flutter_tools] Show linux distribution and kernel release in flutter doctor (#81368) 2021-05-10 10:04:02 -07:00
Dan Field
f82794c968
Fix missing logger (#82064) 2021-05-08 23:29:03 -07:00
Jenn Magder
783e1dd22c
Standardize build system environment defines derived from build info (#81879) 2021-05-07 17:04:02 -07:00
Emmanuel Garcia
094179e82d
Enable Dart plugin registrant on Desktop only (#81586) 2021-05-07 15:36:32 -07:00
Alexandre Ardhuin
9bca38c5e5
remove unnecessary String.toString() (#81859) 2021-05-07 14:54:02 -07:00
Zachary Anderson
04bb954a7d
Revert "Allow users to pass in Xcode build settings as env variables to flutter build macos FLUTTER_XCODE_ (#81384)" (#82004)
This reverts commit 0bba935b76.
2021-05-06 19:04:23 -07:00
Jenn Magder
3e6fe491f3
Remove extended attributes from entire Flutter project (#81435) 2021-05-06 16:34:04 -07:00