Commit Graph

6132 Commits

Author SHA1 Message Date
Christopher Fujino
08d5d51a98
[flutter_tools] Instantiate shutdown hooks before localfilesystem (#110693) 2022-09-02 17:38:56 +00:00
Pierre-Louis
0c2f7bc2a2
Remove errant double spaces (#110758) 2022-09-02 04:00:58 +00:00
David Iglesias
9cb9f6bca4
[tool] Fix flutter.js regression with hot-reload on promise-based init. (#110805) 2022-09-01 22:25:16 +00:00
Christopher Fujino
8361465f77
[flutter_tools] change the way version is calculated on master (#110791) 2022-09-01 20:32:36 +00:00
Gary Qian
ddfcda73cd
Track platform in MigratePlaformConfig and enforce metadata file being provided (#110540) 2022-08-31 19:04:22 +00:00
Tae Hyung Kim
0508a1defd
[flutter_tools] Generate Localizations on flutter run for web (#110526) 2022-08-31 17:42:51 +00:00
Helin Shiah
8842281c29
Use UriConverter from context for test (#110539)
* Use UriConverter from context for test

* Fix type

* Pass URI converter using installHook

* Fix formatting

* Fix formatting in test

* Add comment about URI converter
2022-08-31 09:20:36 -07:00
Jenn Magder
5f5d4802fe
Support single arch local engines for 'build macos-framework' and 'ios-framework' (#110564) 2022-08-30 17:44:14 +00:00
Zachary Anderson
c6ec84e978
[flutter_tools] Pull more arm64 artifacts on Apple Silicon (#110291) 2022-08-29 10:33:24 -07:00
Zachary Anderson
0e195e9d46
Revert "Show output from pub get in flutter pub get (#106300)" (#110478)
This reverts commit 3802eb627e.
2022-08-29 08:02:50 -07:00
Sigurd Meldgaard
3802eb627e
Show output from pub get in flutter pub get (#106300) 2022-08-29 07:37:19 +00:00
Jonah Williams
428cafadb0
[flutter_tools] migrate some files to null safety (#110354) 2022-08-26 18:03:04 +00:00
Christopher Fujino
db51e5d944
[flutter_tools] unpin path_provider_android and roll (#110216) 2022-08-25 19:42:21 +00:00
Danny Tuppeny
676a4264aa
[dap] Don't wait for appStarted before responding to launch/attach + don't call app.stop for unstarted app (#109386) 2022-08-25 15:35:09 +00:00
Christopher Fujino
6e95067273
[flutter_tools] Fix _CastError in HotRunner._resetDirtyAssets (#108771) 2022-08-24 23:40:19 +00:00
eggfly
cf309b61b4
Fix some typos (#110077) 2022-08-24 21:56:09 +08:00
Zachary Anderson
bd6b5cef95
[flutter_tools] Enable custom devices on all channels (#109953) 2022-08-21 12:16:53 -07:00
Jesús S Guerrero
e271e8428b
add GeneralInfo project validator to analyze --suggestions (#109874) 2022-08-19 21:18:49 +00:00
Tae Hyung Kim
646666f8e7
[gen_l10n] Add option to format generated localizations files (#109171)
* init

* fix

* fix 2

* fix 3

* tests

* fix tests

* clarify help text

* fix all tests

* fix formatting?

* add second test

* unused import

* remove print

* trailing spaces

* artifacts is never null

* fix
2022-08-19 14:03:42 -07:00
Anna Gringauze
b7c500fc6b
Remove passing of --debugger-module-names flag to frontend server (#109791)
The flag is true by default so the behavior does not change.

Next steps:

Use the flag for updated debugger module names:
  - Frontend server: make the current behavior controlled
    by the flag non-conditional
  - Frontend server: add more debugging names changes under
    the same flag, false by default
  - Dwds: make changes required for the new module names.
  - Flutter tools: when matching dwds changes roll to flutter,
    pass the flag to the frontend server again.

- Cleanup:
  - Frontend server: make new behavior default
  - Flutter tools: remove uses of the flag.
  - Frontend server: remove the flag.

Towards: https://github.com/dart-lang/webdev/issues/1692
Helps: https://github.com/flutter/flutter/issues/106727
2022-08-19 11:14:43 -07:00
Anna Gringauze
3b6e3a6938
Temporarily remove a bogus warning until fixed by dwds update (#109793)
* Temporarily remove a bogus warning until fixed by dwds update

* Addressed CR feedback
2022-08-19 11:06:53 -07:00
Jackson Gardner
5aad12cab1
Generate syntax for plugin registration that works both with and without null safety. (#109480) 2022-08-19 16:16:41 +00:00
jensjoha
981bdf5476
[flutter_tools] Make flutter test -v print timing of different phases (#108864) 2022-08-18 16:26:56 +00:00
Alexander Aprelev
bfdc9a6cfa
Introduce stubbed exclusive parameter to File.create-overridden method (#109646)
* Introduce stubbed `exclusive` parameter to `File.create`-overridden method.

This is to soften landing of a breaking change https://github.com/dart-lang/sdk/issues/49647
2022-08-17 13:26:08 -07:00
Gary Qian
beef848630
Update flutter.gradle AGP to 7.2.0 and bump default NDK version (#109211) 2022-08-15 23:57:46 +00:00
Christopher Fujino
b79c216845
[flutter_tools] Pin path_provider_android (#109429) 2022-08-12 01:18:41 +00:00
Xavier H
341b62d28e
Fix Transporter app name in log after upload (#107414) 2022-08-11 20:42:33 +00:00
Jesús S Guerrero
edd466811d
Disable jank metrics for web (#109356) 2022-08-11 19:58:06 +00:00
Christopher Fujino
017dd3e7d6
[flutter_tools] Fix race condition with completer in devfs_web (#109059) 2022-08-09 23:57:06 +00:00
Jesús S Guerrero
5627e0d1f6
Add info project validator status (#109169) 2022-08-09 17:59:06 +00:00
Dillon Nys
f3d182f4b4
[flutter_tools] Fix tool crash for map cast (#107648) 2022-08-09 05:51:06 +00:00
Jonah Williams
921c80302c
[flutter_tools] support hot reload of font assets (#109091) 2022-08-08 20:42:06 +00:00
Pierre-Louis
de8a2fa6a7
Update packages (#109054)
In particular, to get `material_color_utilities` `0.2.0`.
2022-08-05 15:21:03 -04:00
Jonah Williams
f62da01068
[flutter_tools] ensure setAssetDirectory uses windows path (#109021) 2022-08-05 15:44:08 +00:00
Aman Verma
b02f68a66c
[flutter_tools] refactor stringsArg (#105032) 2022-08-05 13:17:06 +00:00
Michael Goderbauer
e27a19e3f8
Remove outdated ignores (#108924) 2022-08-03 23:37:05 +00:00
David Iglesias
04f7ea8459
[web] Add onEntrypointLoaded to FlutterLoader. (#108776) 2022-08-03 20:58:06 +00:00
Hannes Winkler
c6aeaa305c
fix flutter not finding custom device (#108884) 2022-08-03 18:20:07 +00:00
Christopher Fujino
4b25e80c4a
[flutter_tools] Migrate more tool tests to null-safety (#108639) 2022-08-02 23:00:06 +00:00
Phil Quitslund
fd0da75cc9
fix noop toString() diagnostics (#108836) 2022-08-02 21:51:06 +00:00
Jenn Magder
6ca4db4bea
Add usage event when macOS app is archived (#108651) 2022-07-30 00:45:05 +00:00
Jenn Magder
7f1a8f7948
Add usage event when iOS app is archived (#108643) 2022-07-29 22:44:06 +00:00
Sam Rawlins
0c57b31265
Ignore body_might_complete_normally_catch_error violations (#106563) 2022-07-29 19:59:08 +00:00
Jesús S Guerrero
6048e07f47
[flutter_tools] join flutter specific with home cache (#105343) 2022-07-29 19:58:06 +00:00
Gary Qian
762c92ead9
Remove doc for --ignore-deprecation and check for pubspec before v1 embedding check (#108523) 2022-07-28 20:48:05 -07:00
Gary Qian
7cfbdadc33
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108472 (#108510) 2022-07-28 19:38:07 -07:00
Kate Lovett
716533925b
Revert "Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108355 (#108472)" (#108488)
This reverts commit 1f8c490c82.
2022-07-27 17:20:20 -05:00
Gary Qian
1f8c490c82
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108355 (#108472) 2022-07-27 14:23:09 -07:00
Zachary Anderson
15082387c6
[flutter_tool] Include impellerc output in ShaderCompilerException (#108348) 2022-07-27 11:37:14 -07:00
Jonah Williams
7e683c023a
[flutter_tools] add tool support for shader hot reload (#107963) 2022-07-27 03:31:06 +00:00
Zachary Anderson
1e69683688
Revert "Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" (#108355)" (#108407)
This reverts commit c4b3625d62.
2022-07-26 19:30:28 -07:00
Gary Qian
c4b3625d62
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" (#108355) 2022-07-26 16:23:08 -07:00
Jenn Magder
4dc1bd40d4
Handle updated error message when iOS device is locked (#108057) 2022-07-26 22:33:07 +00:00
Tae Hyung Kim
001c499f24
[gen_l10n] Warn users when placeholder types are converted to 'num' when using pluralization (#108036)
* init

* asdf

* fix tests

* change warning slightly

* fix test again

* fix spacing and comment

* fix lint
2022-07-26 14:13:06 -07:00
Anurag Roy
f1df76e963
[flutter_tools] Suggest actions to fix failing FlutterValidator (#106355) 2022-07-26 19:47:07 +00:00
Jenn Magder
50474b29ce
Only run pod install on the first iOS build (#108205) 2022-07-26 19:39:06 +00:00
Jenn Magder
70aaff1217
Set Xcode build script phases to always run (#108331) 2022-07-26 19:20:07 +00:00
Jenn Magder
167655e8a7
Only show iOS simulators, reduce output spew in verbose (#108345) 2022-07-26 19:08:06 +00:00
Danny Tuppeny
5d31b07ed5
[flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (#108310)
* [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate

Fixes an issue where the flutter_tester device may not be cleaned up correctly if we just terminate the Flutter process.

* Update integration test expectations

* Revert accidental commit
2022-07-26 10:48:38 +01:00
Zachary Anderson
d155bc1bad
Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (#108349)
This reverts commit ca6cecf034.
2022-07-25 22:20:37 -07:00
Gary Qian
ca6cecf034
Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197) 2022-07-25 15:23:08 -07:00
RockerFlower
5f67b47e23
[iOS] Update template icons (#107873) 2022-07-25 21:36:06 +00:00
Danny Tuppeny
2f4299ad35
[flutter_tools] Remove unused parameter when connected DAP to VM Service (#108285)
Since 02d9c3e6a5 this flag does absolutely nothing. The behaviour it controlled is now automatic and the flag is not required.

The flag will be removed from the Dart SDK in the future after Flutter is no longer using it.
2022-07-25 18:28:12 +01:00
Rich Kadel
549f70c914
Remove outdated Fuchsia concepts (#107335)
Fuchsia will soon remove all support for Component Framework version 1
components (recognized by component manifests ending in `.cmx`).
Notably, some of the `flutter` tool commands for Fuchsia devices--
notably, but not limited to, those related to CFv1--are outdated, and
either do not work today or soon won't work.

This PR removes the outdated components and commands, replacing some
with the newer version, or simply removing the non-working features,
in some cases.
2022-07-22 16:42:48 -07:00
Zachary Anderson
dd20919ad6
[flutter_tool] Build shaders as .iplr and use FragmentProgram.fromAsset for ink_sparkle (#108071) 2022-07-21 20:50:08 -07:00
Christopher Fujino
6abd3691c3
[flutter_tools] add more debugging when pub get fails (#108062) 2022-07-21 19:22:07 +00:00
Jesús S Guerrero
fc3471fd28
check for pubspec instead of lib/ (#107968) 2022-07-21 17:03:09 +00:00
yaakovschectman
1e2be6ed54
Check for bad characters in path on Windows build (#107949)
* Check for bad characters in path on Windows build

* Doc comments

* Fix formatting

* Commenting/formatting

* Link to issue in comment

* Comments, formatting

* Global var rename
2022-07-20 14:05:13 -04:00
Lau Ching Jun
922eea8763
Dart registrant location (#107967) 2022-07-20 08:51:04 +00:00
David Iglesias
d72f08f50f
[web][debug] Remove RequireJS timeouts for debug builds. (#107868) 2022-07-19 22:56:05 +00:00
Danny Tuppeny
c67d2587d5
Provide more useful error message if a non-compliant DAP tool (or user) sends bad input to DAP server (#107827) 2022-07-19 11:48:05 -07:00
Zachary Anderson
e9529e2512
[flutter_tool] Allow includes relative to shader path (#107862) 2022-07-18 18:38:32 -07:00
Christopher Fujino
1371b8dc3c
[flutter_tools] Fix null check errors in attach command (#107864) 2022-07-18 23:10:06 +00:00
Alexandre Ardhuin
ccd33631e3
enable combinators_ordering (#107847) 2022-07-18 22:04:07 +00:00
Christopher Fujino
81045d4a44
Revert "Read dart_plugin_registrant path from FlutterProject to support non-standard path." (#107850) 2022-07-18 19:58:10 +00:00
Christopher Fujino
4f9528293f
[flutter_tools] Remove shuffle from doctor test (#107744) 2022-07-16 00:54:05 +00:00
Jesús S Guerrero
cdf5b1d40d
Pub dependencies project validator (#106895) 2022-07-15 23:12:05 +00:00
Lau Ching Jun
2cfeb0d1e1
Pass device-user in machine mode (#107747) 2022-07-15 15:18:05 -07:00
Lau Ching Jun
8f834cf150
Read dart_plugin_registrant path from FlutterProject to support non-standard path. (#107617) 2022-07-15 12:33:07 -07:00
Christopher Fujino
060adf09db
[flutter_tools] Migrate commands.shard/hermetic/doctor_test to null-safety and make hermetic (#107670) 2022-07-15 19:06:08 +00:00
Christopher Fujino
94da724868
[flutter_tools] fix RangeError in gen-l10n by checking for empty string (#107604) 2022-07-15 18:56:09 +00:00
Tae Hyung Kim
2da228593f
[gen_l10n] Throw error when arb file does not exist (#107583) 2022-07-15 18:18:06 +00:00
Jenn Magder
c4975d9be0
Increase app minimum supported macOS version from 10.11 to 10.13 (#107689) 2022-07-15 11:12:43 -07:00
Lau Ching Jun
5976c3702f
Check device type using platformType instead of type check to support proxied devices. (#107618) 2022-07-14 14:38:06 -07:00
Callum Moffat
902b0124a6
Add UIApplicationSupportsIndirectInputEvents migration (#106889) 2022-07-14 21:00:06 +00:00
Christopher Fujino
cadb264d26
[flutter_tools] Catch more general XmlException rather than XmlParserException (#107574) 2022-07-13 22:38:07 +00:00
jensjoha
803ef6a456
Improve coverage speed by using new caching option for package:coverage (#107395)
Speedup coverage test runs by using (new) coverage handle with caching.

On a `flutter test --coverage` run on `packages/flutter` the runtime goes from ~828 seconds to ~617 seconds, or a ~25% reduction in time spent (testing without coverage takes ~236 seconds so the overhead of `--coverage` in this case goes from ~592 seconds to ~381 seconds, or a ~35% reduction).
2022-07-13 11:07:59 +02:00
Anurag Roy
e6f69add99
[flutter_tools] Replace android v2 embedding broken doc link (#107456) 2022-07-12 20:31:07 +00:00
Danny Tuppeny
78d924af1d
[flutter_tools] [dap] Add support for passing env variables to spawned processes (#107415)
* [flutter_tools] [dap] Add support for passing env variables to spawned processes

* Use named args

* Use in-memory fs and FakePlatform

* Pass filesystem style to MemoryFileSystem
2022-07-12 10:04:08 +01:00
Bryan Oltman
bf7df23350
Remove superfluous periods from pub --help subcommand descriptions. (#106925)
* Remove periods from pub --help command descriptions

* Add trailing period consistently

* Remove added period from PackagesInteractiveGetCommand description

* Verify line ending for first line of command description

* Update _allowedTrailingPatterns to validate that lines end with only one period, bang, or colon
2022-07-11 13:06:31 -04:00
Alexander Biggs
7db73c0a93
[fuchsia] Change format of ffx call to debug spam. (#105169) 2022-07-10 22:51:06 +00:00
Christopher Fujino
84c8abd0f6
[flutter_tools] catch StdinException while trying to re-set single char mode (#107256) 2022-07-07 22:40:05 +00:00
Helin Shiah
118248bcc5
Pass URI converter from context to DDS (#106840)
* Pass URI converter from context to DDS

* Match change that will be merged

* Revert SDK web change
2022-07-07 10:10:04 -07:00
Alexander Aprelev
b1410c2ce7
Ensure flutter run build is done in incremental mode. (#107184)
* Ensure build is done in incremental mode.

This allows for faster bootstrapping of the compiler from previously created dill file.

Fixes https://github.com/flutter/flutter/issues/107183

* Avoid initializeFromDill in aot mode

* Update tests
2022-07-07 09:31:18 -07:00
Christopher Fujino
19ac08dcd7
manual pub package roll; remove test_api pin, unblock bumping dwds (#106887) 2022-07-06 17:28:07 +00:00
David Iglesias
c4aaa394ac
[tool][web] Create an early web plugin_registrant for dartpad. (#106921) 2022-07-02 00:51:06 +00:00
Loïc Sharma
dcbdff087b
Ignore invalid description property in vswhere.exe JSON output (#106836)
The `flutter doctor` command uses `vswhere.exe` to verify the Visual Studio installation. This `vswhere.exe` is known to encode its output incorrectly. This is problematic as the `description` property is localized, and in certain languages this results in invalid JSON due to the incorrect encoding.

This change introduces a fallback to our `vswhere.exe` output parsing logic: if parsing JSON fails, remove the `description` property and retry parsing the JSON.

This fix was also tested on the outputs provided here: https://github.com/flutter/flutter/issues/106601#issuecomment-1170138123

Addresses https://github.com/flutter/flutter/issues/106601
2022-06-30 16:15:20 -07:00
Zachary Anderson
b005a34790
[flutter_tool] Pass --input-type to impellerc (#106845) 2022-06-30 07:12:24 -07:00
Daco Harkes
e4bde83d7f
plugin_ffi warn about lack of platform support (#106813) 2022-06-29 10:29:11 -07:00
Zachary Anderson
9c0f239947
Put shaders under a 'shaders' section in the manifest (#106752) 2022-06-28 19:31:27 -07:00