Commit Graph

9155 Commits

Author SHA1 Message Date
Michael Goderbauer
59bfab157e
Reland "Call mark* methods before attaching child (#25239)" (#25395)
This reverts commit ea7d086e11.

The revert did not fix the flakiness.
2018-12-15 13:29:54 -08:00
Stanislav Baranov
c5251cdc02
Flutter tool support for automatic saving of JIT compilation trace (#25301) 2018-12-14 16:09:17 -08:00
Hans Muller
30fb97be42
Fixed Typography null factory constructor (#24932) 2018-12-14 16:01:17 -08:00
jslavitz
ad2e3eb3b5
Adds support for floating cursor (#25384)
* Adds support for floating cursor.
2018-12-14 15:17:33 -08:00
Jonah Williams
b4f1d5a924
Add fuchsia devices to daemon command (#25344) 2018-12-14 14:37:55 -08:00
S McDowall
4c24bcc862 Remove TextField.noMaxLength, use maxLength = -1 instead (#24999) 2018-12-14 14:18:35 -08:00
David Shuckerow
1a60b166f2
Add ipv6 and observatory port support to the attach command (#25303)
* Add ipv6 and observatory port support to the attach command.

* Remove whitespace

* Explain why a name change is useful here

* Refactor common flags out into the parent

* Add an additional test case for when observatory port is provided but debug port is not

* Remove whitespace

* Fix flag validation
2018-12-14 18:03:49 -04:00
Jonah Williams
a0efb78640
Revert "drop/restore focus when app becomes invisible/visible" (#25390) 2018-12-14 12:45:07 -08:00
Hans Muller
8c439fd39f
IntrinsicWidth stepWidth or stepHeight == 0.0 (#25228) 2018-12-14 12:30:01 -08:00
Jonah Williams
ff97e255b5
drop/restore focus when app becomes invisible/visible (#24744) 2018-12-14 12:15:52 -08:00
Michael Goderbauer
ea7d086e11
Revert "Call mark* methods before attaching child (#25239)" (#25382)
This reverts commit 5c1f1d7618.

Reverting to see if that fixes flakiness of flutter_gallery__transition_perf_with_semantics in devicelab.
2018-12-14 10:30:49 -08:00
Jonah Williams
4cd87705b7
Revert "Adds support for floating cursor (#24761)" (#25352)
This reverts commit 46878d8485.
2018-12-13 20:36:08 -08:00
jslavitz
46878d8485
Adds support for floating cursor (#24761)
* Adds support for floating cursor!
2018-12-13 20:14:27 -08:00
Jasper van Riet
01694ab62d Allow detection of taps on TabBar (#23919) 2018-12-13 13:01:34 -08:00
Justin McCandless
c5457068df
Revert "obscureText and enableInteractiveSelection defaults (#24527)" (#25335)
This reverts commit f8f5953d80.
2018-12-13 11:58:37 -08:00
Justin McCandless
f8f5953d80
obscureText and enableInteractiveSelection defaults (#24527)
* obscureText true defaults to disabling selection

* Tests and comments for selectable text field

* Improve selection docs

* Refactor so that all enableInteractiveSelection params are null by default, delegate to selectionEnabled

* Fix selection param macros
2018-12-13 11:09:13 -08:00
Justin McCandless
952d24bf1e
Text field style merge (#24449)
* Merge TextField style with global style so that style changes don't override unspecified fields

* Test that a style param is merged with the theme

* Test a few more style properties

* Analysis fix
2018-12-13 08:32:55 -08:00
MH Johnson
92efec3998
[Material] Theme-able elevation on dialogs. (#24169)
* Themable elevation on dialogs.

* Added `BackgroundColor` in widget + theme

* Addressing Comments

* Fix test name

* Add debugFillProperties test
2018-12-13 09:11:01 -05:00
Michael Goderbauer
5c1f1d7618
Call mark* methods before attaching child (#25239) 2018-12-12 16:45:51 -08:00
David Shuckerow
e6292c8da1
Revert "Add ipv6 and observatory port support to the attach command." (#25288)
* Revert "e5195ee47 Remove unnecessary includes of Ganesh headers (flutter/engine#7189) (#25282)"

This reverts commit f198d66332.

* Revert "Validate style in TextField (#24587)"

This reverts commit 9a8e2f0c4b.

* Revert "Allow snippets tool to be run from arbitrary CWDs (#25243)"

This reverts commit 4a110b6227.

* Revert "Make doctor output consistent between VS Code/IntelliJ/Android Studio when plugins are missing (#25269)"

This reverts commit e29b023a6b.

* Revert "Add ipv6 and observatory port support to the attach command. (#24537)"

This reverts commit 9150b3f031.
2018-12-12 16:56:50 -04:00
Jonah Williams
f30029bae1
Run flutter tests through mini test engine when run directly (flutter run -t test_file) (#24930) 2018-12-12 12:51:16 -08:00
Justin McCandless
9a8e2f0c4b
Validate style in TextField (#24587)
* Validate style in TextField

* Fix analyze problems

* Use assert and move to top

* Simplified assertion
2018-12-12 09:44:43 -08:00
Danny Tuppeny
e29b023a6b
Make doctor output consistent between VS Code/IntelliJ/Android Studio when plugins are missing (#25269)
* Update VS Code validator to match Android Studio

- Now shows a tick (instead of partial) if installed
- Now shows a cross (instead of dot) if extension is not installed

Fixes #22931.
2018-12-12 17:36:42 +00:00
David Shuckerow
9150b3f031 Add ipv6 and observatory port support to the attach command. (#24537) 2018-12-12 08:28:02 -08:00
Danny Tuppeny
2994d3562a
Add some a basic debug stepping tests (#24515) 2018-12-12 10:56:54 +00:00
Trevor Wang
114335dff0 Support TextField multi-line hint text #20941 (#24976) 2018-12-11 22:46:05 -08:00
xster
65df90d8b5
Add navigatorKey to CupertinoTabView (#25183) 2018-12-11 19:29:13 -08:00
Michael Goderbauer
8ca8dbf062
Do not fade out text for pinned & floating AppBar (#25051) 2018-12-11 19:24:00 -08:00
Jonah Williams
c461e93363
Revert "Ensure that cache dirs and files have appropriate permissions" (#25240) 2018-12-11 15:33:57 -08:00
Hans Muller
234855ca3d
Handle a TabBarView special case: last tab deleted before animation ends (#24892) 2018-12-11 14:22:27 -08:00
Jimmy Casey
3cca1a2ec3 Fixed Spelling. (#25217) 2018-12-11 10:50:51 -08:00
Justin McCandless
6901cd4625
TextFormField cursor params (#24635)
* cursor fields on textformfield

* Test pass-through of cursor properties
2018-12-11 10:42:10 -08:00
Hans Muller
f14055529b
Fixed an InheritedWidget doc typo (#25168) 2018-12-11 09:53:45 -08:00
Jonah Williams
b080a476c8
Fuchsia multiple devices and target (#24953) 2018-12-11 09:18:21 -08:00
Hans Muller
f8a7abb6b8
Add a check for build methods that return context.widget (#25046) 2018-12-11 08:59:28 -08:00
Danny Tuppeny
3f1c308e58
Don't require the AVD folder to exist in order to run flutter emulators (#25154)
Fixes #24750.
2018-12-11 15:27:25 +00:00
Michael Goderbauer
7120dab553
Don't crash if pinned & floating AppBar has less than minExtent remainingPaintExtent (#25048)
Fixes https://github.com/flutter/flutter/issues/21887
2018-12-11 07:18:53 -08:00
Michael Goderbauer
b023a57483
Fix debugPrint(null) to not crash (#24942) 2018-12-11 00:16:43 -08:00
Michael Goderbauer
46599167d5
Remove offstage wording from KeepAlive (#24881)
What KeepAlive does is different from the Offstage widget. Let's not confuse these two and be more speicific in the wording for KeepAlive.
2018-12-10 22:37:46 -08:00
Jonah Williams
61291aeeaf
ensure lastBuildTimestamp is set before early return (#25058) 2018-12-10 15:57:52 -08:00
Todd Volkert
243222c00d
Include error message in crash reports (#24632)
This modifies our flutter_tools crash reports to include the error
message. This error message may contain personally identifying
information (PII), such as a file system path on the developer's
local machine that may contain user names, project code names,
etc. To disable crash reporting, the developer can run the
following command:

    flutter config --no-analytics

For more information on what gets reported during crashes of the
flutter tool, see:

https://github.com/flutter/flutter/wiki/Flutter-CLI-crash-reporting
2018-12-10 13:59:47 -08:00
Todd Volkert
74ab1bfbbd
Ensure that cache dirs and files have appropriate permissions (#24669)
Fixes https://github.com/flutter/flutter/issues/24413
2018-12-10 13:39:50 -08:00
Hans Muller
e7a4e7c3b6
Update Switch doc: disabled state (#24941) 2018-12-10 11:21:28 -08:00
Patrice Chalin
ab36f05474 Replace deprecated link in docs (#25120)
Followup to https://github.com/flutter/website/pull/1949, as requested by @Hixie in https://github.com/flutter/website/issues/1634.

cc @kwalrath
2018-12-10 10:51:41 -08:00
liyuqian
06ffbbfd4a
Change network image URL in doc (#25096)
This fixes https://github.com/flutter/flutter/issues/25092
2018-12-10 09:55:07 -08:00
Michael Goderbauer
8d249c25ea
Fix semantics compiler for offstage children (#24862)
Fixes #20313.
2018-12-10 08:58:14 -08:00
Michael Goderbauer
d74b1c2051
Add animations to SliverAppBar doc (#25091) 2018-12-07 14:19:09 -08:00
Gary Qian
27c8ffa06c
Fix typo in documentation (#25003) 2018-12-05 14:50:59 -08:00
Jonah Williams
a226c0f0d9
Add a flutter-attach entry point for fuchsia (#24878) 2018-11-30 16:18:18 -08:00
Ian Hickson
5391447fae Clarify dart:ui dependencies in foundation library (#24868) 2018-11-29 19:41:26 -08:00