Jonah Williams
93e7d34dc4
[flutter_tools] Remove globals/mocks from GradleUtils ( #76020 )
2021-02-17 14:26:57 -08:00
Jonah Williams
021311ed8a
Revert "[flutter_tools] move process manager into tool ( #75350 )" ( #75639 )
...
This reverts commit 8b6baae44c
2021-02-08 09:21:46 -08:00
Jonah Williams
8b6baae44c
[flutter_tools] move process manager into tool ( #75350 )
...
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. ( #74832 )
...
* opt out the flutter tool
* oops EOF
* fix import
* Update tool_backend.dart
* Update daemon_client.dart
* fix more
2021-01-27 15:17:53 -08:00
Jenn Magder
537cf33a21
Move processUtils to globals ( #67976 )
2020-10-14 13:12:46 -07:00
Jonah Williams
2474b07768
[flutter_tools] add more docs to cocoapods, move to globals ( #67237 )
...
Add some placeholder docs to the Cocoapods validator and Cocoapods class. Add the injected validator to globals. #47161
2020-10-05 17:57:48 -07:00
Jonah Williams
7f2ca5e532
[flutter_tools] refactor engine locator to its own class ( #67274 )
...
Make the logic for locating a local engine path part of its own class, add documentation, and update tests to cover engine source path locating too.
#47161
2020-10-05 16:25:47 -07:00
Jonah Williams
bd3eee75f3
[flutter_tools] rethrow process exceptions as tool exit from gradle build ( #64745 )
...
The flutter tool is currently unable to detect missing permissions in gradle/gradle.bat that would cause a gradle build to fail via process exception. Rather than crashing and exiting, we can display the exception as an error message and tool exit.
While linux/macOS are able to add the +x bit, this is not possible on windows with our current file system/OS API. These crashes represent a substantial amount of crash reporting, but are otherwise not actionable on our end.
2020-09-03 11:55:55 -07:00
Nolan Scobie
43c1b34cf5
Add punctuation for unterminated sentences in doc comments ( #62755 )
...
* Add punctuation for unterminated sentences in doc comments
* Addressing review nit
2020-08-06 19:18:52 -04:00
Jenn Magder
55176c4d6f
Show device diagnostic messages in doctor ( #61585 )
2020-07-17 09:41:03 -07:00
Jonah Williams
e1538d1b88
[flutter_tools] last pass on general.shard unit tests ( #60263 )
...
Last batch of test fixes for general shard.
2020-06-26 13:36:06 -07:00
Jonah Williams
8e765c7f6a
[flutter_tools] put system clock on globals ( #57447 )
2020-05-18 09:56:22 -07:00
Zachary Anderson
533cd7a6d1
[flutter_tools] Delete system temp entries on fatal signals ( #55513 )
2020-05-14 14:27:02 -07:00
Zachary Anderson
6f0ed5e142
[flutter_tools] Restore base/platform.dart ( #56410 )
2020-05-06 08:15:39 -07:00
James D. Lin
b7fd24a7dc
[flutter tools] Move _informUserOfCrash into crash_reporting.dart ( #55614 )
2020-04-28 10:34:03 -07:00
Jonah Williams
f2761b6b04
[flutter_tools] refactor Chrome launch logic to remove globals/statics ( #55160 )
2020-04-22 01:28:51 -07:00
Jenn Magder
457972b757
Move doctor into globals ( #54912 )
...
* Move doctor into globals
* Fix tests
2020-04-15 19:44:42 -07:00
Jonah Williams
8ed40ddd4b
[flutter_tools] refactor FlutterManifest to be context-free ( #54555 )
2020-04-13 18:55:01 -07:00
Zachary Anderson
6fddb7ee8c
[flutter_tools] Handle full device when creating a temp directory ( #53691 )
2020-04-02 10:31:03 -07:00
Jenn Magder
ce40fbaf51
Include metadata in GitHub crash template ( #53118 )
2020-03-27 16:21:45 -07:00
Jenn Magder
ee3920c208
Remove SimControl from context ( #53304 )
2020-03-25 15:40:42 -07:00
Jenn Magder
ba57ea09d1
Revert "Move processUtils into globals ( #53209 )" ( #53301 )
2020-03-25 14:59:03 -07:00
Jenn Magder
9ccac00599
Move processUtils into globals ( #53209 )
2020-03-25 11:23:08 -07:00
Jenn Magder
c93847d187
Remove IOSDeploy from globals, hoist to XCDevice constructor ( #53203 )
2020-03-24 16:50:35 -07:00
Jenn Magder
c9323bdccd
Convert cocoapods_validator_test to testWithoutContext ( #53177 )
2020-03-24 11:34:57 -07:00
Jenn Magder
70c651b0a4
Move BuildSystem to globals ( #53139 )
2020-03-24 11:23:10 -07:00
Jenn Magder
0b321e6715
Remove IMobileDevice from globals, hoist to XCDevice constructor ( #53144 )
...
* Convert ios_device_logger_test.dart to testWithoutContext
* Remove IMobileDevice from globals, hoist to XCDevice constructor
2020-03-24 11:22:54 -07:00
Jenn Magder
ee845255de
Move XcodeProjectInterpreter to globals ( #52847 )
2020-03-18 15:55:09 -07:00
Jenn Magder
e0ab6fc00c
Move outputPreferences to globals ( #52846 )
2020-03-18 15:54:26 -07:00
Jenn Magder
757b39ba99
Ignore fuchsia device-finder no device error ( #52761 )
2020-03-17 16:02:45 -07:00
Christopher Fujino
38a8845481
move iosworkflow to globals ( #52444 )
2020-03-12 10:16:28 -07:00
Jonah Williams
2133343a29
[flutter_tools] cache result of BotDetector in persistent tool state ( #52325 )
...
The Azure bot detection can take up to a second to determine if a client is/isn't a bot. To prevent this from slowing down all flutter commands, we can cache the results in the persistent tool state - since we don't expect the same client id to ever become a bot or stop being a bot
2020-03-10 11:35:52 -07:00
Christopher Fujino
2e18cd347e
Fix simctl process exceptions not being caught ( #51916 )
2020-03-06 13:16:01 -08:00
Jenn Magder
f6a55125d2
Add usage event for failed iOS project migration ( #51879 )
2020-03-06 12:14:29 -08:00
Zachary Anderson
914bd76979
[flutter_tools] Handle errors on the std{out,err}.done future ( #51660 )
2020-02-28 22:31:01 -08:00
Jonah Williams
3b5668c996
[flutter_tools] hide usage of package:mustache behind interface ( #51500 )
2020-02-27 09:17:42 -08:00
Jonah Williams
80619f100f
[flutter_tools] remove globals from plist parser and update tests ( #51444 )
2020-02-26 18:31:42 -08:00
Jonah Williams
65a7941228
[flutter_tools] reduce globals in web validator and chrome launcher ( #51443 )
2020-02-26 10:37:52 -08:00
Christopher Fujino
704fb4cbc7
Remove usage of ideviceinstaller in favor of ios-deploy ( #50772 )
2020-02-25 09:09:40 -08:00
Zachary Anderson
b9ecebf101
Reland: [flutter_tools] Disable analytics for more bots ( #50641 )
2020-02-12 10:58:02 -08:00
Zachary Anderson
1903ce012e
Revert "[flutter_tools] Disable analytics for more bots ( #50579 )" ( #50622 )
...
This reverts commit 0a38f29c0d
2020-02-11 22:47:41 -08:00
Zachary Anderson
0a38f29c0d
[flutter_tools] Disable analytics for more bots ( #50579 )
2020-02-11 15:48:02 -08:00
Christopher Fujino
e6e14b0dd2
Have android validator suggest ANDROID_SDK_ROOT instead of deprecated ANDROID_HOME ( #49846 )
2020-02-06 14:03:03 -08:00
Jenn Magder
a0665aba49
Reland Replace ideviceinfo and idevice_id with xcdevice ( #50252 )
2020-02-06 11:38:47 -08:00
Jenn Magder
ce6fbf6668
Revert "Replace ideviceinfo and idevice_id with xcdevice ( #49854 )" ( #50243 )
...
This reverts commit 3aa7a80053
2020-02-05 18:00:31 -08:00
Jenn Magder
3aa7a80053
Replace ideviceinfo and idevice_id with xcdevice ( #49854 )
2020-02-05 17:37:25 -08:00
Zachary Anderson
103b12fc11
[flutter_tools] Isolate userHomePath, other cleanups ( #50125 )
2020-02-04 18:03:03 -08:00
Zachary Anderson
2c51efef29
[flutter_tools] Make Config context-free ( #49834 )
2020-01-31 12:51:20 -08:00
Zachary Anderson
92f7e16312
[flutter_tools] Make OperatingSystemUtils context-free ( #49740 )
2020-01-29 17:51:31 -08:00
Jenn Magder
d85ea51384
Move iMobileDevice to globals ( #49724 )
2020-01-29 13:51:16 -08:00
