Jonah Williams
27cacca011
[devicelab] migrate new gallery benchmarks to local copy. ( #143545 )
...
This is the next step in archiving flutter/gallery - move devicelab tests to use the local copy.
2024-02-15 22:32:38 +00:00
Victoria Ashworth
e5c286e02e
Upload DerivedData logs in CI ( #142643 )
...
When the Dart VM is not found within 10 minutes in CI on CoreDevices (iOS 17+), stop the app and upload the logs from DerivedData. The app has to be stopped first since the logs are not put in DerivedData until it's stopped.
Also, rearranged some logic to have CoreDevice have its own function for Dart VM url discovery.
Debugging for https://github.com/flutter/flutter/issues/142448 .
2024-02-01 21:31:28 +00:00
Daco Harkes
6ad755536e
Native assets support for Android ( #135148 )
...
Support for FFI calls with `@Native external` functions through Native assets on Android. This enables bundling native code without any build-system boilerplate code.
For more info see:
* https://github.com/flutter/flutter/issues/129757
### Implementation details for Android.
Mainly follows the design of the previous PRs.
For Android, we detect the compilers inside the NDK inside SDK.
And bundling of the assets is done by the flutter.groovy file.
The `minSdkVersion` is propagated from the flutter.groovy file as well.
The NDK is not part of `flutter doctor`, and users can omit it if no native assets have to be build.
However, if any native assets must be built, flutter throws a tool exit if the NDK is not installed.
Add 2 app is not part of this PR yet, instead `flutter build aar` will tool exit if there are any native assets.
2023-12-07 16:29:11 +00:00
Victoria Ashworth
c175cf87a6
Ignore macOS Cocoapods linting failure on DT_TOOLCHAIN_DIR error ( #133588 )
...
Xcode 15 introduced an [error](https://github.com/flutter/flutter/issues/132755 ) into Cocoapods when building macOS apps.
When `pod lib lint` runs, it under the covers is building the app with `xcodebuild`, which is why this error occurs when linting.
A fix has been made in Cocoapods, but is not in an official release so we can't upgrade Cocoapods yet. This is to temporarily ignore lint failure due to that error.
Fixes https://github.com/flutter/flutter/issues/132980 .
Tracking issue to upgrade Cocoapods when fix is in a release: https://github.com/flutter/flutter/issues/133584
Since Xcode 15 isn't in CI, I tested it in a one-off led test:
* [Pre-fix failure](https://chromium-swarm.appspot.com/task?id=6431f228ecf98e10 )
* [Post-fix success](https://chromium-swarm.appspot.com/task?id=645ba7ebdab97210 )
2023-08-31 14:57:07 +00:00
Matan Lurey
a7997f606e
Update dev/devicelab/** to provide --local-engine-host. ( #132342 )
...
Partial work towards https://github.com/flutter/flutter/issues/132245 .
I have to admit I don't totally understand what I've updated, or whether
there are more integration points needed.
2023-08-10 17:25:30 -07:00
Victoria Ashworth
cd18c8c02f
Workaround for Dart VM timeout ( #127875 )
...
Workaround solution for: https://github.com/flutter/flutter/issues/121231
See https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 Error Case 2 for more information.
Sometimes the `ios-deploy` process does not return the logs from the application. We've been unable to figure out why. This is a solution to workaround that by using `idevicesyslog` alongside `ios-deploy` as a backup in getting the log for the Dart VM url. As explained in https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 , when error case 2 happens, the `idevicesyslog` does successfully find the Dart VM.
Also, in the comments of the code it mentions `syslog` is not written on iOS 13+, this was added in response to this issue: https://github.com/flutter/flutter/issues/41133 .
However, `idevicesyslog` does in fact work (at least for iOS 16), we use it to collect device logs for our CI tests already: 1dc26f80f0/dev/devicelab/lib/framework/devices.dart (L998-L1006)
2023-06-02 17:17:57 +00:00
Harry Terkelsen
daaba8a4aa
Add --local-web-sdk in devicelab runner to make --ab testing work for web ( #123825 )
...
This allows us to check for performance differences in local Web SDKs.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-03-31 14:25:00 -07:00
Jenn Magder
e2e313ecf6
Take screenshot on devicelab failure ( #122249 )
...
Take screenshot on devicelab failure
2023-03-15 02:13:21 +00:00
Jonah Williams
e98c53751e
Revert "[Impeller] Temporary flag flip for devicelab tests to use Impeller redux. ( #122340 )" ( #122362 )
...
Revert "[Impeller] Temporary flag flip for devicelab tests to use Impeller redux."
2023-03-10 16:16:30 +00:00
Jonah Williams
de399511d6
[Impeller] Temporary flag flip for devicelab tests to use Impeller redux. ( #122340 )
2023-03-09 17:45:17 -08:00
Jonah Williams
4adb299566
Revert "[Impeller] Temporary flag flip for devicelab tests to use Impeller. ( #122224 )" ( #122236 )
...
This reverts commit 21b8b7297f
2023-03-08 14:04:25 -08:00
Jonah Williams
21b8b7297f
[Impeller] Temporary flag flip for devicelab tests to use Impeller. ( #122224 )
...
[Impeller] Temporary flag flip for devicelab tests to use Impeller.
2023-03-08 21:41:51 +00:00
Jenn Magder
a16e620ec2
Funnel devicelab tests through utils process methods ( #122161 )
...
Funnel devicelab tests through utils process methods
2023-03-08 19:44:40 +00:00
Ben Konyi
ecd7518df5
Reland "Remove references to Observatory ( #118577 )" ( #121606 )
...
This reverts commit 275ab9c69b
2023-02-28 11:57:04 -05:00
Michael Goderbauer
275ab9c69b
Revert "Reland "Remove references to Observatory ( #118577 )" ( #121215 )" ( #121555 )
...
Revert "Reland "Remove references to Observatory (#118577 )""
2023-02-27 23:46:53 +00:00
Ben Konyi
fbae472fc3
Reland "Remove references to Observatory ( #118577 )" ( #121215 )
...
This reverts commit 298d8c76ba
2023-02-27 09:26:43 -05:00
Casey Hillers
298d8c76ba
Revert "Remove references to Observatory ( #118577 )" ( #120929 )
...
This reverts commit 2df140f40d
2023-02-16 21:28:30 -08:00
Ben Konyi
2df140f40d
Remove references to Observatory ( #118577 )
...
Observatory is being deprecated for Dart 3.0 so it should no longer be
referenced in tooling messaging / flags.
See https://github.com/dart-lang/sdk/issues/50233
2023-02-13 14:29:30 -05:00
Michael Goderbauer
ab3c82244e
Remove unnecessary null checks in dev/devicelab ( #118842 )
2023-01-20 18:56:44 +00:00
Ricardo Amador
f989d551ce
Devicelab android emulator ( #113472 )
...
* Testing whether emulator is possible.
* Adding changes to see if emulator can be used from recipe.
* adding emulator support.
* Add the emulator flag for testing.
* Using string for boolean since it cannot be parsed in properties
* Checking to see if these changes are being used.
* Updated bool back to string
* Remove trailing whitespace from file.
2023-01-17 22:01:11 +00:00
Michael Goderbauer
10a7c9ba22
Unify analysis options ( #108462 )
2022-07-28 09:07:49 -07:00
Kaushik Iska
f7504f0380
[openpay] Create an OpenPay benchmark ( #107838 )
2022-07-21 20:01:06 +00:00
Jenn Magder
3f1f0a8170
Add flutter build macos-framework command ( #105242 )
2022-06-03 10:13:08 -07:00
Jenn Magder
c6ced845e3
Remove custom unawaited, prefer dart:async version ( #103212 )
2022-05-07 08:49:04 -07:00
Alexandre Ardhuin
d40ee2149c
remove unnecessary .toString() ( #103226 )
2022-05-06 16:04:13 -07:00
Chris Bracken
4b819782fb
[macOS] Add run release test in devicelab ( #100526 )
...
Adds a test that invokes flutter run in release mode on macOS desktop,
waits for successful launch and the flutter command list, then sends the
'q' command to quit the running app.
This adds an integration test for https://github.com/flutter/flutter/pull/100504 .
Issue: https://github.com/flutter/flutter/issues/100348 (fix)
Issue: https://github.com/flutter/flutter/issues/97978 (partial fix)
Issue: https://github.com/flutter/flutter/issues/97977 (partial fix)
Umbrella issue: https://github.com/flutter/flutter/issues/60113
2022-03-22 14:12:59 -07:00
Ian Hickson
57f097b532
Refactor devicelab bin/run.dart and other cleanup ( #96320 )
2022-01-10 13:40:17 -08:00
Ian Hickson
f90b019c68
Enable prefer_relative_imports and fix files. ( #91573 )
2021-10-11 10:28:07 -07:00
Ian Hickson
b3f63d38ac
Document why some lints aren't enabled and fix some minor issues. ( #91527 )
2021-10-09 04:03:03 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be24
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Darren Austin
ef5ffd08f6
Migrate devicelab framework code to null safety. ( #86325 )
...
(Attempt to reland #85993 )
2021-07-13 12:14:50 -07:00
Darren Austin
08ef7752d5
Revert "Migrate core devicelab framework to null safety. ( #85993 )" ( #86269 )
...
This reverts commit 2175e64e4f
2021-07-11 23:25:25 -07:00
Darren Austin
2175e64e4f
Migrate core devicelab framework to null safety. ( #85993 )
...
Migrate core devicelab framework to null safety.
2021-07-11 18:36:30 -07:00
Jenn Magder
03034e9e4a
Audit devicelab log streaming for nullability ( #84820 )
2021-06-18 00:14:03 -07:00
Dan Field
5cc7b6c3ea
Add option to stream logs to file for flutter logs and way to use it in devicelab runs ( #84008 )
2021-06-07 10:33:00 -07:00
Jenn Magder
94a41cde83
Mixed null safety in dev/devicelab ( #84017 )
2021-06-05 02:29:03 -07:00
Alexandre Ardhuin
34059eec2c
enable lint prefer_interpolation_to_compose_strings ( #83407 )
2021-06-01 11:14:06 -07:00
gaaclarke
7cdd33fe99
added unawaited function for devicelab and turned on unawaited_futures linter ( #82833 )
2021-05-18 14:19:03 -07:00
Jenn Magder
1ff5665fdd
Force LANG=en_US.UTF-8 in test runner ( #82308 )
2021-05-12 10:49:02 -07:00
Jenn Magder
7d5f39281d
Cache location of Java binary in devicelab tests ( #80172 )
2021-04-12 16:50:03 -07:00
omerlevran46
c94648f9cc
[fuchsia] remove no devices found from ffx parsing ( #77651 )
2021-03-15 10:58:05 -07:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint ( #77434 )
2021-03-05 18:38:15 -08:00
Michael Goderbauer
7b251f5f37
Enable use_function_type_syntax_for_parameters lint ( #77163 )
2021-03-04 08:59:17 -08:00
omerlevran46
f996033fcc
[fuchsia] - migrate devicer discovery workflows to use ffx ( #76241 )
2021-03-01 13:16:13 -08:00
Emmanuel Garcia
da90156f8c
Fix plugin java class desugar ( #73758 )
2021-01-13 14:09:04 -08:00
Jenn Magder
13896b3bd1
Decrease device discovery timeout from 10 to 5 seconds ( #69266 )
2020-10-28 19:43:19 -07:00
Jenn Magder
135aab9cf5
Increase device run perf test timeout ( #69260 )
2020-10-28 18:29:04 -07:00
Jonah Williams
37042fdb08
[flutter_tools] remove iOS screenshot on failure functionality ( #68650 )
...
* [flutter_tools] remove iOS screenshot on failure functionality
* remove all screenshot code
2020-10-22 13:34:07 -07:00
