Commit Graph

3 Commits

Author SHA1 Message Date
Chris Bracken
9f8fe3f04c
[Windows] Fix signed/unsigned int comparison (#142341)
Previously, we were comparing the signed int `target_length` (returned by WideCharToMultiByte) to a size_t string length, resulting in a signed/unsigned comparison warning as follows:

```
windows\runner\utils.cpp(54,43): warning C4018:  '>': signed/unsigned mismatch
```

WideCharToMultiByte returns:
* 0 on error
* the number of bytes written to the buffer pointed to by its fifth parameter, lpMultiByteStr, on success.

As a result it's safe to store the return value in an unsigned int, which eliminates the warning.

No changes to tests since this is dependent on end-user project settings/modifications and does not trigger a warning with default project settings.

Fixes: https://github.com/flutter/flutter/issues/134227
2024-02-07 00:09:57 +00:00
Tomasz Gucio
98576cef58
Avoid null terminating characters in strings from Utf8FromUtf16() (#109729)
---------
Co-authored-by: schectman <schectman@google.com>
2023-02-13 19:22:37 +01:00
Loïc Sharma
4898f1f5c5
[Windows] Add app startup integration test (#110114)
Add a basic integration test for the Windows's app startup. In a subsequent change (https://github.com/flutter/flutter/pull/109816), this test will be updated to verify the app's window isn't visible until after the first frame has been drawn.

Part of https://github.com/flutter/flutter/issues/41980
2022-08-25 18:54:20 -07:00