github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
NaN Commits 822 Branches 1,017 Tags 2 GiB
ff7d9432b8
Commit Graph

386 Commits

Author SHA1 Message Date
Ian Hickson
bf017b79b3 Move Point to Offset (#9277) 
* Manually fix every use of Point.x and Point.y

Some of these were moved to dx/dy, but not all.

* Manually convert uses of the old gradient API

* Remove old reference to Point.

* Mechanical changes

I applied the following at the root of the Flutter repository:

git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g'
git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g'
git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g'
git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g'
git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g'
git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g'
git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g'
git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g'
git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g'
git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g'
git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g'
git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g'
git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g'
git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g'
git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g'
git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g'

* Mechanical changes - dartdocs

I applied the following at the root of the Flutter repository:

git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g'
git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g'

* Further improvements and a test

* Fix minor errors from rebasing...

* Roll engine
 2017-04-12 15:06:12 -07:00
Ian Hickson
2a54524337 Fix tests to use Ahem, and helpful changes around that (#9332) 
* Fix tests to use Ahem, and helpful changes around that

- Fix fonts that had metric-specific behaviours.

- LiveTestWidgetsFlutterBinding.allowAllFrames has been renamed
  to LiveTestWidgetsFlutterBinding.framePolicy.

- LiveTestWidgetsFlutterBinding now defaults to using a frame policy
  that pumps slightly more frames, to animate the pointer crosshairs.

- Added "flutter run --use-test-fonts" to enable Ahem on devices.

- Changed how idle() works to be more effective in live mode.

- Display the test name in live mode (unless ahem fonts are enabled).

- Added a toString to TextSelectionPoint.

- Style nit fixes.

* Roll engine to get Ahem changes.

* Update tests for dartdoc changes.

* Fix flutter_tools tests
 2017-04-12 13:33:02 -07:00
Yegor
9dfcc6ec79 Revert "temporarily mark iOS tests as flaky (#9314)" (#9333) 
This reverts commit ff23a1ebfe.

Our iOS lab hardware is back to normal.
 2017-04-11 12:26:15 -07:00
xster
89a7fdfc56 Rename State.config to widget everywhere (#9273) 
Rename State.config to State.widget
Rename State.didUpdateConfig to State.didUpdateWidget
Renamed all State subclasses' local variables named config to something else
 2017-04-10 18:32:24 -07:00
Yegor
a5593b1678 fix analyzer warning: use const where possible (#9320) 2017-04-10 14:20:47 -07:00
Yegor
ff23a1ebfe temporarily mark iOS tests as flaky (#9314) 2017-04-10 10:51:31 -07:00
Alexandre Ardhuin
610955f81d upgrade to linter-0.1.30 (#9297) 
* upgrade to linter-0.1.30

* add prefer_is_empty lint
* add directives_ordering lint
* add no_adjacent_strings_in_list lint
* add no_duplicate_case_values lint
* add prefer_collection_literals lint
* add prefer_const_constructors lint
* add prefer_contains lint
* add prefer_initializing_formals lint
* add unnecessary_null_aware_assignments lint
* add unnecessary_null_in_if_null_operators lint
 2017-04-08 08:43:19 +02:00
Ian Hickson
ebe6da5b17 Rename BlockBody to ListBody. (#9291) 
Nobody knew what a Block was.
 2017-04-07 17:14:54 -07:00
Ian Hickson
3eb87830e9 Constants! Constants everywhere! (#9286) 
Aggressively apply the const lint.
 2017-04-07 12:24:32 -07:00
Yegor
d538c11486 update devicelab docs (#9274) 2017-04-06 16:27:29 -07:00
Yegor
57ca2b5ce8 obey custom timeout supplied by cocoon (#9260) 2017-04-06 10:48:45 -07:00
Michael Goderbauer
a559b8df5c [Regression] Re-enable ANSI color support on Windows (#9232) 
Also adds a test to make sure we don't break it again.
 2017-04-05 15:44:22 -07:00
Ian Hickson
86a490ffe8 Tracked skipped tests in technical debt benchmark (#9206) 2017-04-05 12:23:21 -07:00
Ian Hickson
896ffcdf17 Disable test that is turning the tree red. (#9204) 
This issue is being tracked at: https://github.com/dart-lang/sdk/issues/29230
 2017-04-04 17:01:38 -07:00
Alexandre Ardhuin
189028a958 Separate the 'if' expression from its statement (#9177) 2017-04-04 21:45:50 +02:00
Yegor
1182eb18c5 add "flaky" and "timeout_in_minutes" devicelab task options (#9168) 2017-04-04 10:46:07 -07:00
xster
4245bce545 Add full platform build speed instrumentations (#9162) 
* Add new metric to size_tests instead

* Small lints
 2017-04-04 01:05:53 -07:00
Adam Barth
ae8994860e Rationalize text input widgets (#9119) 
After this patch, there are three major text input widgets:

 * EditableText. This widget is a low-level editing control that
   interacts with the IME and displays a blinking cursor.

 * TextField. This widget is a Material Design text field, with all the
   bells and whistles. It is highly configurable and can be reduced down
   to a fairly simple control by setting its `decoration` property to
   null.

 * TextFormField. This widget is a FormField that wraps a TextField.

This patch also replaces the InputValue data model for these widgets
with a Listenable TextEditingController, which is much more flexible.

Fixes #7031
 2017-04-01 17:30:21 -07:00
Adam Barth
89aaaa9c32 Improve focus management (#9074) 
We now have an explicit focus tree that we manage. Instead of using
GlobalKeys to manage focus, we use FocusNode and FocusScopeNode objects.
The FocusNode is Listenable and notifies when its focus state changes.

Focus notifications trigger by tree mutations are now delayed by one
frame, which is necessary to handle certain complex tree mutations. In
the common case of focus changes being triggered by user input, the
focus notificiation still arives in the same frame.
 2017-03-31 13:10:37 -07:00
Chris Bracken
abfee824cd Re-enable iOS transitions test in devicelab (#9097) 
This reverts commit 326355f0f9.
 2017-03-29 19:19:57 -07:00
Yegor
e067041279 increase vmservice timeout; log stderr in microbenchmarks (#9088) 2017-03-29 15:40:17 -07:00
Ian Hickson
326355f0f9 Turn off this flaky test for now. (#9065) 
cc @cbracken
 2017-03-28 16:40:13 -07:00
Jason Simmons
f7d0aa03f8 Throw an exception if flutter run fails during a microbenchmark (#9061) 2017-03-28 15:46:53 -07:00
Yegor
0ec3ffb4bc increase total task timeout; decrease individual benchmark timeout (#9063) 2017-03-28 15:42:06 -07:00
Michael Goderbauer
506aea0316 enable windows tests with workaround (#9058) 2017-03-28 14:22:03 -07:00
Collin Jackson
e2b49d64d6 Revert "Revert "Revert "Include fragment support in Android build to allow use of FragmentActivity in FlutterActivity (#9036)"" (#9046)" (#9047) 
Test is still failing with increased timeout.

This reverts commit 864b3c37c6.
 2017-03-27 19:16:58 -07:00
Collin Jackson
864b3c37c6 Revert "Revert "Include fragment support in Android build to allow use of FragmentActivity in FlutterActivity (#9036)"" (#9046) 
Increased the time limit slightly to allow the microbenchmark test time to finish.
 2017-03-27 18:12:14 -07:00
Michael Goderbauer
cea7c66dfd Disable flaky WIndows test :( (#9029) 2017-03-27 14:04:50 -07:00
Sarah Zakarias
d274888be6 Rename platform_services to platform_channel (#9018) 
* Rename platform_services to platform_channel

* rename in README

* renamed tests

* update modules.xml
 2017-03-27 11:17:31 +02:00
Hans Muller
606f56221b Eliminated DrawerItem, use ListTile instead (#8992) 2017-03-24 15:34:43 -07:00
Yegor
71690343fb detailed error message re missing xcconfigs (#9001) 2017-03-24 10:35:21 -07:00
Sarah Zakarias
912279bf6f Patch Debug/Release.xcconfig files in devicelab tests (#9000) 2017-03-24 15:57:06 +01:00
Sarah Zakarias
47fc81f14d Revert "Remove flutter_view_ios__start_up.dart (#8978)" (#8996) 
This reverts commit 38e4e48d06.
 2017-03-24 11:45:57 +01:00
Yegor
bc8cc80b9f Xcode 8-compatible provisioning profiles in devicelab tests (#8987) 2017-03-23 17:35:04 -07:00
Sarah Zakarias
38e4e48d06 Remove flutter_view_ios__start_up.dart (#8978) 2017-03-23 16:06:09 +01:00
Sarah Zakarias
18db5a2e68 Add start-up test for flutter_view sample (#8892) 
* Add start-up test for flutter_view sample

* add reportMetrics flag to startup test

* rewording in manifest.yaml
 2017-03-23 13:20:00 +01:00
Mikkel Nygaard Ravn
e918ef5dbe Updated microbenchmark ios project according to #8971 (#8976) 2017-03-23 10:13:38 +01:00
Mikkel Nygaard Ravn
f9336e2bbd Updated complex_layout ios project according to #8971 (#8974) 2017-03-23 09:32:55 +01:00
Alexandre Ardhuin
578ca0a295 use color.shadeXxx instead of color[Xxx] (#8932) 
* use color.shadeXxx instead of color[Xxx]

* remove calls to .shade500 on MaterialColor

* remove calls to .shade200 on MaterialAccentColor

* fix test
 2017-03-21 23:14:55 +01:00
Adam Barth
97816e1571 Rename Dismissable to Dismissible (#8919) 
The latter is the proper spelling.

Fixes #8883
 2017-03-20 16:17:08 -07:00
Ian Hickson
11c2032a4e Run both regular and --watch analysis on Travis (#8913) 
We keep breaking --watch because we don't test it.
 2017-03-20 16:16:34 -07:00
Sarah Zakarias
d1f73fd0ad Add integration test for the Platform Services app (#8826) 2017-03-20 22:19:03 +01:00
Jakob Andersen
03f053a738 Update complex_layout and microbenchmarks to Gradle build. (#8890) 2017-03-20 16:15:02 +01:00
Hans Muller
031e042eee Now each Colors.foo constant is-a Color and a color swatch (#8833) 2017-03-17 15:24:54 -07:00
Michael Goderbauer
9781f1aff0 make hot_mode_dev_cycle benchmark run in verbose mode (#8862) 2017-03-17 12:16:19 -07:00
Devon Carew
9f770ec8a3 update IntelliJ metadata (#8844) 2017-03-17 09:39:18 -07:00
Alexandre Ardhuin
a0769f2488 apply the upcoming rule unnecessary_this (#8838) 2017-03-17 08:05:42 +01:00
Ian Hickson
2bbe82ef30 Increase timeout and verbosity to diagnose devicelab failure (#8832) 2017-03-16 15:02:43 -07:00
Michael Goderbauer
79002c7453 add tasks for Windows bots in device lab (#8827) 2017-03-16 13:47:14 -07:00
Michael Goderbauer
d87f19817f devicelab benchmarks run on Windows (#8814) 
* devicelab benchmarks run on Windows

* fix analyzer issue

* fix test

* fix pubspec
 2017-03-15 16:33:10 -07:00
Alexandre Ardhuin
2166ea5b7f apply partially the upcoming unnecessary_lambdas (#8810) 2017-03-15 23:09:58 +01:00
Alexandre Ardhuin
a9ba0e2f88 prefer_initializing_formals (#8797) 2017-03-15 18:30:55 +01:00
Yegor
f8238185cc fix size Android tests broken by #8759 (#8796) 2017-03-15 10:08:22 -07:00
Adam Barth
e8a6df4df9 Only upload coverage data for the test shard (#8781) 
That's the only shard that computes new coverage data.
 2017-03-14 20:20:54 -07:00
Adam Barth
1e63dc4a72 Merge BuildableElement and Element (#8758) 
There aren't any subclasses of Element that don't also subclass
BuildableElement and I suspect they wouldn't work properly anyway.

Fixes #3656
 2017-03-14 17:49:10 -07:00
Chris Bracken
74e2243ca4 Add details of how to test run a build bot change (#8734) 
Add the minimum set of required properties for run_recipe.py and where
to look them up.
 2017-03-13 10:14:02 -07:00
Yegor
9f020d6104 upgrade package:http so we no longer need custom MultipartRequest (#8715) 2017-03-10 11:05:06 -08:00
Todd Volkert
83d411f979 Change flutter_tools tests to run via pub (#8698) 
`all.dart` is no longer needed. Furthermore, it causes tests to
be skipped, or to silently fail to run anything.

Fixes #7941
 2017-03-10 09:39:01 -08:00
Todd Volkert
1ada132ee8 Add first replay test (#8628) 2017-03-09 12:58:31 -08:00
Alexandre Ardhuin
329e52c02c apply upcoming rule use_collection_literals_when_possible (#8649) 2017-03-08 14:57:31 -08:00
Chris Bracken
6c97dd2c6c Declare locals as final where not reassigned (dev) (#8574) 2017-03-03 18:06:08 -08:00
Alexandre Ardhuin
69b6bb87d1 prefer_is_empty and prefer_is_not_empty (#8474) 2017-03-01 22:17:30 -08:00
Yegor
bfef36f710 add waitUntilNoTransientCallbacks to driver API (#8475) 2017-02-28 15:58:28 -08:00
Adam Barth
f20c3d1032 Add a color argument to Container. (#8396) 
It's common to just want a simple colored box. Simple thing should be simple,
so this patch adds a convenience argument to Continer for creating a box
decoration that is just a color.

Fixes #5555
 2017-02-24 12:25:48 -08:00
Phil Quitslund
a002e72022 Bump to test 0.12.20. (#8349) 
* Bump to test `0.12.20`.

Some test `0.12.20` highlights:
  * introduces `expectLater()`  that returns a `Future` that completes when the matcher has finished running
  * deprecates the `verbose` parameter to `expect()` and the `formatFailure()` (to be removed in `0.13.0`)

Otherwise:
  * to keep up w/ the deprecation of `verbose`, removes `widget_tester` API to pass `verbose` flag (alternatively we could suppress the warning for now)

* Update stack manipulation.

* Fix framecount.
 2017-02-23 15:08:25 -08:00
Alexandre Ardhuin
8c043d06de fix lints for directives_ordering rule (#8382) 2017-02-23 13:37:26 -08:00
Michael Goderbauer
7db8241a6d Revert "Revert "Replace jarsigner with apksigner" (#8164)" (#8320) 
This reverts commit 70d7fe3a0d.

The Java version missmatch on the bots has been resolved.
 2017-02-21 16:26:30 -08:00
Alexandre Ardhuin
e9a775bf38 prefer const constructors (#8316) 2017-02-21 14:54:29 -08:00
Todd Volkert
c233f38291 Update package:test dependencies to 0.12.18+2 (#8247) 2017-02-17 17:35:11 -08:00
Michael Goderbauer
4e531f64c6 make download_android_tools fail when the download fails (#8261) 2017-02-17 16:00:12 -08:00
Adam Barth
e0b12ca17e Two becomes one (#8253) 
Rename all the "2" classes related to scrolling to remove the "2". Now that the
old scrolling code is gone, we don't need to use the suffix.
 2017-02-17 14:06:15 -08:00
Adam Barth
cc808cda5c Fix travis_install.sh 2017-02-16 20:49:25 -08:00
Adam Barth
a44d3b7f7f Shard Travis job into three pieces (#8232) 2017-02-16 20:40:07 -08:00
Phil Quitslund
c458fb9d2c Bump Dart SDK to 1.23.0-dev.0.0 (#8222) 
* ups pinned `test` to `0.12.15+9` (to play nice w/ the latest analyzer)
* integrates `analyzer` with analysis driver defaulting to ON
 2017-02-16 16:50:35 -08:00
Adam Barth
90574b0478 Remove Scrollable1 (#8225) 
All the clients have migrated to Scrollable2.
 2017-02-16 16:41:24 -08:00
Ryan Macnak
d784a2378e Revert "Run coverage tests verbosely to help diagnose timeouts. (#8198)" (#8204) 
This reverts commit fac9efbacd.

The timeout was fixed by 6795c4ab96.
 2017-02-15 18:31:23 -08:00
Ryan Macnak
fac9efbacd Run coverage tests verbosely to help diagnose timeouts. (#8198) 2017-02-15 12:55:27 -08:00
Michael Goderbauer
f81f1f0509 make upload_android_tool.py executable (#8176) 2017-02-15 11:08:16 -08:00
Adam Barth
464a8e7cde Formally deprecate Block and ScrollableViewport (#8166) 
The replacements are ListView and SingleChildScrollView, respectively.
 2017-02-14 21:03:55 -08:00
Michael Goderbauer
70d7fe3a0d Revert "Replace jarsigner with apksigner" (#8164) 2017-02-14 18:02:33 -08:00
Michael Goderbauer
b38a6cbbba Replace jarsigner with apksigner (#8154) 2017-02-14 17:11:24 -08:00
Michael Goderbauer
7231fd3ed6 Enable flutter drive on Windows (#8146) 
... and run some more tests on Windows.
 2017-02-14 13:14:52 -08:00
Adam Barth
7f0b908ddc Don't upload lcov to coveralls for pull requests (#8143) 2017-02-14 10:25:02 -08:00
Michael Goderbauer
769646218a Add git config option to automatically convert CRLF to LF (#8122) 2017-02-14 10:21:33 -08:00
Adam Barth
68ff032f40 Remove mentions of ScrollableViewport from flutter_markdown (#8132) 
Also, actually run the flutter_markdown tests.
 2017-02-14 08:57:44 -08:00
Jakob Andersen
eebc72a343 Update path to built .apk. (#8137) 2017-02-14 13:46:45 +00:00
Adam Barth
88a01ac40c Port complex_layout to Sliver-based scrolling (#8114) 2017-02-13 16:30:19 -08:00
Michael Goderbauer
0d92db2003 Update Android Tools on Windows to e5715e2cc0d5644a241a4b3281bfada92bc145c2 (#8099) 
The old release contained some unused files that caused trouble on the Windows Chromebot.
 2017-02-13 10:26:27 -08:00
Adam Barth
fe0b909313 Remove more clients of LazyBlock (#8071) 
The last remaining client is complex_layout.
 2017-02-10 16:41:37 -08:00
Ian Hickson
073843f2ca Make these microbenchmarks more holistic. (#8070) 
They previously were very sensitive to widgets like LayoutBuilder.
 2017-02-10 15:06:18 -08:00
Michael Goderbauer
f4dbdabeb1 Do not upload anything when tests fail on travis. (#8065) 
This used to be the logic before I made the tests portable.
 2017-02-10 13:12:56 -08:00
Jason Simmons
68221a8023 Add a timestamp and Git commit to the dartdoc home page (#8046) 
Fixes https://github.com/flutter/flutter/issues/7974
 2017-02-10 09:55:58 -08:00
Jason Simmons
6873cdfe30 Add a fake package that generates a link to the Android javadocs in the dartdoc output (#8032) 
Fixes https://github.com/flutter/flutter/issues/7963
 2017-02-09 16:12:09 -08:00
Alexandre Ardhuin
e151a1a438 prefer_contains (#8040) 2017-02-09 15:17:55 -08:00
Ian Hickson
9a0a69ee63 Git ignore new temporary files in dev/bots (#8033) 2017-02-09 14:29:19 -08:00
Michael Goderbauer
723489de02 Make dev/bots/test.dart pass on Windows (#7998) 
* disables all `flutter test` and `flutter drive` tests on Windows as those two commands are not fully implemented on Windows yet
* fixes other failures on Windows
 2017-02-08 15:57:31 -08:00
Adam Barth
b4ec00c2d4 Rename manual_tests/pageable_list.dart to page_view.dart (#7986) 
This manual test has used the PageView widget for a while already.
 2017-02-08 15:23:16 -08:00
Michael Goderbauer
32271e9f3b Remove deprecated setup.sh and test.sh (#7976) 2017-02-08 13:00:44 -08:00
Michael Goderbauer
be99a04dac Make bot tests portable to also run on Windows (#7954) 2017-02-08 10:05:36 -08:00
Adam Barth
474c2c7df6 Switch complex_layout back to LazyBlock (#7940) 
We need to study these benchmark numbers more carefully. See #7937
 2017-02-07 15:21:48 -08:00