flutter/packages/flutter_tools/test/integration.shard/analyze_suggestions_integration_test.dart
Reid Baker f20bc39cc0
Add kotlin compatability to build file validation (#167143)
Fixes https://github.com/flutter/flutter/issues/161443 

* adds a new gradle task like `javaVersion` named `kgpVersion` that
prints the version of kgp.
* adds gradle_utils.dart method for getting kgp version
* * kgp method is moved to utilities and we attempt to use a plugin
method before reflection.
* adds methods or  evaluating KGP + gradle and KGP + AGP compatibility. 
* * It turns out that we have been using incompatible versions that
happen to work with the subset of kotlin we are using.
* Uses new kgp methods in flutter analyze --suggestions as part of the
existing agp/java/gradle compatibility matrix.
* adds new tests for all new functionality
* Adds comments to sections of the code I found could use them. 
* Modifies flutter gallery to use a compatible version of kotlin and
update its lockfiles.


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-18 16:32:08 +00:00

149 lines
6.8 KiB
Dart

// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:convert';
import 'package:args/command_runner.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/io.dart';
import 'package:flutter_tools/src/base/logger.dart';
import 'package:flutter_tools/src/base/platform.dart';
import 'package:flutter_tools/src/commands/analyze.dart';
import 'package:flutter_tools/src/globals.dart' as globals;
import 'package:flutter_tools/src/project.dart';
import 'package:flutter_tools/src/project_validator.dart';
import '../src/common.dart';
import '../src/context.dart';
import '../src/test_flutter_command_runner.dart';
import 'test_utils.dart';
void main() {
late FileSystem fileSystem;
group('analyze --suggestions command integration', () {
setUp(() {
fileSystem = globals.localFileSystem;
});
testUsingContext('General Info Project Validator', () async {
final BufferLogger loggerTest = BufferLogger.test();
final AnalyzeCommand command = AnalyzeCommand(
artifacts: globals.artifacts!,
fileSystem: fileSystem,
logger: loggerTest,
platform: globals.platform,
terminal: globals.terminal,
processManager: globals.processManager,
allProjectValidators: <ProjectValidator>[GeneralInfoProjectValidator()],
suppressAnalytics: true,
);
final CommandRunner<void> runner = createTestCommandRunner(command);
await runner.run(<String>[
'analyze',
'--no-pub',
'--no-current-package',
'--suggestions',
'../../dev/integration_tests/flutter_gallery',
]);
const String expected =
'\n'
'┌───────────────────────────────────────────────────────────────────────────┐\n'
'│ General Info │\n'
'│ [✓] App Name: flutter_gallery │\n'
'│ [✓] Supported Platforms: android, ios, web, macos, linux, windows │\n'
'│ [✓] Is Flutter Package: yes │\n'
'│ [✓] Uses Material Design: yes │\n'
'│ [✓] Is Plugin: no │\n'
'│ [✓] Java/Gradle/KGP/Android Gradle Plugin: ${AndroidProject.validJavaGradleAgpKgpString}\n'
'└───────────────────────────────────────────────────────────────────────────┘\n';
expect(loggerTest.statusText, contains(expected));
});
});
group('analyze --suggestions --machine command integration', () {
late Directory tempDir;
late Platform platform;
setUpAll(() async {
platform = const LocalPlatform();
tempDir = createResolvedTempDirectorySync('run_test.');
await globals.processManager.run(<String>[
'flutter',
'create',
'test_project',
], workingDirectory: tempDir.path);
});
tearDown(() async {
tryToDelete(tempDir);
});
testUsingContext('analyze --suggestions --machine produces expected values', () async {
final ProcessResult result = await globals.processManager.run(<String>[
'flutter',
'analyze',
'--suggestions',
'--machine',
], workingDirectory: tempDir.childDirectory('test_project').path);
expect(result.stdout is String, true);
expect((result.stdout as String).startsWith('{\n'), true);
expect(result.stdout, isNot(contains(',\n}'))); // No trailing commas allowed in JSON
expect((result.stdout as String).endsWith('}\n'), true);
final Map<String, dynamic> decoded =
jsonDecode(result.stdout as String) as Map<String, dynamic>;
expect(decoded.containsKey('FlutterProject.android.exists'), true);
expect(decoded.containsKey('FlutterProject.ios.exists'), true);
expect(decoded.containsKey('FlutterProject.web.exists'), true);
expect(decoded.containsKey('FlutterProject.macos.exists'), true);
expect(decoded.containsKey('FlutterProject.linux.exists'), true);
expect(decoded.containsKey('FlutterProject.windows.exists'), true);
expect(decoded.containsKey('FlutterProject.fuchsia.exists'), true);
expect(decoded.containsKey('FlutterProject.android.isKotlin'), true);
expect(decoded.containsKey('FlutterProject.ios.isSwift'), true);
expect(decoded.containsKey('FlutterProject.isModule'), true);
expect(decoded.containsKey('FlutterProject.isPlugin'), true);
expect(decoded.containsKey('FlutterProject.manifest.appname'), true);
expect(decoded.containsKey('FlutterVersion.frameworkRevision'), true);
expect(decoded.containsKey('FlutterProject.directory'), true);
expect(decoded.containsKey('FlutterProject.metadataFile'), true);
expect(decoded.containsKey('Platform.operatingSystem'), true);
expect(decoded.containsKey('Platform.isAndroid'), true);
expect(decoded.containsKey('Platform.isIOS'), true);
expect(decoded.containsKey('Platform.isWindows'), true);
expect(decoded.containsKey('Platform.isMacOS'), true);
expect(decoded.containsKey('Platform.isFuchsia'), true);
expect(decoded.containsKey('Platform.pathSeparator'), true);
expect(decoded.containsKey('Cache.flutterRoot'), true);
expect(decoded['FlutterProject.android.exists'], true);
expect(decoded['FlutterProject.ios.exists'], true);
expect(decoded['FlutterProject.web.exists'], true);
expect(decoded['FlutterProject.macos.exists'], true);
expect(decoded['FlutterProject.linux.exists'], true);
expect(decoded['FlutterProject.windows.exists'], true);
expect(decoded['FlutterProject.fuchsia.exists'], false);
expect(decoded['FlutterProject.android.isKotlin'], true);
expect(decoded['FlutterProject.ios.isSwift'], true);
expect(decoded['FlutterProject.isModule'], false);
expect(decoded['FlutterProject.isPlugin'], false);
expect(decoded['FlutterProject.manifest.appname'], 'test_project');
expect(decoded['Platform.isAndroid'], false);
expect(decoded['Platform.isIOS'], false);
expect(decoded['Platform.isWindows'], platform.isWindows);
expect(decoded['Platform.isMacOS'], platform.isMacOS);
expect(decoded['Platform.isFuchsia'], platform.isFuchsia);
expect(decoded['Platform.pathSeparator'], platform.pathSeparator);
}, overrides: <Type, Generator>{});
});
}