mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

When iOS and macOS Flutter apps build, they use [Xcode Run Scripts](https://developer.apple.com/documentation/xcode/running-custom-scripts-during-a-build) to call do various logic. For iOS, the Run Scripts calls a bash file ([xcode_backend.sh](https://github.com/flutter/flutter/blob/master/packages/flutter_tools/bin/xcode_backend.sh)), which then calls a dart file ([xcode_backend.dart](https://github.com/flutter/flutter/blob/master/packages/flutter_tools/bin/xcode_backend.dart)). `xcode_backend.dart` then calls `flutter assemble`. For macOS, the Run Scripts calls a bash file ([macos_assemble.sh](https://github.com/flutter/flutter/blob/master/packages/flutter_tools/bin/macos_assemble.sh)), which then calls `flutter assemble` directly. This PR changes `macos_assemble.sh` to call `xcode_backend.dart` like it does for iOS so code can be shared between them and written in dart instead of bash. Fixes https://github.com/flutter/flutter/issues/168033. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
58 lines
2.0 KiB
Dart
58 lines
2.0 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:io' as io;
|
|
|
|
import 'package:flutter_tools/src/base/io.dart';
|
|
|
|
import '../src/common.dart';
|
|
|
|
const String _kMacosAssemblePath = 'bin/macos_assemble.sh';
|
|
|
|
void main() {
|
|
test('macOS assemble defaults to build with no arguments', () async {
|
|
final ProcessResult result = await Process.run(
|
|
_kMacosAssemblePath,
|
|
<String>[],
|
|
environment: <String, String>{
|
|
'SOURCE_ROOT': '../../examples/hello_world',
|
|
'FLUTTER_ROOT': '../..',
|
|
},
|
|
);
|
|
expect(
|
|
result.stderr,
|
|
isNot(contains('error: Your Xcode project is incompatible with this version of Flutter.')),
|
|
);
|
|
expect(result.stderr, isNot(contains('warning: Unrecognized platform')));
|
|
expect(result.exitCode, isNot(0));
|
|
}, skip: !io.Platform.isMacOS); // [intended] requires macos toolchain.
|
|
|
|
test('macOS assemble warns when unable to determine platform', () async {
|
|
final ProcessResult result = await Process.run(
|
|
_kMacosAssemblePath,
|
|
<String>['build', 'asdf'],
|
|
environment: <String, String>{
|
|
'SOURCE_ROOT': '../../examples/hello_world',
|
|
'FLUTTER_ROOT': '../..',
|
|
},
|
|
);
|
|
expect(result.stderr, contains('warning: Unrecognized platform: asdf. Defaulting to iOS.'));
|
|
expect(result.exitCode, isNot(0));
|
|
}, skip: !io.Platform.isMacOS); // [intended] requires macos toolchain.
|
|
|
|
test('macOS assemble fails on unexpected build mode', () async {
|
|
final ProcessResult result = await Process.run(
|
|
_kMacosAssemblePath,
|
|
<String>[],
|
|
environment: <String, String>{'CONFIGURATION': 'Custom'},
|
|
);
|
|
expect(result.stderr, contains('ERROR: Unknown FLUTTER_BUILD_MODE: custom.'));
|
|
expect(
|
|
result.stderr,
|
|
contains("Valid values are 'Debug', 'Profile', or 'Release' (case insensitive)"),
|
|
);
|
|
expect(result.exitCode, isNot(0));
|
|
}, skip: !io.Platform.isMacOS); // [intended] requires macos toolchain.
|
|
}
|