mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
9528c1849e
This feature landed opt-in in 3.29 and opt-out in 3.32: https://docs.flutter.dev/release/breaking-changes/flutter-generate-i10n-source In this PR, we remove the ability to use `flutter config --no-enable-explicit-package-dependencies`, and remove all places that opt-in to the flag (which are currently NOPs). Follow-up PRs will refactor tests relying on the older behavior, and then finally remove `package:flutter_gen` and the `.flutter-plugins` (legacy format) file guarded by this flag.
530 lines
16 KiB
Dart
530 lines
16 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:file/file.dart';
|
|
import 'package:flutter_tools/src/base/io.dart';
|
|
|
|
import '../src/common.dart';
|
|
import 'test_utils.dart';
|
|
|
|
void main() {
|
|
late Directory tempDir;
|
|
late Directory projectDir;
|
|
|
|
setUpAll(() async {
|
|
tempDir = createResolvedTempDirectorySync('xcode_dev_dependencies_test.');
|
|
projectDir = tempDir.childDirectory('project')..createSync();
|
|
final Directory tempPluginADir = tempDir.childDirectory('plugin_a')..createSync();
|
|
|
|
// Create a Flutter project.
|
|
await processManager.run(<String>[
|
|
flutterBin,
|
|
'create',
|
|
projectDir.path,
|
|
'--project-name=testapp',
|
|
], workingDirectory: projectDir.path);
|
|
|
|
// Create a Flutter plugin to add as a dev dependency to the Flutter project.
|
|
await processManager.run(<String>[
|
|
flutterBin,
|
|
'create',
|
|
tempPluginADir.path,
|
|
'--template=plugin',
|
|
'--project-name=plugin_a',
|
|
'--platforms=ios,macos',
|
|
], workingDirectory: tempPluginADir.path);
|
|
|
|
// Add a dev dependency on plugin_a
|
|
await processManager.run(<String>[
|
|
flutterBin,
|
|
'pub',
|
|
'add',
|
|
'dev:plugin_a',
|
|
'--path',
|
|
tempPluginADir.path,
|
|
], workingDirectory: projectDir.path);
|
|
});
|
|
|
|
tearDownAll(() {
|
|
tryToDelete(tempDir);
|
|
});
|
|
|
|
group(
|
|
'Xcode build iOS app',
|
|
() {
|
|
test('succeeds after flutter build ios --config-only', () async {
|
|
final List<String> flutterCommand = <String>[
|
|
flutterBin,
|
|
...getLocalEngineArguments(),
|
|
'build',
|
|
'ios',
|
|
'--config-only',
|
|
'--debug',
|
|
];
|
|
final ProcessResult flutterResult = await processManager.run(
|
|
flutterCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(flutterResult, const ProcessResultMatcher());
|
|
|
|
final List<String> xcodeCommand = <String>[
|
|
'xcodebuild',
|
|
'-workspace',
|
|
'ios/Runner.xcworkspace',
|
|
'-scheme',
|
|
'Runner',
|
|
'CODE_SIGNING_ALLOWED=NO',
|
|
'CODE_SIGNING_REQUIRED=NO',
|
|
'CODE_SIGN_IDENTITY=-',
|
|
'EXPANDED_CODE_SIGN_IDENTITY=-',
|
|
'COMPILER_INDEX_STORE_ENABLE=NO',
|
|
'VERBOSE_SCRIPT_LOGGING=true',
|
|
'-configuration',
|
|
'Debug',
|
|
];
|
|
final ProcessResult xcodeResult = await processManager.run(
|
|
xcodeCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(xcodeResult, const ProcessResultMatcher(stdoutPattern: '** BUILD SUCCEEDED **'));
|
|
});
|
|
|
|
test('fails in Release mode if dev dependencies enabled', () async {
|
|
// Enable dev dependencies by generating debug configuration files
|
|
final List<String> flutterCommand = <String>[
|
|
flutterBin,
|
|
...getLocalEngineArguments(),
|
|
'build',
|
|
'ios',
|
|
'--config-only',
|
|
'--debug',
|
|
];
|
|
final ProcessResult flutterResult = await processManager.run(
|
|
flutterCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(flutterResult, const ProcessResultMatcher());
|
|
|
|
// Xcode release build should error that dev dependencies are enabled.
|
|
final List<String> xcodeCommand = <String>[
|
|
'xcodebuild',
|
|
'-workspace',
|
|
'ios/Runner.xcworkspace',
|
|
'-scheme',
|
|
'Runner',
|
|
'CODE_SIGNING_ALLOWED=NO',
|
|
'CODE_SIGNING_REQUIRED=NO',
|
|
'CODE_SIGN_IDENTITY=-',
|
|
'EXPANDED_CODE_SIGN_IDENTITY=-',
|
|
'COMPILER_INDEX_STORE_ENABLE=NO',
|
|
'VERBOSE_SCRIPT_LOGGING=true',
|
|
'-configuration',
|
|
'Release',
|
|
];
|
|
final ProcessResult xcodeResult = await processManager.run(
|
|
xcodeCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(
|
|
xcodeResult,
|
|
const ProcessResultMatcher(
|
|
exitCode: 65,
|
|
stdoutPattern: 'Release builds should not have Dart dev dependencies enabled',
|
|
stderrPattern: '** BUILD FAILED **',
|
|
),
|
|
);
|
|
});
|
|
|
|
test('fails in Debug mode if dev dependencies disabled', () async {
|
|
// Disable dev dependencies by generating debug configuration files
|
|
final List<String> flutterCommand = <String>[
|
|
flutterBin,
|
|
...getLocalEngineArguments(),
|
|
'build',
|
|
'ios',
|
|
'--config-only',
|
|
'--release',
|
|
];
|
|
final ProcessResult flutterResult = await processManager.run(
|
|
flutterCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(flutterResult, const ProcessResultMatcher());
|
|
|
|
// Xcode debug build should error that dev dependencies are disabled.
|
|
final List<String> xcodeCommand = <String>[
|
|
'xcodebuild',
|
|
'-workspace',
|
|
'ios/Runner.xcworkspace',
|
|
'-scheme',
|
|
'Runner',
|
|
'CODE_SIGNING_ALLOWED=NO',
|
|
'CODE_SIGNING_REQUIRED=NO',
|
|
'CODE_SIGN_IDENTITY=-',
|
|
'EXPANDED_CODE_SIGN_IDENTITY=-',
|
|
'COMPILER_INDEX_STORE_ENABLE=NO',
|
|
'VERBOSE_SCRIPT_LOGGING=true',
|
|
'-configuration',
|
|
'Debug',
|
|
];
|
|
final ProcessResult xcodeResult = await processManager.run(
|
|
xcodeCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(
|
|
xcodeResult,
|
|
const ProcessResultMatcher(
|
|
exitCode: 65,
|
|
stdoutPattern: 'Debug builds require Dart dev dependencies',
|
|
stderrPattern: '** BUILD FAILED **',
|
|
),
|
|
);
|
|
});
|
|
},
|
|
skip: !platform.isMacOS, // [intended] iOS builds only work on macos.
|
|
);
|
|
|
|
group(
|
|
'Xcode build iOS module',
|
|
() {
|
|
test('succeeds after flutter build ios --config-only', () async {
|
|
final String appDirectory = fileSystem.path.join(
|
|
getFlutterRoot(),
|
|
'dev',
|
|
'integration_tests',
|
|
'ios_add2app_life_cycle',
|
|
);
|
|
final String moduleDirectory = fileSystem.path.join(appDirectory, 'flutterapp');
|
|
|
|
final List<String> flutterCommand = <String>[
|
|
flutterBin,
|
|
...getLocalEngineArguments(),
|
|
'build',
|
|
'ios',
|
|
'--config-only',
|
|
'--debug',
|
|
];
|
|
final ProcessResult flutterResult = await processManager.run(
|
|
flutterCommand,
|
|
workingDirectory: moduleDirectory,
|
|
);
|
|
|
|
expect(flutterResult, const ProcessResultMatcher());
|
|
|
|
final ProcessResult podResult = await processManager.run(
|
|
const <String>['pod', 'install'],
|
|
workingDirectory: appDirectory,
|
|
environment: const <String, String>{'LANG': 'en_US.UTF-8'},
|
|
);
|
|
|
|
expect(podResult, const ProcessResultMatcher());
|
|
|
|
final List<String> xcodeCommand = <String>[
|
|
'xcodebuild',
|
|
'-workspace',
|
|
'ios_add2app.xcworkspace',
|
|
'-scheme',
|
|
'ios_add2app',
|
|
'-sdk',
|
|
'iphonesimulator',
|
|
'CODE_SIGNING_ALLOWED=NO',
|
|
'CODE_SIGNING_REQUIRED=NO',
|
|
'CODE_SIGN_IDENTITY=-',
|
|
'EXPANDED_CODE_SIGN_IDENTITY=-',
|
|
'COMPILER_INDEX_STORE_ENABLE=NO',
|
|
'VERBOSE_SCRIPT_LOGGING=true',
|
|
'-configuration',
|
|
'Debug',
|
|
];
|
|
final ProcessResult xcodeResult = await processManager.run(
|
|
xcodeCommand,
|
|
workingDirectory: appDirectory,
|
|
);
|
|
|
|
expect(xcodeResult, const ProcessResultMatcher(stdoutPattern: '** BUILD SUCCEEDED **'));
|
|
});
|
|
|
|
test('fails in Release mode if dev dependencies enabled', () async {
|
|
final String appDirectory = fileSystem.path.join(
|
|
getFlutterRoot(),
|
|
'dev',
|
|
'integration_tests',
|
|
'ios_add2app_life_cycle',
|
|
);
|
|
final String moduleDirectory = fileSystem.path.join(appDirectory, 'flutterapp');
|
|
|
|
// Enable dev dependencies by generating debug configuration files
|
|
final List<String> flutterCommand = <String>[
|
|
flutterBin,
|
|
...getLocalEngineArguments(),
|
|
'build',
|
|
'ios',
|
|
'--config-only',
|
|
'--debug',
|
|
];
|
|
final ProcessResult flutterResult = await processManager.run(
|
|
flutterCommand,
|
|
workingDirectory: moduleDirectory,
|
|
);
|
|
|
|
expect(flutterResult, const ProcessResultMatcher());
|
|
|
|
final ProcessResult podResult = await processManager.run(
|
|
const <String>['pod', 'install'],
|
|
workingDirectory: appDirectory,
|
|
environment: const <String, String>{'LANG': 'en_US.UTF-8'},
|
|
);
|
|
|
|
expect(podResult, const ProcessResultMatcher());
|
|
|
|
// Xcode release build should error that dev dependencies are enabled.
|
|
final List<String> xcodeCommand = <String>[
|
|
'xcodebuild',
|
|
'-workspace',
|
|
'ios_add2app.xcworkspace',
|
|
'-scheme',
|
|
'ios_add2app',
|
|
'-sdk',
|
|
'iphonesimulator',
|
|
'CODE_SIGNING_ALLOWED=NO',
|
|
'CODE_SIGNING_REQUIRED=NO',
|
|
'CODE_SIGN_IDENTITY=-',
|
|
'EXPANDED_CODE_SIGN_IDENTITY=-',
|
|
'COMPILER_INDEX_STORE_ENABLE=NO',
|
|
'VERBOSE_SCRIPT_LOGGING=true',
|
|
'-configuration',
|
|
'Release',
|
|
];
|
|
final ProcessResult xcodeResult = await processManager.run(
|
|
xcodeCommand,
|
|
workingDirectory: appDirectory,
|
|
);
|
|
|
|
expect(
|
|
xcodeResult,
|
|
const ProcessResultMatcher(
|
|
exitCode: 65,
|
|
stdoutPattern: 'Release builds should not have Dart dev dependencies enabled',
|
|
stderrPattern: '** BUILD FAILED **',
|
|
),
|
|
);
|
|
});
|
|
|
|
test('abc fails in Debug mode if dev dependencies disabled', () async {
|
|
final String appDirectory = fileSystem.path.join(
|
|
getFlutterRoot(),
|
|
'dev',
|
|
'integration_tests',
|
|
'ios_add2app_life_cycle',
|
|
);
|
|
final String moduleDirectory = fileSystem.path.join(appDirectory, 'flutterapp');
|
|
|
|
// Disable dev dependencies by generating release configuration files
|
|
final List<String> flutterCommand = <String>[
|
|
flutterBin,
|
|
...getLocalEngineArguments(),
|
|
'build',
|
|
'ios',
|
|
'--config-only',
|
|
'--release',
|
|
];
|
|
final ProcessResult flutterResult = await processManager.run(
|
|
flutterCommand,
|
|
workingDirectory: moduleDirectory,
|
|
);
|
|
|
|
expect(flutterResult, const ProcessResultMatcher());
|
|
|
|
final ProcessResult podResult = await processManager.run(
|
|
const <String>['pod', 'install'],
|
|
workingDirectory: appDirectory,
|
|
environment: const <String, String>{'LANG': 'en_US.UTF-8'},
|
|
);
|
|
|
|
expect(podResult, const ProcessResultMatcher());
|
|
|
|
// Xcode debug build should error that dev dependencies are disabled.
|
|
final List<String> xcodeCommand = <String>[
|
|
'xcodebuild',
|
|
'-workspace',
|
|
'ios_add2app.xcworkspace',
|
|
'-scheme',
|
|
'ios_add2app',
|
|
'-sdk',
|
|
'iphonesimulator',
|
|
'CODE_SIGNING_ALLOWED=NO',
|
|
'CODE_SIGNING_REQUIRED=NO',
|
|
'CODE_SIGN_IDENTITY=-',
|
|
'EXPANDED_CODE_SIGN_IDENTITY=-',
|
|
'COMPILER_INDEX_STORE_ENABLE=NO',
|
|
'VERBOSE_SCRIPT_LOGGING=true',
|
|
'-configuration',
|
|
'Debug',
|
|
];
|
|
final ProcessResult xcodeResult = await processManager.run(
|
|
xcodeCommand,
|
|
workingDirectory: appDirectory,
|
|
);
|
|
|
|
expect(
|
|
xcodeResult,
|
|
const ProcessResultMatcher(
|
|
exitCode: 65,
|
|
stdoutPattern: 'Debug builds require Dart dev dependencies',
|
|
stderrPattern: '** BUILD FAILED **',
|
|
),
|
|
);
|
|
});
|
|
},
|
|
skip: !platform.isMacOS, // [intended] iOS builds only work on macos.
|
|
);
|
|
|
|
group(
|
|
'Xcode build macOS app',
|
|
() {
|
|
test('succeeds after flutter build macos --config-only', () async {
|
|
final List<String> flutterCommand = <String>[
|
|
flutterBin,
|
|
...getLocalEngineArguments(),
|
|
'build',
|
|
'macos',
|
|
'--config-only',
|
|
'--debug',
|
|
];
|
|
final ProcessResult flutterResult = await processManager.run(
|
|
flutterCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(flutterResult, const ProcessResultMatcher());
|
|
|
|
final List<String> xcodeCommand = <String>[
|
|
'xcodebuild',
|
|
'-workspace',
|
|
'macos/Runner.xcworkspace',
|
|
'-scheme',
|
|
'Runner',
|
|
'CODE_SIGNING_ALLOWED=NO',
|
|
'CODE_SIGNING_REQUIRED=NO',
|
|
'CODE_SIGN_IDENTITY=-',
|
|
'EXPANDED_CODE_SIGN_IDENTITY=-',
|
|
'COMPILER_INDEX_STORE_ENABLE=NO',
|
|
'VERBOSE_SCRIPT_LOGGING=true',
|
|
'-configuration',
|
|
'Debug',
|
|
];
|
|
final ProcessResult xcodeResult = await processManager.run(
|
|
xcodeCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(xcodeResult, const ProcessResultMatcher(stdoutPattern: '** BUILD SUCCEEDED **'));
|
|
});
|
|
|
|
test('fails in Release mode if dev dependencies enabled', () async {
|
|
// Enable dev dependencies by generating debug configuration files
|
|
final List<String> flutterCommand = <String>[
|
|
flutterBin,
|
|
...getLocalEngineArguments(),
|
|
'build',
|
|
'macos',
|
|
'--config-only',
|
|
'--debug',
|
|
];
|
|
final ProcessResult flutterResult = await processManager.run(
|
|
flutterCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(flutterResult, const ProcessResultMatcher());
|
|
|
|
// Xcode release build should error that dev dependencies are enabled.
|
|
final List<String> xcodeCommand = <String>[
|
|
'xcodebuild',
|
|
'-workspace',
|
|
'macos/Runner.xcworkspace',
|
|
'-scheme',
|
|
'Runner',
|
|
'CODE_SIGNING_ALLOWED=NO',
|
|
'CODE_SIGNING_REQUIRED=NO',
|
|
'CODE_SIGN_IDENTITY=-',
|
|
'EXPANDED_CODE_SIGN_IDENTITY=-',
|
|
'COMPILER_INDEX_STORE_ENABLE=NO',
|
|
'VERBOSE_SCRIPT_LOGGING=true',
|
|
'-configuration',
|
|
'Release',
|
|
];
|
|
final ProcessResult xcodeResult = await processManager.run(
|
|
xcodeCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(
|
|
xcodeResult,
|
|
const ProcessResultMatcher(
|
|
exitCode: 65,
|
|
stdoutPattern: 'error: Release builds should not have Dart dev dependencies enabled',
|
|
stderrPattern: '** BUILD FAILED **',
|
|
),
|
|
);
|
|
});
|
|
|
|
test('fails in Debug mode if dev dependencies disabled', () async {
|
|
// Disable dev dependencies by generating debug configuration files
|
|
final List<String> flutterCommand = <String>[
|
|
flutterBin,
|
|
...getLocalEngineArguments(),
|
|
'build',
|
|
'macos',
|
|
'--config-only',
|
|
'--release',
|
|
];
|
|
final ProcessResult flutterResult = await processManager.run(
|
|
flutterCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(flutterResult, const ProcessResultMatcher());
|
|
|
|
// Xcode debug build should error that dev dependencies are disabled.
|
|
final List<String> xcodeCommand = <String>[
|
|
'xcodebuild',
|
|
'-workspace',
|
|
'macos/Runner.xcworkspace',
|
|
'-scheme',
|
|
'Runner',
|
|
'CODE_SIGNING_ALLOWED=NO',
|
|
'CODE_SIGNING_REQUIRED=NO',
|
|
'CODE_SIGN_IDENTITY=-',
|
|
'EXPANDED_CODE_SIGN_IDENTITY=-',
|
|
'COMPILER_INDEX_STORE_ENABLE=NO',
|
|
'VERBOSE_SCRIPT_LOGGING=true',
|
|
'-configuration',
|
|
'Debug',
|
|
];
|
|
final ProcessResult xcodeResult = await processManager.run(
|
|
xcodeCommand,
|
|
workingDirectory: projectDir.path,
|
|
);
|
|
|
|
expect(
|
|
xcodeResult,
|
|
const ProcessResultMatcher(
|
|
exitCode: 65,
|
|
stdoutPattern: 'error: Debug builds require Dart dev dependencies',
|
|
stderrPattern: '** BUILD FAILED **',
|
|
),
|
|
);
|
|
});
|
|
},
|
|
skip: !platform.isMacOS, // [intended] iOS builds only work on macos.
|
|
);
|
|
}
|