flutter/packages/flutter_tools/test/commands.shard/hermetic
Matan Lurey 78cfc1ae9b
Plugin.isDevDependency if exclusively in dev_dependencies (#157462)
Work towards https://github.com/flutter/flutter/issues/56591.

I explicitly want an LGTM from @andrewkolos @jmagman @jonahwilliams before merging.

---

After this PR, `<Plugin>.isDevDependency` is resolved based on the following logic, IFF:

- The plugin comes from a package _A_ listed in the app's package's `dev_dependencies: ...`
- The package _A_ is not a normal dependency of any transitive non-dev dependency of the app

See [`compute_dev_dependencies_test.dart`](51676093a3/packages/flutter_tools/test/general.shard/compute_dev_dependencies_test.dart) for probably the best specification of this behavior.

We (still) do not write the property to disk (i.e. it never makes it to `.flutter-plugins-dependencies`), so there is no impact to build artifacts at this time; that would come in a follow-up PR (and then follow-up follow-up PRs for the various build systems in both Gradle and Xcode to actually use that value to omit dependencies).

Some tests had to be updated; for the most part it was updating the default `ProcessManager` because a call to `dart pub deps --json` is now made in code that computes what plugins are available, but there should be no change in behavior.

_/cc @jonasfj @sigurdm for FYI only (we talked on an internal thread about this; see https://github.com/dart-lang/sdk/issues/56968)._

_/cc @camsim99 @cbracken @johnmccutchan for visibility on the change._
2024-11-07 18:09:22 +00:00
..
analyze_continuously_test.dart Remove --disable-dart-dev across flutter/flutter. (#154280) 2024-08-29 22:50:04 +00:00
analyze_suggestion_test.dart Fix formatting (#137613) 2023-10-31 13:27:26 +00:00
analyze_test.dart Remove --disable-dart-dev across flutter/flutter. (#154280) 2024-08-29 22:50:04 +00:00
android_analyze_test.dart Android analyze command should run pub (#153953) 2024-08-23 17:57:07 +00:00
assemble_test.dart Migrate command usage values (#139383) 2023-12-07 16:12:03 +00:00
attach_test.dart Reland1: "Revert "Add and plumb useImplicitPubspecResolution across flutter_tools."" (#158126) 2024-11-05 08:49:42 -08:00
build_aar_test.dart provide command to FakeCommand::onRun (#142206) 2024-01-25 07:51:25 +00:00
build_darwin_framework_test.dart Prevent flutter build ios-framework --xcframework from copying Flutter.xcframework.dSYM into the App.framework folder. (#157394) 2024-10-23 23:35:10 +00:00
build_ios_test.dart Plugin.isDevDependency if exclusively in dev_dependencies (#157462) 2024-11-07 18:09:22 +00:00
build_ipa_test.dart Plugin.isDevDependency if exclusively in dev_dependencies (#157462) 2024-11-07 18:09:22 +00:00
build_linux_test.dart Stop reading .packages from flutter_tools. (#154912) 2024-09-13 13:53:05 +02:00
build_macos_test.dart Plugin.isDevDependency if exclusively in dev_dependencies (#157462) 2024-11-07 18:09:22 +00:00
build_test.dart Flutter preview device (#135639) 2023-10-18 00:27:54 +00:00
build_web_test.dart Plugin.isDevDependency if exclusively in dev_dependencies (#157462) 2024-11-07 18:09:22 +00:00
build_windows_test.dart Stop reading .packages from flutter_tools. (#154912) 2024-09-13 13:53:05 +02:00
clean_test.dart Stop reading .packages from flutter_tools. (#154912) 2024-09-13 13:53:05 +02:00
config_test.dart [Reland] Migration for the sendTiming events for package:unified_analytics (#139299) 2023-12-04 21:39:18 +00:00
create_usage_test.dart Roll pub packages (#156925) 2024-10-18 20:17:18 +00:00
custom_devices_test.dart Remove outdated ignores from tool (#140467) 2023-12-20 22:14:32 +00:00
daemon_test.dart Reland1: "Revert "Add and plumb useImplicitPubspecResolution across flutter_tools."" (#158126) 2024-11-05 08:49:42 -08:00
devices_test.dart Control flow collections: flutter_tools/ (#147450) 2024-05-02 22:19:18 +00:00
doctor_test.dart Arrow syntax for getters (#156483) 2024-10-17 19:25:14 +00:00
downgrade_test.dart Improve 'flutter downgrade' error message (#154434) 2024-09-04 22:06:31 +00:00
drive_test.dart Reland "Launch DDS from Dart SDK and prepare to serve DevTools from DDS (#146593)" (#152386) 2024-07-26 20:51:19 +00:00
flutter_web_platform_test.dart Refactor BuildInfo to always require packageConfigPath (#150559) 2024-07-02 11:19:31 +02:00
generate_localizations_test.dart Reland1: "Revert "Add and plumb useImplicitPubspecResolution across flutter_tools."" (#158126) 2024-11-05 08:49:42 -08:00
http_host_validator_test.dart Switch to more reliable flutter.dev link destinations in the tool (#150587) 2024-06-26 23:30:39 +00:00
ide_config_test.dart Null safety migration of packages/flutter_tools/test/commands.shard/hermetic, part 2/3 (#110708) 2022-09-06 10:39:18 -07:00
install_test.dart Remove outdated ignores from tool (#140467) 2023-12-20 22:14:32 +00:00
ios_analyze_test.dart Makes scheme and target optional parameter when getting universal lin… (#134571) 2023-09-15 21:01:05 +00:00
logs_test.dart [flutter_tools] Fix bad state future already completed in flutter logs (#138517) 2023-11-23 19:56:14 +00:00
precache_test.dart Null safety migration of packages/flutter_tools/test/commands.shard/hermetic, part 3/3 (#110709) 2022-09-06 10:22:40 -07:00
proxied_devices_test.dart Reland1: "Revert "Add and plumb useImplicitPubspecResolution across flutter_tools."" (#158126) 2024-11-05 08:49:42 -08:00
proxy_validator_test.dart add missing trailing commas in list/set/map literals (#102585) 2022-04-27 09:15:35 +02:00
pub_test.dart Stop reading .packages from flutter_tools. (#154912) 2024-09-13 13:53:05 +02:00
run_test.dart Reland1: "Revert "Add and plumb useImplicitPubspecResolution across flutter_tools."" (#158126) 2024-11-05 08:49:42 -08:00
screenshot_command_test.dart Enable flutter screenshot outside Flutter project directory (#138160) 2023-11-17 01:08:13 +00:00
shell_completion_test.dart Null safety migration of packages/flutter_tools/test/commands.shard/hermetic, part 3/3 (#110709) 2022-09-06 10:22:40 -07:00
symbolize_test.dart Extend 'flutter symbolize' to handle deferred loading units. (#149315) 2024-09-16 17:55:05 +00:00
test_test.dart [tool] Emit a deprecation warning for some values of --web-renderer. (#156376) 2024-10-08 01:39:06 +00:00
update_packages_test.dart Copy the flutter version JSON file into the simulated Flutter SDK used by update_packages (#143035) 2024-02-06 20:00:08 -08:00
upgrade_test.dart Reland: Update link branches to main (#146882) 2024-04-17 13:16:33 +00:00