flutter/packages/flutter_tools/test/general.shard/web
Matan Lurey 78cfc1ae9b
Plugin.isDevDependency if exclusively in dev_dependencies (#157462)
Work towards https://github.com/flutter/flutter/issues/56591.

I explicitly want an LGTM from @andrewkolos @jmagman @jonahwilliams before merging.

---

After this PR, `<Plugin>.isDevDependency` is resolved based on the following logic, IFF:

- The plugin comes from a package _A_ listed in the app's package's `dev_dependencies: ...`
- The package _A_ is not a normal dependency of any transitive non-dev dependency of the app

See [`compute_dev_dependencies_test.dart`](51676093a3/packages/flutter_tools/test/general.shard/compute_dev_dependencies_test.dart) for probably the best specification of this behavior.

We (still) do not write the property to disk (i.e. it never makes it to `.flutter-plugins-dependencies`), so there is no impact to build artifacts at this time; that would come in a follow-up PR (and then follow-up follow-up PRs for the various build systems in both Gradle and Xcode to actually use that value to omit dependencies).

Some tests had to be updated; for the most part it was updating the default `ProcessManager` because a call to `dart pub deps --json` is now made in code that computes what plugins are available, but there should be no change in behavior.

_/cc @jonasfj @sigurdm for FYI only (we talked on an internal thread about this; see https://github.com/dart-lang/sdk/issues/56968)._

_/cc @camsim99 @cbracken @johnmccutchan for visibility on the change._
2024-11-07 18:09:22 +00:00
..
migrations Fix JS compilation to use the command 'compile js' instead of using snapshot names to invoke dart2js (#156735) 2024-10-15 15:28:27 -07:00
bootstrap_test.dart flutter test --wasm support (#145347) 2024-03-21 20:08:07 +00:00
compile_web_test.dart Plugin.isDevDependency if exclusively in dev_dependencies (#157462) 2024-11-07 18:09:22 +00:00
devfs_web_ddc_modules_test.dart Refactor devfs_web_ddc_modules_test.dart (#155609) 2024-10-03 21:10:03 +00:00
devfs_web_test.dart Stop reading .packages from flutter_tools. (#154912) 2024-09-13 13:53:05 +02:00
devices_test.dart make ChromiumDevice.stopApp a no-op if it has already been called (#156778) 2024-10-21 11:28:30 -04:00
golden_comparator_process_test.dart Revert "Allow Flutter golden file tests to be flaky (#114450)" (#114902) 2022-11-08 09:26:55 -08:00
golden_comparator_test.dart Reland "Remove references to Observatory (#118577)" (#121606) 2023-02-28 11:57:04 -05:00
memory_fs_test.dart add missing trailing commas in list/set/map literals (#102585) 2022-04-27 09:15:35 +02:00
web_asset_server_test.dart [web] Set COEP:credentialless on flutter run/drive. (#152413) 2024-07-30 23:14:06 +00:00
web_expression_compiler_test.dart Null safety migration of packages/flutter_tools/test/general.shard, part 2/2 (#110712) 2022-09-07 12:28:52 -07:00
web_validator_test.dart [tools]Build IPA validation UI Polish (#116744) 2022-12-15 14:43:32 -08:00
workflow_test.dart