mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

Fixes the #136996 Readresses the #54358 Before: ```sh [✓] VS Code (version unknown) • VS Code at /snap/code/current • Flutter extension version 3.74.0 ✗ Unable to determine VS Code version. ``` After: ```sh [✓] VS Code (version 1.83.1) • VS Code at /snap/code/current/usr/share/code • Flutter extension version 3.74.0 ``` *List which issues are fixed by this PR. You must list at least one issue.* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
102 lines
4.5 KiB
Dart
102 lines
4.5 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:file/memory.dart';
|
|
import 'package:flutter_tools/src/base/file_system.dart';
|
|
import 'package:flutter_tools/src/base/platform.dart';
|
|
import 'package:flutter_tools/src/vscode/vscode.dart';
|
|
|
|
import '../../src/common.dart';
|
|
import '../../src/fake_process_manager.dart';
|
|
|
|
void main() {
|
|
testWithoutContext('VsCodeInstallLocation equality', () {
|
|
const VsCodeInstallLocation installLocation1 = VsCodeInstallLocation('abc', 'zyx', edition: '123');
|
|
const VsCodeInstallLocation installLocation2 = VsCodeInstallLocation('abc', 'zyx', edition: '123');
|
|
const VsCodeInstallLocation installLocation3 = VsCodeInstallLocation('cba', 'zyx', edition: '123');
|
|
const VsCodeInstallLocation installLocation4 = VsCodeInstallLocation('abc', 'xyz', edition: '123');
|
|
const VsCodeInstallLocation installLocation5 = VsCodeInstallLocation('abc', 'xyz', edition: '321');
|
|
|
|
expect(installLocation1, installLocation2);
|
|
expect(installLocation1.hashCode, installLocation2.hashCode);
|
|
expect(installLocation1, isNot(installLocation3));
|
|
expect(installLocation1.hashCode, isNot(installLocation3.hashCode));
|
|
expect(installLocation1, isNot(installLocation4));
|
|
expect(installLocation1.hashCode, isNot(installLocation4.hashCode));
|
|
expect(installLocation1, isNot(installLocation5));
|
|
expect(installLocation1.hashCode, isNot(installLocation5.hashCode));
|
|
});
|
|
|
|
testWithoutContext('VsCode.fromDirectory does not crash when packages.json is malformed', () {
|
|
final MemoryFileSystem fileSystem = MemoryFileSystem.test();
|
|
// Create invalid JSON file.
|
|
fileSystem.file(fileSystem.path.join('', 'resources', 'app', 'package.json'))
|
|
..createSync(recursive: true)
|
|
..writeAsStringSync('{');
|
|
|
|
final VsCode vsCode = VsCode.fromDirectory('', '', fileSystem: fileSystem);
|
|
|
|
expect(vsCode.version, null);
|
|
});
|
|
|
|
testWithoutContext('can locate VS Code installed via Snap', () {
|
|
final FileSystem fileSystem = MemoryFileSystem.test();
|
|
const String home = '/home/me';
|
|
final Platform platform = FakePlatform(environment: <String, String>{'HOME': home});
|
|
|
|
fileSystem.directory(fileSystem.path.join('/snap/code/current/usr/share/code', '.vscode')).createSync(recursive: true);
|
|
|
|
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
|
|
|
|
final List<VsCode> installed = VsCode.allInstalled(fileSystem, platform, processManager);
|
|
expect(installed.length, 1);
|
|
});
|
|
|
|
testWithoutContext('can locate installations on macOS', () {
|
|
final FileSystem fileSystem = MemoryFileSystem.test();
|
|
const String home = '/home/me';
|
|
final Platform platform = FakePlatform(operatingSystem: 'macos', environment: <String, String>{'HOME': home});
|
|
|
|
final String randomLocation = fileSystem.path.join(
|
|
'/',
|
|
'random',
|
|
'Visual Studio Code.app',
|
|
);
|
|
fileSystem.directory(fileSystem.path.join(randomLocation, 'Contents')).createSync(recursive: true);
|
|
|
|
final String randomInsidersLocation = fileSystem.path.join(
|
|
'/',
|
|
'random',
|
|
'Visual Studio Code - Insiders.app',
|
|
);
|
|
fileSystem.directory(fileSystem.path.join(randomInsidersLocation, 'Contents')).createSync(recursive: true);
|
|
|
|
fileSystem.directory(fileSystem.path.join('/', 'Applications', 'Visual Studio Code.app', 'Contents')).createSync(recursive: true);
|
|
fileSystem.directory(fileSystem.path.join('/', 'Applications', 'Visual Studio Code - Insiders.app', 'Contents')).createSync(recursive: true);
|
|
fileSystem.directory(fileSystem.path.join(home, 'Applications', 'Visual Studio Code.app', 'Contents')).createSync(recursive: true);
|
|
fileSystem.directory(fileSystem.path.join(home, 'Applications', 'Visual Studio Code - Insiders.app', 'Contents')).createSync(recursive: true);
|
|
|
|
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[
|
|
FakeCommand(
|
|
command: const <String>[
|
|
'mdfind',
|
|
'kMDItemCFBundleIdentifier="com.microsoft.VSCode"',
|
|
],
|
|
stdout: randomLocation,
|
|
),
|
|
FakeCommand(
|
|
command: const <String>[
|
|
'mdfind',
|
|
'kMDItemCFBundleIdentifier="com.microsoft.VSCodeInsiders"',
|
|
],
|
|
stdout: randomInsidersLocation,
|
|
),
|
|
]);
|
|
|
|
final List<VsCode> installed = VsCode.allInstalled(fileSystem, platform, processManager);
|
|
expect(installed.length, 6);
|
|
expect(processManager, hasNoRemainingExpectations);
|
|
});
|
|
}
|