mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
0a2d9f5658
<!-- start_original_pr_link --> Reverts: flutter/flutter#165749 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: matanlurey <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Still passing command-line arguments from recipes that have no effect but cause the runner to crash. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: matanlurey <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jtmcdole} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Partial re-land of https://github.com/flutter/flutter/pull/165628: - Fixes the mistake that the `Cocoon` class did things that well, were not specific to Cocoon. - Renamed to `MetricsResultWriter`, as that is all it does now. --- Closes https://github.com/flutter/flutter/issues/165618. The `devicelab/bin/test_runner.dart upload-metrics` command use to have _two_ responsibilities: - Well, upload test **metrics** (benchmarks) to Skia Perf (it still does that) - Upload test **status** to Cocoon (it did until https://github.com/flutter/flutter/pull/165614) As https://github.com/flutter/flutter/pull/165614 proved, this API predated the current LUCI setup, where Cocoon itself receives task status updates from LUCI, and it turns out this entire time, DeviceLab was making (at best) NOP calls, and at worst, causing crashes and corrupt data (https://github.com/flutter/flutter/issues/165610). <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
85 lines
3.2 KiB
Dart
85 lines
3.2 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:args/command_runner.dart';
|
|
|
|
import '../framework/metrics_center.dart';
|
|
|
|
class UploadResultsCommand extends Command<void> {
|
|
UploadResultsCommand() {
|
|
argParser.addOption('results-file', help: 'Test results JSON to upload to Cocoon.');
|
|
argParser.addOption(
|
|
'service-account-token-file',
|
|
help: 'Authentication token for uploading results.',
|
|
);
|
|
argParser.addOption(
|
|
'test-flaky',
|
|
help: 'Flag to show whether the test is flaky: "True" or "False"',
|
|
);
|
|
argParser.addOption(
|
|
'git-branch',
|
|
help:
|
|
'[Flutter infrastructure] Git branch of the current commit. LUCI\n'
|
|
'checkouts run in detached HEAD state, so the branch must be passed.',
|
|
);
|
|
argParser.addOption(
|
|
'luci-builder',
|
|
help: '[Flutter infrastructure] Name of the LUCI builder being run on.',
|
|
);
|
|
argParser.addOption(
|
|
'task-name',
|
|
help: '[Flutter infrastructure] Name of the task being run on.',
|
|
);
|
|
argParser.addOption(
|
|
'benchmark-tags',
|
|
help: '[Flutter infrastructure] Benchmark tags to surface on Skia Perf',
|
|
);
|
|
argParser.addOption('test-status', help: 'Test status: Succeeded|Failed');
|
|
argParser.addOption('commit-time', help: 'Commit time in UNIX timestamp');
|
|
argParser.addOption(
|
|
'builder-bucket',
|
|
help: '[Flutter infrastructure] Luci builder bucket the test is running in.',
|
|
);
|
|
}
|
|
|
|
@override
|
|
String get name => 'upload-metrics';
|
|
|
|
@override
|
|
String get description => '[Flutter infrastructure] Upload results data to Cocoon/Skia Perf';
|
|
|
|
@override
|
|
Future<void> run() async {
|
|
final String? resultsPath = argResults!['results-file'] as String?;
|
|
// final String? serviceAccountTokenFile = argResults!['service-account-token-file'] as String?;
|
|
// final String? testFlakyStatus = argResults!['test-flaky'] as String?;
|
|
final String? gitBranch = argResults!['git-branch'] as String?;
|
|
final String? builderName = argResults!['luci-builder'] as String?;
|
|
final String? testStatus = argResults!['test-status'] as String?;
|
|
final String? commitTime = argResults!['commit-time'] as String?;
|
|
final String? taskName = argResults!['task-name'] as String?;
|
|
final String? benchmarkTags = argResults!['benchmark-tags'] as String?;
|
|
final String? builderBucket = argResults!['builder-bucket'] as String?;
|
|
|
|
// Upload metrics to skia perf from test runner when `resultsPath` is specified.
|
|
if (resultsPath != null) {
|
|
await uploadToSkiaPerf(resultsPath, commitTime, taskName, benchmarkTags);
|
|
print('Successfully uploaded metrics to skia perf');
|
|
}
|
|
|
|
print(
|
|
'Intentionally skipping /api/update-task-status ($gitBranch/$builderName/$testStatus/$builderBucket) because yjbanov@ said so',
|
|
);
|
|
// final Cocoon cocoon = Cocoon(serviceAccountTokenPath: serviceAccountTokenFile);
|
|
// return cocoon.sendTaskStatus(
|
|
// resultsPath: resultsPath,
|
|
// isTestFlaky: testFlakyStatus == 'True',
|
|
// gitBranch: gitBranch,
|
|
// builderName: builderName,
|
|
// testStatus: testStatus,
|
|
// builderBucket: builderBucket,
|
|
// );
|
|
}
|
|
}
|