mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

* Reland: [macos] add flavor options to tool commands Adds --flavor option to flutter run and flutter build. Running against preexisting devicelab flavor tests for feature parity between macOS, iOS, and Android. This relands #118421 by alex-wallen which was reverted in #118858 due to the following test failures: The bail-out with "Host and target are the same. Nothing to install." added in `packages/flutter_tools/lib/src/commands/install.dart` triggered failures in the following tests, which unconditionally attempt to install the built app, which is unsupported on desktop since the host and target are the same: * https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout * https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout * https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout Fixes #64088 * Partial revert: eliminate install check on desktop The original flavour support patch included a check that triggered a failure when flutter install is run on desktop OSes. This was intentional, since the host and target devices are the same and installation is unnecessary to launch the app on currently-supported desktop OSes. Note that Windows UWP apps *do* require installation to run, and we used to have an install command for those apps, though UWP is no longer supported. Since that part of the change was orthogonal to flavour support itself, I'm reverting that component of the change and we can deal with it separately if so desired.
135 lines
5.8 KiB
Dart
135 lines
5.8 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:file/memory.dart';
|
|
import 'package:flutter_tools/src/base/file_system.dart';
|
|
import 'package:flutter_tools/src/base/logger.dart';
|
|
import 'package:flutter_tools/src/base/platform.dart';
|
|
import 'package:flutter_tools/src/build_info.dart';
|
|
import 'package:flutter_tools/src/device.dart';
|
|
import 'package:flutter_tools/src/project.dart';
|
|
import 'package:flutter_tools/src/windows/application_package.dart';
|
|
import 'package:flutter_tools/src/windows/windows_device.dart';
|
|
import 'package:flutter_tools/src/windows/windows_workflow.dart';
|
|
import 'package:test/fake.dart';
|
|
|
|
import '../../src/common.dart';
|
|
import '../../src/fake_process_manager.dart';
|
|
import '../../src/fakes.dart';
|
|
|
|
void main() {
|
|
testWithoutContext('WindowsDevice defaults', () async {
|
|
final WindowsDevice windowsDevice = setUpWindowsDevice();
|
|
final File dummyFile = MemoryFileSystem.test().file('dummy');
|
|
final PrebuiltWindowsApp windowsApp = PrebuiltWindowsApp(executable: 'foo', applicationPackage: dummyFile);
|
|
|
|
expect(await windowsDevice.targetPlatform, TargetPlatform.windows_x64);
|
|
expect(windowsDevice.name, 'Windows');
|
|
expect(await windowsDevice.installApp(windowsApp), true);
|
|
expect(await windowsDevice.uninstallApp(windowsApp), true);
|
|
expect(await windowsDevice.isLatestBuildInstalled(windowsApp), true);
|
|
expect(await windowsDevice.isAppInstalled(windowsApp), true);
|
|
expect(windowsDevice.category, Category.desktop);
|
|
|
|
expect(windowsDevice.supportsRuntimeMode(BuildMode.debug), true);
|
|
expect(windowsDevice.supportsRuntimeMode(BuildMode.profile), true);
|
|
expect(windowsDevice.supportsRuntimeMode(BuildMode.release), true);
|
|
expect(windowsDevice.supportsRuntimeMode(BuildMode.jitRelease), false);
|
|
});
|
|
|
|
testWithoutContext('WindowsDevices does not list devices if the workflow is unsupported', () async {
|
|
expect(await WindowsDevices(
|
|
windowsWorkflow: WindowsWorkflow(
|
|
featureFlags: TestFeatureFlags(),
|
|
platform: FakePlatform(operatingSystem: 'windows'),
|
|
),
|
|
operatingSystemUtils: FakeOperatingSystemUtils(),
|
|
logger: BufferLogger.test(),
|
|
processManager: FakeProcessManager.any(),
|
|
fileSystem: MemoryFileSystem.test(),
|
|
).devices, <Device>[]);
|
|
});
|
|
|
|
testWithoutContext('WindowsDevices lists a devices if the workflow is supported', () async {
|
|
expect(await WindowsDevices(
|
|
windowsWorkflow: WindowsWorkflow(
|
|
featureFlags: TestFeatureFlags(isWindowsEnabled: true),
|
|
platform: FakePlatform(operatingSystem: 'windows')
|
|
),
|
|
operatingSystemUtils: FakeOperatingSystemUtils(),
|
|
logger: BufferLogger.test(),
|
|
processManager: FakeProcessManager.any(),
|
|
fileSystem: MemoryFileSystem.test(),
|
|
).devices, hasLength(1));
|
|
});
|
|
|
|
testWithoutContext('isSupportedForProject is true with editable host app', () async {
|
|
final FileSystem fileSystem = MemoryFileSystem.test();
|
|
final WindowsDevice windowsDevice = setUpWindowsDevice(fileSystem: fileSystem);
|
|
fileSystem.file('pubspec.yaml').createSync();
|
|
fileSystem.file('.packages').createSync();
|
|
fileSystem.directory('windows').createSync();
|
|
fileSystem.file(fileSystem.path.join('windows', 'CMakeLists.txt')).createSync();
|
|
final FlutterProject flutterProject = setUpFlutterProject(fileSystem.currentDirectory);
|
|
|
|
expect(windowsDevice.isSupportedForProject(flutterProject), true);
|
|
});
|
|
|
|
testWithoutContext('isSupportedForProject is false with no host app', () async {
|
|
final FileSystem fileSystem = MemoryFileSystem.test();
|
|
final WindowsDevice windowsDevice = setUpWindowsDevice(fileSystem: fileSystem);
|
|
fileSystem.file('pubspec.yaml').createSync();
|
|
fileSystem.file('.packages').createSync();
|
|
final FlutterProject flutterProject = setUpFlutterProject(fileSystem.currentDirectory);
|
|
|
|
expect(windowsDevice.isSupportedForProject(flutterProject), false);
|
|
});
|
|
|
|
testWithoutContext('isSupportedForProject is false with no build file', () async {
|
|
final FileSystem fileSystem = MemoryFileSystem.test();
|
|
final WindowsDevice windowsDevice = setUpWindowsDevice(fileSystem: fileSystem);
|
|
fileSystem.file('pubspec.yaml').createSync();
|
|
fileSystem.file('.packages').createSync();
|
|
fileSystem.directory('windows').createSync();
|
|
final FlutterProject flutterProject = setUpFlutterProject(fileSystem.currentDirectory);
|
|
|
|
expect(windowsDevice.isSupportedForProject(flutterProject), false);
|
|
});
|
|
|
|
testWithoutContext('executablePathForDevice uses the correct package executable', () async {
|
|
final WindowsDevice windowsDevice = setUpWindowsDevice();
|
|
final FakeWindowsApp fakeApp = FakeWindowsApp();
|
|
|
|
expect(windowsDevice.executablePathForDevice(fakeApp, BuildInfo.debug), 'debug/executable');
|
|
expect(windowsDevice.executablePathForDevice(fakeApp, BuildInfo.profile), 'profile/executable');
|
|
expect(windowsDevice.executablePathForDevice(fakeApp, BuildInfo.release), 'release/executable');
|
|
});
|
|
}
|
|
|
|
FlutterProject setUpFlutterProject(Directory directory) {
|
|
final FlutterProjectFactory flutterProjectFactory = FlutterProjectFactory(
|
|
fileSystem: directory.fileSystem,
|
|
logger: BufferLogger.test(),
|
|
);
|
|
return flutterProjectFactory.fromDirectory(directory);
|
|
}
|
|
|
|
WindowsDevice setUpWindowsDevice({
|
|
FileSystem? fileSystem,
|
|
Logger? logger,
|
|
ProcessManager? processManager,
|
|
}) {
|
|
return WindowsDevice(
|
|
fileSystem: fileSystem ?? MemoryFileSystem.test(),
|
|
logger: logger ?? BufferLogger.test(),
|
|
processManager: processManager ?? FakeProcessManager.any(),
|
|
operatingSystemUtils: FakeOperatingSystemUtils(),
|
|
);
|
|
}
|
|
|
|
class FakeWindowsApp extends Fake implements WindowsApp {
|
|
@override
|
|
String executable(BuildMode buildMode) => '${buildMode.name}/executable';
|
|
}
|