mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00

Fixes https://github.com/flutter/flutter/issues/112833 Most of the actual changes here are in [packages/flutter_tools/lib/src/version.dart](https://github.com/flutter/flutter/pull/124558/files#diff-092e00109d9e1589fbc7c6de750e29a6ae512b2dd44e85d60028953561201605), while the rest is largely just addressing changes to the constructor of `FlutterVersion` which now has different dependencies. This change makes `FlutterVersion` an interface with two concrete implementations: 1. `_FlutterVersionGit` which is mostly the previous implementation, and 2. `_FlutterVersionFromFile` which will read a new `.version.json` file from the root of the repo The [`FlutterVersion` constructor](https://github.com/flutter/flutter/pull/124558/files#diff-092e00109d9e1589fbc7c6de750e29a6ae512b2dd44e85d60028953561201605R70) is now a factory that first checks if `.version.json` exists, and if so returns an instance of `_FlutterVersionFromGit` else it returns the fallback `_FlutterVersionGit` which will end up writing `.version.json` so that we don't need to re-calculate the version on the next invocation. `.version.json` will be deleted in the bash/batch entrypoints any time we need to rebuild he tool (this will usually be because the user did `flutter upgrade` or `flutter channel`, or manually changed the commit with git).
171 lines
8.3 KiB
Dart
171 lines
8.3 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'dart:convert';
|
|
|
|
import 'package:args/command_runner.dart';
|
|
import 'package:flutter_tools/src/base/file_system.dart';
|
|
import 'package:flutter_tools/src/base/io.dart';
|
|
import 'package:flutter_tools/src/base/logger.dart';
|
|
import 'package:flutter_tools/src/base/platform.dart';
|
|
import 'package:flutter_tools/src/commands/analyze.dart';
|
|
import 'package:flutter_tools/src/globals.dart' as globals;
|
|
import 'package:flutter_tools/src/project.dart';
|
|
import 'package:flutter_tools/src/project_validator.dart';
|
|
|
|
import '../src/common.dart';
|
|
import '../src/context.dart';
|
|
import '../src/test_flutter_command_runner.dart';
|
|
import 'test_utils.dart';
|
|
|
|
void main() {
|
|
late FileSystem fileSystem;
|
|
|
|
group('analyze --suggestions command integration', () {
|
|
|
|
setUp(() {
|
|
fileSystem = globals.localFileSystem;
|
|
});
|
|
|
|
testUsingContext('General Info Project Validator', () async {
|
|
final BufferLogger loggerTest = BufferLogger.test();
|
|
final AnalyzeCommand command = AnalyzeCommand(
|
|
artifacts: globals.artifacts!,
|
|
fileSystem: fileSystem,
|
|
logger: loggerTest,
|
|
platform: globals.platform,
|
|
terminal: globals.terminal,
|
|
processManager: globals.processManager,
|
|
allProjectValidators: <ProjectValidator>[GeneralInfoProjectValidator()],
|
|
suppressAnalytics: true,
|
|
);
|
|
final CommandRunner<void> runner = createTestCommandRunner(command);
|
|
|
|
await runner.run(<String>[
|
|
'analyze',
|
|
'--no-pub',
|
|
'--no-current-package',
|
|
'--suggestions',
|
|
'../../dev/integration_tests/flutter_gallery',
|
|
]);
|
|
|
|
const String expected = '\n'
|
|
'┌───────────────────────────────────────────────────────────────────┐\n'
|
|
'│ General Info │\n'
|
|
'│ [✓] App Name: flutter_gallery │\n'
|
|
'│ [✓] Supported Platforms: android, ios, web, macos, linux, windows │\n'
|
|
'│ [✓] Is Flutter Package: yes │\n'
|
|
'│ [✓] Uses Material Design: yes │\n'
|
|
'│ [✓] Is Plugin: no │\n'
|
|
'│ [✓] Java/Gradle/Android Gradle Plugin: ${AndroidProject.validJavaGradleAgpString} │\n'
|
|
'└───────────────────────────────────────────────────────────────────┘\n';
|
|
|
|
expect(loggerTest.statusText, contains(expected));
|
|
});
|
|
|
|
testUsingContext('PubDependenciesProjectValidator success ', () async {
|
|
final BufferLogger loggerTest = BufferLogger.test();
|
|
final AnalyzeCommand command = AnalyzeCommand(
|
|
artifacts: globals.artifacts!,
|
|
fileSystem: fileSystem,
|
|
logger: loggerTest,
|
|
platform: globals.platform,
|
|
terminal: globals.terminal,
|
|
processManager: globals.processManager,
|
|
allProjectValidators: <ProjectValidator>[
|
|
PubDependenciesProjectValidator(globals.processManager),
|
|
],
|
|
suppressAnalytics: true,
|
|
);
|
|
final CommandRunner<void> runner = createTestCommandRunner(command);
|
|
|
|
await runner.run(<String>[
|
|
'analyze',
|
|
'--no-pub',
|
|
'--no-current-package',
|
|
'--suggestions',
|
|
'../../dev/integration_tests/flutter_gallery',
|
|
]);
|
|
|
|
const String expected = '\n'
|
|
'┌────────────────────────────────────────────────────────────────────────────────────┐\n'
|
|
'│ Pub dependencies │\n'
|
|
'│ [✓] Dart dependencies: All pub dependencies are hosted on https://pub.dartlang.org │\n'
|
|
'└────────────────────────────────────────────────────────────────────────────────────┘\n';
|
|
expect(loggerTest.statusText, contains(expected));
|
|
});
|
|
});
|
|
|
|
group('analyze --suggestions --machine command integration', () {
|
|
late Directory tempDir;
|
|
late Platform platform;
|
|
|
|
setUpAll(() async {
|
|
platform = const LocalPlatform();
|
|
tempDir = createResolvedTempDirectorySync('run_test.');
|
|
await globals.processManager.run(<String>['flutter', 'create', 'test_project'], workingDirectory: tempDir.path);
|
|
});
|
|
|
|
tearDown(() async {
|
|
tryToDelete(tempDir);
|
|
});
|
|
|
|
testUsingContext('analyze --suggestions --machine produces expected values', () async {
|
|
final ProcessResult result = await globals.processManager.run(<String>['flutter', 'analyze', '--suggestions', '--machine'], workingDirectory: tempDir.childDirectory('test_project').path);
|
|
|
|
expect(result.stdout is String, true);
|
|
expect((result.stdout as String).startsWith('{\n'), true);
|
|
expect(result.stdout, isNot(contains(',\n}'))); // No trailing commas allowed in JSON
|
|
expect((result.stdout as String).endsWith('}\n'), true);
|
|
|
|
final Map<String, dynamic> decoded = jsonDecode(result.stdout as String) as Map<String, dynamic>;
|
|
|
|
expect(decoded.containsKey('FlutterProject.android.exists'), true);
|
|
expect(decoded.containsKey('FlutterProject.ios.exists'), true);
|
|
expect(decoded.containsKey('FlutterProject.web.exists'), true);
|
|
expect(decoded.containsKey('FlutterProject.macos.exists'), true);
|
|
expect(decoded.containsKey('FlutterProject.linux.exists'), true);
|
|
expect(decoded.containsKey('FlutterProject.windows.exists'), true);
|
|
expect(decoded.containsKey('FlutterProject.fuchsia.exists'), true);
|
|
expect(decoded.containsKey('FlutterProject.android.isKotlin'), true);
|
|
expect(decoded.containsKey('FlutterProject.ios.isSwift'), true);
|
|
expect(decoded.containsKey('FlutterProject.isModule'), true);
|
|
expect(decoded.containsKey('FlutterProject.isPlugin'), true);
|
|
expect(decoded.containsKey('FlutterProject.manifest.appname'), true);
|
|
expect(decoded.containsKey('FlutterVersion.frameworkRevision'), true);
|
|
|
|
expect(decoded.containsKey('FlutterProject.directory'), true);
|
|
expect(decoded.containsKey('FlutterProject.metadataFile'), true);
|
|
expect(decoded.containsKey('Platform.operatingSystem'), true);
|
|
expect(decoded.containsKey('Platform.isAndroid'), true);
|
|
expect(decoded.containsKey('Platform.isIOS'), true);
|
|
expect(decoded.containsKey('Platform.isWindows'), true);
|
|
expect(decoded.containsKey('Platform.isMacOS'), true);
|
|
expect(decoded.containsKey('Platform.isFuchsia'), true);
|
|
expect(decoded.containsKey('Platform.pathSeparator'), true);
|
|
expect(decoded.containsKey('Cache.flutterRoot'), true);
|
|
|
|
expect(decoded['FlutterProject.android.exists'], true);
|
|
expect(decoded['FlutterProject.ios.exists'], true);
|
|
expect(decoded['FlutterProject.web.exists'], true);
|
|
expect(decoded['FlutterProject.macos.exists'], true);
|
|
expect(decoded['FlutterProject.linux.exists'], true);
|
|
expect(decoded['FlutterProject.windows.exists'], true);
|
|
expect(decoded['FlutterProject.fuchsia.exists'], false);
|
|
expect(decoded['FlutterProject.android.isKotlin'], true);
|
|
expect(decoded['FlutterProject.ios.isSwift'], true);
|
|
expect(decoded['FlutterProject.isModule'], false);
|
|
expect(decoded['FlutterProject.isPlugin'], false);
|
|
expect(decoded['FlutterProject.manifest.appname'], 'test_project');
|
|
|
|
expect(decoded['Platform.isAndroid'], false);
|
|
expect(decoded['Platform.isIOS'], false);
|
|
expect(decoded['Platform.isWindows'], platform.isWindows);
|
|
expect(decoded['Platform.isMacOS'], platform.isMacOS);
|
|
expect(decoded['Platform.isFuchsia'], platform.isFuchsia);
|
|
expect(decoded['Platform.pathSeparator'], platform.pathSeparator);
|
|
}, overrides: <Type, Generator>{});
|
|
});
|
|
}
|