mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
21144362f8
Cleans up https://github.com/flutter/flutter/pull/155800. In summary, `ResidentRunner`/`FlutterDevice` have branching behavior around logging that depends on the type of `DeviceLogReader` on the `FlutterDevice` instance. Let's instead move this behavior to the `DeviceLogReader` implementations. My apologies for the large diff. Much of this is a refactor that was a bit too difficult to separate into its own commits. Here are the main two changes * Replaces the mutable `connectedVmService` field on the `DeviceLogReader` class with a new method `provideVmService`. This serves largely the same purpose as the mutable field, but it allows for asynchronous code. This is where we put the logic that used to exist in `FlutterDevice.tryInitLogReader`. * Removes the `tryInitLogReader` method from `FlutterDevice`. This method served to set the `appPid` field on the `FlutterDevice`'s `DeviceLogReader` instance. This was only used in the case of Android to filter out logs unrelated to the flutter app coming from the device, so we can move this logic to `AdbLogReader`'s implementation of `provideVmService`. |
||
|---|---|---|
| .. | ||
| code_signing_test.dart | ||
| core_devices_test.dart | ||
| devices_test.dart | ||
| ios_deploy_test.dart | ||
| ios_device_install_test.dart | ||
| ios_device_logger_test.dart | ||
| ios_device_port_forwarder_test.dart | ||
| ios_device_project_test.dart | ||
| ios_device_start_nonprebuilt_test.dart | ||
| ios_device_start_prebuilt_test.dart | ||
| ios_project_migration_test.dart | ||
| ios_workflow_test.dart | ||
| mac_test.dart | ||
| simulators_test.dart | ||
| xcode_debug_test.dart | ||
| xcodeproj_test.dart | ||
| xcresult_test_data.dart | ||
| xcresult_test.dart | ||